GH-43040: [C++] Reduce the recursion of many-join test by zanmato1984 · Pull Request #43042 · apache/arrow

zanmato1984 · 2024-06-25T11:35:49Z

Rationale for this change

The current recursion 64 in many-join test is too aggressive so stack (the C program stack) overflow may happen on alpine or emscripten causing issues like #43040 .

What changes are included in this PR?

Reduce the recursion to 16, which is strong enough for the purpose of #41335 which introduced this test.

Are these changes tested?

Change is test.

Are there any user-facing changes?

None.

GitHub Issue: [C++] Acero hash join ManyJoins test failing on several nightly builds #43040

github-actions · 2024-06-25T11:36:11Z

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

zanmato1984 · 2024-06-25T11:38:53Z

@github-actions crossbow submit -g cpp

github-actions · 2024-06-25T11:41:27Z

Revision: 7251176

Submitted crossbow builds: ursacomputing/crossbow @ actions-5714627e25

Task	Status
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-39-cpp
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-gcc-14

zanmato1984 · 2024-06-25T11:51:57Z

@github-actions crossbow submit -g cpp

github-actions · 2024-06-25T11:54:26Z

Revision: 3e6acd8

Submitted crossbow builds: ursacomputing/crossbow @ actions-d143fbd7c0

Task	Status
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-39-cpp
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-gcc-14

zanmato1984 · 2024-06-25T12:02:25Z

Revision: 7251176
Submitted crossbow builds: ursacomputing/crossbow @ actions-5714627e25
Task Status
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-39-cpp
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-gcc-14

Ran with join recursion = 16.

zanmato1984 · 2024-06-25T12:02:45Z

Revision: 3e6acd8
Submitted crossbow builds: ursacomputing/crossbow @ actions-d143fbd7c0
Task Status
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-39-cpp
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-gcc-14

Ran with join recursion = 72.

zanmato1984 · 2024-06-25T12:04:18Z

@github-actions crossbow submit -g cpp

github-actions · 2024-06-25T12:06:49Z

Revision: 6ccaa6c

Submitted crossbow builds: ursacomputing/crossbow @ actions-368846a25e

Task	Status
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-39-cpp
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-gcc-14

github-actions · 2024-06-25T12:10:28Z

⚠️ GitHub issue #43040has been automatically assigned in GitHub to PR creator.

zanmato1984 · 2024-06-25T12:10:50Z

Revision: 6ccaa6c
Submitted crossbow builds: ursacomputing/crossbow @ actions-368846a25e
Task Status
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-39-cpp
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-gcc-14

Ran with join recursion = 16 again.

zanmato1984 · 2024-06-25T12:21:51Z

Hi @pitrou @felipecrv , would you help to take a look? This will fix two long failing jobs.

cc @jorisvandenbossche

zanmato1984 · 2024-06-25T12:24:07Z


 // A fair number of joins to guarantee temp vector stack overflow before GH-41335.
- const int num_joins = 64;
+ const int num_joins = 16;


To make sure this conservative value serves the same protection purpose, I've verified in my local that, by reverting commit 6c386da, the test failed (with "temp stack overflow") with 16 joins (actually the minimal number for joins to fail is 14).

Can you condition the reduction on the specific platforms that can't handle num_joins=64? To ensure possible bugs on a high number of joins are caught in regression tests.

Yeah that's a nice idea. It's just that the condition could be very tricky to identify. So far I've experienced the following combinations on number of joins being 64:
Ubuntu w/ or w/o ASAN (the CI jobs), all good.
MacOS w/ ASAN, stack overflow; MacOS w/o ASAN, good.
Alpine and Emscripten w/o ASAN (the CI jobs), segfault or memory out-of-bound (presumably to be caused by stack overflow as well).
And I don't find macros to differentiate Linux distributions such as Alpine and Ubuntu. To enable at least one build to run 64-join, it seems the only safe condition is to enable 64 joins on Linux w/ ASAN - but that's just because we have only sanitizer build on Ubuntu.
Any suggestions?

I think we can stick with 16 if it's enough to reproduce the issue.

I think we can stick with 16 if it's enough to reproduce the issue.
What do you mean by "enough to repro the issue"? Reducing to 16 is making the issue "go away".

I think the "issue" here means this:
by reverting commit 6c386da, the test failed (with "temp stack overflow") with 16 joins
In other words, 16 joins serves the purpose that this test is originally designed to cover.

Ahh. Now I see it.

felipecrv · 2024-06-26T14:04:49Z

I will let @pitrou approve and merge this one.

pitrou

LGTM, thanks for fixing this @zanmato1984

conbench-apache-arrow · 2024-06-26T22:08:39Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 2a8fa3e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Reduce the recursion of many join test
7251176

zanmato1984 requested a review from westonpace as a code owner June 25, 2024 11:35

zanmato1984 marked this pull request as draft June 25, 2024 11:35

github-actionsBot added Component: C++ awaiting review Awaiting review labels Jun 25, 2024

Double check by increasing again and see if CI fails
3e6acd8

Reduce the recursion of many join test again
6ccaa6c

zanmato1984 changed the title ~~EXPERIMENT: [C++] Reduce the recursion of many join test~~GH-43040: [C++] Reduce the recursion of many-join testJun 25, 2024

zanmato1984 marked this pull request as ready for review June 25, 2024 12:20

zanmato1984 commented Jun 25, 2024
View reviewed changes

github-actionsBot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 25, 2024

zanmato1984 mentioned this pull request Jun 25, 2024
[C++] Acero hash join ManyJoins test failing on several nightly builds #43040
Closed

github-actionsBot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jun 25, 2024

felipecrv approved these changes Jun 26, 2024
View reviewed changes

github-actionsBot removed the awaiting changes Awaiting changes label Jun 26, 2024

github-actionsBot added the awaiting merge Awaiting merge label Jun 26, 2024

pitrou approved these changes Jun 26, 2024
View reviewed changes

pitrou merged commit 2a8fa3e into apache:mainJun 26, 2024

pitrou removed the awaiting merge Awaiting merge label Jun 26, 2024

github-actionsBot added the awaiting committer review Awaiting committer review label Jun 26, 2024

Uh oh!

Conversation

zanmato1984 commented Jun 25, 2024• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actionsBot commented Jun 25, 2024

Uh oh!

zanmato1984 commented Jun 25, 2024

Uh oh!

github-actionsBot commented Jun 25, 2024

Uh oh!

zanmato1984 commented Jun 25, 2024

Uh oh!

github-actionsBot commented Jun 25, 2024

Uh oh!

zanmato1984 commented Jun 25, 2024

Uh oh!

zanmato1984 commented Jun 25, 2024

Uh oh!

zanmato1984 commented Jun 25, 2024

Uh oh!

github-actionsBot commented Jun 25, 2024

Uh oh!

github-actionsBot commented Jun 25, 2024

Uh oh!

zanmato1984 commented Jun 25, 2024

Uh oh!

zanmato1984 commented Jun 25, 2024

Uh oh!

zanmato1984Jun 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felipecrvJun 25, 2024

Choose a reason for hiding this comment

Uh oh!

zanmato1984Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

pitrouJun 25, 2024

Choose a reason for hiding this comment

Uh oh!

felipecrvJun 25, 2024

Choose a reason for hiding this comment

Uh oh!

zanmato1984Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

felipecrvJun 26, 2024

Choose a reason for hiding this comment

Uh oh!

felipecrv commented Jun 26, 2024

Uh oh!

pitrou left a comment

Choose a reason for hiding this comment

Uh oh!

conbench-apache-arrowBot commented Jun 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zanmato1984 commented Jun 25, 2024•
edited by github-actions Bot
Loading

zanmato1984Jun 25, 2024•
edited
Loading