Skip to content

MINOR: [Java] Bump ch.qos.logback:logback-classic from 1.3.14 to 1.4.14 in /java - #43310

Merged
danepitkin merged 3 commits into
apache:mainfrom
danepitkin:danepitkin/logback-1-5-6
Jul 22, 2024
Merged

MINOR: [Java] Bump ch.qos.logback:logback-classic from 1.3.14 to 1.4.14 in /java#43310
danepitkin merged 3 commits into
apache:mainfrom
danepitkin:danepitkin/logback-1-5-6

Conversation

@danepitkin

@danepitkindanepitkin commented Jul 17, 2024

Copy link
Copy Markdown
Member

Rationale for this change

With Java 8 deprecated, we can bump logback to the next version which supports Java 11 at build and runtime. See https://github.com/apache/arrow/pull/40778/files

What changes are included in this PR?

  • Bump logback-classic to 1.4.14

Are these changes tested?

CI

Are there any user-facing changes?

No

@danepitkin

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g java

@github-actions

Copy link
Copy Markdown

Revision: ff6a151

Submitted crossbow builds: ursacomputing/crossbow @ actions-5b735d9dc6

TaskStatus
java-jarsGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64GitHub Actions
verify-rc-source-java-macos-amd64GitHub Actions

@danepitkin

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g java

@github-actions

Copy link
Copy Markdown

Revision: 63f628b

Submitted crossbow builds: ursacomputing/crossbow @ actions-d7566f83b4

TaskStatus
java-jarsGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64GitHub Actions
verify-rc-source-java-macos-amd64GitHub Actions

@danepitkin

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g java

@danepitkindanepitkin changed the title MINOR: [Java] Bump ch.qos.logback:logback-classic from 1.3.14 to 1.5.6 in /javaMINOR: [Java] Bump ch.qos.logback:logback-classic from 1.3.14 to 1.4.14 in /javaJul 17, 2024
@github-actions

Copy link
Copy Markdown

Revision: 6edff42

Submitted crossbow builds: ursacomputing/crossbow @ actions-8b50bd2155

TaskStatus
java-jarsGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64GitHub Actions
verify-rc-source-java-macos-amd64GitHub Actions

@vibhatha

Copy link
Copy Markdown
Contributor

@danepitkin the java-jars failure seems to be unrelated.

@lidavidm

Copy link
Copy Markdown
Member

Can we get it investigated and fixed? If we're going to run java-jars on so many PRs it needs to be kept green.

@vibhatha

Copy link
Copy Markdown
Contributor
  1. One warning is that the object files have been built for macOS 13.0 but linked with 10.5
  2. Undefined symbols
ld: Undefined symbols:
testing::internal::MakeAndRegisterTestInfo(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, char const*, char const*, char const*, testing::internal::CodeLocation, void const*, void (*)(), void (*)(), testing::internal::TestFactoryBase*), referenced from:
__GLOBAL__sub_I_adapter_test.cc in adapter_test.cc.o

Seems like here the compiler cannot resolve testing::internal::MakeAndRegisterTestInfo.

I am looking into this... And there are no other CI failures related to C++ PRs in this association, I suspect library installation issue in the build scripts?

@danepitkin

Copy link
Copy Markdown
MemberAuthor

@vibhatha could you create an issue? I'll merge this since the failure is unrelated and everything else looks good. (The Release scripts failure is unrelated and already fixed on main).

@danepitkin

Copy link
Copy Markdown
MemberAuthor

After reviewing crossbow (http://crossbow.voltrondata.com/), it seems MacOS builds started failing 6 days ago.

First MacOS failure: https://github.com/ursacomputing/crossbow/actions/runs/9953458018/job/27502447467

@danepitkin
danepitkin merged commit ec58e4d into apache:mainJul 22, 2024
@danepitkindanepitkin removed the awaiting review Awaiting review label Jul 22, 2024
@vibhatha

Copy link
Copy Markdown
Contributor

@danepitkin Issue filed: #43377

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ec58e4d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them.

@danepitkin

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-debian-12-docs

@github-actions

Copy link
Copy Markdown

Revision: 6edff42

Submitted crossbow builds: ursacomputing/crossbow @ actions-169aaeb47e

TaskStatus
test-debian-12-docsGitHub Actions

@vibhatha

Copy link
Copy Markdown
Contributor

@danepitkin I filed this issue: #43378
I think it is the same happening here. I saw a few CIs failing in multiple PRs for the same reason.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…14 in /java (apache#43310)
### Rationale for this change
With Java 8 deprecated, we can bump logback to the next version which supports Java 11 at build and runtime. See https://github.com/apache/arrow/pull/40778/files
### What changes are included in this PR?
* Bump logback-classic to 1.4.14
### Are these changes tested?
CI
### Are there any user-facing changes?
No
Authored-by: Dane Pitkin <dpitkin@apache.org>
Signed-off-by: Dane Pitkin <dpitkin@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@danepitkin@vibhatha@lidavidm