Uh oh!
There was an error while loading. Please reload this page.
GH-43432: [Java][Packaging] Clean up java-jars job - #43431
Merged
Conversation
danepitkin
commented
Jul 26, 2024
MemberAuthor
@github-actions crossbow submit -g java |
danepitkin
marked this pull request as draft
July 26, 2024 15:30
Revision: c5e0d18 Submitted crossbow builds: ursacomputing/crossbow @ actions-1f283d34fe
|
danepitkin
commented
Jul 26, 2024
MemberAuthor
@github-actions crossbow submit java-jars |
Revision: e468604 Submitted crossbow builds: ursacomputing/crossbow @ actions-cd7ed11f15
|
vibhatha
approved these changes
Jul 29, 2024
vibhatha
left a comment
Contributor
There was a problem hiding this comment.
Thanks @danepitkin. LGTM!
lidavidm
approved these changes
Jul 29, 2024
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c980ebf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
### Rationale for this change 1) Remove maven module references 2) Fix warning in java-jars job: ``` Warning: Some problems were encountered while building the effective model for org.apache.arrow:arrow-bom:pom:18.0.0-SNAPSHOT Warning: 'parent.relativePath' of POM org.apache.arrow:arrow-bom:18.0.0-SNAPSHOT (/Users/runner/work/crossbow/crossbow/arrow/java/bom/pom.xml) points at org.apache.arrow:arrow-java-root instead of org.apache:apache, please verify your project structure @ line 23, column 11 Warning: Warning: It is highly recommended to fix these problems because they threaten the stability of your build. Warning: Warning: For this reason, future Maven versions might no longer support building such malformed projects. ``` ### What changes are included in this PR? * Delete `mvn versions:set` for removed maven module * Add empty relativePath to Arrow BOM, so it doesn't use arrow-java-root ### Are these changes tested? java-jars CI job ### Are there any user-facing changes? No * GitHub Issue: apache#43432 Authored-by: Dane Pitkin <dpitkin@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
mvn versions:setfor removed maven moduleAre these changes tested?
java-jars CI job
Are there any user-facing changes?
No