Skip to content

GH-43455: [Go] Add Opaque canonical extension type - #43459

Merged
zeroshade merged 2 commits into
apache:mainfrom
lidavidm:gh-43455
Aug 6, 2024
Merged

GH-43455: [Go] Add Opaque canonical extension type#43459
zeroshade merged 2 commits into
apache:mainfrom
lidavidm:gh-43455

Conversation

@lidavidm

@lidavidmlidavidm commented Jul 28, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Rationale for this change

Add the newly ratified extension type.

What changes are included in this PR?

The Go implementation only.

Are these changes tested?

Yes

Are there any user-facing changes?

No.

@lidavidm
lidavidm requested a review from zeroshade as a code ownerJuly 28, 2024 23:57
@lidavidm
lidavidm marked this pull request as draft July 28, 2024 23:57
@github-actions

github-actionsBot commented Jul 28, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #43455has been automatically assigned in GitHub to PR creator.

@lidavidmlidavidm linked an issue Jul 29, 2024 that may be closed by this pull request
[Go] Add Opaque canonical extension type #43455
Closed
@lidavidm
lidavidm marked this pull request as ready for review July 29, 2024 05:12
@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jul 29, 2024
@lidavidm

lidavidm commented Aug 2, 2024

Copy link
Copy Markdown
MemberAuthor

rebased + fixed the author before I merge

joellubi
joellubi reviewed Aug 2, 2024
View reviewed changes
Comment threadgo/arrow/extensions/opaque.go
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Aug 2, 2024
@lidavidm@joellubi
Update go/arrow/extensions/opaque.go
0f6fdf0
Co-authored-by: Joel Lubinitsky <33523178+joellubi@users.noreply.github.com>
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 4, 2024
@lidavidm

lidavidm commented Aug 6, 2024

Copy link
Copy Markdown
MemberAuthor

Any further comments here?

joellubi
joellubi approved these changes Aug 6, 2024
View reviewed changes

@joellubijoellubi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Aug 6, 2024
@zeroshade
zeroshade merged commit dea09ec into apache:mainAug 6, 2024
@zeroshadezeroshade removed the awaiting merge Awaiting merge label Aug 6, 2024
@zeroshadezeroshade mentioned this pull request Aug 6, 2024
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Aug 6, 2024

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dea09ec.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

@lidavidm
lidavidm deleted the gh-43455 branch August 6, 2024 23:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeroshadezeroshadezeroshade approved these changes
@joellubijoellubijoellubi approved these changes

Assignees

No one assigned

Labels

Component: Go

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Go] Add Opaque canonical extension type

3 participants

@lidavidm@zeroshade@joellubi