GH-43506: [Java] Fix TestFragmentScanOptions result not match by jinchengchenghh · Pull Request #43639 · apache/arrow

jinchengchenghh · 2024-08-12T07:47:40Z

Rationale for this change

JNI test was not tested in CI. So the test failed but passed the CI.
The parseChar function should return char but return bool, a typo error.

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

GitHub Issue: [Java] Fix TestFragmentScanOptions test result does not match #43506
GitHub Issue: [Java] Fix TestFragmentScanOptions test result does not match #43506

github-actions · 2024-08-12T07:48:04Z

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

vibhatha · 2024-08-12T07:50:08Z

Rename to -> #43506: [Java] Fix TestFragmentScanOptions result not match

vibhatha · 2024-08-12T07:51:06Z

@github-actions crossbow submit -g java

github-actions · 2024-08-12T07:53:31Z

Revision: ea541c6b8fdcb0f97f25d52dd07cb893fd2f15de

Submitted crossbow builds: ursacomputing/crossbow @ actions-acd4c173ff

Task	Status
java-jars
test-conda-python-3.11-spark-master
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-08-12T08:50:19Z

@jinchengchenghh I think still there is an inaccuracy in the test case. One CI is failing.

vibhatha · 2024-08-12T08:51:05Z

Still the CI is failing...

vibhatha · 2024-08-12T11:44:01Z

Still failing right...

github-actions · 2024-08-12T21:17:12Z

⚠️ GitHub issue #43506has been automatically assigned in GitHub to PR creator.

jinchengchenghh · 2024-08-13T01:11:55Z

I will take a look today.

jinchengchenghh · 2024-08-13T05:47:26Z

Only gandiva failed now. @vibhatha

vibhatha · 2024-08-13T06:40:36Z

@jinchengchenghh it seems like there is a symbol not found issue again; https://github.com/apache/arrow/actions/runs/10363135011/job/28686234425?pr=43639#step:7:20512

jinchengchenghh · 2024-08-13T06:46:40Z

Do I need to disable this test in this PR? Or you will create a new PR to disable it?

vibhatha · 2024-08-13T07:00:19Z

@kou shall we disable this like the last time but note this as an issue and comment in the code?

kou · 2024-08-13T07:12:21Z

Yes but why is this happen again? Was #43503 not enough?

vibhatha · 2024-08-13T07:19:43Z

Yes but why is this happen again? Was #43503 not enough?

The tests related to Gandiva passed when we merged that PR, but it failed due to the exact reason in this PR. We might have missed something as it seems.

jinchengchenghh · 2024-08-13T07:20:44Z

Yes, this test ProjectorTest.testMakeProjectorParallel is not disabled while ProjectorTest.testMakeProjector is disabled.
https://github.com/apache/arrow/blob/main/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorTest.java#L152

Does it not occur before?

vibhatha · 2024-08-13T07:22:11Z

We should check that trace. We may have missed it.

vibhatha · 2024-08-13T10:03:40Z

@jinchengchenghh let's disable this too.

jinchengchenghh · 2024-08-14T07:21:37Z

Yes, I think we could disable the gandiva test in a separate PR. Can we merge this one first? @vibhatha

lidavidm · 2024-08-14T07:41:30Z

@github-actions crossbow submit -g java

github-actions · 2024-08-14T07:43:47Z

Revision: 855a3af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7af4649f9c

Task	Status
java-jars
test-conda-python-3.11-spark-master
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

jinchengchenghh · 2024-08-15T22:15:28Z

Can you help merge this one? @vibhatha Thanks!

vibhatha · 2024-08-16T00:00:46Z

@jinchengchenghh I don't have merge rights. @lidavidm will definitely merge this as it is already approved. LGTM as well.

jinchengchenghh · 2024-08-16T00:03:41Z

Ok. Thanks for your kindly review. @vibhatha

vibhatha · 2024-08-16T00:08:43Z

@jinchengchenghh did we file a new issue for the Gandiva failure?

jinchengchenghh · 2024-08-16T00:11:47Z

Maybe we can use the exists issue apache/arrow-java#63

vibhatha · 2024-08-16T00:13:10Z

Sure let's do that.

lidavidm · 2024-08-18T07:29:28Z

@vibhatha do we need to ping any Gandiva maintainers to figure out the failures?

vibhatha · 2024-08-18T07:32:19Z

@lidavidm I think so. And I think @kou also tried to fix this earlier.

lidavidm · 2024-08-18T07:56:35Z

ok, let me dig

vibhatha · 2024-08-18T12:46:04Z

Thanks @lidavidm, I am not well versed in this part of the project.

conbench-apache-arrow · 2024-08-18T15:22:16Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5ef7e01.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

…pache#43639) ### Rationale for this change JNI test was not tested in CI. So the test failed but passed the CI. The parseChar function should return char but return bool, a typo error. ### What changes are included in this PR? ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#43506 Authored-by: Chengcheng Jin <chengcheng.jin@intel.com> Signed-off-by: David Li <li.davidm96@gmail.com>

jinchengchenghh requested a review from lidavidm as a code owner August 12, 2024 07:47

github-actionsBot added Component: Java awaiting review Awaiting review labels Aug 12, 2024

vibhatha closed this Aug 12, 2024

vibhatha reopened this Aug 12, 2024

kou changed the title ~~[GH-43506] Fix TestFragmentScanOptions result not match~~GH-43506: [Java] Fix TestFragmentScanOptions result not matchAug 12, 2024

jinchengchenghh force-pushed the option branch from ea541c6 to 52871fdCompare August 13, 2024 01:18

jinchengchenghh added 2 commits August 13, 2024 08:50

fix TestFragmentScanOptions
77e5277

Fix parseChar return type
52871fd

jinchengchenghh added 2 commits August 13, 2024 10:13

fix test
a1be096

fix
855a3af

lidavidm approved these changes Aug 14, 2024
View reviewed changes

github-actionsBot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 14, 2024

vibhatha approved these changes Aug 16, 2024
View reviewed changes

jinchengchenghh mentioned this pull request Aug 16, 2024
[Java] Gandiva Tests are failing due to linking issues apache/arrow-java#63
Closed

lidavidm approved these changes Aug 18, 2024
View reviewed changes

lidavidm merged commit 5ef7e01 into apache:mainAug 18, 2024

lidavidm removed the awaiting merge Awaiting merge label Aug 18, 2024

lidavidm mentioned this pull request Aug 18, 2024
[Java] Fix TestFragmentScanOptions test result does not match #43506
Closed

Uh oh!

Conversation

jinchengchenghh commented Aug 12, 2024• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actionsBot commented Aug 12, 2024

Uh oh!

vibhatha commented Aug 12, 2024

Uh oh!

vibhatha commented Aug 12, 2024

Uh oh!

github-actionsBot commented Aug 12, 2024

Uh oh!

vibhatha commented Aug 12, 2024

Uh oh!

vibhatha commented Aug 12, 2024

Uh oh!

vibhatha commented Aug 12, 2024

Uh oh!

github-actionsBot commented Aug 12, 2024

Uh oh!

jinchengchenghh commented Aug 13, 2024

Uh oh!

jinchengchenghh commented Aug 13, 2024

Uh oh!

vibhatha commented Aug 13, 2024

Uh oh!

jinchengchenghh commented Aug 13, 2024

Uh oh!

vibhatha commented Aug 13, 2024

Uh oh!

kou commented Aug 13, 2024

Uh oh!

vibhatha commented Aug 13, 2024

Uh oh!

jinchengchenghh commented Aug 13, 2024

Uh oh!

vibhatha commented Aug 13, 2024

Uh oh!

vibhatha commented Aug 13, 2024

Uh oh!

jinchengchenghh commented Aug 14, 2024

Uh oh!

lidavidm commented Aug 14, 2024

Uh oh!

github-actionsBot commented Aug 14, 2024

Uh oh!

jinchengchenghh commented Aug 15, 2024

Uh oh!

vibhatha commented Aug 16, 2024

Uh oh!

jinchengchenghh commented Aug 16, 2024

Uh oh!

vibhatha commented Aug 16, 2024

Uh oh!

jinchengchenghh commented Aug 16, 2024

Uh oh!

vibhatha commented Aug 16, 2024

Uh oh!

lidavidm commented Aug 18, 2024

Uh oh!

vibhatha commented Aug 18, 2024

Uh oh!

lidavidm commented Aug 18, 2024

Uh oh!

vibhatha commented Aug 18, 2024

Uh oh!

conbench-apache-arrowBot commented Aug 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

jinchengchenghh commented Aug 12, 2024•
edited by github-actions Bot
Loading