GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders - #43736

Merged
jonkeane merged 15 commits into
apache:mainfrom
jonkeane:crammacm1
Aug 18, 2024
Merged

GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders#43736
jonkeane merged 15 commits into
apache:mainfrom
jonkeane:crammacm1

Conversation

@jonkeane

@jonkeanejonkeane commented Aug 17, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.

@jonkeane

jonkeane commented Aug 17, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-install-local

@github-actions

github-actionsBot commented Aug 17, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #43735has been automatically assigned in GitHub to PR creator.

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Aug 17, 2024
@github-actions

github-actionsBot commented Aug 17, 2024

Copy link
Copy Markdown

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd

Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c

TaskStatus
test-r-install-localGitHub Actions

@jonkeane

jonkeane commented Aug 17, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Aug 17, 2024

Copy link
Copy Markdown

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a

Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Aug 17, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Aug 17, 2024

Copy link
Copy Markdown

Revision: b75dd5945183896854d40862f834975c6fbba534

Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Aug 17, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Aug 17, 2024

Copy link
Copy Markdown

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb

Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Aug 17, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Aug 17, 2024

Copy link
Copy Markdown

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8

Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Aug 17, 2024

Copy link
Copy Markdown
MemberAuthor

The R version failure is resolved in #43737

kou
kou reviewed Aug 17, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake Outdated
Comment on lines 4968 to 4989

@koukouAug 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?

arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940 in 49be60f

set(GRPC_C_FLAGS "${EP_C_FLAGS}")
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}")
if(NOTMSVC)
# Negate warnings that gRPC cannot build under
# See https://github.com/grpc/grpc/issues/29417
string(APPEND
GRPC_C_FLAGS
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option")
string(APPEND
GRPC_CXX_FLAGS
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option")
endif()
set(GRPC_CMAKE_ARGS
"${EP_COMMON_CMAKE_ARGS}"
"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"

@jonkeanejonkeaneAug 17, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Aug 17, 2024
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 17, 2024
@jonkeane

jonkeane commented Aug 17, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g r

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 17, 2024
@github-actions

github-actionsBot commented Aug 17, 2024

Copy link
Copy Markdown

Revision: 5e80a72

Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061

TaskStatus
r-binary-packagesGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-r-sanitizerGitHub Actions

@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 17, 2024
kou
kou reviewed Aug 18, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake Outdated
Comment on lines +4978 to +4982
set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" "-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
"-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")

set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
${AWS_EP_COMMON_CMAKE_ARGS}

@koukouAug 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?

set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_C_FLAGS=${AWS_C_FLAGS}
-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
...

kou
kou reviewed Aug 18, 2024
View reviewed changes
Comment threaddev/tasks/tasks.yml Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 18, 2024
@jonkeane@kou
Update dev/tasks/tasks.yml
8df5b13
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 18, 2024
@jonkeane

jonkeane commented Aug 18, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Aug 18, 2024

Copy link
Copy Markdown

Revision: 625a847

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Aug 18, 2024

Copy link
Copy Markdown
MemberAuthor

The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR

@jonkeane
jonkeane marked this pull request as ready for review August 18, 2024 12:43
@jonkeane
jonkeane merged commit 1ae38d0 into apache:mainAug 18, 2024
@jonkeanejonkeane removed the awaiting change review Awaiting change review label Aug 18, 2024
@jonkeanejonkeane mentioned this pull request Aug 18, 2024
Closed
jonkeane added a commit that referenced this pull request Aug 18, 2024
@jonkeane@kou
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders (#4…
7998ed0
…3736)
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735
Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeanejonkeane mentioned this pull request Aug 18, 2024
Closed
38 tasks
@conbench-apache-arrow

conbench-apache-arrowBot commented Aug 18, 2024

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonkeane@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders - #43736
Merged
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Aug 18, 2024
Merged
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders#43736
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Conversation
@jonkeane
@jonkeanejonkeane
commented
Aug 17, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-install-local
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43735has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd
Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c
TaskStatus
test-r-install-localGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a
Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b75dd5945183896854d40862f834975c6fbba534
Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb
Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8
Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
The R version failure is resolved in #43737
kou
kou
reviewed
Aug 17, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

4968
 to 
4989

@koukouAug 17, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?
arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940
in
49be60f
set(GRPC_C_FLAGS "${EP_C_FLAGS}") 
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}") 
if(NOTMSVC) 
# Negate warnings that gRPC cannot build under
# See https://github.com/grpc/grpc/issues/29417
string(APPEND
 GRPC_C_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
string(APPEND
 GRPC_CXX_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
 endif() 
set(GRPC_CMAKE_ARGS 
"${EP_COMMON_CMAKE_ARGS}"
"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"
@jonkeanejonkeaneAug 17, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Aug 17, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g r
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 5e80a72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061
TaskStatus
r-binary-packagesGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

+4978
 to 
+4982

 set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" "-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
 "-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")

 set(AWSSDK_COMMON_CMAKE_ARGS
 ${EP_COMMON_CMAKE_ARGS}
 ${AWS_EP_COMMON_CMAKE_ARGS}
@koukouAug 18, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?
set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_C_FLAGS=${AWS_C_FLAGS}
-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
...
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threaddev/tasks/tasks.yml
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 18, 2024
@jonkeane@kou
Update dev/tasks/tasks.yml
8df5b13
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 18, 2024
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 18, 2024

Copy link


Copy Markdown

Revision: 625a847
Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR
@jonkeane
jonkeane
marked this pull request as ready for review
August 18, 2024 12:43
@jonkeane
jonkeane
merged commit 1ae38d0
into
apache:mainAug 18, 2024
@jonkeanejonkeane
removed
the 
awaiting change review
Awaiting change review
label
Aug 18, 2024
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

jonkeane added a commit
that referenced
this pull request
Aug 18, 2024
@jonkeane@kou
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders (#4…
7998ed0
…3736)
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735
Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

38 tasks
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Aug 18, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jonkeane@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders - #43736
Merged
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Aug 18, 2024
Merged
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders#43736
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Conversation
@jonkeane
@jonkeanejonkeane
commented
Aug 17, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-install-local
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43735has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd
Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c
TaskStatus
test-r-install-localGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a
Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b75dd5945183896854d40862f834975c6fbba534
Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb
Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8
Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
The R version failure is resolved in #43737
kou
kou
reviewed
Aug 17, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

4968
 to 
4989

@koukouAug 17, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?
arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940
in
49be60f
set(GRPC_C_FLAGS "${EP_C_FLAGS}") 
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}") 
if(NOTMSVC) 
# Negate warnings that gRPC cannot build under
# See https://github.com/grpc/grpc/issues/29417
string(APPEND
 GRPC_C_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
string(APPEND
 GRPC_CXX_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
 endif() 
set(GRPC_CMAKE_ARGS 
"${EP_COMMON_CMAKE_ARGS}"
"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"
@jonkeanejonkeaneAug 17, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Aug 17, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g r
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 5e80a72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061
TaskStatus
r-binary-packagesGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

+4978
 to 
+4982

 set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" "-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
 "-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")

 set(AWSSDK_COMMON_CMAKE_ARGS
 ${EP_COMMON_CMAKE_ARGS}
 ${AWS_EP_COMMON_CMAKE_ARGS}
@koukouAug 18, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?
set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_C_FLAGS=${AWS_C_FLAGS}
-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
...
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threaddev/tasks/tasks.yml
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 18, 2024
@jonkeane@kou
Update dev/tasks/tasks.yml
8df5b13
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 18, 2024
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 18, 2024

Copy link


Copy Markdown

Revision: 625a847
Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR
@jonkeane
jonkeane
marked this pull request as ready for review
August 18, 2024 12:43
@jonkeane
jonkeane
merged commit 1ae38d0
into
apache:mainAug 18, 2024
@jonkeanejonkeane
removed
the 
awaiting change review
Awaiting change review
label
Aug 18, 2024
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

jonkeane added a commit
that referenced
this pull request
Aug 18, 2024
@jonkeane@kou
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders (#4…
7998ed0
…3736)
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735
Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

38 tasks
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Aug 18, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jonkeane@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders - #43736
Merged
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Aug 18, 2024
Merged
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders#43736
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Conversation
@jonkeane
@jonkeanejonkeane
commented
Aug 17, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-install-local
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43735has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd
Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c
TaskStatus
test-r-install-localGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a
Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b75dd5945183896854d40862f834975c6fbba534
Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb
Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8
Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
The R version failure is resolved in #43737
kou
kou
reviewed
Aug 17, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

4968
 to 
4989

@koukouAug 17, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?
arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940
in
49be60f
set(GRPC_C_FLAGS "${EP_C_FLAGS}") 
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}") 
if(NOTMSVC) 
# Negate warnings that gRPC cannot build under
# See https://github.com/grpc/grpc/issues/29417
string(APPEND
 GRPC_C_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
string(APPEND
 GRPC_CXX_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
 endif() 
set(GRPC_CMAKE_ARGS 
"${EP_COMMON_CMAKE_ARGS}"
"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"
@jonkeanejonkeaneAug 17, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Aug 17, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g r
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 5e80a72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061
TaskStatus
r-binary-packagesGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

+4978
 to 
+4982

 set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" "-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
 "-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")

 set(AWSSDK_COMMON_CMAKE_ARGS
 ${EP_COMMON_CMAKE_ARGS}
 ${AWS_EP_COMMON_CMAKE_ARGS}
@koukouAug 18, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?
set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_C_FLAGS=${AWS_C_FLAGS}
-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
...
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threaddev/tasks/tasks.yml
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 18, 2024
@jonkeane@kou
Update dev/tasks/tasks.yml
8df5b13
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 18, 2024
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 18, 2024

Copy link


Copy Markdown

Revision: 625a847
Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR
@jonkeane
jonkeane
marked this pull request as ready for review
August 18, 2024 12:43
@jonkeane
jonkeane
merged commit 1ae38d0
into
apache:mainAug 18, 2024
@jonkeanejonkeane
removed
the 
awaiting change review
Awaiting change review
label
Aug 18, 2024
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

jonkeane added a commit
that referenced
this pull request
Aug 18, 2024
@jonkeane@kou
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders (#4…
7998ed0
…3736)
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735
Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

38 tasks
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Aug 18, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jonkeane@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders - #43736
Merged
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Aug 18, 2024
Merged
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders#43736
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Conversation
@jonkeane
@jonkeanejonkeane
commented
Aug 17, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-install-local
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43735has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd
Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c
TaskStatus
test-r-install-localGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a
Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b75dd5945183896854d40862f834975c6fbba534
Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb
Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8
Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
The R version failure is resolved in #43737
kou
kou
reviewed
Aug 17, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

4968
 to 
4989

@koukouAug 17, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?
arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940
in
49be60f
set(GRPC_C_FLAGS "${EP_C_FLAGS}") 
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}") 
if(NOTMSVC) 
# Negate warnings that gRPC cannot build under
# See https://github.com/grpc/grpc/issues/29417
string(APPEND
 GRPC_C_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
string(APPEND
 GRPC_CXX_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
 endif() 
set(GRPC_CMAKE_ARGS 
"${EP_COMMON_CMAKE_ARGS}"
"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"
@jonkeanejonkeaneAug 17, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Aug 17, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g r
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 5e80a72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061
TaskStatus
r-binary-packagesGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

+4978
 to 
+4982

 set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" "-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
 "-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")

 set(AWSSDK_COMMON_CMAKE_ARGS
 ${EP_COMMON_CMAKE_ARGS}
 ${AWS_EP_COMMON_CMAKE_ARGS}
@koukouAug 18, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?
set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_C_FLAGS=${AWS_C_FLAGS}
-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
...
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threaddev/tasks/tasks.yml
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 18, 2024
@jonkeane@kou
Update dev/tasks/tasks.yml
8df5b13
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 18, 2024
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 18, 2024

Copy link


Copy Markdown

Revision: 625a847
Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR
@jonkeane
jonkeane
marked this pull request as ready for review
August 18, 2024 12:43
@jonkeane
jonkeane
merged commit 1ae38d0
into
apache:mainAug 18, 2024
@jonkeanejonkeane
removed
the 
awaiting change review
Awaiting change review
label
Aug 18, 2024
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

jonkeane added a commit
that referenced
this pull request
Aug 18, 2024
@jonkeane@kou
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders (#4…
7998ed0
…3736)
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735
Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

38 tasks
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Aug 18, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jonkeane@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders - #43736
Merged
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Aug 18, 2024
Merged
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders#43736
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Conversation
@jonkeane
@jonkeanejonkeane
commented
Aug 17, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-install-local
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43735has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd
Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c
TaskStatus
test-r-install-localGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a
Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b75dd5945183896854d40862f834975c6fbba534
Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb
Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8
Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
The R version failure is resolved in #43737
kou
kou
reviewed
Aug 17, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

4968
 to 
4989

@koukouAug 17, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?
arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940
in
49be60f
set(GRPC_C_FLAGS "${EP_C_FLAGS}") 
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}") 
if(NOTMSVC) 
# Negate warnings that gRPC cannot build under
# See https://github.com/grpc/grpc/issues/29417
string(APPEND
 GRPC_C_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
string(APPEND
 GRPC_CXX_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
 endif() 
set(GRPC_CMAKE_ARGS 
"${EP_COMMON_CMAKE_ARGS}"
"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"
@jonkeanejonkeaneAug 17, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Aug 17, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g r
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 5e80a72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061
TaskStatus
r-binary-packagesGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

+4978
 to 
+4982

 set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" "-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
 "-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")

 set(AWSSDK_COMMON_CMAKE_ARGS
 ${EP_COMMON_CMAKE_ARGS}
 ${AWS_EP_COMMON_CMAKE_ARGS}
@koukouAug 18, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?
set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_C_FLAGS=${AWS_C_FLAGS}
-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
...
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threaddev/tasks/tasks.yml
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 18, 2024
@jonkeane@kou
Update dev/tasks/tasks.yml
8df5b13
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 18, 2024
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 18, 2024

Copy link


Copy Markdown

Revision: 625a847
Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR
@jonkeane
jonkeane
marked this pull request as ready for review
August 18, 2024 12:43
@jonkeane
jonkeane
merged commit 1ae38d0
into
apache:mainAug 18, 2024
@jonkeanejonkeane
removed
the 
awaiting change review
Awaiting change review
label
Aug 18, 2024
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

jonkeane added a commit
that referenced
this pull request
Aug 18, 2024
@jonkeane@kou
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders (#4…
7998ed0
…3736)
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735
Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

38 tasks
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Aug 18, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jonkeane@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders - #43736
Merged
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Aug 18, 2024
Merged
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders#43736
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Conversation
@jonkeane
@jonkeanejonkeane
commented
Aug 17, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-install-local
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43735has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd
Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c
TaskStatus
test-r-install-localGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a
Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b75dd5945183896854d40862f834975c6fbba534
Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb
Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8
Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
The R version failure is resolved in #43737
kou
kou
reviewed
Aug 17, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

4968
 to 
4989

@koukouAug 17, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?
arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940
in
49be60f
set(GRPC_C_FLAGS "${EP_C_FLAGS}") 
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}") 
if(NOTMSVC) 
# Negate warnings that gRPC cannot build under
# See https://github.com/grpc/grpc/issues/29417
string(APPEND
 GRPC_C_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
string(APPEND
 GRPC_CXX_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
 endif() 
set(GRPC_CMAKE_ARGS 
"${EP_COMMON_CMAKE_ARGS}"
"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"
@jonkeanejonkeaneAug 17, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Aug 17, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g r
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 5e80a72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061
TaskStatus
r-binary-packagesGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

+4978
 to 
+4982

 set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" "-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
 "-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")

 set(AWSSDK_COMMON_CMAKE_ARGS
 ${EP_COMMON_CMAKE_ARGS}
 ${AWS_EP_COMMON_CMAKE_ARGS}
@koukouAug 18, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?
set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_C_FLAGS=${AWS_C_FLAGS}
-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
...
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threaddev/tasks/tasks.yml
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 18, 2024
@jonkeane@kou
Update dev/tasks/tasks.yml
8df5b13
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 18, 2024
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 18, 2024

Copy link


Copy Markdown

Revision: 625a847
Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR
@jonkeane
jonkeane
marked this pull request as ready for review
August 18, 2024 12:43
@jonkeane
jonkeane
merged commit 1ae38d0
into
apache:mainAug 18, 2024
@jonkeanejonkeane
removed
the 
awaiting change review
Awaiting change review
label
Aug 18, 2024
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

jonkeane added a commit
that referenced
this pull request
Aug 18, 2024
@jonkeane@kou
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders (#4…
7998ed0
…3736)
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735
Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

38 tasks
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Aug 18, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jonkeane@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders - #43736
Merged
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Aug 18, 2024
Merged
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders#43736
jonkeane merged 15 commits into
apache:mainfrom 
jonkeane:crammacm1
Conversation
@jonkeane
@jonkeanejonkeane
commented
Aug 17, 2024•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Member
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-install-local
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

⚠️ GitHub issue #43735has been automatically assigned in GitHub to PR creator.
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd
Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c
TaskStatus
test-r-install-localGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a
Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: b75dd5945183896854d40862f834975c6fbba534
Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb
Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8
Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
The R version failure is resolved in #43737
kou
kou
reviewed
Aug 17, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

4968
 to 
4989

@koukouAug 17, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?
arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940
in
49be60f
set(GRPC_C_FLAGS "${EP_C_FLAGS}") 
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}") 
if(NOTMSVC) 
# Negate warnings that gRPC cannot build under
# See https://github.com/grpc/grpc/issues/29417
string(APPEND
 GRPC_C_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
string(APPEND
 GRPC_CXX_FLAGS 
" -Wno-attributes"
" -Wno-format-security"
" -Wno-unknown-warning-option") 
 endif() 
set(GRPC_CMAKE_ARGS 
"${EP_COMMON_CMAKE_ARGS}"
"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"
@jonkeanejonkeaneAug 17, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting committer review
Awaiting committer review
labels
Aug 17, 2024
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
@jonkeane
jonkeane
commented
Aug 17, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g r
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 17, 2024
@github-actions
github-actionsBot
commented
Aug 17, 2024

Copy link


Copy Markdown

Revision: 5e80a72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061
TaskStatus
r-binary-packagesGitHub Actions
test-r-arrow-backwards-compatibilityGitHub Actions
test-r-clang-sanitizerGitHub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGitHub Actions
test-r-dev-duckdbGitHub Actions
test-r-devdocsGitHub Actions
test-r-extra-packagesGitHub Actions
test-r-gcc-11GitHub Actions
test-r-gcc-12GitHub Actions
test-r-install-localGitHub Actions
test-r-install-local-minsizerelGitHub Actions
test-r-linux-as-cranGitHub Actions
test-r-linux-rchkGitHub Actions
test-r-linux-valgrindGitHub Actions
test-r-macos-as-cranGitHub Actions
test-r-minimal-buildAzure
test-r-offline-maximalGitHub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-release-latestAzure
test-r-rocker-r-ver-latestAzure
test-r-rstudio-r-base-4.1-opensuse155Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04GitHub Actions
test-r-versionsGitHub Actions
test-ubuntu-r-sanitizerGitHub Actions
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 17, 2024
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated


Comment on lines

+4978
 to 
+4982

 set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" "-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
 "-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")

 set(AWSSDK_COMMON_CMAKE_ARGS
 ${EP_COMMON_CMAKE_ARGS}
 ${AWS_EP_COMMON_CMAKE_ARGS}
@koukouAug 18, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?
set(AWSSDK_COMMON_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS}
-DCMAKE_C_FLAGS=${AWS_C_FLAGS}
-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
...
kou
kou
reviewed
Aug 18, 2024
View reviewed changes
Comment threaddev/tasks/tasks.yml
Outdated

@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Aug 18, 2024
@jonkeane@kou
Update dev/tasks/tasks.yml
8df5b13
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actionsgithub-actionsBot
added

awaiting change review
Awaiting change review
and removed

awaiting changes
Awaiting changes
labels
Aug 18, 2024
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit test-r-macos-as-cran
@github-actions
github-actionsBot
commented
Aug 18, 2024

Copy link


Copy Markdown

Revision: 625a847
Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3
TaskStatus
test-r-macos-as-cranGitHub Actions
@jonkeane
jonkeane
commented
Aug 18, 2024

Copy link


Copy Markdown

MemberAuthor
The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR
@jonkeane
jonkeane
marked this pull request as ready for review
August 18, 2024 12:43
@jonkeane
jonkeane
merged commit 1ae38d0
into
apache:mainAug 18, 2024
@jonkeanejonkeane
removed
the 
awaiting change review
Awaiting change review
label
Aug 18, 2024
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

jonkeane added a commit
that referenced
this pull request
Aug 18, 2024
@jonkeane@kou
GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders (#4…
7998ed0
…3736)
Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735
Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeanejonkeane
mentioned this pull request
Aug 18, 2024

Closed

38 tasks
@conbench-apache-arrow
conbench-apache-arrowBot
commented
Aug 18, 2024

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou left review comments
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jonkeane@kou