Skip to content

GH-43883: [CI] Remove Python version guard when installing GCS testbench - #43884

Merged
pitrou merged 4 commits into
apache:mainfrom
pitrou:gh43883-gcs-testbench-py-version
Sep 2, 2024
Merged

GH-43883: [CI] Remove Python version guard when installing GCS testbench#43884
pitrou merged 4 commits into
apache:mainfrom
pitrou:gh43883-gcs-testbench-py-version

Conversation

@pitrou

@pitroupitrou commented Aug 29, 2024•
edited
Loading

Copy link
Copy Markdown
Member

We can now use the GCS testbench even if we are testing a Python version that does not support it.

@github-actions

github-actionsBot commented Aug 29, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #43883has been automatically assigned in GitHub to PR creator.

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Aug 29, 2024
@pitrou

pitrou commented Aug 29, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2014-cp38-amd64 wheel-manylinux-2014-cp38-arm64 wheel-manylinux-2014-cp313-amd64 wheel-manylinux-2014-cp313-arm64 wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed the gh43883-gcs-testbench-py-version branch from 8fc4c1d to d8cd7cfCompareAugust 29, 2024 08:56
@pitrou

pitrou commented Aug 29, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 wheel-macos-catalina-cp38-amd64 wheel-macos-catalina-cp313-amd64

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed the gh43883-gcs-testbench-py-version branch from d8cd7cf to 0f522cdCompareAugust 29, 2024 09:04
@pitrou

pitrou commented Aug 29, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 wheel-macos-catalina-cp38-amd64 wheel-macos-catalina-cp313-amd64

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed the gh43883-gcs-testbench-py-version branch from 0f522cd to ea00794CompareAugust 29, 2024 09:38
@pitrou

pitrou commented Aug 29, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-macos wheel-linux

@pitrou

pitrou commented Aug 29, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python -g r

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou marked this pull request as ready for review August 29, 2024 10:50
kou
kou approved these changes Aug 29, 2024
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment threadci/scripts/install_gcs_testbench.sh Outdated
Comment threadci/scripts/install_gcs_testbench.sh Outdated
@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 29, 2024
@pitrou
pitrouforce-pushed the gh43883-gcs-testbench-py-version branch from ea00794 to 9118ef1CompareSeptember 2, 2024 16:00
@pitrou

pitrou commented Sep 2, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@pitrou

pitrou commented Sep 2, 2024

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelmacos wheellinux

@github-actions

github-actionsBot commented Sep 2, 2024

Copy link
Copy Markdown

Revision: 9118ef1

Submitted crossbow builds: ursacomputing/crossbow @ actions-a6eb850120

TaskStatus
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-alpine-linux-cppGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-cython2GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.10-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.10-substraitGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.8GitHub Actions
test-conda-python-3.8-pandas-1.0-numpy-1.19GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-latest-numpy-latestGitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cppGitHub Actions
test-cuda-pythonGitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-20.04-cppGitHub Actions
test-ubuntu-20.04-cpp-bundledGitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-20.04-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions

@github-actions

github-actionsBot commented Sep 2, 2024

Copy link
Copy Markdown

Revision: 9118ef1

Submitted crossbow builds: ursacomputing/crossbow @ actions-b4e876b95b

TaskStatus
wheel-macos-monterey-cp310-amd64GitHub Actions
wheel-macos-monterey-cp310-arm64GitHub Actions
wheel-macos-monterey-cp311-amd64GitHub Actions
wheel-macos-monterey-cp311-arm64GitHub Actions
wheel-macos-monterey-cp312-amd64GitHub Actions
wheel-macos-monterey-cp312-arm64GitHub Actions
wheel-macos-monterey-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-arm64GitHub Actions
wheel-macos-monterey-cp38-amd64GitHub Actions
wheel-macos-monterey-cp38-arm64GitHub Actions
wheel-macos-monterey-cp39-amd64GitHub Actions
wheel-macos-monterey-cp39-arm64GitHub Actions
wheel-manylinux-2-28-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp38-amd64GitHub Actions
wheel-manylinux-2-28-cp38-arm64GitHub Actions
wheel-manylinux-2-28-cp39-amd64GitHub Actions
wheel-manylinux-2-28-cp39-arm64GitHub Actions
wheel-manylinux-2014-cp310-amd64GitHub Actions
wheel-manylinux-2014-cp310-arm64GitHub Actions
wheel-manylinux-2014-cp311-amd64GitHub Actions
wheel-manylinux-2014-cp311-arm64GitHub Actions
wheel-manylinux-2014-cp312-amd64GitHub Actions
wheel-manylinux-2014-cp312-arm64GitHub Actions
wheel-manylinux-2014-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp38-amd64GitHub Actions
wheel-manylinux-2014-cp38-arm64GitHub Actions
wheel-manylinux-2014-cp39-amd64GitHub Actions
wheel-manylinux-2014-cp39-arm64GitHub Actions

@pitrou

pitrou commented Sep 2, 2024

Copy link
Copy Markdown
MemberAuthor

I've addressed your review comments @kou (I didn't know bash had arrays!). I'll merge if CI passes. Thank you!

@pitrou
pitrou merged commit 7d4cf37 into apache:mainSep 2, 2024
@pitroupitrou removed the awaiting merge Awaiting merge label Sep 2, 2024
@pitroupitrou mentioned this pull request Sep 2, 2024
Closed
@pitrou
pitrou deleted the gh43883-gcs-testbench-py-version branch September 2, 2024 16:55
@conbench-apache-arrow

conbench-apache-arrowBot commented Sep 3, 2024

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7d4cf37.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
@pitrou@khwilson
apacheGH-43883: [CI] Remove Python version guard when installing GCS …
7ed01ee
…testbench (apache#43884)
We can now use the GCS testbench even if we are testing a Python version that does not support it.
* GitHub Issue: apache#43883
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@jorisvandenbosschejorisvandenbossche mentioned this pull request Sep 23, 2024
Closed
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@jorisvandenbosschejorisvandenbosscheAwaiting requested review from jorisvandenbossche

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pitrou@kou