Skip to content

GH-43576: [Java] Gandiva Tests are failing due to linking issues - #43978

Merged
lidavidm merged 3 commits into
apache:mainfrom
vibhatha:feat-disable-gandiva-failing-tests
Sep 10, 2024
Merged

GH-43576: [Java] Gandiva Tests are failing due to linking issues#43978
lidavidm merged 3 commits into
apache:mainfrom
vibhatha:feat-disable-gandiva-failing-tests

Conversation

@vibhatha

@vibhathavibhatha commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

Rationale for this change

Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component.

What changes are included in this PR?

This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests.
Re-enabling task will be tracked using https://github.com/apache/arrow/issues/43981

Are these changes tested?

Yes, by existing CIs and tests.

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue apache/arrow-java#63has been automatically assigned in GitHub to PR creator.

@vibhatha
vibhatha marked this pull request as ready for review September 9, 2024 09:39
@vibhatha

Copy link
Copy Markdown
ContributorAuthor

@lidavidm There are a very high number of test cases failing in the disabled test class. Instead of disabling each one, I disabled the class for now, but created a Github issue and tagged it in the disable message.

@danepitkindanepitkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think this is the right move. Hopefully Gandiva maintainers can help repair this module.

@github-actionsgithub-actionsBot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 9, 2024
@lidavidm
lidavidm merged commit f3dd298 into apache:mainSep 10, 2024
@lidavidmlidavidm removed the awaiting committer review Awaiting committer review label Sep 10, 2024
@github-actionsgithub-actionsBot added the awaiting merge Awaiting merge label Sep 10, 2024
@vibhatha

Copy link
Copy Markdown
ContributorAuthor

@danepitkin Yes, we need the Gandiva maintainers' support.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f3dd298.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 101 possible false positives for unstable benchmarks that are known to sometimes produce them.

khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
…che#43978)
### Rationale for this change
Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. ### What changes are included in this PR?
This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. Re-enabling task will be tracked using https://github.com/apache/arrow/issues/43981
### Are these changes tested?
Yes, by existing CIs and tests.
### Are there any user-facing changes?
No
* GitHub Issue: #43576
Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #43576 has no components, please add labels for components.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…che#43978)
### Rationale for this change
Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. ### What changes are included in this PR?
This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. Re-enabling task will be tracked using https://github.com/apache/arrow/issues/43981
### Are these changes tested?
Yes, by existing CIs and tests.
### Are there any user-facing changes?
No
* GitHub Issue: #43576
Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vibhatha@lidavidm@danepitkin