Skip to content

GH-43519: [Python][CI] Add Python 3.13 conda test build - #44192

Merged
raulcd merged 6 commits into
apache:mainfrom
jorisvandenbossche:gh-43519-conda
Oct 11, 2024
Merged

GH-43519: [Python][CI] Add Python 3.13 conda test build#44192
raulcd merged 6 commits into
apache:mainfrom
jorisvandenbossche:gh-43519-conda

Conversation

@jorisvandenbossche

@jorisvandenbosschejorisvandenbossche commented Sep 23, 2024

Copy link
Copy Markdown
Member

Rationale for this change

When adding Python 3.13 support (#43539), conda was not yet ready to support Python 3.13. But over the last weeks most conda packages having being updated, so trying again.

@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-3.13

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #43519has been automatically assigned in GitHub to PR creator.

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Sep 23, 2024
@github-actions

Copy link
Copy Markdown

Revision: d158130

Submitted crossbow builds: ursacomputing/crossbow @ actions-c5bb1eee3e

TaskStatus
test-conda-python-3.13GitHub Actions

@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-3.13

@github-actions

Copy link
Copy Markdown

Revision: 7ba4564

Submitted crossbow builds: ursacomputing/crossbow @ actions-1aece06481

TaskStatus
test-conda-python-3.13GitHub Actions

@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-3.13

@github-actions

Copy link
Copy Markdown

Revision: 00694df

Submitted crossbow builds: ursacomputing/crossbow @ actions-e431ba77ed

TaskStatus
test-conda-python-3.13GitHub Actions

@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-3.13

@github-actions

Copy link
Copy Markdown

Revision: fe77477

Submitted crossbow builds: ursacomputing/crossbow @ actions-e20eebe4b4

TaskStatus
test-conda-python-3.13GitHub Actions

@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-*

@github-actions

Copy link
Copy Markdown

Revision: fe77477

Submitted crossbow builds: ursacomputing/crossbow @ actions-0c7af69ade

TaskStatus
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-cython2GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.10-substraitGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions

@jorisvandenbossche
jorisvandenbossche marked this pull request as ready for review September 24, 2024 07:50
@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

Not entirely sure if it is worth adding this as long as we have to specify a custom channel (--channel conda-forge/label/python_rc), but the current version of the PR seems to work.

--channel conda-forge/label/python_rc \
$([ "$python" == $(gdb --batch --eval-command 'python import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")') ] && echo "gdb") \
"python=${python}.*=*_cpython" \
"python=${python}.*=*_cp*" \

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this change is that the build output name changed recently in https://github.com/conda-forge/python-feedstock/pull/679/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR106

While before the build name always ended with _cpython, they now changed it to end with _{{ abi_tag }} (so in practice something like _cp313.

The above _cp* should work for both cases, while still ensuring we get cpython and not pypy

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Sep 24, 2024
@github-actionsgithub-actionsBot removed the awaiting changes Awaiting changes label Oct 10, 2024
@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-*

@github-actionsgithub-actionsBot added the awaiting change review Awaiting change review label Oct 10, 2024
@github-actions

Copy link
Copy Markdown

Revision: 4d6f5c6

Submitted crossbow builds: ursacomputing/crossbow @ actions-445d0307de

TaskStatus
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-cython2GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.10-substraitGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
Member

Thanks @jorisvandenbossche , I missed that PR

@raulcdraulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raulcd
raulcd merged commit 45b3697 into apache:mainOct 11, 2024
@raulcdraulcd removed the awaiting change review Awaiting change review label Oct 11, 2024
@github-actionsgithub-actionsBot added the awaiting merge Awaiting merge label Oct 11, 2024
raulcd pushed a commit that referenced this pull request Oct 11, 2024
### Rationale for this change
When adding Python 3.13 support (#43539), conda was not yet ready to support Python 3.13. But over the last weeks most conda packages having being updated, so trying again.
* GitHub Issue: #43519
Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 45b3697.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting mergeAwaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jorisvandenbossche@raulcd