Uh oh!
There was an error while loading. Please reload this page.
GH-43572: [JS] Move most dependencies to the devDependencies - #44517
GH-43572: [JS] Move most dependencies to the devDependencies#44517sgonyea wants to merge 1 commit into
Conversation
domoritz
commented
Oct 23, 2024
This probably breaks the cli, no? I also think it's common to have typescript typings as dependencies. Iirc there was a similar pr recently that didn't work. |
7732ae6 to
e75311fComparesgonyea
commented
Oct 24, 2024
@domoritz Thanks for the review! I updated the PR to restore some of the imports used in the bin commands. It looks like the only js/bin being exported is the arrow2csv. But I restored the deps being imported directly in the js/bin to be safe. |
domoritz
commented
Oct 24, 2024
I think we need tslib and the helpers, though, no? |
domoritz
commented
Oct 26, 2024
Here is the pull request I was tinking of with discussion of why we need the dependencies: #43215. We could make the package lighter by removing the CLI tool from the public API. Would you like to make a pull request for that? |
| "@types/command-line-args": "^5.2.3", | ||
| "@types/command-line-usage": "^5.0.4", |
There was a problem hiding this comment.
these are indeed not needed since the cli doesn't expose types I think
| "@types/node": "^20.13.0", | ||
| "tslib": "^2.6.2", | ||
| "@swc/helpers": "^0.5.11", |
There was a problem hiding this comment.
These are dependencies since they are needed at runtime or for correct types.
brianretford
commented
May 9, 2025
Where'd this go? Need any help? |
domoritz
commented
May 10, 2025
I didn't get a response to my suggestion to remove the cli. |
thisisnic
commented
Mar 29, 2026
JS has now moved to https://github.com/apache/arrow-js and this PR appears to no longer be active, so I'm closing it |
Rationale for this change
Adding apache-arrow as a dependency causes its dependencies to interact with the projects own dependencies. It's also bloating up JS build sizes.
Moving these dependencies to devDependencies will resolve this issue.
What changes are included in this PR?
Moves most dependencies to devDependencies in the package.json.
Are these changes tested?
n/a
Are there any user-facing changes?
This does not change user-facing APIs.