Uh oh!
There was an error while loading. Please reload this page.
Conversation
pitrou
commented
Jun 5, 2019
pitrou
commented
Jun 6, 2019
Does it work? I get the following error here: |
ghost
commented
Jun 6, 2019
It's because |
pitrou
commented
Jun 6, 2019
Now I get another error: |
Ah sorry, forgot conda-forge is needed, and there appears to be a config file to pin certain packages: |
pitrou
commented
Jun 6, 2019
Thanks :-) It finally worked. |
kszucs
commented
Jun 11, 2019
Looks good to me, but let me check via crossbow. |
pitrou
commented
Jun 24, 2019
@ursabot crossbow build -g conda |
ursabot
commented
Jun 24, 2019
|
pitrou
commented
Jun 24, 2019
@ursabot crossbow package -g conda |
ursabot
commented
Jun 24, 2019
AMD64 Conda Crossbow (#24815) builder failed. Revision: 5685d10c4765b1bf5b34722339825d7f233b51e4 Crossbow: |
pitrou
commented
Jun 24, 2019
@ursabot crossbow package -g conda |
ursabot
commented
Jun 24, 2019
AMD64 Conda Crossbow (#24824) builder has been succeeded. Revision: 584ba8404c95810b4cf4e59209a4e438036989df Submitted crossbow builds: ursa-labs/crossbow @ ursabot-58
|
pitrou
commented
Jun 24, 2019
@ursabot crossbow package -g conda |
ursabot
commented
Jun 24, 2019
AMD64 Conda Crossbow (#24851) builder has been succeeded. Revision: eda0f67ff60f6d0e5fd51d2e0042a2b34b973cf5 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-59
|
pitrou
commented
Jun 24, 2019
kszucs
commented
Jun 24, 2019
I'm working on it #4649 |
pitrou
commented
Jun 26, 2019
@kszucs Could you help rebasing this and fixing conflicts? Thanks :-) |
ghost
commented
Jun 26, 2019
I just rebased this. |
I've just fetched it :) |
kszucs
commented
Jun 26, 2019
@ursabot crossbow package -g conda |
ursabot
commented
Jun 26, 2019
AMD64 Conda Crossbow (#26191) builder has been succeeded. Revision: f1e8b5db3fc27ef8ba6673df5fb0ae911647e3aa Submitted crossbow builds: ursa-labs/crossbow @ ursabot-77
|
pitrou
commented
Jun 26, 2019
@lihalite Can you add a test that |
ghost
commented
Jun 26, 2019
@pitrou done. |
pitrou
commented
Jun 26, 2019
@ursabot crossbow package -g conda |
ursabot
commented
Jun 26, 2019
AMD64 Conda Crossbow (#26209) builder has been succeeded. Revision: 689d61de2bcf2859cb44cd08f58e9072e0c73214 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-79
|
pitrou
commented
Jun 26, 2019
Not sure what happened but this build fails on uriparser: https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=123 |
kszucs
commented
Jun 26, 2019
@ursabot crossbow package conda-linux-gcc-py37 |
kszucs
commented
Jun 26, 2019
@ursabot crossbow package conda-linux-gcc-py37 |
ursabot
commented
Jun 26, 2019
AMD64 Conda Crossbow (#26379) builder has been succeeded. Revision: 7ca809be7c46a1f0bf299c4f143ab5dc950e8c61 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-84
|
kszucs
commented
Jun 27, 2019
@ursabot crossbow package conda-linux-gcc-py37 |
ursabot
commented
Jun 27, 2019
AMD64 Conda Crossbow (#27029) builder has been succeeded. Revision: f612508 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-90
|
| -DCMAKE_INSTALL_LIBDIR=$PREFIX/lib \ | ||
| -DLLVM_TOOLS_BINARY_DIR=$PREFIX/bin \ | ||
| -DARROW_DEPENDENCY_SOURCE=SYSTEM \ | ||
| -Duriparser_SOURCE=BUNDLED \ |
There was a problem hiding this comment.
Note that we need to package uriparser before we can release this on conda-forge; there bundling of thirdparties is not really accepted.
There was a problem hiding this comment.
Thanks for the update, didn't know that.
There was a problem hiding this comment.
Even for small private dependencies?
There was a problem hiding this comment.
I think we can temporarily statically-link uriparser, we had a bunch of stuff statically linked on conda-forge for a long time before the CMake refactor
kszucs
commented
Jun 27, 2019
@ursabot crossbow package -g conda |
ursabot
commented
Jun 27, 2019
AMD64 Conda Crossbow (#27040) builder has been succeeded. Revision: e764a59 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-91
|
kszucs
commented
Jun 27, 2019
@ursabot crossbow package conda-osx-clang-py27 conda-osx-clang-py36 |
ursabot
commented
Jun 27, 2019
AMD64 Conda Crossbow (#27173) builder has been succeeded. Revision: c0b95ac Submitted crossbow builds: ursa-labs/crossbow @ ursabot-93
|
kszucs
commented
Jun 27, 2019
Conda probably doesn't move the submodules to the testing directory, skipping the tests instead. |
kszucs
commented
Jun 27, 2019
@ursabot crossbow package -g conda |
ursabot
commented
Jun 27, 2019
AMD64 Conda Crossbow (#27225) builder has been succeeded. Revision: c1baa4c Submitted crossbow builds: ursa-labs/crossbow @ ursabot-94
|
codecov-io
commented
Jun 27, 2019
Codecov Report
@@ Coverage Diff @@## master #4473 +/- ##
===========================================
- Coverage 86.42% 64.96% -21.46%
===========================================
Files 989 482 -507 Lines 137498 63194 -74304 Branches 1418 0 -1418 ===========================================
- Hits 118834 41057 -77777 - Misses 18302 22137 +3835 + Partials 362 0 -362
Continue to review full report at Codecov.
|
wesm
commented
Jun 27, 2019
Ugly mess of conda-build warnings in the Windows build https://gist.github.com/wesm/fdbdcfb0882ecba6d27d563566c90532 I'm looking at the Windows build script |
wesm
commented
Jun 27, 2019
@ursabot crossbow package conda-win-vs2015-py36 conda-win-vs2015-py37 |
wesm
commented
Jun 27, 2019
@ursabot crossbow package conda-win-vs2015-py36 conda-win-vs2015-py37 |
wesm
left a comment
There was a problem hiding this comment.
+1. The Windows builds are passing now
wesm
commented
Jun 28, 2019
kszucs
commented
Jun 28, 2019
@wesm thanks for fixing the windows builds. When use use [skip ci] pattern in the commit message, then ursabot will skip executing that particular commit. It is because we proxy the request to the standard PR building mechanism of buildbot. |
No description provided.