Skip to content

GH-44729: [C++][Acero] Enable nested types for non-keys fields in AsofJoin operation - #44871

Open
mroz45 wants to merge 5 commits into
apache:mainfrom
mroz45:types
Open

GH-44729: [C++][Acero] Enable nested types for non-keys fields in AsofJoin operation#44871
mroz45 wants to merge 5 commits into
apache:mainfrom
mroz45:types

Conversation

@mroz45

@mroz45mroz45 commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

Rationale for this change

Add support for nested types

What changes are included in this PR?

Change unmnaterialized_table to use AppendArraySlice

Are these changes tested?

I added tests for case List, Fixed Size List and Struct

Are there any user-facing changes?

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@mroz45mroz45 closed this Nov 27, 2024
@mroz45mroz45 reopened this Nov 27, 2024
@mroz45
mroz45force-pushed the types branch 2 times, most recently from 105633e to cedceb5CompareNovember 27, 2024 15:20
@koukou changed the title GH-[44729]: [C++][Acero] Enable nested types for non-keys fields in AsofJoin operationGH-44729: [C++][Acero] Enable nested types for non-keys fields in AsofJoin operationNov 28, 2024
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #44729has been automatically assigned in GitHub to PR creator.

@yangason

Copy link
Copy Markdown

Is there any progress on this merge request?

@mroz45

Copy link
Copy Markdown
ContributorAuthor

Is there any progress on this merge request?

For now, it supports Map, Struct, and List. @zanmato1984, could you check if this approach is correct?

@github-actions

Copy link
Copy Markdown

Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.

@github-actionsgithub-actionsBot added the Status: stale-warning Issues and PRs flagged as stale which are due to be closed if no indication otherwise label Aug 26, 2026
@github-actionsgithub-actionsBot removed the Status: stale-warning Issues and PRs flagged as stale which are due to be closed if no indication otherwise label Aug 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mroz45@yangason