Uh oh!
There was an error while loading. Please reload this page.
GH-43416: [CI] Upgrade vcpkg version on our CI - #44919
Closed
raulcd wants to merge 3 commits into
Closed
Conversation
raulcd
commented
Dec 3, 2024
MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp39-amd64 |
|
raulcd
commented
Dec 3, 2024
MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 |
Revision: 64bd563 Submitted crossbow builds: ursacomputing/crossbow @ actions-6d419b6abd
|
raulcd
commented
Dec 3, 2024
MemberAuthor
This already looks better than the previous PR where it failed to build Arrow C++. |
raulcd
commented
Dec 3, 2024
MemberAuthor
@kou@assignUser@amoeba have you seen this absl missing symbol before? conda seems to be using this abseil version without problems: |
raulcd
commented
Dec 3, 2024
MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp312-cp312-amd64 |
Revision: 64bd563 Submitted crossbow builds: ursacomputing/crossbow @ actions-1238b5b942
|
kou
commented
Dec 4, 2024
Member
Hmm. Could you show build flags? diff --git a/ci/scripts/python_wheel_manylinux_build.sh b/ci/scripts/python_wheel_manylinux_build.sh
index 6365fcfacf..e28443e36d 100755
--- a/ci/scripts/python_wheel_manylinux_build.sh+++ b/ci/scripts/python_wheel_manylinux_build.sh@@ -132,7 +132,7 @@ cmake \
${ARROW_EXTRA_CMAKE_FLAGS} \
-G ${CMAKE_GENERATOR} \
/arrow/cpp
-cmake --build . --target install+cmake --build . --verbose --target install
popd
# Check that we don't expose any unwanted symbols |
raulcd
commented
Dec 4, 2024
MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 |
Revision: d5ccbf3 Submitted crossbow builds: ursacomputing/crossbow @ actions-bf973505be
|
MemberAuthor
I did investigated a little more. We can see this on the build log: If I do some minimal processing this seem to be all the libabsl related libraries present on the log: If I check on a local docker container the symbol seems missing on I'll try something that probably does not work :) |
raulcd
commented
Dec 4, 2024
MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64 |
Revision: 0a05df3 Submitted crossbow builds: ursacomputing/crossbow @ actions-d73e6f1d3e
|
kou
commented
Dec 5, 2024
Member
Thanks. If you can reproduce this in local, could you try changing link order in the command line you identified. |
MemberAuthor
It does seem that link order gets rid of the undefined symbol (manually modified build.ninja to change the link order) but I am currently facing a second undefined symbol: I'll keep investigating around around the link order. |
raulcd
commented
Apr 2, 2025
MemberAuthor
Closing stale in favor of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We are using a pretty old version and we are seeing some CI jobs.
What changes are included in this PR?
Upgrade vcpkg version
Are these changes tested?
on CI
Are there any user-facing changes?
No