ARROW-4845: [R] Compiler warnings on Windows MingW64 - #4511

Closed
romainfrancois wants to merge 3 commits into
apache:masterfrom
romainfrancois:ARROW-4845/sign_compare
Closed

ARROW-4845: [R] Compiler warnings on Windows MingW64#4511
romainfrancois wants to merge 3 commits into
apache:masterfrom
romainfrancois:ARROW-4845/sign_compare

Conversation

@romainfrancois

@romainfrancoisromainfrancois commented Jun 10, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@romainfrancois

romainfrancois commented Jun 10, 2019

Copy link
Copy Markdown
ContributorAuthor

This did not test on win builder because I supposed we need a new build of libarrow, #4413 followed up on #4316 and introduced some incompatibilities. https://win-builder.r-project.org/KG75rToaX3Qd/

How do we trigger new builds for https://github.com/rwinlib/arrow ? @jeroen@javierluraschi

@codecov-io

codecov-io commented Jun 10, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4511 into master will decrease coverage by 13.09%.
The diff coverage is 85.71%.

Impacted file tree graph

@@ Coverage Diff @@## master #4511 +/- ##
===========================================
- Coverage 88.11% 75.01% -13.1% 
===========================================
Files 850 54 -796 Lines 105774 3114 -102660 Branches 1253 0 -1253 ===========================================
- Hits 93203 2336 -90867 + Misses 12326 778 -11548 + Partials 245 0 -245
Impacted FilesCoverage Δ
r/src/arrowExports.cpp72.7% <ø> (ø)⬆️
r/src/recordbatch.cpp82.69% <85.71%> (+0.51%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
... and 788 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ee38f...7052b9e. Read the comment docs.

@nealrichardson

nealrichardson commented Jun 10, 2019

Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/ARROW-4845 shows lots of warnings that look to be from different lines--are you sure this is the only change needed?

@romainfrancois

romainfrancois commented Jun 11, 2019

Copy link
Copy Markdown
ContributorAuthor

I'm not sure, that's why I tried to trigger a win builder build with devtools::check_win_devel() but it ended with this:

*** arch - i386
"D:/RCompile/recent/R/bin/i386/Rscript.exe" "../tools/winlibs.R" 0.13.0.9000
Error in download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", : cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip'
In addition: Warning message:
In download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", :
cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip': HTTP status was '404 Not Found'
Execution halted
make: *** [winlibs] Error 1
ERROR: compilation failed for package 'arrow'
* removing 'd:/RCompile/CRANguest/R-devel/lib/arrow'

before it could show me compile errors.

pitrou
pitrou reviewed Jun 11, 2019
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix would indeed silence the warning, but some comments.

Comment threadr/src/recordbatch.cpp Outdated
Comment threadr/src/recordbatch.cpp Outdated
@romainfrancois

romainfrancois commented Jun 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Perhaps we can use -Wall on travis to get some other warnings as well.

@romainfrancois
romainfrancoisforce-pushed the ARROW-4845/sign_compare branch from 8ec6d6a to e646f82CompareJune 12, 2019 07:17
@romainfrancois
romainfrancois deleted the ARROW-4845/sign_compare branch June 12, 2019 08:30
@jeroen

jeroen commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

Once libarrow 0.14 is released you can send a PR to https://github.com/r-windows/rtools-packages and https://github.com/r-windows/rtools-backports and we can upload new binaries on rwinlib.

@wesm

wesm commented Jun 12, 2019

Copy link
Copy Markdown
Member

At some point we need to document the source build process on Windows rather than relying on pre-packaged binaries so that we can run it in CI, otherwise we will eventually get slammed with a Windows-only problem post-release

https://issues.apache.org/jira/browse/ARROW-3758

@jeroen

jeroen commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

The build process is documented and automated.

You can either build libarrow locally or send a PR to https://github.com/r-windows/rtools-backports and then download the binaries from appveyor, and build your R package with that.

There is nothing special about rwinlib, it's just a place where we host binaries for (stable) libraries. But you could host them anywhere else.

@asfimportasfimport mentioned this pull request Jun 12, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou left review comments

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@romainfrancois@codecov-io@nealrichardson@jeroen@wesm@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-4845: [R] Compiler warnings on Windows MingW64 - #4511
Closed
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Closed
ARROW-4845: [R] Compiler warnings on Windows MingW64#4511
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Conversation
@romainfrancois
@romainfrancoisromainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@romainfrancois
romainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

ContributorAuthor
This did not test on win builder because I supposed we need a new build of libarrow, #4413 followed up on #4316 and introduced some incompatibilities. https://win-builder.r-project.org/KG75rToaX3Qd/
How do we trigger new builds for https://github.com/rwinlib/arrow ? @jeroen@javierluraschi
@codecov-io
codecov-io
commented
Jun 10, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4511 into master will decrease coverage by 13.09%.

The diff coverage is 85.71%.
Impacted file tree graph
@@ Coverage Diff @@## master #4511 +/- ##
===========================================
- Coverage 88.11% 75.01% -13.1% 
===========================================
Files 850 54 -796 Lines 105774 3114 -102660 Branches 1253 0 -1253 ===========================================
- Hits 93203 2336 -90867 + Misses 12326 778 -11548 + Partials 245 0 -245
Impacted FilesCoverage Δ
r/src/arrowExports.cpp72.7% <ø> (ø)⬆️
r/src/recordbatch.cpp82.69% <85.71%> (+0.51%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
... and 788 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 48ee38f...7052b9e. Read the comment docs.
@nealrichardson
nealrichardson
commented
Jun 10, 2019

Copy link


Copy Markdown

Member
https://issues.apache.org/jira/browse/ARROW-4845 shows lots of warnings that look to be from different lines--are you sure this is the only change needed?
@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
I'm not sure, that's why I tried to trigger a win builder build with devtools::check_win_devel() but it ended with this:
*** arch - i386
"D:/RCompile/recent/R/bin/i386/Rscript.exe" "../tools/winlibs.R" 0.13.0.9000
Error in download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", : cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip'
In addition: Warning message:
In download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", :
cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip': HTTP status was '404 Not Found'
Execution halted
make: *** [winlibs] Error 1
ERROR: compilation failed for package 'arrow'
* removing 'd:/RCompile/CRANguest/R-devel/lib/arrow'

before it could show me compile errors.
pitrou
pitrou
reviewed
Jun 11, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix would indeed silence the warning, but some comments.
Comment threadr/src/recordbatch.cpp
Outdated

Comment threadr/src/recordbatch.cpp
Outdated

@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Perhaps we can use -Wall on travis to get some other warnings as well.
@romainfrancois
romainfrancoisforce-pushed
the
ARROW-4845/sign_compare
branch
from
8ec6d6a to
e646f82CompareJune 12, 2019 07:17
@romainfrancois
romainfrancois
deleted the

ARROW-4845/sign_compare

branch
June 12, 2019 08:30
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
Once libarrow 0.14 is released you can send a PR to https://github.com/r-windows/rtools-packages and https://github.com/r-windows/rtools-backports and we can upload new binaries on rwinlib.
@wesm
wesm
commented
Jun 12, 2019

Copy link


Copy Markdown

Member
At some point we need to document the source build process on Windows rather than relying on pre-packaged binaries so that we can run it in CI, otherwise we will eventually get slammed with a Windows-only problem post-release
https://issues.apache.org/jira/browse/ARROW-3758
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
The build process is documented and automated.
You can either build libarrow locally or send a PR to https://github.com/r-windows/rtools-backports and then download the binaries from appveyor, and build your R package with that.
There is nothing special about rwinlib, it's just a place where we host binaries for (stable) libraries. But you could host them anywhere else.
@asfimportasfimport
mentioned this pull request
Jun 12, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@romainfrancois@codecov-io@nealrichardson@jeroen@wesm@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4845: [R] Compiler warnings on Windows MingW64 - #4511
Closed
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Closed
ARROW-4845: [R] Compiler warnings on Windows MingW64#4511
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Conversation
@romainfrancois
@romainfrancoisromainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@romainfrancois
romainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

ContributorAuthor
This did not test on win builder because I supposed we need a new build of libarrow, #4413 followed up on #4316 and introduced some incompatibilities. https://win-builder.r-project.org/KG75rToaX3Qd/
How do we trigger new builds for https://github.com/rwinlib/arrow ? @jeroen@javierluraschi
@codecov-io
codecov-io
commented
Jun 10, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4511 into master will decrease coverage by 13.09%.

The diff coverage is 85.71%.
Impacted file tree graph
@@ Coverage Diff @@## master #4511 +/- ##
===========================================
- Coverage 88.11% 75.01% -13.1% 
===========================================
Files 850 54 -796 Lines 105774 3114 -102660 Branches 1253 0 -1253 ===========================================
- Hits 93203 2336 -90867 + Misses 12326 778 -11548 + Partials 245 0 -245
Impacted FilesCoverage Δ
r/src/arrowExports.cpp72.7% <ø> (ø)⬆️
r/src/recordbatch.cpp82.69% <85.71%> (+0.51%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
... and 788 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 48ee38f...7052b9e. Read the comment docs.
@nealrichardson
nealrichardson
commented
Jun 10, 2019

Copy link


Copy Markdown

Member
https://issues.apache.org/jira/browse/ARROW-4845 shows lots of warnings that look to be from different lines--are you sure this is the only change needed?
@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
I'm not sure, that's why I tried to trigger a win builder build with devtools::check_win_devel() but it ended with this:
*** arch - i386
"D:/RCompile/recent/R/bin/i386/Rscript.exe" "../tools/winlibs.R" 0.13.0.9000
Error in download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", : cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip'
In addition: Warning message:
In download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", :
cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip': HTTP status was '404 Not Found'
Execution halted
make: *** [winlibs] Error 1
ERROR: compilation failed for package 'arrow'
* removing 'd:/RCompile/CRANguest/R-devel/lib/arrow'

before it could show me compile errors.
pitrou
pitrou
reviewed
Jun 11, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix would indeed silence the warning, but some comments.
Comment threadr/src/recordbatch.cpp
Outdated

Comment threadr/src/recordbatch.cpp
Outdated

@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Perhaps we can use -Wall on travis to get some other warnings as well.
@romainfrancois
romainfrancoisforce-pushed
the
ARROW-4845/sign_compare
branch
from
8ec6d6a to
e646f82CompareJune 12, 2019 07:17
@romainfrancois
romainfrancois
deleted the

ARROW-4845/sign_compare

branch
June 12, 2019 08:30
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
Once libarrow 0.14 is released you can send a PR to https://github.com/r-windows/rtools-packages and https://github.com/r-windows/rtools-backports and we can upload new binaries on rwinlib.
@wesm
wesm
commented
Jun 12, 2019

Copy link


Copy Markdown

Member
At some point we need to document the source build process on Windows rather than relying on pre-packaged binaries so that we can run it in CI, otherwise we will eventually get slammed with a Windows-only problem post-release
https://issues.apache.org/jira/browse/ARROW-3758
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
The build process is documented and automated.
You can either build libarrow locally or send a PR to https://github.com/r-windows/rtools-backports and then download the binaries from appveyor, and build your R package with that.
There is nothing special about rwinlib, it's just a place where we host binaries for (stable) libraries. But you could host them anywhere else.
@asfimportasfimport
mentioned this pull request
Jun 12, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@romainfrancois@codecov-io@nealrichardson@jeroen@wesm@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4845: [R] Compiler warnings on Windows MingW64 - #4511
Closed
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Closed
ARROW-4845: [R] Compiler warnings on Windows MingW64#4511
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Conversation
@romainfrancois
@romainfrancoisromainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@romainfrancois
romainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

ContributorAuthor
This did not test on win builder because I supposed we need a new build of libarrow, #4413 followed up on #4316 and introduced some incompatibilities. https://win-builder.r-project.org/KG75rToaX3Qd/
How do we trigger new builds for https://github.com/rwinlib/arrow ? @jeroen@javierluraschi
@codecov-io
codecov-io
commented
Jun 10, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4511 into master will decrease coverage by 13.09%.

The diff coverage is 85.71%.
Impacted file tree graph
@@ Coverage Diff @@## master #4511 +/- ##
===========================================
- Coverage 88.11% 75.01% -13.1% 
===========================================
Files 850 54 -796 Lines 105774 3114 -102660 Branches 1253 0 -1253 ===========================================
- Hits 93203 2336 -90867 + Misses 12326 778 -11548 + Partials 245 0 -245
Impacted FilesCoverage Δ
r/src/arrowExports.cpp72.7% <ø> (ø)⬆️
r/src/recordbatch.cpp82.69% <85.71%> (+0.51%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
... and 788 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 48ee38f...7052b9e. Read the comment docs.
@nealrichardson
nealrichardson
commented
Jun 10, 2019

Copy link


Copy Markdown

Member
https://issues.apache.org/jira/browse/ARROW-4845 shows lots of warnings that look to be from different lines--are you sure this is the only change needed?
@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
I'm not sure, that's why I tried to trigger a win builder build with devtools::check_win_devel() but it ended with this:
*** arch - i386
"D:/RCompile/recent/R/bin/i386/Rscript.exe" "../tools/winlibs.R" 0.13.0.9000
Error in download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", : cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip'
In addition: Warning message:
In download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", :
cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip': HTTP status was '404 Not Found'
Execution halted
make: *** [winlibs] Error 1
ERROR: compilation failed for package 'arrow'
* removing 'd:/RCompile/CRANguest/R-devel/lib/arrow'

before it could show me compile errors.
pitrou
pitrou
reviewed
Jun 11, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix would indeed silence the warning, but some comments.
Comment threadr/src/recordbatch.cpp
Outdated

Comment threadr/src/recordbatch.cpp
Outdated

@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Perhaps we can use -Wall on travis to get some other warnings as well.
@romainfrancois
romainfrancoisforce-pushed
the
ARROW-4845/sign_compare
branch
from
8ec6d6a to
e646f82CompareJune 12, 2019 07:17
@romainfrancois
romainfrancois
deleted the

ARROW-4845/sign_compare

branch
June 12, 2019 08:30
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
Once libarrow 0.14 is released you can send a PR to https://github.com/r-windows/rtools-packages and https://github.com/r-windows/rtools-backports and we can upload new binaries on rwinlib.
@wesm
wesm
commented
Jun 12, 2019

Copy link


Copy Markdown

Member
At some point we need to document the source build process on Windows rather than relying on pre-packaged binaries so that we can run it in CI, otherwise we will eventually get slammed with a Windows-only problem post-release
https://issues.apache.org/jira/browse/ARROW-3758
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
The build process is documented and automated.
You can either build libarrow locally or send a PR to https://github.com/r-windows/rtools-backports and then download the binaries from appveyor, and build your R package with that.
There is nothing special about rwinlib, it's just a place where we host binaries for (stable) libraries. But you could host them anywhere else.
@asfimportasfimport
mentioned this pull request
Jun 12, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@romainfrancois@codecov-io@nealrichardson@jeroen@wesm@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-4845: [R] Compiler warnings on Windows MingW64 - #4511
Closed
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Closed
ARROW-4845: [R] Compiler warnings on Windows MingW64#4511
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Conversation
@romainfrancois
@romainfrancoisromainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@romainfrancois
romainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

ContributorAuthor
This did not test on win builder because I supposed we need a new build of libarrow, #4413 followed up on #4316 and introduced some incompatibilities. https://win-builder.r-project.org/KG75rToaX3Qd/
How do we trigger new builds for https://github.com/rwinlib/arrow ? @jeroen@javierluraschi
@codecov-io
codecov-io
commented
Jun 10, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4511 into master will decrease coverage by 13.09%.

The diff coverage is 85.71%.
Impacted file tree graph
@@ Coverage Diff @@## master #4511 +/- ##
===========================================
- Coverage 88.11% 75.01% -13.1% 
===========================================
Files 850 54 -796 Lines 105774 3114 -102660 Branches 1253 0 -1253 ===========================================
- Hits 93203 2336 -90867 + Misses 12326 778 -11548 + Partials 245 0 -245
Impacted FilesCoverage Δ
r/src/arrowExports.cpp72.7% <ø> (ø)⬆️
r/src/recordbatch.cpp82.69% <85.71%> (+0.51%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
... and 788 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 48ee38f...7052b9e. Read the comment docs.
@nealrichardson
nealrichardson
commented
Jun 10, 2019

Copy link


Copy Markdown

Member
https://issues.apache.org/jira/browse/ARROW-4845 shows lots of warnings that look to be from different lines--are you sure this is the only change needed?
@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
I'm not sure, that's why I tried to trigger a win builder build with devtools::check_win_devel() but it ended with this:
*** arch - i386
"D:/RCompile/recent/R/bin/i386/Rscript.exe" "../tools/winlibs.R" 0.13.0.9000
Error in download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", : cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip'
In addition: Warning message:
In download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", :
cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip': HTTP status was '404 Not Found'
Execution halted
make: *** [winlibs] Error 1
ERROR: compilation failed for package 'arrow'
* removing 'd:/RCompile/CRANguest/R-devel/lib/arrow'

before it could show me compile errors.
pitrou
pitrou
reviewed
Jun 11, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix would indeed silence the warning, but some comments.
Comment threadr/src/recordbatch.cpp
Outdated

Comment threadr/src/recordbatch.cpp
Outdated

@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Perhaps we can use -Wall on travis to get some other warnings as well.
@romainfrancois
romainfrancoisforce-pushed
the
ARROW-4845/sign_compare
branch
from
8ec6d6a to
e646f82CompareJune 12, 2019 07:17
@romainfrancois
romainfrancois
deleted the

ARROW-4845/sign_compare

branch
June 12, 2019 08:30
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
Once libarrow 0.14 is released you can send a PR to https://github.com/r-windows/rtools-packages and https://github.com/r-windows/rtools-backports and we can upload new binaries on rwinlib.
@wesm
wesm
commented
Jun 12, 2019

Copy link


Copy Markdown

Member
At some point we need to document the source build process on Windows rather than relying on pre-packaged binaries so that we can run it in CI, otherwise we will eventually get slammed with a Windows-only problem post-release
https://issues.apache.org/jira/browse/ARROW-3758
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
The build process is documented and automated.
You can either build libarrow locally or send a PR to https://github.com/r-windows/rtools-backports and then download the binaries from appveyor, and build your R package with that.
There is nothing special about rwinlib, it's just a place where we host binaries for (stable) libraries. But you could host them anywhere else.
@asfimportasfimport
mentioned this pull request
Jun 12, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@romainfrancois@codecov-io@nealrichardson@jeroen@wesm@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4845: [R] Compiler warnings on Windows MingW64 - #4511
Closed
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Closed
ARROW-4845: [R] Compiler warnings on Windows MingW64#4511
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Conversation
@romainfrancois
@romainfrancoisromainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@romainfrancois
romainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

ContributorAuthor
This did not test on win builder because I supposed we need a new build of libarrow, #4413 followed up on #4316 and introduced some incompatibilities. https://win-builder.r-project.org/KG75rToaX3Qd/
How do we trigger new builds for https://github.com/rwinlib/arrow ? @jeroen@javierluraschi
@codecov-io
codecov-io
commented
Jun 10, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4511 into master will decrease coverage by 13.09%.

The diff coverage is 85.71%.
Impacted file tree graph
@@ Coverage Diff @@## master #4511 +/- ##
===========================================
- Coverage 88.11% 75.01% -13.1% 
===========================================
Files 850 54 -796 Lines 105774 3114 -102660 Branches 1253 0 -1253 ===========================================
- Hits 93203 2336 -90867 + Misses 12326 778 -11548 + Partials 245 0 -245
Impacted FilesCoverage Δ
r/src/arrowExports.cpp72.7% <ø> (ø)⬆️
r/src/recordbatch.cpp82.69% <85.71%> (+0.51%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
... and 788 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 48ee38f...7052b9e. Read the comment docs.
@nealrichardson
nealrichardson
commented
Jun 10, 2019

Copy link


Copy Markdown

Member
https://issues.apache.org/jira/browse/ARROW-4845 shows lots of warnings that look to be from different lines--are you sure this is the only change needed?
@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
I'm not sure, that's why I tried to trigger a win builder build with devtools::check_win_devel() but it ended with this:
*** arch - i386
"D:/RCompile/recent/R/bin/i386/Rscript.exe" "../tools/winlibs.R" 0.13.0.9000
Error in download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", : cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip'
In addition: Warning message:
In download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", :
cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip': HTTP status was '404 Not Found'
Execution halted
make: *** [winlibs] Error 1
ERROR: compilation failed for package 'arrow'
* removing 'd:/RCompile/CRANguest/R-devel/lib/arrow'

before it could show me compile errors.
pitrou
pitrou
reviewed
Jun 11, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix would indeed silence the warning, but some comments.
Comment threadr/src/recordbatch.cpp
Outdated

Comment threadr/src/recordbatch.cpp
Outdated

@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Perhaps we can use -Wall on travis to get some other warnings as well.
@romainfrancois
romainfrancoisforce-pushed
the
ARROW-4845/sign_compare
branch
from
8ec6d6a to
e646f82CompareJune 12, 2019 07:17
@romainfrancois
romainfrancois
deleted the

ARROW-4845/sign_compare

branch
June 12, 2019 08:30
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
Once libarrow 0.14 is released you can send a PR to https://github.com/r-windows/rtools-packages and https://github.com/r-windows/rtools-backports and we can upload new binaries on rwinlib.
@wesm
wesm
commented
Jun 12, 2019

Copy link


Copy Markdown

Member
At some point we need to document the source build process on Windows rather than relying on pre-packaged binaries so that we can run it in CI, otherwise we will eventually get slammed with a Windows-only problem post-release
https://issues.apache.org/jira/browse/ARROW-3758
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
The build process is documented and automated.
You can either build libarrow locally or send a PR to https://github.com/r-windows/rtools-backports and then download the binaries from appveyor, and build your R package with that.
There is nothing special about rwinlib, it's just a place where we host binaries for (stable) libraries. But you could host them anywhere else.
@asfimportasfimport
mentioned this pull request
Jun 12, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@romainfrancois@codecov-io@nealrichardson@jeroen@wesm@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-4845: [R] Compiler warnings on Windows MingW64 - #4511
Closed
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Closed
ARROW-4845: [R] Compiler warnings on Windows MingW64#4511
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Conversation
@romainfrancois
@romainfrancoisromainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@romainfrancois
romainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

ContributorAuthor
This did not test on win builder because I supposed we need a new build of libarrow, #4413 followed up on #4316 and introduced some incompatibilities. https://win-builder.r-project.org/KG75rToaX3Qd/
How do we trigger new builds for https://github.com/rwinlib/arrow ? @jeroen@javierluraschi
@codecov-io
codecov-io
commented
Jun 10, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4511 into master will decrease coverage by 13.09%.

The diff coverage is 85.71%.
Impacted file tree graph
@@ Coverage Diff @@## master #4511 +/- ##
===========================================
- Coverage 88.11% 75.01% -13.1% 
===========================================
Files 850 54 -796 Lines 105774 3114 -102660 Branches 1253 0 -1253 ===========================================
- Hits 93203 2336 -90867 + Misses 12326 778 -11548 + Partials 245 0 -245
Impacted FilesCoverage Δ
r/src/arrowExports.cpp72.7% <ø> (ø)⬆️
r/src/recordbatch.cpp82.69% <85.71%> (+0.51%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
... and 788 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 48ee38f...7052b9e. Read the comment docs.
@nealrichardson
nealrichardson
commented
Jun 10, 2019

Copy link


Copy Markdown

Member
https://issues.apache.org/jira/browse/ARROW-4845 shows lots of warnings that look to be from different lines--are you sure this is the only change needed?
@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
I'm not sure, that's why I tried to trigger a win builder build with devtools::check_win_devel() but it ended with this:
*** arch - i386
"D:/RCompile/recent/R/bin/i386/Rscript.exe" "../tools/winlibs.R" 0.13.0.9000
Error in download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", : cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip'
In addition: Warning message:
In download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", :
cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip': HTTP status was '404 Not Found'
Execution halted
make: *** [winlibs] Error 1
ERROR: compilation failed for package 'arrow'
* removing 'd:/RCompile/CRANguest/R-devel/lib/arrow'

before it could show me compile errors.
pitrou
pitrou
reviewed
Jun 11, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix would indeed silence the warning, but some comments.
Comment threadr/src/recordbatch.cpp
Outdated

Comment threadr/src/recordbatch.cpp
Outdated

@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Perhaps we can use -Wall on travis to get some other warnings as well.
@romainfrancois
romainfrancoisforce-pushed
the
ARROW-4845/sign_compare
branch
from
8ec6d6a to
e646f82CompareJune 12, 2019 07:17
@romainfrancois
romainfrancois
deleted the

ARROW-4845/sign_compare

branch
June 12, 2019 08:30
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
Once libarrow 0.14 is released you can send a PR to https://github.com/r-windows/rtools-packages and https://github.com/r-windows/rtools-backports and we can upload new binaries on rwinlib.
@wesm
wesm
commented
Jun 12, 2019

Copy link


Copy Markdown

Member
At some point we need to document the source build process on Windows rather than relying on pre-packaged binaries so that we can run it in CI, otherwise we will eventually get slammed with a Windows-only problem post-release
https://issues.apache.org/jira/browse/ARROW-3758
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
The build process is documented and automated.
You can either build libarrow locally or send a PR to https://github.com/r-windows/rtools-backports and then download the binaries from appveyor, and build your R package with that.
There is nothing special about rwinlib, it's just a place where we host binaries for (stable) libraries. But you could host them anywhere else.
@asfimportasfimport
mentioned this pull request
Jun 12, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@romainfrancois@codecov-io@nealrichardson@jeroen@wesm@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-4845: [R] Compiler warnings on Windows MingW64 - #4511
Closed
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Closed
ARROW-4845: [R] Compiler warnings on Windows MingW64#4511
romainfrancois wants to merge 3 commits into
apache:masterfrom 
romainfrancois:ARROW-4845/sign_compare
Conversation
@romainfrancois
@romainfrancoisromainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@romainfrancois
romainfrancois
commented
Jun 10, 2019

Copy link


Copy Markdown

ContributorAuthor
This did not test on win builder because I supposed we need a new build of libarrow, #4413 followed up on #4316 and introduced some incompatibilities. https://win-builder.r-project.org/KG75rToaX3Qd/
How do we trigger new builds for https://github.com/rwinlib/arrow ? @jeroen@javierluraschi
@codecov-io
codecov-io
commented
Jun 10, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4511 into master will decrease coverage by 13.09%.

The diff coverage is 85.71%.
Impacted file tree graph
@@ Coverage Diff @@## master #4511 +/- ##
===========================================
- Coverage 88.11% 75.01% -13.1% 
===========================================
Files 850 54 -796 Lines 105774 3114 -102660 Branches 1253 0 -1253 ===========================================
- Hits 93203 2336 -90867 + Misses 12326 778 -11548 + Partials 245 0 -245
Impacted FilesCoverage Δ
r/src/arrowExports.cpp72.7% <ø> (ø)⬆️
r/src/recordbatch.cpp82.69% <85.71%> (+0.51%)⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
... and 788 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 48ee38f...7052b9e. Read the comment docs.
@nealrichardson
nealrichardson
commented
Jun 10, 2019

Copy link


Copy Markdown

Member
https://issues.apache.org/jira/browse/ARROW-4845 shows lots of warnings that look to be from different lines--are you sure this is the only change needed?
@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
I'm not sure, that's why I tried to trigger a win builder build with devtools::check_win_devel() but it ended with this:
*** arch - i386
"D:/RCompile/recent/R/bin/i386/Rscript.exe" "../tools/winlibs.R" 0.13.0.9000
Error in download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", : cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip'
In addition: Warning message:
In download.file(sprintf("https://github.com/rwinlib/arrow/archive/v%s.zip", :
cannot open URL 'https://github.com/rwinlib/arrow/archive/v0.13.0.9000.zip': HTTP status was '404 Not Found'
Execution halted
make: *** [winlibs] Error 1
ERROR: compilation failed for package 'arrow'
* removing 'd:/RCompile/CRANguest/R-devel/lib/arrow'

before it could show me compile errors.
pitrou
pitrou
reviewed
Jun 11, 2019
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix would indeed silence the warning, but some comments.
Comment threadr/src/recordbatch.cpp
Outdated

Comment threadr/src/recordbatch.cpp
Outdated

@romainfrancois
romainfrancois
commented
Jun 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Perhaps we can use -Wall on travis to get some other warnings as well.
@romainfrancois
romainfrancoisforce-pushed
the
ARROW-4845/sign_compare
branch
from
8ec6d6a to
e646f82CompareJune 12, 2019 07:17
@romainfrancois
romainfrancois
deleted the

ARROW-4845/sign_compare

branch
June 12, 2019 08:30
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
Once libarrow 0.14 is released you can send a PR to https://github.com/r-windows/rtools-packages and https://github.com/r-windows/rtools-backports and we can upload new binaries on rwinlib.
@wesm
wesm
commented
Jun 12, 2019

Copy link


Copy Markdown

Member
At some point we need to document the source build process on Windows rather than relying on pre-packaged binaries so that we can run it in CI, otherwise we will eventually get slammed with a Windows-only problem post-release
https://issues.apache.org/jira/browse/ARROW-3758
@jeroen
jeroen
commented
Jun 12, 2019

Copy link


Copy Markdown

Contributor
The build process is documented and automated.
You can either build libarrow locally or send a PR to https://github.com/r-windows/rtools-backports and then download the binaries from appveyor, and build your R package with that.
There is nothing special about rwinlib, it's just a place where we host binaries for (stable) libraries. But you could host them anywhere else.
@asfimportasfimport
mentioned this pull request
Jun 12, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou left review comments

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@romainfrancois@codecov-io@nealrichardson@jeroen@wesm@pitrou