GH-45978: [C++] Bump bundled mimalloc version - #45979

Merged
pitrou merged 2 commits into
apache:mainfrom
pitrou:gh45978-bump-mimalloc
Jun 12, 2025
Merged

GH-45978: [C++] Bump bundled mimalloc version#45979
pitrou merged 2 commits into
apache:mainfrom
pitrou:gh45978-bump-mimalloc

Conversation

@pitrou

@pitroupitrou commented Mar 31, 2025•
edited
Loading

Copy link
Copy Markdown
Member

What changes are included in this PR?

Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.

Are these changes tested?

Yes, by CI builds.

Are there any user-facing changes?

No.

@pitroupitrou mentioned this pull request Mar 31, 2025
Closed
@github-actions

github-actionsBot commented Mar 31, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #45978has been automatically assigned in GitHub to PR creator.

@pitrou

pitrou commented Mar 31, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Mar 31, 2025
@pitroupitrou mentioned this pull request Mar 31, 2025
Merged
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed the gh45978-bump-mimalloc branch from c9a3cbe to 161d91bCompareMarch 31, 2025 14:12
@pitrou

pitrou commented Mar 31, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou

pitrou commented Mar 31, 2025

Copy link
Copy Markdown
MemberAuthor

I've opened microsoft/mimalloc#1056 for the Alpine Linux failure but I don't think it should be holding this.

@pitroupitrou mentioned this pull request Mar 31, 2025
Closed
@pitrou
pitrouforce-pushed the gh45978-bump-mimalloc branch 2 times, most recently from 2185744 to 222ec0bCompareMarch 31, 2025 15:05
assignUser
assignUser reviewed Mar 31, 2025
View reviewed changes

@assignUserassignUser left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also need to forward snappy
Edit: #45980

Comment thread.github/workflows/cpp.yml Outdated
Comment on lines +299 to +311
ARROW_SUBSTRAIT: ON
ARROW_USE_GLOG: OFF
ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
ARROW_VERBOSE_THIRDPARTY_BUILD: ON

@assignUserassignUserMar 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'll revert these before merge?

@pitroupitrouMar 31, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was to debug the build/link errors on Windows which are now fixed.

@github-actionsgithub-actionsBot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 31, 2025
@pitrou
pitrouforce-pushed the gh45978-bump-mimalloc branch from 8241964 to 97490ecCompareJune 11, 2025 19:14
@pitrou

pitrou commented Jun 11, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g cpp -g python

@github-actions

github-actionsBot commented Jun 11, 2025

Copy link
Copy Markdown

Revision: 97490ec58b0ed1c9993b607aa0046bc7fbfde66a

Submitted crossbow builds: ursacomputing/crossbow @ actions-21dfeaf22e

TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@pitroupitrou added the CI: Extra Run extra CI label Jun 11, 2025
@pitrou

pitrou commented Jun 11, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheelcp313*

@pitrou
apacheGH-45978: [C++] Bump bundled mimalloc version
1fe3480
Update bundled mimalloc version from 2.0.6 to 2.2.4.
This will also help fix the CMake 4.0 compatibility issues.
@pitrou
pitrouforce-pushed the gh45978-bump-mimalloc branch from 97490ec to 1fe3480CompareJune 11, 2025 20:03
@github-actions

github-actionsBot commented Jun 11, 2025

Copy link
Copy Markdown

Revision: 1fe3480

Submitted crossbow builds: ursacomputing/crossbow @ actions-dc8e7b294f

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@pitrou

pitrou commented Jun 11, 2025

Copy link
Copy Markdown
MemberAuthor

This is ready for review @kou . CI looks good except for a probably unrelated failure in the Python emscripten build.

kou
kou approved these changes Jun 11, 2025
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake Outdated
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake Outdated
@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 11, 2025
@pitrou
pitrouforce-pushed the gh45978-bump-mimalloc branch from 5af7504 to cc5d86eCompareJune 12, 2025 05:29
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Jun 12, 2025
@pitrou
pitrou merged commit 0826be5 into apache:mainJun 12, 2025
@pitroupitrou removed the awaiting changes Awaiting changes label Jun 12, 2025
@pitroupitrou mentioned this pull request Jun 12, 2025
Closed
@pitrou
pitrou deleted the gh45978-bump-mimalloc branch June 12, 2025 08:00
@pitroupitrou mentioned this pull request Jun 12, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Jun 12, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0826be5.

There were 76 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.

alinaliBQ pushed a commit to Bit-Quill/arrow that referenced this pull request Jun 17, 2025
@pitrou@alinaliBQ
apacheGH-45978: [C++] Bump bundled mimalloc version (apache#45979)
dc4defe
### What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
### Are these changes tested?
Yes, by CI builds.
### Are there any user-facing changes?
No.
* GitHub Issue: apache#45978
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@koukou mentioned this pull request Jul 4, 2025
Closed
@kou

kou commented Jul 4, 2025

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-r-linux-sanitizers

@github-actions

github-actionsBot commented Jul 4, 2025

Copy link
Copy Markdown

Revision: cc5d86e

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f9a3a132

TaskStatus
test-r-linux-sanitizersGitHub Actions

@Tom-NewtonTom-Newton mentioned this pull request Aug 6, 2025
Closed
@Tom-Newton

Tom-Newton commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

I think this change has caused a memory leak when reading parquet #47266

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserassignUser left review comments
@jonkeanejonkeaneAwaiting requested review from jonkeane
@raulcdraulcdAwaiting requested review from raulcd

Assignees

No one assigned

Labels

CI: ExtraRun extra CIComponent: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@Tom-Newton@assignUser
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-45978: [C++] Bump bundled mimalloc version - #45979
Merged
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Jun 12, 2025
Merged
GH-45978: [C++] Bump bundled mimalloc version#45979
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Conversation
@pitrou
@pitroupitrou
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Member
What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
Are these changes tested?
Yes, by CI builds.
Are there any user-facing changes?
No.
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Closed

@github-actions
github-actionsBot
commented
Mar 31, 2025

Copy link


Copy Markdown

⚠️ GitHub issue #45978has been automatically assigned in GitHub to PR creator.
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 31, 2025
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Merged

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
c9a3cbe to
161d91bCompareMarch 31, 2025 14:12
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
I've opened microsoft/mimalloc#1056 for the Alpine Linux failure but I don't think it should be holding this.
@pitroupitrou
mentioned this pull request
Mar 31, 2025

Closed

@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
2 times, most recently
from
2185744 to
222ec0bCompareMarch 31, 2025 15:05
assignUser
assignUser
reviewed
Mar 31, 2025
View reviewed changes
@assignUserassignUser
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also need to forward snappy 

Edit: #45980
Comment thread.github/workflows/cpp.yml
Outdated


Comment on lines

+299
 to 
+311

 ARROW_SUBSTRAIT: ON
 ARROW_USE_GLOG: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: ON
@assignUserassignUserMar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'll revert these before merge?
@pitroupitrouMar 31, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was to debug the build/link errors on Windows which are now fixed.
@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Mar 31, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
8241964 to
97490ecCompareJune 11, 2025 19:14
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 97490ec58b0ed1c9993b607aa0046bc7fbfde66a
Submitted crossbow builds: ursacomputing/crossbow @ actions-21dfeaf22e
TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions
@pitroupitrou
added
the 
CI: Extra
Run extra CI
label
Jun 11, 2025
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheelcp313*
@pitrou
apacheGH-45978: [C++] Bump bundled mimalloc version
1fe3480
Update bundled mimalloc version from 2.0.6 to 2.2.4.
This will also help fix the CMake 4.0 compatibility issues.
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
97490ec to
1fe3480CompareJune 11, 2025 20:03
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 1fe3480
Submitted crossbow builds: ursacomputing/crossbow @ actions-dc8e7b294f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
This is ready for review @kou . CI looks good except for a probably unrelated failure in the Python emscripten build.
kou
kou
approved these changes
Jun 11, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Jun 11, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
5af7504 to
cc5d86eCompareJune 12, 2025 05:29
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting merge
Awaiting merge
labels
Jun 12, 2025
@pitrou
pitrou
merged commit 0826be5
into
apache:mainJun 12, 2025
@pitroupitrou
removed
the 
awaiting changes
Awaiting changes
label
Jun 12, 2025
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@pitrou
pitrou
deleted the

gh45978-bump-mimalloc

branch
June 12, 2025 08:00
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jun 12, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0826be5.
There were 76 benchmark results with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.
alinaliBQ pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
@pitrou@alinaliBQ
apacheGH-45978: [C++] Bump bundled mimalloc version (apache#45979)
dc4defe
### What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
### Are these changes tested?
Yes, by CI builds.
### Are there any user-facing changes?
No.
* GitHub Issue: apache#45978
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@koukou
mentioned this pull request
Jul 4, 2025

Closed

@kou
kou
commented
Jul 4, 2025

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-r-linux-sanitizers
@github-actions
github-actionsBot
commented
Jul 4, 2025

Copy link


Copy Markdown

Revision: cc5d86e
Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f9a3a132
TaskStatus
test-r-linux-sanitizersGitHub Actions
@Tom-NewtonTom-Newton
mentioned this pull request
Aug 6, 2025

Closed

@Tom-Newton
Tom-Newton
commented
Aug 6, 2025

Copy link


Copy Markdown

Contributor
I think this change has caused a memory leak when reading parquet #47266
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserassignUser left review comments
@jonkeanejonkeaneAwaiting requested review from jonkeane
@raulcdraulcdAwaiting requested review from raulcd

Assignees


No one assigned


Labels

CI: ExtraRun extra CIComponent: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@Tom-Newton@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-45978: [C++] Bump bundled mimalloc version - #45979
Merged
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Jun 12, 2025
Merged
GH-45978: [C++] Bump bundled mimalloc version#45979
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Conversation
@pitrou
@pitroupitrou
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Member
What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
Are these changes tested?
Yes, by CI builds.
Are there any user-facing changes?
No.
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Closed

@github-actions
github-actionsBot
commented
Mar 31, 2025

Copy link


Copy Markdown

⚠️ GitHub issue #45978has been automatically assigned in GitHub to PR creator.
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 31, 2025
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Merged

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
c9a3cbe to
161d91bCompareMarch 31, 2025 14:12
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
I've opened microsoft/mimalloc#1056 for the Alpine Linux failure but I don't think it should be holding this.
@pitroupitrou
mentioned this pull request
Mar 31, 2025

Closed

@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
2 times, most recently
from
2185744 to
222ec0bCompareMarch 31, 2025 15:05
assignUser
assignUser
reviewed
Mar 31, 2025
View reviewed changes
@assignUserassignUser
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also need to forward snappy 

Edit: #45980
Comment thread.github/workflows/cpp.yml
Outdated


Comment on lines

+299
 to 
+311

 ARROW_SUBSTRAIT: ON
 ARROW_USE_GLOG: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: ON
@assignUserassignUserMar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'll revert these before merge?
@pitroupitrouMar 31, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was to debug the build/link errors on Windows which are now fixed.
@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Mar 31, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
8241964 to
97490ecCompareJune 11, 2025 19:14
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 97490ec58b0ed1c9993b607aa0046bc7fbfde66a
Submitted crossbow builds: ursacomputing/crossbow @ actions-21dfeaf22e
TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions
@pitroupitrou
added
the 
CI: Extra
Run extra CI
label
Jun 11, 2025
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheelcp313*
@pitrou
apacheGH-45978: [C++] Bump bundled mimalloc version
1fe3480
Update bundled mimalloc version from 2.0.6 to 2.2.4.
This will also help fix the CMake 4.0 compatibility issues.
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
97490ec to
1fe3480CompareJune 11, 2025 20:03
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 1fe3480
Submitted crossbow builds: ursacomputing/crossbow @ actions-dc8e7b294f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
This is ready for review @kou . CI looks good except for a probably unrelated failure in the Python emscripten build.
kou
kou
approved these changes
Jun 11, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Jun 11, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
5af7504 to
cc5d86eCompareJune 12, 2025 05:29
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting merge
Awaiting merge
labels
Jun 12, 2025
@pitrou
pitrou
merged commit 0826be5
into
apache:mainJun 12, 2025
@pitroupitrou
removed
the 
awaiting changes
Awaiting changes
label
Jun 12, 2025
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@pitrou
pitrou
deleted the

gh45978-bump-mimalloc

branch
June 12, 2025 08:00
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jun 12, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0826be5.
There were 76 benchmark results with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.
alinaliBQ pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
@pitrou@alinaliBQ
apacheGH-45978: [C++] Bump bundled mimalloc version (apache#45979)
dc4defe
### What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
### Are these changes tested?
Yes, by CI builds.
### Are there any user-facing changes?
No.
* GitHub Issue: apache#45978
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@koukou
mentioned this pull request
Jul 4, 2025

Closed

@kou
kou
commented
Jul 4, 2025

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-r-linux-sanitizers
@github-actions
github-actionsBot
commented
Jul 4, 2025

Copy link


Copy Markdown

Revision: cc5d86e
Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f9a3a132
TaskStatus
test-r-linux-sanitizersGitHub Actions
@Tom-NewtonTom-Newton
mentioned this pull request
Aug 6, 2025

Closed

@Tom-Newton
Tom-Newton
commented
Aug 6, 2025

Copy link


Copy Markdown

Contributor
I think this change has caused a memory leak when reading parquet #47266
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserassignUser left review comments
@jonkeanejonkeaneAwaiting requested review from jonkeane
@raulcdraulcdAwaiting requested review from raulcd

Assignees


No one assigned


Labels

CI: ExtraRun extra CIComponent: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@Tom-Newton@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-45978: [C++] Bump bundled mimalloc version - #45979
Merged
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Jun 12, 2025
Merged
GH-45978: [C++] Bump bundled mimalloc version#45979
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Conversation
@pitrou
@pitroupitrou
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Member
What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
Are these changes tested?
Yes, by CI builds.
Are there any user-facing changes?
No.
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Closed

@github-actions
github-actionsBot
commented
Mar 31, 2025

Copy link


Copy Markdown

⚠️ GitHub issue #45978has been automatically assigned in GitHub to PR creator.
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 31, 2025
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Merged

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
c9a3cbe to
161d91bCompareMarch 31, 2025 14:12
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
I've opened microsoft/mimalloc#1056 for the Alpine Linux failure but I don't think it should be holding this.
@pitroupitrou
mentioned this pull request
Mar 31, 2025

Closed

@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
2 times, most recently
from
2185744 to
222ec0bCompareMarch 31, 2025 15:05
assignUser
assignUser
reviewed
Mar 31, 2025
View reviewed changes
@assignUserassignUser
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also need to forward snappy 

Edit: #45980
Comment thread.github/workflows/cpp.yml
Outdated


Comment on lines

+299
 to 
+311

 ARROW_SUBSTRAIT: ON
 ARROW_USE_GLOG: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: ON
@assignUserassignUserMar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'll revert these before merge?
@pitroupitrouMar 31, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was to debug the build/link errors on Windows which are now fixed.
@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Mar 31, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
8241964 to
97490ecCompareJune 11, 2025 19:14
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 97490ec58b0ed1c9993b607aa0046bc7fbfde66a
Submitted crossbow builds: ursacomputing/crossbow @ actions-21dfeaf22e
TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions
@pitroupitrou
added
the 
CI: Extra
Run extra CI
label
Jun 11, 2025
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheelcp313*
@pitrou
apacheGH-45978: [C++] Bump bundled mimalloc version
1fe3480
Update bundled mimalloc version from 2.0.6 to 2.2.4.
This will also help fix the CMake 4.0 compatibility issues.
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
97490ec to
1fe3480CompareJune 11, 2025 20:03
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 1fe3480
Submitted crossbow builds: ursacomputing/crossbow @ actions-dc8e7b294f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
This is ready for review @kou . CI looks good except for a probably unrelated failure in the Python emscripten build.
kou
kou
approved these changes
Jun 11, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Jun 11, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
5af7504 to
cc5d86eCompareJune 12, 2025 05:29
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting merge
Awaiting merge
labels
Jun 12, 2025
@pitrou
pitrou
merged commit 0826be5
into
apache:mainJun 12, 2025
@pitroupitrou
removed
the 
awaiting changes
Awaiting changes
label
Jun 12, 2025
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@pitrou
pitrou
deleted the

gh45978-bump-mimalloc

branch
June 12, 2025 08:00
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jun 12, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0826be5.
There were 76 benchmark results with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.
alinaliBQ pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
@pitrou@alinaliBQ
apacheGH-45978: [C++] Bump bundled mimalloc version (apache#45979)
dc4defe
### What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
### Are these changes tested?
Yes, by CI builds.
### Are there any user-facing changes?
No.
* GitHub Issue: apache#45978
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@koukou
mentioned this pull request
Jul 4, 2025

Closed

@kou
kou
commented
Jul 4, 2025

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-r-linux-sanitizers
@github-actions
github-actionsBot
commented
Jul 4, 2025

Copy link


Copy Markdown

Revision: cc5d86e
Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f9a3a132
TaskStatus
test-r-linux-sanitizersGitHub Actions
@Tom-NewtonTom-Newton
mentioned this pull request
Aug 6, 2025

Closed

@Tom-Newton
Tom-Newton
commented
Aug 6, 2025

Copy link


Copy Markdown

Contributor
I think this change has caused a memory leak when reading parquet #47266
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserassignUser left review comments
@jonkeanejonkeaneAwaiting requested review from jonkeane
@raulcdraulcdAwaiting requested review from raulcd

Assignees


No one assigned


Labels

CI: ExtraRun extra CIComponent: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@Tom-Newton@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-45978: [C++] Bump bundled mimalloc version - #45979
Merged
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Jun 12, 2025
Merged
GH-45978: [C++] Bump bundled mimalloc version#45979
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Conversation
@pitrou
@pitroupitrou
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Member
What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
Are these changes tested?
Yes, by CI builds.
Are there any user-facing changes?
No.
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Closed

@github-actions
github-actionsBot
commented
Mar 31, 2025

Copy link


Copy Markdown

⚠️ GitHub issue #45978has been automatically assigned in GitHub to PR creator.
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 31, 2025
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Merged

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
c9a3cbe to
161d91bCompareMarch 31, 2025 14:12
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
I've opened microsoft/mimalloc#1056 for the Alpine Linux failure but I don't think it should be holding this.
@pitroupitrou
mentioned this pull request
Mar 31, 2025

Closed

@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
2 times, most recently
from
2185744 to
222ec0bCompareMarch 31, 2025 15:05
assignUser
assignUser
reviewed
Mar 31, 2025
View reviewed changes
@assignUserassignUser
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also need to forward snappy 

Edit: #45980
Comment thread.github/workflows/cpp.yml
Outdated


Comment on lines

+299
 to 
+311

 ARROW_SUBSTRAIT: ON
 ARROW_USE_GLOG: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: ON
@assignUserassignUserMar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'll revert these before merge?
@pitroupitrouMar 31, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was to debug the build/link errors on Windows which are now fixed.
@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Mar 31, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
8241964 to
97490ecCompareJune 11, 2025 19:14
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 97490ec58b0ed1c9993b607aa0046bc7fbfde66a
Submitted crossbow builds: ursacomputing/crossbow @ actions-21dfeaf22e
TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions
@pitroupitrou
added
the 
CI: Extra
Run extra CI
label
Jun 11, 2025
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheelcp313*
@pitrou
apacheGH-45978: [C++] Bump bundled mimalloc version
1fe3480
Update bundled mimalloc version from 2.0.6 to 2.2.4.
This will also help fix the CMake 4.0 compatibility issues.
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
97490ec to
1fe3480CompareJune 11, 2025 20:03
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 1fe3480
Submitted crossbow builds: ursacomputing/crossbow @ actions-dc8e7b294f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
This is ready for review @kou . CI looks good except for a probably unrelated failure in the Python emscripten build.
kou
kou
approved these changes
Jun 11, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Jun 11, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
5af7504 to
cc5d86eCompareJune 12, 2025 05:29
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting merge
Awaiting merge
labels
Jun 12, 2025
@pitrou
pitrou
merged commit 0826be5
into
apache:mainJun 12, 2025
@pitroupitrou
removed
the 
awaiting changes
Awaiting changes
label
Jun 12, 2025
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@pitrou
pitrou
deleted the

gh45978-bump-mimalloc

branch
June 12, 2025 08:00
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jun 12, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0826be5.
There were 76 benchmark results with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.
alinaliBQ pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
@pitrou@alinaliBQ
apacheGH-45978: [C++] Bump bundled mimalloc version (apache#45979)
dc4defe
### What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
### Are these changes tested?
Yes, by CI builds.
### Are there any user-facing changes?
No.
* GitHub Issue: apache#45978
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@koukou
mentioned this pull request
Jul 4, 2025

Closed

@kou
kou
commented
Jul 4, 2025

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-r-linux-sanitizers
@github-actions
github-actionsBot
commented
Jul 4, 2025

Copy link


Copy Markdown

Revision: cc5d86e
Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f9a3a132
TaskStatus
test-r-linux-sanitizersGitHub Actions
@Tom-NewtonTom-Newton
mentioned this pull request
Aug 6, 2025

Closed

@Tom-Newton
Tom-Newton
commented
Aug 6, 2025

Copy link


Copy Markdown

Contributor
I think this change has caused a memory leak when reading parquet #47266
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserassignUser left review comments
@jonkeanejonkeaneAwaiting requested review from jonkeane
@raulcdraulcdAwaiting requested review from raulcd

Assignees


No one assigned


Labels

CI: ExtraRun extra CIComponent: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@Tom-Newton@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-45978: [C++] Bump bundled mimalloc version - #45979
Merged
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Jun 12, 2025
Merged
GH-45978: [C++] Bump bundled mimalloc version#45979
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Conversation
@pitrou
@pitroupitrou
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Member
What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
Are these changes tested?
Yes, by CI builds.
Are there any user-facing changes?
No.
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Closed

@github-actions
github-actionsBot
commented
Mar 31, 2025

Copy link


Copy Markdown

⚠️ GitHub issue #45978has been automatically assigned in GitHub to PR creator.
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 31, 2025
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Merged

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
c9a3cbe to
161d91bCompareMarch 31, 2025 14:12
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
I've opened microsoft/mimalloc#1056 for the Alpine Linux failure but I don't think it should be holding this.
@pitroupitrou
mentioned this pull request
Mar 31, 2025

Closed

@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
2 times, most recently
from
2185744 to
222ec0bCompareMarch 31, 2025 15:05
assignUser
assignUser
reviewed
Mar 31, 2025
View reviewed changes
@assignUserassignUser
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also need to forward snappy 

Edit: #45980
Comment thread.github/workflows/cpp.yml
Outdated


Comment on lines

+299
 to 
+311

 ARROW_SUBSTRAIT: ON
 ARROW_USE_GLOG: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: ON
@assignUserassignUserMar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'll revert these before merge?
@pitroupitrouMar 31, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was to debug the build/link errors on Windows which are now fixed.
@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Mar 31, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
8241964 to
97490ecCompareJune 11, 2025 19:14
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 97490ec58b0ed1c9993b607aa0046bc7fbfde66a
Submitted crossbow builds: ursacomputing/crossbow @ actions-21dfeaf22e
TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions
@pitroupitrou
added
the 
CI: Extra
Run extra CI
label
Jun 11, 2025
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheelcp313*
@pitrou
apacheGH-45978: [C++] Bump bundled mimalloc version
1fe3480
Update bundled mimalloc version from 2.0.6 to 2.2.4.
This will also help fix the CMake 4.0 compatibility issues.
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
97490ec to
1fe3480CompareJune 11, 2025 20:03
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 1fe3480
Submitted crossbow builds: ursacomputing/crossbow @ actions-dc8e7b294f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
This is ready for review @kou . CI looks good except for a probably unrelated failure in the Python emscripten build.
kou
kou
approved these changes
Jun 11, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Jun 11, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
5af7504 to
cc5d86eCompareJune 12, 2025 05:29
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting merge
Awaiting merge
labels
Jun 12, 2025
@pitrou
pitrou
merged commit 0826be5
into
apache:mainJun 12, 2025
@pitroupitrou
removed
the 
awaiting changes
Awaiting changes
label
Jun 12, 2025
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@pitrou
pitrou
deleted the

gh45978-bump-mimalloc

branch
June 12, 2025 08:00
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jun 12, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0826be5.
There were 76 benchmark results with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.
alinaliBQ pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
@pitrou@alinaliBQ
apacheGH-45978: [C++] Bump bundled mimalloc version (apache#45979)
dc4defe
### What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
### Are these changes tested?
Yes, by CI builds.
### Are there any user-facing changes?
No.
* GitHub Issue: apache#45978
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@koukou
mentioned this pull request
Jul 4, 2025

Closed

@kou
kou
commented
Jul 4, 2025

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-r-linux-sanitizers
@github-actions
github-actionsBot
commented
Jul 4, 2025

Copy link


Copy Markdown

Revision: cc5d86e
Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f9a3a132
TaskStatus
test-r-linux-sanitizersGitHub Actions
@Tom-NewtonTom-Newton
mentioned this pull request
Aug 6, 2025

Closed

@Tom-Newton
Tom-Newton
commented
Aug 6, 2025

Copy link


Copy Markdown

Contributor
I think this change has caused a memory leak when reading parquet #47266
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserassignUser left review comments
@jonkeanejonkeaneAwaiting requested review from jonkeane
@raulcdraulcdAwaiting requested review from raulcd

Assignees


No one assigned


Labels

CI: ExtraRun extra CIComponent: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@Tom-Newton@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-45978: [C++] Bump bundled mimalloc version - #45979
Merged
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Jun 12, 2025
Merged
GH-45978: [C++] Bump bundled mimalloc version#45979
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Conversation
@pitrou
@pitroupitrou
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Member
What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
Are these changes tested?
Yes, by CI builds.
Are there any user-facing changes?
No.
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Closed

@github-actions
github-actionsBot
commented
Mar 31, 2025

Copy link


Copy Markdown

⚠️ GitHub issue #45978has been automatically assigned in GitHub to PR creator.
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 31, 2025
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Merged

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
c9a3cbe to
161d91bCompareMarch 31, 2025 14:12
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
I've opened microsoft/mimalloc#1056 for the Alpine Linux failure but I don't think it should be holding this.
@pitroupitrou
mentioned this pull request
Mar 31, 2025

Closed

@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
2 times, most recently
from
2185744 to
222ec0bCompareMarch 31, 2025 15:05
assignUser
assignUser
reviewed
Mar 31, 2025
View reviewed changes
@assignUserassignUser
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also need to forward snappy 

Edit: #45980
Comment thread.github/workflows/cpp.yml
Outdated


Comment on lines

+299
 to 
+311

 ARROW_SUBSTRAIT: ON
 ARROW_USE_GLOG: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: ON
@assignUserassignUserMar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'll revert these before merge?
@pitroupitrouMar 31, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was to debug the build/link errors on Windows which are now fixed.
@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Mar 31, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
8241964 to
97490ecCompareJune 11, 2025 19:14
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 97490ec58b0ed1c9993b607aa0046bc7fbfde66a
Submitted crossbow builds: ursacomputing/crossbow @ actions-21dfeaf22e
TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions
@pitroupitrou
added
the 
CI: Extra
Run extra CI
label
Jun 11, 2025
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheelcp313*
@pitrou
apacheGH-45978: [C++] Bump bundled mimalloc version
1fe3480
Update bundled mimalloc version from 2.0.6 to 2.2.4.
This will also help fix the CMake 4.0 compatibility issues.
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
97490ec to
1fe3480CompareJune 11, 2025 20:03
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 1fe3480
Submitted crossbow builds: ursacomputing/crossbow @ actions-dc8e7b294f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
This is ready for review @kou . CI looks good except for a probably unrelated failure in the Python emscripten build.
kou
kou
approved these changes
Jun 11, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Jun 11, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
5af7504 to
cc5d86eCompareJune 12, 2025 05:29
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting merge
Awaiting merge
labels
Jun 12, 2025
@pitrou
pitrou
merged commit 0826be5
into
apache:mainJun 12, 2025
@pitroupitrou
removed
the 
awaiting changes
Awaiting changes
label
Jun 12, 2025
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@pitrou
pitrou
deleted the

gh45978-bump-mimalloc

branch
June 12, 2025 08:00
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jun 12, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0826be5.
There were 76 benchmark results with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.
alinaliBQ pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
@pitrou@alinaliBQ
apacheGH-45978: [C++] Bump bundled mimalloc version (apache#45979)
dc4defe
### What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
### Are these changes tested?
Yes, by CI builds.
### Are there any user-facing changes?
No.
* GitHub Issue: apache#45978
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@koukou
mentioned this pull request
Jul 4, 2025

Closed

@kou
kou
commented
Jul 4, 2025

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-r-linux-sanitizers
@github-actions
github-actionsBot
commented
Jul 4, 2025

Copy link


Copy Markdown

Revision: cc5d86e
Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f9a3a132
TaskStatus
test-r-linux-sanitizersGitHub Actions
@Tom-NewtonTom-Newton
mentioned this pull request
Aug 6, 2025

Closed

@Tom-Newton
Tom-Newton
commented
Aug 6, 2025

Copy link


Copy Markdown

Contributor
I think this change has caused a memory leak when reading parquet #47266
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserassignUser left review comments
@jonkeanejonkeaneAwaiting requested review from jonkeane
@raulcdraulcdAwaiting requested review from raulcd

Assignees


No one assigned


Labels

CI: ExtraRun extra CIComponent: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@Tom-Newton@assignUser

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-45978: [C++] Bump bundled mimalloc version - #45979
Merged
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Jun 12, 2025
Merged
GH-45978: [C++] Bump bundled mimalloc version#45979
pitrou merged 2 commits into
apache:mainfrom 
pitrou:gh45978-bump-mimalloc
Conversation
@pitrou
@pitroupitrou
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Member
What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
Are these changes tested?
Yes, by CI builds.
Are there any user-facing changes?
No.
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Closed

@github-actions
github-actionsBot
commented
Mar 31, 2025

Copy link


Copy Markdown

⚠️ GitHub issue #45978has been automatically assigned in GitHub to PR creator.
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actionsgithub-actionsBot
added
the 
awaiting review
Awaiting review
label
Mar 31, 2025
@pitroupitrou
mentioned this pull request
Mar 31, 2025
 Merged

@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
c9a3cbe to
161d91bCompareMarch 31, 2025 14:12
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Mar 31, 2025

Copy link


Copy Markdown

MemberAuthor
I've opened microsoft/mimalloc#1056 for the Alpine Linux failure but I don't think it should be holding this.
@pitroupitrou
mentioned this pull request
Mar 31, 2025

Closed

@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
2 times, most recently
from
2185744 to
222ec0bCompareMarch 31, 2025 15:05
assignUser
assignUser
reviewed
Mar 31, 2025
View reviewed changes
@assignUserassignUser
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also need to forward snappy 

Edit: #45980
Comment thread.github/workflows/cpp.yml
Outdated


Comment on lines

+299
 to 
+311

 ARROW_SUBSTRAIT: ON
 ARROW_USE_GLOG: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
 ARROW_VERBOSE_THIRDPARTY_BUILD: ON
@assignUserassignUserMar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you'll revert these before merge?
@pitroupitrouMar 31, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was to debug the build/link errors on Windows which are now fixed.
@github-actionsgithub-actionsBot
added

awaiting committer review
Awaiting committer review
and removed

awaiting review
Awaiting review
labels
Mar 31, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
8241964 to
97490ecCompareJune 11, 2025 19:14
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g cpp -g python
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 97490ec58b0ed1c9993b607aa0046bc7fbfde66a
Submitted crossbow builds: ursacomputing/crossbow @ actions-21dfeaf22e
TaskStatus
example-cpp-minimal-build-staticGitHub Actions
example-cpp-minimal-build-static-system-dependencyGitHub Actions
example-cpp-tutorialGitHub Actions
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-build-cpp-fuzzGitHub Actions
test-conda-cppGitHub Actions
test-conda-cpp-valgrindGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-cpp-amd64GitHub Actions
test-debian-12-cpp-i386GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-39-cppGitHub Actions
test-fedora-39-python-3GitHub Actions
test-ubuntu-22.04-cppGitHub Actions
test-ubuntu-22.04-cpp-20GitHub Actions
test-ubuntu-22.04-cpp-bundledGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-no-threadingGitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-cppGitHub Actions
test-ubuntu-24.04-cpp-bundled-offlineGitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundledGitHub Actions
test-ubuntu-24.04-cpp-gcc-14GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formatsGitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizerGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions
@pitroupitrou
added
the 
CI: Extra
Run extra CI
label
Jun 11, 2025
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheelcp313*
@pitrou
apacheGH-45978: [C++] Bump bundled mimalloc version
1fe3480
Update bundled mimalloc version from 2.0.6 to 2.2.4.
This will also help fix the CMake 4.0 compatibility issues.
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
97490ec to
1fe3480CompareJune 11, 2025 20:03
@github-actions
github-actionsBot
commented
Jun 11, 2025

Copy link


Copy Markdown

Revision: 1fe3480
Submitted crossbow builds: ursacomputing/crossbow @ actions-dc8e7b294f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@pitrou
pitrou
commented
Jun 11, 2025

Copy link


Copy Markdown

MemberAuthor
This is ready for review @kou . CI looks good except for a probably unrelated failure in the Python emscripten build.
kou
kou
approved these changes
Jun 11, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Comment threadcpp/cmake_modules/ThirdpartyToolchain.cmake
Outdated

@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting committer review
Awaiting committer review
labels
Jun 11, 2025
@pitrou
pitrouforce-pushed
the
gh45978-bump-mimalloc
branch
from
5af7504 to
cc5d86eCompareJune 12, 2025 05:29
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting merge
Awaiting merge
labels
Jun 12, 2025
@pitrou
pitrou
merged commit 0826be5
into
apache:mainJun 12, 2025
@pitroupitrou
removed
the 
awaiting changes
Awaiting changes
label
Jun 12, 2025
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@pitrou
pitrou
deleted the

gh45978-bump-mimalloc

branch
June 12, 2025 08:00
@pitroupitrou
mentioned this pull request
Jun 12, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Jun 12, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0826be5.
There were 76 benchmark results with an error:
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.
alinaliBQ pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
@pitrou@alinaliBQ
apacheGH-45978: [C++] Bump bundled mimalloc version (apache#45979)
dc4defe
### What changes are included in this PR?
Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.
### Are these changes tested?
Yes, by CI builds.
### Are there any user-facing changes?
No.
* GitHub Issue: apache#45978
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@koukou
mentioned this pull request
Jul 4, 2025

Closed

@kou
kou
commented
Jul 4, 2025

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-r-linux-sanitizers
@github-actions
github-actionsBot
commented
Jul 4, 2025

Copy link


Copy Markdown

Revision: cc5d86e
Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f9a3a132
TaskStatus
test-r-linux-sanitizersGitHub Actions
@Tom-NewtonTom-Newton
mentioned this pull request
Aug 6, 2025

Closed

@Tom-Newton
Tom-Newton
commented
Aug 6, 2025

Copy link


Copy Markdown

Contributor
I think this change has caused a memory leak when reading parquet #47266
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserassignUser left review comments
@jonkeanejonkeaneAwaiting requested review from jonkeane
@raulcdraulcdAwaiting requested review from raulcd

Assignees


No one assigned


Labels

CI: ExtraRun extra CIComponent: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@kou@Tom-Newton@assignUser