Skip to content

ARROW-5633: [Python] Enable bz2 in Linux wheels - #4628

Closed
pitrou wants to merge 1 commit into
apache:masterfrom
pitrou:ARROW-5633-bz2-wheels
Closed

ARROW-5633: [Python] Enable bz2 in Linux wheels#4628
pitrou wants to merge 1 commit into
apache:masterfrom
pitrou:ARROW-5633-bz2-wheels

Conversation

@pitrou

Copy link
Copy Markdown
Member

No description provided.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@ursabot help

@ursabot

Copy link
Copy Markdown
No such command "help".

@pitrou

Copy link
Copy Markdown
MemberAuthor

@ursabot crossbow build wheel

@ursabot

Copy link
Copy Markdown
No such command "build".

@pitrou

Copy link
Copy Markdown
MemberAuthor

@ursabot crossbow wheel

@apacheapache deleted a comment from ursabotJun 20, 2019
@apacheapache deleted a comment from ursabotJun 20, 2019
@pitrou

Copy link
Copy Markdown
MemberAuthor

@ursabot build wheel

@ursabot

Copy link
Copy Markdown
Got unexpected extra argument (wheel)

@pitrou

Copy link
Copy Markdown
MemberAuthor

EEk!

@kszucs

Copy link
Copy Markdown
Member

@ursabot crossbow --help

@ursabot

Copy link
Copy Markdown
Usage: @ursabot crossbow [OPTIONS] COMMAND [ARGS]...
Trigger crossbow builds for this pull request
Options:
--help Show this message and exit.
Commands:
package Submit crossbow packaging tasks.
test Submit crossbow testing tasks.

@kszucs

Copy link
Copy Markdown
Member

@ursabot crossbow package --help

@pitrou

Copy link
Copy Markdown
MemberAuthor

@ursabot crossbow package wheel

@ursabot

Copy link
Copy Markdown
Usage: @ursabot crossbow package [OPTIONS] [TASK]...
Submit crossbow packaging tasks.
See groups defined in arrow/dev/tasks/tasks.yml
Options:
-g, --group [conda|wheel|linux|gandiva]
Submit task groups as defined in task.yml
--help Show this message and exit.

@ursabot

Copy link
Copy Markdown

AMD64 Conda Crossbow (#22369) builder failed.

Revision: 3c0e62eaa7232a8760193687b41eec901552292e

Crossbow: 'python crossbow.py ...' step's stderr:

Error: Invalid task(s) {'wheel'}. Must be one of {'ubuntu-xenial', 'conda-linux-gcc-py27', 'wheel-win-cp37m', 'ubuntu-bionic', 'debian-stretch-arm64', 'wheel-osx-cp35m', 'wheel-win-cp35m', 'centos-7', 'gandiva-jar-osx', 'conda-win-vs2015-py37', 'debian-stretch', 'conda-linux-gcc-py37', 'wheel-linux-cp37m', 'wheel-osx-cp36m', 'wheel-linux-cp36m', 'ubuntu-cosmic', 'conda-osx-clang-py36', 'conda-osx-clang-py37', 'wheel-linux-cp27m', 'conda-linux-gcc-py36', 'centos-6', 'wheel-win-cp36m', 'wheel-linux-cp27mu', 'conda-win-vs2015-py36', 'wheel-linux-cp35m', 'wheel-osx-cp27m', 'wheel-osx-cp37m', 'gandiva-jar-trusty', 'conda-osx-clang-py27'}

@pitrou

Copy link
Copy Markdown
MemberAuthor

@ursabot crossbow package wheel-win-cp36m

@kszucs

kszucs commented Jun 20, 2019

Copy link
Copy Markdown
Member

@pitrou You want to run @ursabot crossbow package --group wheel
or a standalone task, just like You did :)

@ursabot

Copy link
Copy Markdown

AMD64 Conda Crossbow (#22370) builder has been succeeded.

Revision: 3c0e62eaa7232a8760193687b41eec901552292e

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-29

TaskStatus
wheel-win-cp36mBuild Status

@kszucs

Copy link
Copy Markdown
Member

@pitrou For testing the linux wheels you need to rebuild the image, add docker-compose build python-manylinux1 after https://github.com/apache/arrow/blob/master/dev/tasks/python-wheels/travis.linux.yml#L49 then submit the linux task.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@kszucs I've already rebuilt and uploaded the image from my machine.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@kszucs What does this task do? How is it different from the manylinux task on travis-CI?

@kszucs

Copy link
Copy Markdown
Member

Basically the same, but uploads the artifact and the wheel tasks build wheels for multiple python versions.

@pitrou

Copy link
Copy Markdown
MemberAuthor

@ursabot crossbow package wheel-win-cp36m

@ursabot

Copy link
Copy Markdown

AMD64 Conda Crossbow (#22382) builder has been succeeded.

Revision: 519ae92d908270fb9629693b2bf947f73cce574d

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-30

TaskStatus
wheel-win-cp36mBuild Status

@pitrou
pitrouforce-pushed the ARROW-5633-bz2-wheels branch from 519ae92 to 3fe4c5aCompareJune 20, 2019 11:27
@pitrou
pitrouforce-pushed the ARROW-5633-bz2-wheels branch from 3fe4c5a to 5bc9e83CompareJune 20, 2019 11:27
@pitroupitrou changed the title ARROW-5633: [Python] Enable bz2 in wheelsARROW-5633: [Python] Enable bz2 in Linux wheelsJun 20, 2019
@pitrou

Copy link
Copy Markdown
MemberAuthor

I give up on Windows. @kou@xhochy feel free to take a look.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #4628 into master will decrease coverage by 23.77%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #4628 +/- ##
===========================================
- Coverage 88.49% 64.71% -23.78% 
===========================================
Files 890 480 -410 Lines 110406 62556 -47850 Branches 1418 0 -1418 ===========================================
- Hits 97701 40482 -57219 - Misses 12424 22074 +9650 + Partials 281 0 -281
Impacted FilesCoverage Δ
cpp/src/arrow/util/memory.h0% <0%> (-100%)⬇️
cpp/src/gandiva/date_utils.h0% <0%> (-100%)⬇️
cpp/src/arrow/util/memory.cc0% <0%> (-100%)⬇️
cpp/src/arrow/filesystem/util-internal.cc0% <0%> (-100%)⬇️
cpp/src/arrow/util/sse-util.h0% <0%> (-100%)⬇️
cpp/src/gandiva/decimal_type_util.h0% <0%> (-100%)⬇️
cpp/src/arrow/compute/logical_type.h0% <0%> (-100%)⬇️
cpp/src/parquet/hasher.h0% <0%> (-100%)⬇️
cpp/src/gandiva/basic_decimal_scalar.h0% <0%> (-100%)⬇️
cpp/src/arrow/compute/kernels/boolean.cc0% <0%> (-100%)⬇️
... and 641 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 961927a...5bc9e83. Read the comment docs.

@wesm

wesm commented Jun 20, 2019

Copy link
Copy Markdown
Member

The Windows wheel build is currently broken? Is there a JIRA for this?

@pitrou

Copy link
Copy Markdown
MemberAuthor

@wesm Why broken?

@wesm

wesm commented Jun 20, 2019

Copy link
Copy Markdown
Member

You said "I give up on Windows." I wondered what you meant

@wesmwesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesmwesm closed this in a0e1fbbJun 20, 2019
@pitrou
pitrou deleted the ARROW-5633-bz2-wheels branch June 20, 2019 15:29
@pitrou

Copy link
Copy Markdown
MemberAuthor

Ah, no, it's simply that I gave up on enabling bz2 in Windows wheels.

@wesm

wesm commented Jun 20, 2019

Copy link
Copy Markdown
Member

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pitrou@ursabot@kszucs@codecov-io@wesm