Skip to content

ARROW-5653: [C++] Ensure testing libraries are not installed - #4635

Closed
fsaintjacques wants to merge 2 commits into
apache:masterfrom
fsaintjacques:ARROW-5653-fix-cpp-docker
Closed

ARROW-5653: [C++] Ensure testing libraries are not installed#4635
fsaintjacques wants to merge 2 commits into
apache:masterfrom
fsaintjacques:ARROW-5653-fix-cpp-docker

Conversation

@fsaintjacques

Copy link
Copy Markdown
Contributor

libarrow_testing and libarrow_flight_testing should not be installed.
Also fix the unit tests with LD_LIBRARY_PATH due to install target and
cmake handling of RPATH.

ARROW_TEST_*_LINK_LIBS is already included via the add_arrow_test
function.
libarrow_testing and libarrow_flight_testing should not be installed.
Also fix the unit tests with LD_LIBRARY_PATH due to install target and
cmake handling of RPATH.
@wesm

wesm commented Jun 20, 2019

Copy link
Copy Markdown
Member

@ursabot crossbow test docker

@ursabot

Copy link
Copy Markdown

AMD64 Conda Crossbow (#22682) builder has been succeeded.

Revision: 10f4e1f

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-31

TaskStatus
docker-python-3.6-alpineBuild Status
docker-python-3.7Build Status
docker-turbodbc-integrationBuild Status
docker-python-2.7-alpineBuild Status
docker-spark-integrationBuild Status
docker-cppBuild Status
docker-cpp-alpineBuild Status
docker-python-3.6-nopandasBuild Status
docker-pandas-masterBuild Status
docker-c_glibBuild Status
docker-rBuild Status
docker-hdfs-integrationBuild Status
docker-dask-integrationBuild Status
docker-jsBuild Status
docker-clang-formatBuild Status
docker-rustBuild Status
docker-iwyuBuild Status
docker-cpp-cmake32Build Status
docker-goBuild Status
docker-python-2.7Build Status
docker-docsBuild Status
docker-python-2.7-nopandasBuild Status
docker-python-3.6Build Status
docker-lintBuild Status
docker-javaBuild Status

@fsaintjacquesfsaintjacques changed the title ARROW-5633: [C++] Ensure testing libraries are not installedARROW-5653: [C++] Ensure testing libraries are not installedJun 20, 2019
@wesm

wesm commented Jun 21, 2019

Copy link
Copy Markdown
Member

Looks like macOS is setting the install rpath in the executables

 2/65 Test #2: plasma-client_tests ................***Failed 0.52 sec
Running plasma-client_tests, redirecting output into /Users/travis/build/apache/arrow/cpp-build/build/test-logs/plasma-client_tests.txt (attempt 1/1)
dyld: Library not loaded: /Users/travis/build/apache/arrow/cpp-install/lib/libarrow_testing.14.dylib
Referenced from: /Users/travis/build/apache/arrow/cpp-build/debug/plasma-client_tests
Reason: image not found
/Users/travis/build/apache/arrow/cpp/build-support/run-test.sh: line 97: 11021 Abort trap: 6 $TEST_EXECUTABLE "$@" 2>&1
11022 Done | $ROOT/build-support/asan_symbolize.py
11024 Done | ${CXXFILT:-c++filt}
11026 Done | $ROOT/build-support/stacktrace_addr2line.pl $TEST_EXECUTABLE
11028 Done | $pipe_cmd 2>&1
11030 Done | tee $LOGFILE
~/build/apache/arrow/cpp-build/src/plasma

@fsaintjacques

Copy link
Copy Markdown
ContributorAuthor

I'll close this in favor of #4605

@StefanBruens

Copy link
Copy Markdown

Why was this closed? libarrow_testing.{so,a} is still installed, dito the header files.

@wesm

wesm commented Aug 6, 2022

Copy link
Copy Markdown
Member

Can you please open a Jira issue? To make sure this is fixed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@fsaintjacques@wesm@ursabot@StefanBruens