Uh oh!
There was an error while loading. Please reload this page.
GH-45303: [C++] Refactor ZSTD from ExternalProject to FetchContent - #46393
GH-45303: [C++] Refactor ZSTD from ExternalProject to FetchContent#46393jonkeane wants to merge 2 commits into
Conversation
pitrou
commented
Jun 12, 2025
Is there anything left to do here? cc @kou |
| # Check which target name is actually created by zstd's CMake | ||
| # zstd on macOS often creates 'zstd_static' despite what the docs say | ||
| if(TARGET zstd_static) |
There was a problem hiding this comment.
Hmm. This is strange...
The target name must be libzstd_static: https://github.com/facebook/zstd/blob/5e6bdf5e3dee6d977ea87b2c50c3bcb14fed3603/build/cmake/lib/CMakeLists.txt#L141
| @@ -2690,49 +2690,87 @@ if(ARROW_WITH_LZ4) | |||
| endif() | |||
| macro(build_zstd) | |||
There was a problem hiding this comment.
We must use function() not macro() here to create a new scope.
jonkeane
commented
Aug 21, 2025
Sorry, I haven't had the bandwidth to come back to this. Would someone want to take it over for me? If no that's ok — I'll close the PR. |
kou
commented
Aug 22, 2025
No problem. I'll take it over later. |
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer. |
Rationale for this change
Refactor ZSTD from ExternalProject to FetchContent
Partially resolves#45303
What changes are included in this PR?
Cmake, refactored
Are these changes tested?
Yes
Are there any user-facing changes?
No