GH-31603: [C++] Add SecureString implementation to arrow/util/ - #46626

Merged

pitrou merged 22 commits into

apache:mainfrom

EnricoMi:secure-string-util

Jun 9, 2025

Commits on Jun 9, 2025

Add SecureString implementation to arrow/util/
EnricoMi
authored and
pitrou
committed
fa3c780
Fix import for memset_s, improve for loops in tests
EnricoMi
and
pitrou
committed
96fe8e3
Address code review comments
EnricoMi
authored and
pitrou
committed
fd5d43d
Test secure SecureString deconstruction
EnricoMi
authored and
pitrou
committed
7ece2b0
Test correctness of AssertSecurelyCleared
EnricoMi
authored and
pitrou
committed
15aa6de
Rename SecureString argument to other
EnricoMi
authored and
pitrou
committed
89e3f00
Move std::move into secure_move, assert string ptr
EnricoMi
authored and
pitrou
committed
cb5c9de
Add comments, fix linting
EnricoMi
authored and
pitrou
committed
3722395
Improve assertions
EnricoMi
authored and
pitrou
committed
753bfe7
Use testing::AssertionResult rather than capturing assertions through TestPartResultReporterInterface
EnricoMi
authored and
pitrou
committed
fb01ecb
Expect string buffers larger than requested size
EnricoMi
authored and
pitrou
committed
0918e19
Handle string buffers larger than init size
EnricoMi
authored and
pitrou
committed
489a532
Don't access deallocated memory in ASAN / Valgrind mode
EnricoMi
authored and
pitrou
committed
bf46015
Fix SecureClear for non-local strings, stabalize mem assertions
EnricoMi
authored and
pitrou
committed
aeb6637
Avoid assigning short string to long string in test
EnricoMi
authored and
pitrou
committed
66e0def
Fix memory issues in tests
EnricoMi
authored and
pitrou
committed
7f529d1
Improve comments
EnricoMi
authored and
pitrou
committed
49ccae1
Apply code review comments
EnricoMi
authored and
pitrou
committed
804617c
Move SecureClear(std::string*) up in source file as well
EnricoMi
authored and
pitrou
committed
210a592
Undefine macro after use
pitrou
committed
99cd8c3
Fix and enhance Construct test
pitrou
committed
e32b68d
Also skip deallocated area tests on Thread Sanitizer
pitrou
committed
408572c

Navigation Menu

Uh oh!

GH-31603: [C++] Add SecureString implementation to arrow/util/ - #46626

GH-31603: [C++] Add SecureString implementation to arrow/util/#46626
pitrou merged 22 commits into
apache:mainfrom
EnricoMi:secure-string-util

Commits on Jun 9, 2025

Add SecureString implementation to arrow/util/

Fix import for memset_s, improve for loops in tests

Address code review comments

Test secure SecureString deconstruction

Test correctness of AssertSecurelyCleared

Rename SecureString argument to other

Move std::move into secure_move, assert string ptr

Add comments, fix linting

Improve assertions

Use testing::AssertionResult rather than capturing assertions through TestPartResultReporterInterface

Expect string buffers larger than requested size

Handle string buffers larger than init size

Don't access deallocated memory in ASAN / Valgrind mode

Fix SecureClear for non-local strings, stabalize mem assertions

Avoid assigning short string to long string in test

Fix memory issues in tests

Improve comments

Apply code review comments

Move SecureClear(std::string*) up in source file as well

Undefine macro after use

Fix and enhance Construct test

Also skip deallocated area tests on Thread Sanitizer