Uh oh!
There was an error while loading. Please reload this page.
GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + minor CMake references) - #46834
Conversation
assignUser
left a comment
There was a problem hiding this comment.
Let's also update the docs: https://github.com/apache/arrow/blob/main/docs/source/developers/cpp/building.rst?plain=1#L454
Good point @assignUser. Also, here are a few other places we refer to 3.16: arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake Lines 5305 to 5314 in 639201b arrow/ci/conan/all/conanfile.py Lines 270 to 272 in 639201b |
raulcd
commented
Jun 20, 2025
@github-actions crossbow submit -g conan example-cpp-minimal-* |
Revision: f0310e6 Submitted crossbow builds: ursacomputing/crossbow @ actions-5c4d9c0865
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6822857. There were 119 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…Make (#46880) ### Rationale for this change #46834 required CMake 3.25 or later for an example CMake project. ### What changes are included in this PR? Don't build the example CMake project with CMake < 3.25 in package verification. Amazon Linux 2023, CentOS 7 and Ubuntu 22.04 don't provide CMake 3.25 or later. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #46879 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Rationale for this change
Current system requirements is outdated and was not updated to match the CMake update on:
While fixing the above it was noted that there were still other pending references on some of our codebase (docs + minor CMake)
What changes are included in this PR?
Update:
Are these changes tested?
CI and Archery has been exercised, no new tests are required.
Are there any user-facing changes?
No