Skip to content

GH-46869: [C++][Parquet] Deprecate arrow::Status parquet::arrow::FileReadeder::GetRecordBatchReader()#46932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Jul 4, 2025
Merged

GH-46869: [C++][Parquet] Deprecate arrow::Status parquet::arrow::FileReadeder::GetRecordBatchReader()#46932

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a77784
[C++][Parquet] Add arrow::Result version of parquet::arrow::FileReade…
Ziy1-Tan Jun 29, 2025
f285b94
Deprecate shared_ptr version
Ziy1-Tan Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cpp/src/parquet/arrow/reader.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,11 +191,19 @@ class PARQUET_EXPORT FileReader {
///
/// \returns error Status if either row_group_indices or column_indices
/// contains an invalid index
/// \deprecated Deprecated in 21.0.0. Use arrow::Result version instead.
ARROW_DEPRECATED("Deprecated in 21.0.0. Use arrow::Result version instead.")
::arrow::Status GetRecordBatchReader(const std::vector<int>& row_group_indices,
const std::vector<int>& column_indices,
std::shared_ptr<::arrow::RecordBatchReader>* out);

/// \deprecated Deprecated in 21.0.0. Use arrow::Result version instead.
ARROW_DEPRECATED("Deprecated in 21.0.0. Use arrow::Result version instead.")
::arrow::Status GetRecordBatchReader(const std::vector<int>& row_group_indices,
std::shared_ptr<::arrow::RecordBatchReader>* out);

/// \deprecated Deprecated in 21.0.0. Use arrow::Result version instead.
ARROW_DEPRECATED("Deprecated in 21.0.0. Use arrow::Result version instead.")
::arrow::Status GetRecordBatchReader(std::shared_ptr<::arrow::RecordBatchReader>* out);

/// \brief Return a generator of record batches.
Expand Down