Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 4.3k
GH-34577 [Python] Expose eol and null_string csv WriteOptions#46976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1355,6 +1355,10 @@ cdef class WriteOptions(_Weakrefable): | ||
| CSV data | ||
| delimiter : 1-character string, optional (default ",") | ||
| The character delimiting individual cells in the CSV data. | ||
| eol : str, optional (default "\\n") | ||
| The end of line character to use for ending rows | ||
| null_string : str, optional (default "") | ||
| The string to write for null values. Quotes are not allowed in this string. | ||
| quoting_style : str, optional (default "needed") | ||
| Whether to quote values, and if so, which quoting style to use. | ||
| The following values are accepted: | ||
| @@ -1370,14 +1374,18 @@ cdef class WriteOptions(_Weakrefable): | ||
| __slots__ = () | ||
| def __init__(self, *, include_header=None, batch_size=None, | ||
| delimiter=None, quoting_style=None): | ||
| delimiter=None, eol=None, null_string=None, quoting_style=None): | ||
| self.options.reset(new CCSVWriteOptions(CCSVWriteOptions.Defaults())) | ||
| if include_header is not None: | ||
| self.include_header = include_header | ||
| if batch_size is not None: | ||
| self.batch_size = batch_size | ||
| if delimiter is not None: | ||
| self.delimiter = delimiter | ||
| if eol is not None: | ||
| self.eol = eol | ||
| if null_string is not None: | ||
| self.null_string = null_string | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It found this glorious typo 🤦. Only have semi-working syntax highlighting and didn't have enough time to figure out how to run the tests locally :/. | ||
| if quoting_style is not None: | ||
| self.quoting_style = quoting_style | ||
| @@ -1415,6 +1423,28 @@ cdef class WriteOptions(_Weakrefable): | ||
| def delimiter(self, value): | ||
| deref(self.options).delimiter = _single_char(value) | ||
| @property | ||
| def eol(self): | ||
| """ | ||
| The end of line character to use for ending rows | ||
| """ | ||
| return frombytes(deref(self.options).eol) | ||
| @eol.setter | ||
| def eol(self, value): | ||
| deref(self.options).eol = tobytes(value) | ||
| @property | ||
| def null_string(self): | ||
| """ | ||
| The string to write for null values. Quotes are not allowed in this string. | ||
| """ | ||
| return frombytes(deref(self.options).null_string) | ||
| @null_string.setter | ||
| def null_string(self, value): | ||
| deref(self.options).null_string = tobytes(value) | ||
| @property | ||
| def quoting_style(self): | ||
| """ | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to escape the backslash to render in final doc rather than to break the doc comment.