GH-45867: [Python] Fix `SetuptoolsDeprecationWarning` by paddyroddy · Pull Request #47141 · apache/arrow

paddyroddy · 2025-07-20T08:33:33Z

Rationale for this change

When building locally, I get many errors along the lines of

Please ensure the files specified are contained by the root
of the Python package (normally marked by `pyproject.toml`).
By 2026-Mar-20, you need to update your project and remove deprecated calls
or your builds will no longer be supported.
See https://packaging.python.org/en/latest/specifications/glob-patterns/ for details.

What changes are included in this PR?

Make the licence SPDX compliant
Remove the licence classifier
Move the licence files from setup.cfg to pyproject.toml
Fix the disallowed glob patterns via symlinks
Bumped the minimum version of setuptools due to macOS CI failures (don't know why this happened, caching maybe?)

I appreciate the symlink change might prove controversial. See discussions in #45867, fixes#45867.

Are these changes tested?

When I rebuild locally, I get no errors any more.

Are there any user-facing changes?

Yes. The minimum required version of setuptools is now 77. However, this is available on >=3.9 so won't affect anyone really.

GitHub Issue: [CI][Python] A new version (77.0.2) of setuptools seems to have broken some of our builds #45867

github-actions · 2025-07-20T08:33:57Z

⚠️ GitHub issue #45867has been automatically assigned in GitHub to PR creator.

github-actions · 2025-07-20T09:33:40Z

⚠️ GitHub issue #45867has been automatically assigned in GitHub to PR creator.

rok · 2025-07-20T10:03:57Z

 # versions released after 2022
 "setuptools_scm[toml]>=8",
- "setuptools>=64",
+ "setuptools>=77",


This is required due to setuptools<77 not recognizing the new license strings proposed in this PR (see pypa/setuptools#4903 for explanation). I'm not sure if this is controversial so bringing it up here. @raulcd

rok · 2025-07-20T10:22:54Z

@github-actions crossbow submit

github-actions · 2025-07-20T10:24:00Z

no tasks were provided for the job
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/16398862798

raulcd · 2025-07-20T10:25:16Z

@github-actions crossbow submit -g python -g wheels

github-actions · 2025-07-20T10:26:23Z

Invalid group(s) {'wheels'}. Must be one of {'example-cpp', 'python', 'nightly-release', 'cpp', 'verify-rc-source-macos', 'wheel', 'test', 'verify-rc-source', 'cuda', 'vcpkg', 'linux-amd64', 'conan', 'r', 'nightly', 'ruby', 'linux', 'c-glib', 'linux-arm64', 'verify-rc-source-linux', 'example', 'packaging', 'integration', 'example-python', 'fuzz', 'nightly-tests', 'verify-rc', 'homebrew', 'nightly-packaging'}
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/16398880949

raulcd · 2025-07-20T10:27:28Z

@github-actions crossbow submit -g python

github-actions · 2025-07-20T10:29:58Z

Revision: 6b1a08b

Submitted crossbow builds: ursacomputing/crossbow @ actions-2fdf3226a1

Task	Status
example-python-minimal-build-fedora-conda
example-python-minimal-build-ubuntu-venv
test-conda-python-3.10
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest-numpy-latest
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-latest-numpy-1.26
test-conda-python-3.11-pandas-latest-numpy-latest
test-conda-python-3.11-pandas-nightly-numpy-nightly
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.12-cpython-debug
test-conda-python-3.13
test-conda-python-3.9
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5
test-conda-python-emscripten
test-cuda-python-ubuntu-22.04-cuda-11.7.1
test-debian-12-python-3-amd64
test-debian-12-python-3-i386
test-fedora-42-python-3
test-ubuntu-22.04-python-3
test-ubuntu-22.04-python-313-freethreading
test-ubuntu-24.04-python-3

kou · 2025-07-20T11:31:45Z

Does symbolic link work on Windows...?

Good point. I guess there's no other way to fix it then other than copying or creating new licence and notice files.

Have copied over the files for the tests @rok

Per https://gitforwindows.org/symbolic-links.html:
Short version: there is no exact equivalent for POSIX symlinks on Windows, and the closest thing is unavailable for non-admins by default unless Developer Mode is enabled and a relatively recent Windows 10 version is used. Therefore, symlink emulation support is only turned on by default when that scenario is detected. Support can be enabled by the user, via the core.symlinks=true config setting.
Windows 10 reached EOL last month, and supposedly Developer Mode is required for Visual Studio use.
I'm not sure of all the Windows workflows that may / may not require developer mode, but maybe its worth just requiring it for any Windows devs of PyArrow so that symlinks can be used?

kou · 2025-07-20T11:32:51Z

@github-actions crossbow submit -g wheel

github-actions · 2025-07-20T11:34:05Z

⚠️ GitHub issue #45867has been automatically assigned in GitHub to PR creator.

github-actions · 2025-07-20T11:36:02Z

Revision: 6b1a08b

Submitted crossbow builds: ursacomputing/crossbow @ actions-fe79dfe84b

Task	Status
python-sdist
wheel-macos-monterey-cp310-cp310-amd64
wheel-macos-monterey-cp310-cp310-arm64
wheel-macos-monterey-cp311-cp311-amd64
wheel-macos-monterey-cp311-cp311-arm64
wheel-macos-monterey-cp312-cp312-amd64
wheel-macos-monterey-cp312-cp312-arm64
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313-arm64
wheel-macos-monterey-cp313-cp313t-amd64
wheel-macos-monterey-cp313-cp313t-arm64
wheel-macos-monterey-cp39-cp39-amd64
wheel-macos-monterey-cp39-cp39-arm64
wheel-manylinux-2-28-cp310-cp310-amd64
wheel-manylinux-2-28-cp310-cp310-arm64
wheel-manylinux-2-28-cp311-cp311-amd64
wheel-manylinux-2-28-cp311-cp311-arm64
wheel-manylinux-2-28-cp312-cp312-amd64
wheel-manylinux-2-28-cp312-cp312-arm64
wheel-manylinux-2-28-cp313-cp313-amd64
wheel-manylinux-2-28-cp313-cp313-arm64
wheel-manylinux-2-28-cp313-cp313t-amd64
wheel-manylinux-2-28-cp313-cp313t-arm64
wheel-manylinux-2-28-cp39-cp39-amd64
wheel-manylinux-2-28-cp39-cp39-arm64
wheel-musllinux-1-2-cp310-cp310-amd64
wheel-musllinux-1-2-cp310-cp310-arm64
wheel-musllinux-1-2-cp311-cp311-amd64
wheel-musllinux-1-2-cp311-cp311-arm64
wheel-musllinux-1-2-cp312-cp312-amd64
wheel-musllinux-1-2-cp312-cp312-arm64
wheel-musllinux-1-2-cp313-cp313-amd64
wheel-musllinux-1-2-cp313-cp313-arm64
wheel-musllinux-1-2-cp313-cp313t-amd64
wheel-musllinux-1-2-cp313-cp313t-arm64
wheel-musllinux-1-2-cp39-cp39-amd64
wheel-musllinux-1-2-cp39-cp39-arm64
wheel-windows-cp310-cp310-amd64
wheel-windows-cp311-cp311-amd64
wheel-windows-cp312-cp312-amd64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp313-cp313t-amd64
wheel-windows-cp39-cp39-amd64

rok · 2025-12-16T13:04:13Z

The macOS segfaults are expected and unrelated.

rok

This looks pretty good to me! @raulcd

pitrou · 2025-12-18T10:04:29Z

@github-actions crossbow submit -g python

pitrou · 2025-12-18T10:04:38Z

@github-actions crossbow submit wheelcp313*

github-actions · 2025-12-18T10:07:13Z

Revision: e47ca7c

Submitted crossbow builds: ursacomputing/crossbow @ actions-1176ee40f3

Task	Status
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313-arm64
wheel-macos-monterey-cp313-cp313t-amd64
wheel-macos-monterey-cp313-cp313t-arm64
wheel-manylinux-2-28-cp313-cp313-amd64
wheel-manylinux-2-28-cp313-cp313-arm64
wheel-manylinux-2-28-cp313-cp313t-amd64
wheel-manylinux-2-28-cp313-cp313t-arm64
wheel-musllinux-1-2-cp313-cp313-amd64
wheel-musllinux-1-2-cp313-cp313-arm64
wheel-musllinux-1-2-cp313-cp313t-amd64
wheel-musllinux-1-2-cp313-cp313t-arm64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp313-cp313t-amd64

github-actions · 2025-12-18T10:07:26Z

Revision: e47ca7c

Submitted crossbow builds: ursacomputing/crossbow @ actions-8124fa0f6c

Task	Status
example-python-minimal-build-fedora-conda
example-python-minimal-build-ubuntu-venv
test-conda-python-3.10
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-1.3.4-numpy-1.21.2
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-latest-numpy-latest
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.12-cpython-debug
test-conda-python-3.12-pandas-latest-numpy-1.26
test-conda-python-3.12-pandas-latest-numpy-latest
test-conda-python-3.13
test-conda-python-3.13-pandas-nightly-numpy-nightly
test-conda-python-3.13-pandas-upstream_devel-numpy-nightly
test-conda-python-3.14
test-conda-python-emscripten
test-cuda-python-ubuntu-22.04-cuda-11.7.1
test-cuda-python-ubuntu-24.04-cuda-13.0.2
test-debian-12-python-3-amd64
test-debian-12-python-3-i386
test-fedora-42-python-3
test-ubuntu-22.04-python-3
test-ubuntu-22.04-python-313-freethreading
test-ubuntu-24.04-python-3

pitrou · 2025-12-18T11:29:15Z

CI failures are unrelated, thanks a lot @paddyroddy !

pitrou · 2025-12-18T11:29:50Z

@github-actions crossbow submit python-sdist

github-actions · 2025-12-18T11:32:05Z

Revision: e47ca7c

Submitted crossbow builds: ursacomputing/crossbow @ actions-b1e74a8dee

Task	Status
python-sdist

conbench-apache-arrow · 2025-12-24T22:51:58Z

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 866502e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

…7141) ### Rationale for this change When building locally, I get many errors along the lines of ``` Please ensure the files specified are contained by the root of the Python package (normally marked by `pyproject.toml`). By 2026-Mar-20, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://packaging.python.org/en/latest/specifications/glob-patterns/ for details. ``` <img width="958" height="755" alt="terminal demo" src="https://github.com/user-attachments/assets/67f0e261-c4d2-403c-b004-688dfaaccda6" /> ### What changes are included in this PR? - Make the licence [SPDX compliant](https://spdx.org/licenses) - Remove the licence classifier - Move the licence files from `setup.cfg` to `pyproject.toml` - Fix the [disallowed glob patterns](https://packaging.python.org/en/latest/specifications/glob-patterns) via symlinks - Bumped the minimum version of `setuptools` due to macOS CI failures (don't know why this happened, caching maybe?) I appreciate the symlink change might prove controversial. See discussions in apache#45867, fixesapache#45867. ### Are these changes tested? When I rebuild locally, I get no errors any more. ### Are there any user-facing changes? Yes. The minimum required version of `setuptools` is now `77`. However, this is available on `>=3.9` so won't affect anyone really. * GitHub Issue: apache#45867 Authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>

paddyroddy added 4 commits July 20, 2025 10:23

Make licence SPDX compliant
0216dd7

Licence classifiers are deprecated
7b5fcce

Move license-files to pyproject.toml
5fc3f18

.. isn't valid so create symlinks and point to them
4be7410

paddyroddy requested review from AlenkaF, raulcd and rok as code owners July 20, 2025 08:33

github-actionsBot added Component: Python awaiting review Awaiting review labels Jul 20, 2025

Set minimum setuptools as 77
6b1a08b

paddyroddy requested review from assignUser, jonkeane and kou as code owners July 20, 2025 09:20

rok reviewed Jul 20, 2025
View reviewed changes

github-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jul 20, 2025

kou reviewed Jul 20, 2025
View reviewed changes

kou changed the title ~~GH-45867: [PYTHON] Fix SetuptoolsDeprecationWarning~~GH-45867: [Python] Fix SetuptoolsDeprecationWarningJul 20, 2025

Copy over text files instead
df371b1

paddyroddy added 3 commits December 16, 2025 12:06

Create SDist files
04f2b1b

Add to gitignore
8477a23

Fix linting
e392cbe

pitrou reviewed Dec 16, 2025
View reviewed changes

Comment threadpython/setup.py Outdated

paddyroddy added 2 commits December 16, 2025 13:49

Change to warning
5930c76

Merge branch 'main' into paddyroddy/fix-setuptools-deprecation
ba20e2d

rok reviewed Dec 16, 2025
View reviewed changes

github-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Dec 16, 2025

rok requested a review from pitrou December 17, 2025 22:54

pitrou requested changes Dec 18, 2025
View reviewed changes

Comment threadpython/setup.py Outdated
Comment threadpython/.gitignore Outdated

Suggestions from review
e47ca7c

github-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 18, 2025

pitrou approved these changes Dec 18, 2025
View reviewed changes

pitrou merged commit 866502e into apache:mainDec 18, 2025
31 checks passed

pitrou removed the awaiting change review Awaiting change review label Dec 18, 2025

pitrou mentioned this pull request Dec 18, 2025
[CI][Python] A new version (77.0.2) of setuptools seems to have broken some of our builds #45867
Closed

radoering mentioned this pull request Jan 26, 2026
[Python][Packaging] Missing license files in 23.0.0 wheels #48983
Closed

WillAyd mentioned this pull request Jan 28, 2026
GH-36411: [C++][Python] Some fixes for sdist build and wheel building WillAyd/arrow#1
Closed

Uh oh!

Conversation

paddyroddy commented Jul 20, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actionsBot commented Jul 20, 2025

Uh oh!

github-actionsBot commented Jul 20, 2025

Uh oh!

rokJul 20, 2025

Choose a reason for hiding this comment

Uh oh!

rok commented Jul 20, 2025

Uh oh!

github-actionsBot commented Jul 20, 2025

Uh oh!

raulcd commented Jul 20, 2025

Uh oh!

github-actionsBot commented Jul 20, 2025

Uh oh!

raulcd commented Jul 20, 2025

Uh oh!

github-actionsBot commented Jul 20, 2025

Uh oh!

kouJul 20, 2025

Choose a reason for hiding this comment

Uh oh!

paddyroddyJul 20, 2025

Choose a reason for hiding this comment

Uh oh!

paddyroddyJul 20, 2025

Choose a reason for hiding this comment

Uh oh!

WillAydNov 26, 2025

Choose a reason for hiding this comment

Uh oh!

kou commented Jul 20, 2025

Uh oh!

github-actionsBot commented Jul 20, 2025

Uh oh!

github-actionsBot commented Jul 20, 2025

Uh oh!

rok commented Dec 16, 2025

Uh oh!

Uh oh!

rok left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pitrou commented Dec 18, 2025

Uh oh!

pitrou commented Dec 18, 2025

Uh oh!

github-actionsBot commented Dec 18, 2025

Uh oh!

github-actionsBot commented Dec 18, 2025

Uh oh!

pitrou commented Dec 18, 2025

Uh oh!

pitrou commented Dec 18, 2025

Uh oh!

github-actionsBot commented Dec 18, 2025

Uh oh!

Uh oh!

conbench-apache-arrowBot commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

paddyroddy commented Jul 20, 2025•
edited
Loading