Skip to content

GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds#47313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlenkaF merged 8 commits into from
Sep 2, 2025
Merged

GH-47256: [Python] Do not use cffi in free-threaded 3.13 builds #47313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b8c378d
Squash: all 10 commits
AlenkaF Aug 13, 2025
1e13f4a
Revert "Squash: all 10 commits"
AlenkaF Aug 13, 2025
1df829d
Use environment markers
AlenkaF Aug 13, 2025
a41c8ce
Bring back dockerfile patches only for 3.13 version
AlenkaF Aug 26, 2025
5367be4
Use a separate requirements file instead
AlenkaF Aug 26, 2025
be6ca4c
Fix typo
AlenkaF Aug 26, 2025
430f26b
Simplify requirements
AlenkaF Sep 1, 2025
c5c8e4e
Reorganise requirements-wheel-test-3.13t
AlenkaF Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/docker/linux-apt-python-313-freethreading.dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ RUN apt-get update -y -q && \
rm -rf /var/lib/apt/lists*

COPY python/requirements-build.txt \
python/requirements-test.txt \
python/requirements-test-3.13t.txt \
/arrow/python/

ENV ARROW_PYTHON_VENV /arrow-dev
Expand All@@ -38,7 +38,7 @@ RUN ${ARROW_PYTHON_VENV}/bin/python -m pip install \
--prefer-binary \
--extra-index-url "https://pypi.anaconda.org/scientific-python-nightly-wheels/simple" \
-r arrow/python/requirements-build.txt \
-r arrow/python/requirements-test.txt
-r arrow/python/requirements-test-3.13t.txt

# We want to run the PyArrow test suite with the GIL disabled, but cffi
# (more precisely, the `_cffi_backend` module) currently doesn't declare
Expand Down
7 changes: 2 additions & 5 deletions ci/docker/python-free-threaded-wheel-windows-test-vs2022.dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,16 +37,13 @@ ENV PYTHON_CMD="py -${python}t"
SHELL ["cmd", "/S", "/C"]
RUN %PYTHON_CMD% -m pip install -U pip setuptools

COPY python/requirements-wheel-test.txt C:/arrow/python/
COPY python/requirements-wheel-test-3.13t.txt C:/arrow/python/

@raulcdraulcdAug 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.14 is going to be released around the next Arrow release (2025-10-07), we might want to add wheels for Arrow 22.
Can you add a comment here to revisit for Python 3.14? We will probably have to make this conditional

@pitroupitrouAug 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just open an issue for 3.14.

@AlenkaFAlenkaFAug 27, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I planned to open an issue for 3.14 - forgot to add in the comments!
Will do asap.

@AlenkaFAlenkaFAug 27, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #47437

# Cython and Pandas wheels for 3.13 free-threaded are not released yet
RUN %PYTHON_CMD% -m pip install \
--extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple \
--pre \
--prefer-binary \
-r C:/arrow/python/requirements-wheel-test.txt
# cffi-based tests would crash when importing cffi.
# hadolint ignore=DL3059
RUN %PYTHON_CMD% -m pip uninstall -y cffi
-r C:/arrow/python/requirements-wheel-test-3.13t.txt

ENV PYTHON="${python}t"
ENV PYTHON_GIL=0
5 changes: 5 additions & 0 deletions python/requirements-test-3.13t.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
hypothesis
packaging
pandas
pytest
pytz
9 changes: 9 additions & 0 deletions python/requirements-wheel-test-3.13t.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
cython
hypothesis
numpy~=2.1.0
packaging
pandas
pytest
pytz
requests; sys_platform == 'win32'
tzdata; sys_platform == 'win32'
Loading