Uh oh!
There was an error while loading. Please reload this page.
GH-47393: [C++][Acero] Support for multi threaded input: SortedMergeNode - #47394
Open
X-Lemon-X wants to merge 5 commits into
Open
GH-47393: [C++][Acero] Support for multi threaded input: SortedMergeNode#47394X-Lemon-X wants to merge 5 commits into
X-Lemon-X wants to merge 5 commits into
Conversation
added 2 commits
August 21, 2025 10:36
… to SortedMerge Node with back pressure control
…MergeNode, BackPressure. Moved BackpressureCountingNode to test_nodes
X-Lemon-X
marked this pull request as ready for review
August 21, 2025 13:23
added 2 commits
August 21, 2025 13:57
… ARROW_ENABLE_THREADING is not enabled
…quires threading enabled
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Lack of multi threading inputs support (batches were incoming not in order if they were ordered) with nodes like SortedMergeNode, previously resolved by disabling multi threading when using them.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Yes. Users of those node must assert ordering on input where appropriate.