Skip to content

GH-47370: [Python] Require Cython 3.1 - #47396

Merged
AlenkaF merged 1 commit into
apache:mainfrom
thisisnic:GH-47370_cython3.1
Sep 2, 2025
Merged

GH-47370: [Python] Require Cython 3.1#47396
AlenkaF merged 1 commit into
apache:mainfrom
thisisnic:GH-47370_cython3.1

Conversation

@thisisnic

@thisisnicthisisnic commented Aug 21, 2025

Copy link
Copy Markdown
Member

Rationale for this change

Upgrading Cython to version 3.1

What changes are included in this PR?

Replace all mentions of earlier versions with 3.1

Are these changes tested?

Nah but I'll run CI

Are there any user-facing changes?

Only if they're using Cython < 3.1

@thisisnic

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g python

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Aug 21, 2025
@github-actions

Copy link
Copy Markdown

Revision: bdded002dc1c13c2939f46b12f59cd5f30ce86cd

Submitted crossbow builds: ursacomputing/crossbow @ actions-0f0c2ad351

TaskStatus
example-python-minimal-build-fedora-condaGitHub Actions
example-python-minimal-build-ubuntu-venvGitHub Actions
test-conda-python-3.10GitHub Actions
test-conda-python-3.10-hdfs-2.9.2GitHub Actions
test-conda-python-3.10-hdfs-3.2.1GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11GitHub Actions
test-conda-python-3.11-dask-latestGitHub Actions
test-conda-python-3.11-dask-upstream_develGitHub Actions
test-conda-python-3.11-hypothesisGitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latestGitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightlyGitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightlyGitHub Actions
test-conda-python-3.11-spark-masterGitHub Actions
test-conda-python-3.12GitHub Actions
test-conda-python-3.12-cpython-debugGitHub Actions
test-conda-python-3.13GitHub Actions
test-conda-python-3.9GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5GitHub Actions
test-conda-python-emscriptenGitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1GitHub Actions
test-debian-12-python-3-amd64GitHub Actions
test-debian-12-python-3-i386GitHub Actions
test-fedora-42-python-3GitHub Actions
test-ubuntu-22.04-python-3GitHub Actions
test-ubuntu-22.04-python-313-freethreadingGitHub Actions
test-ubuntu-24.04-python-3GitHub Actions

@koukou changed the title GH-47370: [Python] Require Cython 3.1 GH-47370: [Python] Require Cython 3.1Aug 22, 2025
@raulcd

Copy link
Copy Markdown
Member

The macOS failures have been fixed on main, could you rebase to validate CI?

@AlenkaFAlenkaF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look good to me.

The two MinGW failures are not connected and are tracked here:
#47440

Will wait for one last check from @raulcd before we merge.

@raulcdraulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I've compared with the changes we did when we updated to minimum required Cython 3 and it seems like everything is covered:

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Sep 1, 2025
@raulcd

Copy link
Copy Markdown
Member

I plan to merge this as we all seem to be on agreement, I'll merge in the next couple of days unless there's any concern.
@WillAyd@pitrou FYI

@pitrou

Copy link
Copy Markdown
Member

As a followup task, perhaps look for places in the codebase where we can simplify things?

@WillAyd

Copy link
Copy Markdown
Contributor

Thanks!

@thisisnic

Copy link
Copy Markdown
MemberAuthor

As a followup task, perhaps look for places in the codebase where we can simplify things?

Sounds good, is there any particular kind of thing we want to simplify?

@pitrou

Copy link
Copy Markdown
Member

You'll find at least some ideas in the original issue ;)

@AlenkaF

Copy link
Copy Markdown
Member

Thank you @thisisnic!
I have created a follow-up issue (#47467) and will go ahead and merge the changes here.

@AlenkaF
AlenkaF merged commit 940592b into apache:mainSep 2, 2025
27 of 29 checks passed
@AlenkaFAlenkaF removed the awaiting merge Awaiting merge label Sep 2, 2025
@AlenkaFAlenkaF mentioned this pull request Sep 2, 2025
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 940592b.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
### Rationale for this change
Upgrading Cython to version 3.1
### What changes are included in this PR?
Replace all mentions of earlier versions with 3.1
### Are these changes tested?
Nah but I'll run CI
### Are there any user-facing changes?
Only if they're using Cython < 3.1
* GitHub Issue: apache#47370
Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@thisisnic@raulcd@pitrou@WillAyd@AlenkaF