GH-47402: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2086: Double quote to prevent globbing and word splitting
• SC2012: Use find instead of ls to better handle non-alphanumeric filenames

shellcheck ci/scripts/python_test_emscripten.sh
In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cd "${build_dir}"
In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
For more information:
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2086: Quote variables.
• SC2012: skip shellcheck.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47402

[github-actions]

⚠️ GitHub issue #47402has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

This part use ls with -t option, so we can't use echo.
I don't know alternate command which is usable on macOS / Linux.
(As far as I know, find and stat can't use the same option on macOS / Linux)

latest=$(python3-c '
importglob, osfiles=glob.glob("dist/pyarrow*.whl")
iffiles:
print(max(files, key=os.path.getmtime))
')
echo"$latest"

[hiroyuki-sato]

@kou CI has been passed. Please take a look when you get a chance.

[kou]

@github-actions crossbow submit emscripten

[github-actions]

Revision: 2e4daa4

Submitted crossbow builds: ursacomputing/crossbow @ actions-ccceaf6e7f

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

I reverted this change for testing test-conda-python-emscripten

[hiroyuki-sato]

@github-actions crossbow submit emscripten

[github-actions]

Unable to match any tasks for `emscripten`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/17230344793

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 46d2857

Submitted crossbow builds: ursacomputing/crossbow @ actions-80377eea67

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

test-conda-python-emscripten testing has been failed after revert this change. So, test-conda-python-emscripten failure unrelated this change.

[kou]

OK. Let's complete #47330 before this.

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 0a2541a

Submitted crossbow builds: ursacomputing/crossbow @ actions-c47d1b6828

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: bc5e282

Submitted crossbow builds: ursacomputing/crossbow @ actions-a99c8df489

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

It looks like the CI for test-conda-python-emscripten passed in #50598.

[raulcd]

LGTM

[hiroyuki-sato]

Both the CI and Crossbow have passed.

I rebased this PR only to rerun the test-conda-python-emscripten test. There have been no changes to the code in this PR since the last review.

Since #50610 also modifies .pre-commit-config.yaml, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.

[raulcd]

Thanks so much for working on those @hiroyuki-sato ! I merged this one before :)

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6efe7b3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2086: Double quote to prevent globbing and word splitting
• SC2012: Use find instead of ls to better handle non-alphanumeric filenames

shellcheck ci/scripts/python_test_emscripten.sh
In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cd "${build_dir}"
In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
For more information:
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2086: Quote variables.
• SC2012: skip shellcheck.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47402

[github-actions]

⚠️ GitHub issue #47402has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

This part use ls with -t option, so we can't use echo.
I don't know alternate command which is usable on macOS / Linux.
(As far as I know, find and stat can't use the same option on macOS / Linux)

latest=$(python3-c '
importglob, osfiles=glob.glob("dist/pyarrow*.whl")
iffiles:
print(max(files, key=os.path.getmtime))
')
echo"$latest"

[hiroyuki-sato]

@kou CI has been passed. Please take a look when you get a chance.

[kou]

@github-actions crossbow submit emscripten

[github-actions]

Revision: 2e4daa4

Submitted crossbow builds: ursacomputing/crossbow @ actions-ccceaf6e7f

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

I reverted this change for testing test-conda-python-emscripten

[hiroyuki-sato]

@github-actions crossbow submit emscripten

[github-actions]

Unable to match any tasks for `emscripten`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/17230344793

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 46d2857

Submitted crossbow builds: ursacomputing/crossbow @ actions-80377eea67

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

test-conda-python-emscripten testing has been failed after revert this change. So, test-conda-python-emscripten failure unrelated this change.

[kou]

OK. Let's complete #47330 before this.

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 0a2541a

Submitted crossbow builds: ursacomputing/crossbow @ actions-c47d1b6828

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: bc5e282

Submitted crossbow builds: ursacomputing/crossbow @ actions-a99c8df489

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

It looks like the CI for test-conda-python-emscripten passed in #50598.

[raulcd]

LGTM

[hiroyuki-sato]

Both the CI and Crossbow have passed.

I rebased this PR only to rerun the test-conda-python-emscripten test. There have been no changes to the code in this PR since the last review.

Since #50610 also modifies .pre-commit-config.yaml, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.

[raulcd]

Thanks so much for working on those @hiroyuki-sato ! I merged this one before :)

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6efe7b3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2086: Double quote to prevent globbing and word splitting
• SC2012: Use find instead of ls to better handle non-alphanumeric filenames

shellcheck ci/scripts/python_test_emscripten.sh
In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cd "${build_dir}"
In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
For more information:
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2086: Quote variables.
• SC2012: skip shellcheck.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47402

[github-actions]

⚠️ GitHub issue #47402has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

This part use ls with -t option, so we can't use echo.
I don't know alternate command which is usable on macOS / Linux.
(As far as I know, find and stat can't use the same option on macOS / Linux)

latest=$(python3-c '
importglob, osfiles=glob.glob("dist/pyarrow*.whl")
iffiles:
print(max(files, key=os.path.getmtime))
')
echo"$latest"

[hiroyuki-sato]

@kou CI has been passed. Please take a look when you get a chance.

[kou]

@github-actions crossbow submit emscripten

[github-actions]

Revision: 2e4daa4

Submitted crossbow builds: ursacomputing/crossbow @ actions-ccceaf6e7f

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

I reverted this change for testing test-conda-python-emscripten

[hiroyuki-sato]

@github-actions crossbow submit emscripten

[github-actions]

Unable to match any tasks for `emscripten`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/17230344793

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 46d2857

Submitted crossbow builds: ursacomputing/crossbow @ actions-80377eea67

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

test-conda-python-emscripten testing has been failed after revert this change. So, test-conda-python-emscripten failure unrelated this change.

[kou]

OK. Let's complete #47330 before this.

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 0a2541a

Submitted crossbow builds: ursacomputing/crossbow @ actions-c47d1b6828

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: bc5e282

Submitted crossbow builds: ursacomputing/crossbow @ actions-a99c8df489

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

It looks like the CI for test-conda-python-emscripten passed in #50598.

[raulcd]

LGTM

[hiroyuki-sato]

Both the CI and Crossbow have passed.

I rebased this PR only to rerun the test-conda-python-emscripten test. There have been no changes to the code in this PR since the last review.

Since #50610 also modifies .pre-commit-config.yaml, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.

[raulcd]

Thanks so much for working on those @hiroyuki-sato ! I merged this one before :)

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6efe7b3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2086: Double quote to prevent globbing and word splitting
• SC2012: Use find instead of ls to better handle non-alphanumeric filenames

shellcheck ci/scripts/python_test_emscripten.sh
In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cd "${build_dir}"
In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
For more information:
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2086: Quote variables.
• SC2012: skip shellcheck.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47402

[github-actions]

⚠️ GitHub issue #47402has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

This part use ls with -t option, so we can't use echo.
I don't know alternate command which is usable on macOS / Linux.
(As far as I know, find and stat can't use the same option on macOS / Linux)

latest=$(python3-c '
importglob, osfiles=glob.glob("dist/pyarrow*.whl")
iffiles:
print(max(files, key=os.path.getmtime))
')
echo"$latest"

[hiroyuki-sato]

@kou CI has been passed. Please take a look when you get a chance.

[kou]

@github-actions crossbow submit emscripten

[github-actions]

Revision: 2e4daa4

Submitted crossbow builds: ursacomputing/crossbow @ actions-ccceaf6e7f

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

I reverted this change for testing test-conda-python-emscripten

[hiroyuki-sato]

@github-actions crossbow submit emscripten

[github-actions]

Unable to match any tasks for `emscripten`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/17230344793

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 46d2857

Submitted crossbow builds: ursacomputing/crossbow @ actions-80377eea67

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

test-conda-python-emscripten testing has been failed after revert this change. So, test-conda-python-emscripten failure unrelated this change.

[kou]

OK. Let's complete #47330 before this.

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 0a2541a

Submitted crossbow builds: ursacomputing/crossbow @ actions-c47d1b6828

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: bc5e282

Submitted crossbow builds: ursacomputing/crossbow @ actions-a99c8df489

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

It looks like the CI for test-conda-python-emscripten passed in #50598.

[raulcd]

LGTM

[hiroyuki-sato]

Both the CI and Crossbow have passed.

I rebased this PR only to rerun the test-conda-python-emscripten test. There have been no changes to the code in this PR since the last review.

Since #50610 also modifies .pre-commit-config.yaml, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.

[raulcd]

Thanks so much for working on those @hiroyuki-sato ! I merged this one before :)

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6efe7b3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2086: Double quote to prevent globbing and word splitting
• SC2012: Use find instead of ls to better handle non-alphanumeric filenames

shellcheck ci/scripts/python_test_emscripten.sh
In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cd "${build_dir}"
In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
For more information:
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2086: Quote variables.
• SC2012: skip shellcheck.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47402

[github-actions]

⚠️ GitHub issue #47402has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

This part use ls with -t option, so we can't use echo.
I don't know alternate command which is usable on macOS / Linux.
(As far as I know, find and stat can't use the same option on macOS / Linux)

latest=$(python3-c '
importglob, osfiles=glob.glob("dist/pyarrow*.whl")
iffiles:
print(max(files, key=os.path.getmtime))
')
echo"$latest"

[hiroyuki-sato]

@kou CI has been passed. Please take a look when you get a chance.

[kou]

@github-actions crossbow submit emscripten

[github-actions]

Revision: 2e4daa4

Submitted crossbow builds: ursacomputing/crossbow @ actions-ccceaf6e7f

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

I reverted this change for testing test-conda-python-emscripten

[hiroyuki-sato]

@github-actions crossbow submit emscripten

[github-actions]

Unable to match any tasks for `emscripten`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/17230344793

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 46d2857

Submitted crossbow builds: ursacomputing/crossbow @ actions-80377eea67

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

test-conda-python-emscripten testing has been failed after revert this change. So, test-conda-python-emscripten failure unrelated this change.

[kou]

OK. Let's complete #47330 before this.

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 0a2541a

Submitted crossbow builds: ursacomputing/crossbow @ actions-c47d1b6828

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: bc5e282

Submitted crossbow builds: ursacomputing/crossbow @ actions-a99c8df489

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

It looks like the CI for test-conda-python-emscripten passed in #50598.

[raulcd]

LGTM

[hiroyuki-sato]

Both the CI and Crossbow have passed.

I rebased this PR only to rerun the test-conda-python-emscripten test. There have been no changes to the code in this PR since the last review.

Since #50610 also modifies .pre-commit-config.yaml, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.

[raulcd]

Thanks so much for working on those @hiroyuki-sato ! I merged this one before :)

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6efe7b3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2086: Double quote to prevent globbing and word splitting
• SC2012: Use find instead of ls to better handle non-alphanumeric filenames

shellcheck ci/scripts/python_test_emscripten.sh
In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cd "${build_dir}"
In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
For more information:
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2086: Quote variables.
• SC2012: skip shellcheck.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47402

[github-actions]

⚠️ GitHub issue #47402has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

This part use ls with -t option, so we can't use echo.
I don't know alternate command which is usable on macOS / Linux.
(As far as I know, find and stat can't use the same option on macOS / Linux)

latest=$(python3-c '
importglob, osfiles=glob.glob("dist/pyarrow*.whl")
iffiles:
print(max(files, key=os.path.getmtime))
')
echo"$latest"

[hiroyuki-sato]

@kou CI has been passed. Please take a look when you get a chance.

[kou]

@github-actions crossbow submit emscripten

[github-actions]

Revision: 2e4daa4

Submitted crossbow builds: ursacomputing/crossbow @ actions-ccceaf6e7f

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

I reverted this change for testing test-conda-python-emscripten

[hiroyuki-sato]

@github-actions crossbow submit emscripten

[github-actions]

Unable to match any tasks for `emscripten`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/17230344793

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 46d2857

Submitted crossbow builds: ursacomputing/crossbow @ actions-80377eea67

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

test-conda-python-emscripten testing has been failed after revert this change. So, test-conda-python-emscripten failure unrelated this change.

[kou]

OK. Let's complete #47330 before this.

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 0a2541a

Submitted crossbow builds: ursacomputing/crossbow @ actions-c47d1b6828

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: bc5e282

Submitted crossbow builds: ursacomputing/crossbow @ actions-a99c8df489

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

It looks like the CI for test-conda-python-emscripten passed in #50598.

[raulcd]

LGTM

[hiroyuki-sato]

Both the CI and Crossbow have passed.

I rebased this PR only to rerun the test-conda-python-emscripten test. There have been no changes to the code in this PR since the last review.

Since #50610 also modifies .pre-commit-config.yaml, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.

[raulcd]

Thanks so much for working on those @hiroyuki-sato ! I merged this one before :)

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6efe7b3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2086: Double quote to prevent globbing and word splitting
• SC2012: Use find instead of ls to better handle non-alphanumeric filenames

shellcheck ci/scripts/python_test_emscripten.sh
In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cd "${build_dir}"
In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
For more information:
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2086: Quote variables.
• SC2012: skip shellcheck.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47402

[github-actions]

⚠️ GitHub issue #47402has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

This part use ls with -t option, so we can't use echo.
I don't know alternate command which is usable on macOS / Linux.
(As far as I know, find and stat can't use the same option on macOS / Linux)

latest=$(python3-c '
importglob, osfiles=glob.glob("dist/pyarrow*.whl")
iffiles:
print(max(files, key=os.path.getmtime))
')
echo"$latest"

[hiroyuki-sato]

@kou CI has been passed. Please take a look when you get a chance.

[kou]

@github-actions crossbow submit emscripten

[github-actions]

Revision: 2e4daa4

Submitted crossbow builds: ursacomputing/crossbow @ actions-ccceaf6e7f

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

I reverted this change for testing test-conda-python-emscripten

[hiroyuki-sato]

@github-actions crossbow submit emscripten

[github-actions]

Unable to match any tasks for `emscripten`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/17230344793

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 46d2857

Submitted crossbow builds: ursacomputing/crossbow @ actions-80377eea67

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

test-conda-python-emscripten testing has been failed after revert this change. So, test-conda-python-emscripten failure unrelated this change.

[kou]

OK. Let's complete #47330 before this.

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 0a2541a

Submitted crossbow builds: ursacomputing/crossbow @ actions-c47d1b6828

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: bc5e282

Submitted crossbow builds: ursacomputing/crossbow @ actions-a99c8df489

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

It looks like the CI for test-conda-python-emscripten passed in #50598.

[raulcd]

LGTM

[hiroyuki-sato]

Both the CI and Crossbow have passed.

I rebased this PR only to rerun the test-conda-python-emscripten test. There have been no changes to the code in this PR since the last review.

Since #50610 also modifies .pre-commit-config.yaml, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.

[raulcd]

Thanks so much for working on those @hiroyuki-sato ! I merged this one before :)

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6efe7b3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2086: Double quote to prevent globbing and word splitting
• SC2012: Use find instead of ls to better handle non-alphanumeric filenames

shellcheck ci/scripts/python_test_emscripten.sh
In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cd "${build_dir}"
In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
For more information:
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2086: Quote variables.
• SC2012: skip shellcheck.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47402

[github-actions]

⚠️ GitHub issue #47402has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

This part use ls with -t option, so we can't use echo.
I don't know alternate command which is usable on macOS / Linux.
(As far as I know, find and stat can't use the same option on macOS / Linux)

latest=$(python3-c '
importglob, osfiles=glob.glob("dist/pyarrow*.whl")
iffiles:
print(max(files, key=os.path.getmtime))
')
echo"$latest"

[hiroyuki-sato]

@kou CI has been passed. Please take a look when you get a chance.

[kou]

@github-actions crossbow submit emscripten

[github-actions]

Revision: 2e4daa4

Submitted crossbow builds: ursacomputing/crossbow @ actions-ccceaf6e7f

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

I reverted this change for testing test-conda-python-emscripten

[hiroyuki-sato]

@github-actions crossbow submit emscripten

[github-actions]

Unable to match any tasks for `emscripten`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/17230344793

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 46d2857

Submitted crossbow builds: ursacomputing/crossbow @ actions-80377eea67

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

test-conda-python-emscripten testing has been failed after revert this change. So, test-conda-python-emscripten failure unrelated this change.

[kou]

OK. Let's complete #47330 before this.

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: 0a2541a

Submitted crossbow builds: ursacomputing/crossbow @ actions-c47d1b6828

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

@github-actions crossbow submit test-conda-python-emscripten test-ubuntu-22.04-cpp-emscripten

[github-actions]

Revision: bc5e282

Submitted crossbow builds: ursacomputing/crossbow @ actions-a99c8df489

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

[hiroyuki-sato]

It looks like the CI for test-conda-python-emscripten passed in #50598.

[raulcd]

LGTM

[hiroyuki-sato]

Both the CI and Crossbow have passed.

I rebased this PR only to rerun the test-conda-python-emscripten test. There have been no changes to the code in this PR since the last review.

Since #50610 also modifies .pre-commit-config.yaml, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.

[raulcd]

Thanks so much for working on those @hiroyuki-sato ! I merged this one before :)

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6efe7b3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.