ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh - #4749

Closed
shiro615 wants to merge 9 commits into
apache:masterfrom
shiro615:release-replace-c-glib-after-running-autogen
Closed

ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh#4749
shiro615 wants to merge 9 commits into
apache:masterfrom
shiro615:release-replace-c-glib-after-running-autogen

Conversation

@shiro615

@shiro615shiro615 commented Jun 29, 2019

Copy link
Copy Markdown
Contributor

c_glib/ source archive is generated by make dist because includes configure script.
The current dev/release/02-source.sh build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run make dist. But it is slow.
So this PR run only c_glib/autogen.sh and then replace c_glib/.

shiro615
shiro615 commented Jun 29, 2019
View reviewed changes
Comment threaddev/release/source/Dockerfile Outdated

@shiro615shiro615Jun 29, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the libraries for building Arrow C++, because just runs c_glib/autogen.sh.

shiro615
shiro615 commented Jun 29, 2019
View reviewed changes
Comment threadci/travis_release_test.sh Outdated

@shiro615shiro615Jun 29, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the test for GLib configure.
But if you don't want to enable this option, I will remove this.

@koukouJul 3, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.
Could you remove omit from 02-source-test.rb.?

@shiro615shiro615Jul 3, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it.

@koukouJul 3, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this change?

@shiro615shiro615Jul 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...sorry. I've removed this change.

@codecov-io

codecov-io commented Jun 29, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4749 into master will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #4749 +/- ##
==========================================
- Coverage 86.44% 85.89% -0.55% 
==========================================
Files 992 881 -111 Lines 138020 115177 -22843 Branches 1418 1418 ==========================================
- Hits 119311 98936 -20375 + Misses 18347 15879 -2468 
Partials 362 362
Impacted FilesCoverage Δ
cpp/src/arrow/array/builder_union.cc0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.h0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.cc0% <0%> (-92.9%)⬇️
cpp/src/arrow/adapters/orc/adapter_util.cc15.74% <0%> (-64.97%)⬇️
cpp/src/arrow/array/builder_union.h0% <0%> (-61.91%)⬇️
cpp/src/arrow/util/cpu-info.h0% <0%> (-50%)⬇️
cpp/src/arrow/csv/options.h66.66% <0%> (-33.34%)⬇️
cpp/src/arrow/extension_type.cc66.66% <0%> (-26.67%)⬇️
cpp/src/parquet/column_scanner.cc55% <0%> (-25%)⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c52.79% <0%> (-20.82%)⬇️
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d25902...447f83e. Read the comment docs.

@shiro615shiro615 changed the title ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shWIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@shiro615shiro615 changed the title WIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@wesm

wesm commented Jul 3, 2019

Copy link
Copy Markdown
Member

Seems like a nice improvement. Will let @kou review

@kou

kou commented Jul 3, 2019

Copy link
Copy Markdown
Member

I'll take a look this after 0.14.0 RC0. Please wait a while.

kou
kou requested changes Jul 3, 2019
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my comments?
I've added a commit to use docker-compose.

Comment threaddev/release/rat_exclude_files.txt Outdated

@koukouJul 3, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove them after we run autogen.sh instead of adding them to archive?

@shiro615shiro615Jul 3, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to remove them after running autogen.sh.

Comment threadci/travis_release_test.sh Outdated

@koukouJul 3, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.
Could you remove omit from 02-source-test.rb.?

@kou
kouforce-pushed the release-replace-c-glib-after-running-autogen branch from 216fcda to 9a69f8eCompareJuly 5, 2019 00:17
kou
kou approved these changes Jul 5, 2019
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
I've rebased on master. I'll merge this when CI is green.

@koukou closed this in 9ffb9cdJul 5, 2019
@shiro615
shiro615 deleted the release-replace-c-glib-after-running-autogen branch July 6, 2019 01:37
wesm pushed a commit that referenced this pull request Jul 13, 2019
@shiro615@wesm
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/auto…
297c953
…gen.sh in dev/release/02-source.sh
c_glib/ source archive is generated by `make dist` because includes configure script.
The current `dev/release/02-source.sh` build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run `make dist`. But it is slow.
So this PR run only `c_glib/autogen.sh` and then replace c_glib/.
Author: Yosuke Shiro <yosuke.shiro615@gmail.com>
Author: Sutou Kouhei <kou@clear-code.com>
Closes#4749 from shiro615/release-replace-c-glib-after-running-autogen and squashes the following commits:
9a69f8e <Yosuke Shiro> Remove an unnecessary environment variable
3a2550f <Yosuke Shiro> Remove omit from 02-source-test.rb
501a2dd <Yosuke Shiro> Remove autom4te.cache after running autogen.sh
46a4f89 <Sutou Kouhei> Use docker-compose
e357a88 <Yosuke Shiro> Exclude c_glib/autom4te.cache/* from RAT check
70cb4a7 <Yosuke Shiro> Remove an unnecessary diff
aa78680 <Yosuke Shiro> Enable test test_glib_configure on Travis CI
e04276e <Yosuke Shiro> Remove libraries for C++ build
56098ae <Yosuke Shiro> Replace c_glib/ by c_glib/ after running autogen.sh
@asfimportasfimport mentioned this pull request Aug 1, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shiro615@codecov-io@wesm@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh - #4749
Closed
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Closed
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh#4749
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Conversation
@shiro615
@shiro615shiro615
commented
Jun 29, 2019

Copy link


Copy Markdown

Contributor
c_glib/ source archive is generated by make dist because includes configure script.

The current dev/release/02-source.sh build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run make dist. But it is slow.

So this PR run only c_glib/autogen.sh and then replace c_glib/.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threaddev/release/source/Dockerfile
Outdated

@shiro615shiro615Jun 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the libraries for building Arrow C++, because just runs c_glib/autogen.sh.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threadci/travis_release_test.sh
Outdated

@shiro615shiro615Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the test for GLib configure.

But if you don't want to enable this option, I will remove this.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this change?
@shiro615shiro615Jul 4, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...sorry. I've removed this change.
@codecov-io
codecov-io
commented
Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4749 into master will decrease coverage by 0.54%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4749 +/- ##
==========================================
- Coverage 86.44% 85.89% -0.55% 
==========================================
Files 992 881 -111 Lines 138020 115177 -22843 Branches 1418 1418 ==========================================
- Hits 119311 98936 -20375 + Misses 18347 15879 -2468 
Partials 362 362
Impacted FilesCoverage Δ
cpp/src/arrow/array/builder_union.cc0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.h0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.cc0% <0%> (-92.9%)⬇️
cpp/src/arrow/adapters/orc/adapter_util.cc15.74% <0%> (-64.97%)⬇️
cpp/src/arrow/array/builder_union.h0% <0%> (-61.91%)⬇️
cpp/src/arrow/util/cpu-info.h0% <0%> (-50%)⬇️
cpp/src/arrow/csv/options.h66.66% <0%> (-33.34%)⬇️
cpp/src/arrow/extension_type.cc66.66% <0%> (-26.67%)⬇️
cpp/src/parquet/column_scanner.cc55% <0%> (-25%)⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c52.79% <0%> (-20.82%)⬇️
... and 179 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 4d25902...447f83e. Read the comment docs.
@shiro615shiro615
changed the title
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shWIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@shiro615shiro615
changed the title
WIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@wesm
wesm
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
Seems like a nice improvement. Will let @kou review
@kou
kou
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
I'll take a look this after 0.14.0 RC0. Please wait a while.
kou
kou
requested changes
Jul 3, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my comments?

I've added a commit to use docker-compose.
Comment threaddev/release/rat_exclude_files.txt
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove them after we run autogen.sh instead of adding them to archive?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to remove them after running autogen.sh.
Comment threadci/travis_release_test.sh
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@kou
kouforce-pushed
the
release-replace-c-glib-after-running-autogen
branch
from
216fcda to
9a69f8eCompareJuly 5, 2019 00:17
kou
kou
approved these changes
Jul 5, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I've rebased on master. I'll merge this when CI is green.
@koukou
closed this
in
9ffb9cdJul 5, 2019
@shiro615
shiro615
deleted the

release-replace-c-glib-after-running-autogen

branch
July 6, 2019 01:37
wesm pushed a commit
that referenced
this pull request
Jul 13, 2019
@shiro615@wesm
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/auto…
297c953
…gen.sh in dev/release/02-source.sh
c_glib/ source archive is generated by `make dist` because includes configure script.
The current `dev/release/02-source.sh` build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run `make dist`. But it is slow.
So this PR run only `c_glib/autogen.sh` and then replace c_glib/.
Author: Yosuke Shiro <yosuke.shiro615@gmail.com>
Author: Sutou Kouhei <kou@clear-code.com>
Closes#4749 from shiro615/release-replace-c-glib-after-running-autogen and squashes the following commits:
9a69f8e <Yosuke Shiro> Remove an unnecessary environment variable
3a2550f <Yosuke Shiro> Remove omit from 02-source-test.rb
501a2dd <Yosuke Shiro> Remove autom4te.cache after running autogen.sh
46a4f89 <Sutou Kouhei> Use docker-compose
e357a88 <Yosuke Shiro> Exclude c_glib/autom4te.cache/* from RAT check
70cb4a7 <Yosuke Shiro> Remove an unnecessary diff
aa78680 <Yosuke Shiro> Enable test test_glib_configure on Travis CI
e04276e <Yosuke Shiro> Remove libraries for C++ build
56098ae <Yosuke Shiro> Replace c_glib/ by c_glib/ after running autogen.sh
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@shiro615@codecov-io@wesm@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh - #4749
Closed
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Closed
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh#4749
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Conversation
@shiro615
@shiro615shiro615
commented
Jun 29, 2019

Copy link


Copy Markdown

Contributor
c_glib/ source archive is generated by make dist because includes configure script.

The current dev/release/02-source.sh build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run make dist. But it is slow.

So this PR run only c_glib/autogen.sh and then replace c_glib/.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threaddev/release/source/Dockerfile
Outdated

@shiro615shiro615Jun 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the libraries for building Arrow C++, because just runs c_glib/autogen.sh.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threadci/travis_release_test.sh
Outdated

@shiro615shiro615Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the test for GLib configure.

But if you don't want to enable this option, I will remove this.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this change?
@shiro615shiro615Jul 4, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...sorry. I've removed this change.
@codecov-io
codecov-io
commented
Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4749 into master will decrease coverage by 0.54%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4749 +/- ##
==========================================
- Coverage 86.44% 85.89% -0.55% 
==========================================
Files 992 881 -111 Lines 138020 115177 -22843 Branches 1418 1418 ==========================================
- Hits 119311 98936 -20375 + Misses 18347 15879 -2468 
Partials 362 362
Impacted FilesCoverage Δ
cpp/src/arrow/array/builder_union.cc0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.h0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.cc0% <0%> (-92.9%)⬇️
cpp/src/arrow/adapters/orc/adapter_util.cc15.74% <0%> (-64.97%)⬇️
cpp/src/arrow/array/builder_union.h0% <0%> (-61.91%)⬇️
cpp/src/arrow/util/cpu-info.h0% <0%> (-50%)⬇️
cpp/src/arrow/csv/options.h66.66% <0%> (-33.34%)⬇️
cpp/src/arrow/extension_type.cc66.66% <0%> (-26.67%)⬇️
cpp/src/parquet/column_scanner.cc55% <0%> (-25%)⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c52.79% <0%> (-20.82%)⬇️
... and 179 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 4d25902...447f83e. Read the comment docs.
@shiro615shiro615
changed the title
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shWIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@shiro615shiro615
changed the title
WIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@wesm
wesm
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
Seems like a nice improvement. Will let @kou review
@kou
kou
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
I'll take a look this after 0.14.0 RC0. Please wait a while.
kou
kou
requested changes
Jul 3, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my comments?

I've added a commit to use docker-compose.
Comment threaddev/release/rat_exclude_files.txt
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove them after we run autogen.sh instead of adding them to archive?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to remove them after running autogen.sh.
Comment threadci/travis_release_test.sh
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@kou
kouforce-pushed
the
release-replace-c-glib-after-running-autogen
branch
from
216fcda to
9a69f8eCompareJuly 5, 2019 00:17
kou
kou
approved these changes
Jul 5, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I've rebased on master. I'll merge this when CI is green.
@koukou
closed this
in
9ffb9cdJul 5, 2019
@shiro615
shiro615
deleted the

release-replace-c-glib-after-running-autogen

branch
July 6, 2019 01:37
wesm pushed a commit
that referenced
this pull request
Jul 13, 2019
@shiro615@wesm
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/auto…
297c953
…gen.sh in dev/release/02-source.sh
c_glib/ source archive is generated by `make dist` because includes configure script.
The current `dev/release/02-source.sh` build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run `make dist`. But it is slow.
So this PR run only `c_glib/autogen.sh` and then replace c_glib/.
Author: Yosuke Shiro <yosuke.shiro615@gmail.com>
Author: Sutou Kouhei <kou@clear-code.com>
Closes#4749 from shiro615/release-replace-c-glib-after-running-autogen and squashes the following commits:
9a69f8e <Yosuke Shiro> Remove an unnecessary environment variable
3a2550f <Yosuke Shiro> Remove omit from 02-source-test.rb
501a2dd <Yosuke Shiro> Remove autom4te.cache after running autogen.sh
46a4f89 <Sutou Kouhei> Use docker-compose
e357a88 <Yosuke Shiro> Exclude c_glib/autom4te.cache/* from RAT check
70cb4a7 <Yosuke Shiro> Remove an unnecessary diff
aa78680 <Yosuke Shiro> Enable test test_glib_configure on Travis CI
e04276e <Yosuke Shiro> Remove libraries for C++ build
56098ae <Yosuke Shiro> Replace c_glib/ by c_glib/ after running autogen.sh
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@shiro615@codecov-io@wesm@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh - #4749
Closed
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Closed
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh#4749
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Conversation
@shiro615
@shiro615shiro615
commented
Jun 29, 2019

Copy link


Copy Markdown

Contributor
c_glib/ source archive is generated by make dist because includes configure script.

The current dev/release/02-source.sh build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run make dist. But it is slow.

So this PR run only c_glib/autogen.sh and then replace c_glib/.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threaddev/release/source/Dockerfile
Outdated

@shiro615shiro615Jun 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the libraries for building Arrow C++, because just runs c_glib/autogen.sh.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threadci/travis_release_test.sh
Outdated

@shiro615shiro615Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the test for GLib configure.

But if you don't want to enable this option, I will remove this.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this change?
@shiro615shiro615Jul 4, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...sorry. I've removed this change.
@codecov-io
codecov-io
commented
Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4749 into master will decrease coverage by 0.54%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4749 +/- ##
==========================================
- Coverage 86.44% 85.89% -0.55% 
==========================================
Files 992 881 -111 Lines 138020 115177 -22843 Branches 1418 1418 ==========================================
- Hits 119311 98936 -20375 + Misses 18347 15879 -2468 
Partials 362 362
Impacted FilesCoverage Δ
cpp/src/arrow/array/builder_union.cc0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.h0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.cc0% <0%> (-92.9%)⬇️
cpp/src/arrow/adapters/orc/adapter_util.cc15.74% <0%> (-64.97%)⬇️
cpp/src/arrow/array/builder_union.h0% <0%> (-61.91%)⬇️
cpp/src/arrow/util/cpu-info.h0% <0%> (-50%)⬇️
cpp/src/arrow/csv/options.h66.66% <0%> (-33.34%)⬇️
cpp/src/arrow/extension_type.cc66.66% <0%> (-26.67%)⬇️
cpp/src/parquet/column_scanner.cc55% <0%> (-25%)⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c52.79% <0%> (-20.82%)⬇️
... and 179 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 4d25902...447f83e. Read the comment docs.
@shiro615shiro615
changed the title
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shWIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@shiro615shiro615
changed the title
WIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@wesm
wesm
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
Seems like a nice improvement. Will let @kou review
@kou
kou
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
I'll take a look this after 0.14.0 RC0. Please wait a while.
kou
kou
requested changes
Jul 3, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my comments?

I've added a commit to use docker-compose.
Comment threaddev/release/rat_exclude_files.txt
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove them after we run autogen.sh instead of adding them to archive?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to remove them after running autogen.sh.
Comment threadci/travis_release_test.sh
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@kou
kouforce-pushed
the
release-replace-c-glib-after-running-autogen
branch
from
216fcda to
9a69f8eCompareJuly 5, 2019 00:17
kou
kou
approved these changes
Jul 5, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I've rebased on master. I'll merge this when CI is green.
@koukou
closed this
in
9ffb9cdJul 5, 2019
@shiro615
shiro615
deleted the

release-replace-c-glib-after-running-autogen

branch
July 6, 2019 01:37
wesm pushed a commit
that referenced
this pull request
Jul 13, 2019
@shiro615@wesm
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/auto…
297c953
…gen.sh in dev/release/02-source.sh
c_glib/ source archive is generated by `make dist` because includes configure script.
The current `dev/release/02-source.sh` build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run `make dist`. But it is slow.
So this PR run only `c_glib/autogen.sh` and then replace c_glib/.
Author: Yosuke Shiro <yosuke.shiro615@gmail.com>
Author: Sutou Kouhei <kou@clear-code.com>
Closes#4749 from shiro615/release-replace-c-glib-after-running-autogen and squashes the following commits:
9a69f8e <Yosuke Shiro> Remove an unnecessary environment variable
3a2550f <Yosuke Shiro> Remove omit from 02-source-test.rb
501a2dd <Yosuke Shiro> Remove autom4te.cache after running autogen.sh
46a4f89 <Sutou Kouhei> Use docker-compose
e357a88 <Yosuke Shiro> Exclude c_glib/autom4te.cache/* from RAT check
70cb4a7 <Yosuke Shiro> Remove an unnecessary diff
aa78680 <Yosuke Shiro> Enable test test_glib_configure on Travis CI
e04276e <Yosuke Shiro> Remove libraries for C++ build
56098ae <Yosuke Shiro> Replace c_glib/ by c_glib/ after running autogen.sh
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@shiro615@codecov-io@wesm@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh - #4749
Closed
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Closed
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh#4749
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Conversation
@shiro615
@shiro615shiro615
commented
Jun 29, 2019

Copy link


Copy Markdown

Contributor
c_glib/ source archive is generated by make dist because includes configure script.

The current dev/release/02-source.sh build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run make dist. But it is slow.

So this PR run only c_glib/autogen.sh and then replace c_glib/.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threaddev/release/source/Dockerfile
Outdated

@shiro615shiro615Jun 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the libraries for building Arrow C++, because just runs c_glib/autogen.sh.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threadci/travis_release_test.sh
Outdated

@shiro615shiro615Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the test for GLib configure.

But if you don't want to enable this option, I will remove this.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this change?
@shiro615shiro615Jul 4, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...sorry. I've removed this change.
@codecov-io
codecov-io
commented
Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4749 into master will decrease coverage by 0.54%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4749 +/- ##
==========================================
- Coverage 86.44% 85.89% -0.55% 
==========================================
Files 992 881 -111 Lines 138020 115177 -22843 Branches 1418 1418 ==========================================
- Hits 119311 98936 -20375 + Misses 18347 15879 -2468 
Partials 362 362
Impacted FilesCoverage Δ
cpp/src/arrow/array/builder_union.cc0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.h0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.cc0% <0%> (-92.9%)⬇️
cpp/src/arrow/adapters/orc/adapter_util.cc15.74% <0%> (-64.97%)⬇️
cpp/src/arrow/array/builder_union.h0% <0%> (-61.91%)⬇️
cpp/src/arrow/util/cpu-info.h0% <0%> (-50%)⬇️
cpp/src/arrow/csv/options.h66.66% <0%> (-33.34%)⬇️
cpp/src/arrow/extension_type.cc66.66% <0%> (-26.67%)⬇️
cpp/src/parquet/column_scanner.cc55% <0%> (-25%)⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c52.79% <0%> (-20.82%)⬇️
... and 179 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 4d25902...447f83e. Read the comment docs.
@shiro615shiro615
changed the title
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shWIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@shiro615shiro615
changed the title
WIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@wesm
wesm
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
Seems like a nice improvement. Will let @kou review
@kou
kou
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
I'll take a look this after 0.14.0 RC0. Please wait a while.
kou
kou
requested changes
Jul 3, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my comments?

I've added a commit to use docker-compose.
Comment threaddev/release/rat_exclude_files.txt
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove them after we run autogen.sh instead of adding them to archive?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to remove them after running autogen.sh.
Comment threadci/travis_release_test.sh
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@kou
kouforce-pushed
the
release-replace-c-glib-after-running-autogen
branch
from
216fcda to
9a69f8eCompareJuly 5, 2019 00:17
kou
kou
approved these changes
Jul 5, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I've rebased on master. I'll merge this when CI is green.
@koukou
closed this
in
9ffb9cdJul 5, 2019
@shiro615
shiro615
deleted the

release-replace-c-glib-after-running-autogen

branch
July 6, 2019 01:37
wesm pushed a commit
that referenced
this pull request
Jul 13, 2019
@shiro615@wesm
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/auto…
297c953
…gen.sh in dev/release/02-source.sh
c_glib/ source archive is generated by `make dist` because includes configure script.
The current `dev/release/02-source.sh` build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run `make dist`. But it is slow.
So this PR run only `c_glib/autogen.sh` and then replace c_glib/.
Author: Yosuke Shiro <yosuke.shiro615@gmail.com>
Author: Sutou Kouhei <kou@clear-code.com>
Closes#4749 from shiro615/release-replace-c-glib-after-running-autogen and squashes the following commits:
9a69f8e <Yosuke Shiro> Remove an unnecessary environment variable
3a2550f <Yosuke Shiro> Remove omit from 02-source-test.rb
501a2dd <Yosuke Shiro> Remove autom4te.cache after running autogen.sh
46a4f89 <Sutou Kouhei> Use docker-compose
e357a88 <Yosuke Shiro> Exclude c_glib/autom4te.cache/* from RAT check
70cb4a7 <Yosuke Shiro> Remove an unnecessary diff
aa78680 <Yosuke Shiro> Enable test test_glib_configure on Travis CI
e04276e <Yosuke Shiro> Remove libraries for C++ build
56098ae <Yosuke Shiro> Replace c_glib/ by c_glib/ after running autogen.sh
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@shiro615@codecov-io@wesm@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh - #4749
Closed
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Closed
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh#4749
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Conversation
@shiro615
@shiro615shiro615
commented
Jun 29, 2019

Copy link


Copy Markdown

Contributor
c_glib/ source archive is generated by make dist because includes configure script.

The current dev/release/02-source.sh build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run make dist. But it is slow.

So this PR run only c_glib/autogen.sh and then replace c_glib/.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threaddev/release/source/Dockerfile
Outdated

@shiro615shiro615Jun 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the libraries for building Arrow C++, because just runs c_glib/autogen.sh.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threadci/travis_release_test.sh
Outdated

@shiro615shiro615Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the test for GLib configure.

But if you don't want to enable this option, I will remove this.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this change?
@shiro615shiro615Jul 4, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...sorry. I've removed this change.
@codecov-io
codecov-io
commented
Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4749 into master will decrease coverage by 0.54%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4749 +/- ##
==========================================
- Coverage 86.44% 85.89% -0.55% 
==========================================
Files 992 881 -111 Lines 138020 115177 -22843 Branches 1418 1418 ==========================================
- Hits 119311 98936 -20375 + Misses 18347 15879 -2468 
Partials 362 362
Impacted FilesCoverage Δ
cpp/src/arrow/array/builder_union.cc0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.h0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.cc0% <0%> (-92.9%)⬇️
cpp/src/arrow/adapters/orc/adapter_util.cc15.74% <0%> (-64.97%)⬇️
cpp/src/arrow/array/builder_union.h0% <0%> (-61.91%)⬇️
cpp/src/arrow/util/cpu-info.h0% <0%> (-50%)⬇️
cpp/src/arrow/csv/options.h66.66% <0%> (-33.34%)⬇️
cpp/src/arrow/extension_type.cc66.66% <0%> (-26.67%)⬇️
cpp/src/parquet/column_scanner.cc55% <0%> (-25%)⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c52.79% <0%> (-20.82%)⬇️
... and 179 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 4d25902...447f83e. Read the comment docs.
@shiro615shiro615
changed the title
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shWIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@shiro615shiro615
changed the title
WIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@wesm
wesm
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
Seems like a nice improvement. Will let @kou review
@kou
kou
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
I'll take a look this after 0.14.0 RC0. Please wait a while.
kou
kou
requested changes
Jul 3, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my comments?

I've added a commit to use docker-compose.
Comment threaddev/release/rat_exclude_files.txt
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove them after we run autogen.sh instead of adding them to archive?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to remove them after running autogen.sh.
Comment threadci/travis_release_test.sh
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@kou
kouforce-pushed
the
release-replace-c-glib-after-running-autogen
branch
from
216fcda to
9a69f8eCompareJuly 5, 2019 00:17
kou
kou
approved these changes
Jul 5, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I've rebased on master. I'll merge this when CI is green.
@koukou
closed this
in
9ffb9cdJul 5, 2019
@shiro615
shiro615
deleted the

release-replace-c-glib-after-running-autogen

branch
July 6, 2019 01:37
wesm pushed a commit
that referenced
this pull request
Jul 13, 2019
@shiro615@wesm
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/auto…
297c953
…gen.sh in dev/release/02-source.sh
c_glib/ source archive is generated by `make dist` because includes configure script.
The current `dev/release/02-source.sh` build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run `make dist`. But it is slow.
So this PR run only `c_glib/autogen.sh` and then replace c_glib/.
Author: Yosuke Shiro <yosuke.shiro615@gmail.com>
Author: Sutou Kouhei <kou@clear-code.com>
Closes#4749 from shiro615/release-replace-c-glib-after-running-autogen and squashes the following commits:
9a69f8e <Yosuke Shiro> Remove an unnecessary environment variable
3a2550f <Yosuke Shiro> Remove omit from 02-source-test.rb
501a2dd <Yosuke Shiro> Remove autom4te.cache after running autogen.sh
46a4f89 <Sutou Kouhei> Use docker-compose
e357a88 <Yosuke Shiro> Exclude c_glib/autom4te.cache/* from RAT check
70cb4a7 <Yosuke Shiro> Remove an unnecessary diff
aa78680 <Yosuke Shiro> Enable test test_glib_configure on Travis CI
e04276e <Yosuke Shiro> Remove libraries for C++ build
56098ae <Yosuke Shiro> Replace c_glib/ by c_glib/ after running autogen.sh
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@shiro615@codecov-io@wesm@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh - #4749
Closed
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Closed
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh#4749
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Conversation
@shiro615
@shiro615shiro615
commented
Jun 29, 2019

Copy link


Copy Markdown

Contributor
c_glib/ source archive is generated by make dist because includes configure script.

The current dev/release/02-source.sh build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run make dist. But it is slow.

So this PR run only c_glib/autogen.sh and then replace c_glib/.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threaddev/release/source/Dockerfile
Outdated

@shiro615shiro615Jun 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the libraries for building Arrow C++, because just runs c_glib/autogen.sh.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threadci/travis_release_test.sh
Outdated

@shiro615shiro615Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the test for GLib configure.

But if you don't want to enable this option, I will remove this.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this change?
@shiro615shiro615Jul 4, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...sorry. I've removed this change.
@codecov-io
codecov-io
commented
Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4749 into master will decrease coverage by 0.54%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4749 +/- ##
==========================================
- Coverage 86.44% 85.89% -0.55% 
==========================================
Files 992 881 -111 Lines 138020 115177 -22843 Branches 1418 1418 ==========================================
- Hits 119311 98936 -20375 + Misses 18347 15879 -2468 
Partials 362 362
Impacted FilesCoverage Δ
cpp/src/arrow/array/builder_union.cc0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.h0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.cc0% <0%> (-92.9%)⬇️
cpp/src/arrow/adapters/orc/adapter_util.cc15.74% <0%> (-64.97%)⬇️
cpp/src/arrow/array/builder_union.h0% <0%> (-61.91%)⬇️
cpp/src/arrow/util/cpu-info.h0% <0%> (-50%)⬇️
cpp/src/arrow/csv/options.h66.66% <0%> (-33.34%)⬇️
cpp/src/arrow/extension_type.cc66.66% <0%> (-26.67%)⬇️
cpp/src/parquet/column_scanner.cc55% <0%> (-25%)⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c52.79% <0%> (-20.82%)⬇️
... and 179 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 4d25902...447f83e. Read the comment docs.
@shiro615shiro615
changed the title
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shWIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@shiro615shiro615
changed the title
WIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@wesm
wesm
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
Seems like a nice improvement. Will let @kou review
@kou
kou
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
I'll take a look this after 0.14.0 RC0. Please wait a while.
kou
kou
requested changes
Jul 3, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my comments?

I've added a commit to use docker-compose.
Comment threaddev/release/rat_exclude_files.txt
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove them after we run autogen.sh instead of adding them to archive?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to remove them after running autogen.sh.
Comment threadci/travis_release_test.sh
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@kou
kouforce-pushed
the
release-replace-c-glib-after-running-autogen
branch
from
216fcda to
9a69f8eCompareJuly 5, 2019 00:17
kou
kou
approved these changes
Jul 5, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I've rebased on master. I'll merge this when CI is green.
@koukou
closed this
in
9ffb9cdJul 5, 2019
@shiro615
shiro615
deleted the

release-replace-c-glib-after-running-autogen

branch
July 6, 2019 01:37
wesm pushed a commit
that referenced
this pull request
Jul 13, 2019
@shiro615@wesm
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/auto…
297c953
…gen.sh in dev/release/02-source.sh
c_glib/ source archive is generated by `make dist` because includes configure script.
The current `dev/release/02-source.sh` build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run `make dist`. But it is slow.
So this PR run only `c_glib/autogen.sh` and then replace c_glib/.
Author: Yosuke Shiro <yosuke.shiro615@gmail.com>
Author: Sutou Kouhei <kou@clear-code.com>
Closes#4749 from shiro615/release-replace-c-glib-after-running-autogen and squashes the following commits:
9a69f8e <Yosuke Shiro> Remove an unnecessary environment variable
3a2550f <Yosuke Shiro> Remove omit from 02-source-test.rb
501a2dd <Yosuke Shiro> Remove autom4te.cache after running autogen.sh
46a4f89 <Sutou Kouhei> Use docker-compose
e357a88 <Yosuke Shiro> Exclude c_glib/autom4te.cache/* from RAT check
70cb4a7 <Yosuke Shiro> Remove an unnecessary diff
aa78680 <Yosuke Shiro> Enable test test_glib_configure on Travis CI
e04276e <Yosuke Shiro> Remove libraries for C++ build
56098ae <Yosuke Shiro> Replace c_glib/ by c_glib/ after running autogen.sh
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@shiro615@codecov-io@wesm@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh - #4749
Closed
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Closed
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.sh#4749
shiro615 wants to merge 9 commits into
apache:masterfrom 
shiro615:release-replace-c-glib-after-running-autogen
Conversation
@shiro615
@shiro615shiro615
commented
Jun 29, 2019

Copy link


Copy Markdown

Contributor
c_glib/ source archive is generated by make dist because includes configure script.

The current dev/release/02-source.sh build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run make dist. But it is slow.

So this PR run only c_glib/autogen.sh and then replace c_glib/.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threaddev/release/source/Dockerfile
Outdated

@shiro615shiro615Jun 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the libraries for building Arrow C++, because just runs c_glib/autogen.sh.
shiro615
shiro615
commented
Jun 29, 2019
View reviewed changes
Comment threadci/travis_release_test.sh
Outdated

@shiro615shiro615Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the test for GLib configure.

But if you don't want to enable this option, I will remove this.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it.
@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this change?
@shiro615shiro615Jul 4, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...sorry. I've removed this change.
@codecov-io
codecov-io
commented
Jun 29, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4749 into master will decrease coverage by 0.54%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4749 +/- ##
==========================================
- Coverage 86.44% 85.89% -0.55% 
==========================================
Files 992 881 -111 Lines 138020 115177 -22843 Branches 1418 1418 ==========================================
- Hits 119311 98936 -20375 + Misses 18347 15879 -2468 
Partials 362 362
Impacted FilesCoverage Δ
cpp/src/arrow/array/builder_union.cc0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.h0% <0%> (-100%)⬇️
cpp/src/arrow/csv/reader.cc0% <0%> (-92.9%)⬇️
cpp/src/arrow/adapters/orc/adapter_util.cc15.74% <0%> (-64.97%)⬇️
cpp/src/arrow/array/builder_union.h0% <0%> (-61.91%)⬇️
cpp/src/arrow/util/cpu-info.h0% <0%> (-50%)⬇️
cpp/src/arrow/csv/options.h66.66% <0%> (-33.34%)⬇️
cpp/src/arrow/extension_type.cc66.66% <0%> (-26.67%)⬇️
cpp/src/parquet/column_scanner.cc55% <0%> (-25%)⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c52.79% <0%> (-20.82%)⬇️
... and 179 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 4d25902...447f83e. Read the comment docs.
@shiro615shiro615
changed the title
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shWIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@shiro615shiro615
changed the title
WIP ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/autogen.sh in dev/release/02-source.shJun 29, 2019
@wesm
wesm
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
Seems like a nice improvement. Will let @kou review
@kou
kou
commented
Jul 3, 2019

Copy link


Copy Markdown

Member
I'll take a look this after 0.14.0 RC0. Please wait a while.
kou
kou
requested changes
Jul 3, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my comments?

I've added a commit to use docker-compose.
Comment threaddev/release/rat_exclude_files.txt
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove them after we run autogen.sh instead of adding them to archive?
@shiro615shiro615Jul 3, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to remove them after running autogen.sh.
Comment threadci/travis_release_test.sh
Outdated

@koukouJul 3, 2019

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just increase just 1min. We can always run this test now.

Could you remove omit from 02-source-test.rb.?
@kou
kouforce-pushed
the
release-replace-c-glib-after-running-autogen
branch
from
216fcda to
9a69f8eCompareJuly 5, 2019 00:17
kou
kou
approved these changes
Jul 5, 2019
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I've rebased on master. I'll merge this when CI is green.
@koukou
closed this
in
9ffb9cdJul 5, 2019
@shiro615
shiro615
deleted the

release-replace-c-glib-after-running-autogen

branch
July 6, 2019 01:37
wesm pushed a commit
that referenced
this pull request
Jul 13, 2019
@shiro615@wesm
ARROW-5784: [Release][GLib] Replace c_glib/ after running c_glib/auto…
297c953
…gen.sh in dev/release/02-source.sh
c_glib/ source archive is generated by `make dist` because includes configure script.
The current `dev/release/02-source.sh` build Arrow C++ and Arrow GLib to include the artifacts of GTK-Doc and then run `make dist`. But it is slow.
So this PR run only `c_glib/autogen.sh` and then replace c_glib/.
Author: Yosuke Shiro <yosuke.shiro615@gmail.com>
Author: Sutou Kouhei <kou@clear-code.com>
Closes#4749 from shiro615/release-replace-c-glib-after-running-autogen and squashes the following commits:
9a69f8e <Yosuke Shiro> Remove an unnecessary environment variable
3a2550f <Yosuke Shiro> Remove omit from 02-source-test.rb
501a2dd <Yosuke Shiro> Remove autom4te.cache after running autogen.sh
46a4f89 <Sutou Kouhei> Use docker-compose
e357a88 <Yosuke Shiro> Exclude c_glib/autom4te.cache/* from RAT check
70cb4a7 <Yosuke Shiro> Remove an unnecessary diff
aa78680 <Yosuke Shiro> Enable test test_glib_configure on Travis CI
e04276e <Yosuke Shiro> Remove libraries for C++ build
56098ae <Yosuke Shiro> Replace c_glib/ by c_glib/ after running autogen.sh
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@shiro615@codecov-io@wesm@kou