GH-47614: [CI] Upgrade vcpkg on our CI - #47627

Merged
raulcd merged 20 commits into
apache:mainfrom
raulcd:GH-43416-4
Oct 3, 2025
Merged

GH-47614: [CI] Upgrade vcpkg on our CI#47627
raulcd merged 20 commits into
apache:mainfrom
raulcd:GH-43416-4

Conversation

@raulcd

@raulcdraulcd commented Sep 23, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Rationale for this change

Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.

What changes are included in this PR?

  • Update the vcpkg version to the latest released
  • Update minio version to solve failure due to newer aws-sdk
  • Remove unnecessary vcpkg patches
  • Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
  • Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.

Are these changes tested?

Yes, via archery on CI.

Are there any user-facing changes?

No

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Sep 23, 2025
@raulcd

This comment was marked as outdated.

Sign in to view
@raulcd

raulcd commented Sep 23, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64

@github-actions

github-actionsBot commented Sep 23, 2025

Copy link
Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4

Submitted crossbow builds: ursacomputing/crossbow @ actions-60c2e12547

TaskStatus
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions

@raulcd

raulcd commented Sep 23, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp312-cp312-arm64 wheel-macos-monterey-cp312-cp312-amd64

@github-actions

github-actionsBot commented Sep 23, 2025

Copy link
Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4

Submitted crossbow builds: ursacomputing/crossbow @ actions-63c80eedf6

TaskStatus
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions

@raulcd

This comment was marked as outdated.

Sign in to view
1 similar comment
@raulcd

raulcd commented Sep 23, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-musllinux-1-2-cp312-cp312-arm64

@github-actions

github-actionsBot commented Sep 23, 2025

Copy link
Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72

Submitted crossbow builds: ursacomputing/crossbow @ actions-75b62cd59e

TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions

@github-actions

github-actionsBot commented Sep 23, 2025

Copy link
Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72

Submitted crossbow builds: ursacomputing/crossbow @ actions-557ed877e6

TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions

@raulcd

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd

raulcd commented Sep 23, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-*

@github-actions

github-actionsBot commented Sep 23, 2025

Copy link
Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72

Submitted crossbow builds: ursacomputing/crossbow @ actions-ad950fd0f7

TaskStatus
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@raulcdraulcd mentioned this pull request Sep 23, 2025
Closed
@raulcd

raulcd commented Sep 23, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

There are two Python test failures on the musllinux wheel related to ORC timezone but there's no tzdata-legacy for alpine, I tried upgrading to alpine 3.22 instead of 3.21 but this did not solve the issue so I am unsure why those tests would fail now, the only change is the vcpkg upgrade which uses a newer ORC version but not on the underlying testing image:

 E subprocess.CalledProcessError: Command '['/usr/local/bin/python', '-c', 'if 1:\n import os\n os.environ[\'TZDIR\'] = \'/tmp/non_existent\'\n\n from pyarrow import orc\n try:\n orc_file = orc.ORCFile(\'/usr/local/lib/python3.12/site-packages/pyarrow/tests/data/orc/TestOrcFile.testDate1900.orc\')\n orc_file.read()\n except Exception as e:\n assert "time zone database" in str(e).lower(), e\n else:\n assert False, "Should have raised exception"\n ']' died with <Signals.SIGABRT: 6>.
usr/local/lib/python3.12/subprocess.py:571: CalledProcessError
----------------------------- Captured stderr call -----------------------------
terminate called after throwing an instance of 'orc::TimezoneError'
what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.

@wgtmac@kou any idea?
failure here:
https://github.com/ursacomputing/crossbow/actions/runs/17951257777/job/51050872037

@wgtmac

wgtmac commented Sep 24, 2025

Copy link
Copy Markdown
Member

I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427

@raulcd

raulcd commented Sep 25, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd

raulcd commented Sep 25, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

@github-actions

github-actionsBot commented Sep 25, 2025

Copy link
Copy Markdown

Revision: c7fa2b963b212ac99c4661a741903ebd9480b4ce

Submitted crossbow builds: ursacomputing/crossbow @ actions-67f7bf6a17

TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions

@raulcd

raulcd commented Sep 25, 2025

Copy link
Copy Markdown
MemberAuthor

I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427

@wgtmac I've been investigating a little further the issue is with a couple tests that are "intentionally" removing the timezone and expecting ORC to raise an exception and Arrow to catch it but not to crash, the problem (on this specific case) is with ORC 2.1.0 which is the one on vcpkg and musllinux. See the backtrace:

terminate called after throwing an instance of 'orc::TimezoneError'what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.
Thread 1 "python" received signal SIGABRT, Aborted.
__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
warning: 40	./arch/x86_64/syscall_arch.h: No such file or directory
(gdb) backtrace
#0__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
#10x000076f54c58fe1b in raise (sig=sig@entry=6) at src/signal/raise.c:11
#20x000076f54c5739ad in abort () at src/exit/abort.c:11
#30x000076f5484f2a4a in ?? () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#40x000076f548504ef8 in __cxxabiv1::__terminate(void (*)()) () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#50x000076f548504f65 in std::terminate() () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#60x000076f5485051b8 in __cxa_throw () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#70x000076f54a04b1ee in orc::loadTZDB(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#80x000076f54a04b9f3 in std::once_flag::_Prepare_execution::_Prepare_execution<std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#1}>(orc::LazyTimezone::getImpl() const::{lambda()#1}&)::{lambda()#1}::_FUN() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#90x000076f54c599656 in __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:22
#10__pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:11
#110x000076f54c5996f3 in __pthread_once (control=<optimized out>, init=<optimized out>) at src/thread/pthread_once.c:47
#120x000076f54a049659 in orc::LazyTimezone::getEpoch() const () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#130x000076f54a0804cf in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#140x000076f54a08155d in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#150x000076f54a081c36 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#160x000076f54a0815e3 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#170x000076f54a02f60d in orc::RowReaderImpl::startNextStripe() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#180x000076f54a030005 in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#190x000076f5495206a5 in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#200x000076f549520d6a in arrow::adapters::orc::ORCFileReader::Impl::ReadTable(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#210x000076f54951a3d7 in arrow::adapters::orc::ORCFileReader::Read() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#220x000076f525a6c55c in __pyx_pw_7pyarrow_4_orc_9ORCReader_43read(_object*, _object* const*, long, _object*) ()

@pitrou based on the stacktrace and the report this seems to be the exact same issue fixed that introduced the failing tests, any idea?

@raulcd

raulcd commented Sep 25, 2025

Copy link
Copy Markdown
MemberAuthor

The Windows failures are completely different and are due to a flight compilation error, I am trying to understand what is the problem too:

2025-09-25T12:18:12.0217461Z "C:\arrow-build\install.vcxproj" (default target) (1) ->
2025-09-25T12:18:12.0217793Z "C:\arrow-build\ALL_BUILD.vcxproj" (default target) (3) ->
2025-09-25T12:18:12.0218183Z "C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj" (default target) (25) ->
2025-09-25T12:18:12.0218544Z (ClCompile target) -> 2025-09-25T12:18:12.0219110Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0220135Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,8): error C2146: syntax error: missing ')' before identifier 'LPWSABUF' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0221162Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0222161Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,8): error C2146: syntax error: missing ')' before identifier 'DWORD' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0223529Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1109,48): error C3646: 'lpfnCompletionProc': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0224620Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(2721,14): error C2061: syntax error: identifier 'LPCONDITIONPROC' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0225621Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0226632Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0227643Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0229336Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0230498Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3098,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0231788Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3202,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0232967Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3259,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0234136Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3307,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0235777Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3336,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0236955Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3380,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0238561Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(4119,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0240758Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(764,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0243403Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(805,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0245552Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(862,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0246917Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(905,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0247998Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(939,12): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0249132Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(949,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0250761Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(956,35): error C2065: 'lpCompletionRoutine': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0251901Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(430,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0253045Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(492,40): error C3646: 'lpCompletionRoutine': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254185Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(516,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254821Z 2025-09-25T12:18:12.0254890Z 13 Warning(s)
2025-09-25T12:18:12.0255116Z 27 Error(s)

We should try to push the vcpkg version update because we have been using a really old one and updating it fixes the macOS wheels.

@raulcd

raulcd commented Sep 25, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

@github-actions

github-actionsBot commented Sep 25, 2025

Copy link
Copy Markdown

Revision: b73a6f75ac91e3ef3475c274855cf69a1a57df57

Submitted crossbow builds: ursacomputing/crossbow @ actions-01928a4f01

TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions

@pitrou

pitrou commented Sep 25, 2025

Copy link
Copy Markdown
Member

@raulcd Did you check that arrow::adapters::orc::ORCFileReader::Impl::ReadBatch catches exceptions appropriately?

@raulcd

raulcd commented Sep 25, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

@github-actions

github-actionsBot commented Sep 25, 2025

Copy link
Copy Markdown

Revision: 51110d116e4fc4cb0d962e8f012e3177748e828e

Submitted crossbow builds: ursacomputing/crossbow @ actions-f5546167b3

TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions

@raulcd

raulcd commented Sep 25, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

@raulcd

raulcd commented Oct 1, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-macos-monterey-cp313-*-amd64

@github-actions

github-actionsBot commented Oct 1, 2025

Copy link
Copy Markdown

Revision: b02bc4f

Submitted crossbow builds: ursacomputing/crossbow @ actions-b64128ce9f

TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions

@raulcd

raulcd commented Oct 1, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

@github-actions

github-actionsBot commented Oct 1, 2025

Copy link
Copy Markdown

Revision: 09c6acd

Submitted crossbow builds: ursacomputing/crossbow @ actions-1b5b55ee21

TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions

@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Oct 2, 2025
@raulcd

raulcd commented Oct 2, 2025

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit -g wheel

@raulcd
raulcd marked this pull request as ready for review October 2, 2025 06:55
@github-actions

github-actionsBot commented Oct 2, 2025

Copy link
Copy Markdown

Revision: 09c6acd

Submitted crossbow builds: ursacomputing/crossbow @ actions-896442bc8b

TaskStatus
python-sdistGitHub Actions
wheel-macos-monterey-cp310-cp310-amd64GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-amd64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-arm64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions

@raulcd
raulcd requested review from kou and pitrouOctober 2, 2025 11:26
kou
kou approved these changes Oct 2, 2025
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Oct 2, 2025
@pitrou

pitrou commented Oct 2, 2025 via email

Copy link
Copy Markdown
Member

@raulcd
raulcd merged commit cde3f6a into apache:mainOct 3, 2025
44 checks passed
@raulcdraulcd removed the awaiting merge Awaiting merge label Oct 3, 2025
@raulcdraulcd mentioned this pull request Oct 3, 2025
Closed
@raulcd
raulcd deleted the GH-43416-4 branch October 3, 2025 07:45
@lidavidmlidavidm mentioned this pull request Oct 3, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Oct 3, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cde3f6a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.

@koukou mentioned this pull request Oct 8, 2025
Merged
@raulcdraulcd mentioned this pull request Oct 10, 2025
Closed
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Oct 15, 2025
@raulcd@zanmato1984
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
cf9d9bc
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@bveeramanibveeramani mentioned this pull request Nov 17, 2025
Closed
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@raulcd@Mottl
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
f002634
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@lidavidmlidavidmAwaiting requested review from lidavidmlidavidm is a code owner
@pitroupitrouAwaiting requested review from pitrou

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd@wgtmac@pitrou@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
GH-47614: [CI] Upgrade vcpkg on our CI - #47627
Merged
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Oct 3, 2025
Merged
GH-47614: [CI] Upgrade vcpkg on our CI#47627
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Conversation
@raulcd
@raulcdraulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
What changes are included in this PR?
  • Update the vcpkg version to the latest released
  • Update minio version to solve failure due to newer aws-sdk
  • Remove unnecessary vcpkg patches
  • Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
  • Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
Are these changes tested?
Yes, via archery on CI.
Are there any user-facing changes?
No
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Sep 23, 2025
@raulcd

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-60c2e12547
TaskStatus
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp312-cp312-arm64 wheel-macos-monterey-cp312-cp312-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-63c80eedf6
TaskStatus
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view

1 similar comment

@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-musllinux-1-2-cp312-cp312-arm64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-75b62cd59e
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-557ed877e6
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-*
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ad950fd0f7
TaskStatus
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcdraulcd
mentioned this pull request
Sep 23, 2025
 Closed

@raulcd
raulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
There are two Python test failures on the musllinux wheel related to ORC timezone but there's no tzdata-legacy for alpine, I tried upgrading to alpine 3.22 instead of 3.21 but this did not solve the issue so I am unsure why those tests would fail now, the only change is the vcpkg upgrade which uses a newer ORC version but not on the underlying testing image:
 E subprocess.CalledProcessError: Command '['/usr/local/bin/python', '-c', 'if 1:\n import os\n os.environ[\'TZDIR\'] = \'/tmp/non_existent\'\n\n from pyarrow import orc\n try:\n orc_file = orc.ORCFile(\'/usr/local/lib/python3.12/site-packages/pyarrow/tests/data/orc/TestOrcFile.testDate1900.orc\')\n orc_file.read()\n except Exception as e:\n assert "time zone database" in str(e).lower(), e\n else:\n assert False, "Should have raised exception"\n ']' died with <Signals.SIGABRT: 6>.
usr/local/lib/python3.12/subprocess.py:571: CalledProcessError
----------------------------- Captured stderr call -----------------------------
terminate called after throwing an instance of 'orc::TimezoneError'
what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.

@wgtmac@kou any idea?

failure here:
https://github.com/ursacomputing/crossbow/actions/runs/17951257777/job/51050872037
@wgtmac
wgtmac
commented
Sep 24, 2025

Copy link


Copy Markdown

Member
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: c7fa2b963b212ac99c4661a741903ebd9480b4ce
Submitted crossbow builds: ursacomputing/crossbow @ actions-67f7bf6a17
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@wgtmac I've been investigating a little further the issue is with a couple tests that are "intentionally" removing the timezone and expecting ORC to raise an exception and Arrow to catch it but not to crash, the problem (on this specific case) is with ORC 2.1.0 which is the one on vcpkg and musllinux. See the backtrace:
terminate called after throwing an instance of 'orc::TimezoneError'what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.
Thread 1 "python" received signal SIGABRT, Aborted.
__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
warning: 40	./arch/x86_64/syscall_arch.h: No such file or directory
(gdb) backtrace
#0__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
#10x000076f54c58fe1b in raise (sig=sig@entry=6) at src/signal/raise.c:11
#20x000076f54c5739ad in abort () at src/exit/abort.c:11
#30x000076f5484f2a4a in ?? () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#40x000076f548504ef8 in __cxxabiv1::__terminate(void (*)()) () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#50x000076f548504f65 in std::terminate() () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#60x000076f5485051b8 in __cxa_throw () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#70x000076f54a04b1ee in orc::loadTZDB(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#80x000076f54a04b9f3 in std::once_flag::_Prepare_execution::_Prepare_execution<std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#1}>(orc::LazyTimezone::getImpl() const::{lambda()#1}&)::{lambda()#1}::_FUN() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#90x000076f54c599656 in __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:22
#10__pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:11
#110x000076f54c5996f3 in __pthread_once (control=<optimized out>, init=<optimized out>) at src/thread/pthread_once.c:47
#120x000076f54a049659 in orc::LazyTimezone::getEpoch() const () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#130x000076f54a0804cf in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#140x000076f54a08155d in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#150x000076f54a081c36 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#160x000076f54a0815e3 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#170x000076f54a02f60d in orc::RowReaderImpl::startNextStripe() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#180x000076f54a030005 in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#190x000076f5495206a5 in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#200x000076f549520d6a in arrow::adapters::orc::ORCFileReader::Impl::ReadTable(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#210x000076f54951a3d7 in arrow::adapters::orc::ORCFileReader::Read() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#220x000076f525a6c55c in __pyx_pw_7pyarrow_4_orc_9ORCReader_43read(_object*, _object* const*, long, _object*) ()
@pitrou based on the stacktrace and the report this seems to be the exact same issue fixed that introduced the failing tests, any idea?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
The Windows failures are completely different and are due to a flight compilation error, I am trying to understand what is the problem too:
2025-09-25T12:18:12.0217461Z "C:\arrow-build\install.vcxproj" (default target) (1) ->
2025-09-25T12:18:12.0217793Z "C:\arrow-build\ALL_BUILD.vcxproj" (default target) (3) ->
2025-09-25T12:18:12.0218183Z "C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj" (default target) (25) ->
2025-09-25T12:18:12.0218544Z (ClCompile target) -> 2025-09-25T12:18:12.0219110Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0220135Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,8): error C2146: syntax error: missing ')' before identifier 'LPWSABUF' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0221162Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0222161Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,8): error C2146: syntax error: missing ')' before identifier 'DWORD' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0223529Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1109,48): error C3646: 'lpfnCompletionProc': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0224620Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(2721,14): error C2061: syntax error: identifier 'LPCONDITIONPROC' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0225621Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0226632Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0227643Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0229336Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0230498Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3098,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0231788Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3202,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0232967Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3259,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0234136Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3307,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0235777Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3336,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0236955Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3380,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0238561Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(4119,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0240758Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(764,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0243403Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(805,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0245552Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(862,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0246917Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(905,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0247998Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(939,12): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0249132Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(949,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0250761Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(956,35): error C2065: 'lpCompletionRoutine': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0251901Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(430,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0253045Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(492,40): error C3646: 'lpCompletionRoutine': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254185Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(516,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254821Z 2025-09-25T12:18:12.0254890Z 13 Warning(s)
2025-09-25T12:18:12.0255116Z 27 Error(s)

We should try to push the vcpkg version update because we have been using a really old one and updating it fixes the macOS wheels.
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: b73a6f75ac91e3ef3475c274855cf69a1a57df57
Submitted crossbow builds: ursacomputing/crossbow @ actions-01928a4f01
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@pitrou
pitrou
commented
Sep 25, 2025

Copy link


Copy Markdown

Member
@raulcd Did you check that arrow::adapters::orc::ORCFileReader::Impl::ReadBatch catches exceptions appropriately?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: 51110d116e4fc4cb0d962e8f012e3177748e828e
Submitted crossbow builds: ursacomputing/crossbow @ actions-f5546167b3
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-macos-monterey-cp313-*-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: b02bc4f
Submitted crossbow builds: ursacomputing/crossbow @ actions-b64128ce9f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-1b5b55ee21
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Oct 2, 2025
@raulcd
raulcd
commented
Oct 2, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g wheel
@raulcd
raulcd
marked this pull request as ready for review
October 2, 2025 06:55
@github-actions
github-actionsBot
commented
Oct 2, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-896442bc8b
TaskStatus
python-sdistGitHub Actions
wheel-macos-monterey-cp310-cp310-amd64GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-amd64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-arm64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
requested review from
kou and pitrouOctober 2, 2025 11:26
kou
kou
approved these changes
Oct 2, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Oct 2, 2025
@pitrou
pitrou
commented
Oct 2, 2025
via email 

Copy link


Copy Markdown

Member
@raulcd
raulcd
merged commit cde3f6a
into
apache:mainOct 3, 2025

44 checks passed

@raulcdraulcd
removed
the 
awaiting merge
Awaiting merge
label
Oct 3, 2025
@raulcdraulcd
mentioned this pull request
Oct 3, 2025

Closed

@raulcd
raulcd
deleted the

GH-43416-4

branch
October 3, 2025 07:45
@lidavidmlidavidm
mentioned this pull request
Oct 3, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Oct 3, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cde3f6a.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
@koukou
mentioned this pull request
Oct 8, 2025
 Merged

@raulcdraulcd
mentioned this pull request
Oct 10, 2025
 Closed

zanmato1984 pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
@raulcd@zanmato1984
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
cf9d9bc
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@bveeramanibveeramani
mentioned this pull request
Nov 17, 2025

Closed

Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
@raulcd@Mottl
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
f002634
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@lidavidmlidavidmAwaiting requested review from lidavidmlidavidm is a code owner
@pitroupitrouAwaiting requested review from pitrou

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd@wgtmac@pitrou@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-47614: [CI] Upgrade vcpkg on our CI - #47627
Merged
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Oct 3, 2025
Merged
GH-47614: [CI] Upgrade vcpkg on our CI#47627
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Conversation
@raulcd
@raulcdraulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
What changes are included in this PR?
  • Update the vcpkg version to the latest released
  • Update minio version to solve failure due to newer aws-sdk
  • Remove unnecessary vcpkg patches
  • Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
  • Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
Are these changes tested?
Yes, via archery on CI.
Are there any user-facing changes?
No
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Sep 23, 2025
@raulcd

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-60c2e12547
TaskStatus
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp312-cp312-arm64 wheel-macos-monterey-cp312-cp312-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-63c80eedf6
TaskStatus
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view

1 similar comment

@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-musllinux-1-2-cp312-cp312-arm64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-75b62cd59e
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-557ed877e6
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-*
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ad950fd0f7
TaskStatus
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcdraulcd
mentioned this pull request
Sep 23, 2025
 Closed

@raulcd
raulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
There are two Python test failures on the musllinux wheel related to ORC timezone but there's no tzdata-legacy for alpine, I tried upgrading to alpine 3.22 instead of 3.21 but this did not solve the issue so I am unsure why those tests would fail now, the only change is the vcpkg upgrade which uses a newer ORC version but not on the underlying testing image:
 E subprocess.CalledProcessError: Command '['/usr/local/bin/python', '-c', 'if 1:\n import os\n os.environ[\'TZDIR\'] = \'/tmp/non_existent\'\n\n from pyarrow import orc\n try:\n orc_file = orc.ORCFile(\'/usr/local/lib/python3.12/site-packages/pyarrow/tests/data/orc/TestOrcFile.testDate1900.orc\')\n orc_file.read()\n except Exception as e:\n assert "time zone database" in str(e).lower(), e\n else:\n assert False, "Should have raised exception"\n ']' died with <Signals.SIGABRT: 6>.
usr/local/lib/python3.12/subprocess.py:571: CalledProcessError
----------------------------- Captured stderr call -----------------------------
terminate called after throwing an instance of 'orc::TimezoneError'
what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.

@wgtmac@kou any idea?

failure here:
https://github.com/ursacomputing/crossbow/actions/runs/17951257777/job/51050872037
@wgtmac
wgtmac
commented
Sep 24, 2025

Copy link


Copy Markdown

Member
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: c7fa2b963b212ac99c4661a741903ebd9480b4ce
Submitted crossbow builds: ursacomputing/crossbow @ actions-67f7bf6a17
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@wgtmac I've been investigating a little further the issue is with a couple tests that are "intentionally" removing the timezone and expecting ORC to raise an exception and Arrow to catch it but not to crash, the problem (on this specific case) is with ORC 2.1.0 which is the one on vcpkg and musllinux. See the backtrace:
terminate called after throwing an instance of 'orc::TimezoneError'what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.
Thread 1 "python" received signal SIGABRT, Aborted.
__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
warning: 40	./arch/x86_64/syscall_arch.h: No such file or directory
(gdb) backtrace
#0__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
#10x000076f54c58fe1b in raise (sig=sig@entry=6) at src/signal/raise.c:11
#20x000076f54c5739ad in abort () at src/exit/abort.c:11
#30x000076f5484f2a4a in ?? () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#40x000076f548504ef8 in __cxxabiv1::__terminate(void (*)()) () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#50x000076f548504f65 in std::terminate() () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#60x000076f5485051b8 in __cxa_throw () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#70x000076f54a04b1ee in orc::loadTZDB(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#80x000076f54a04b9f3 in std::once_flag::_Prepare_execution::_Prepare_execution<std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#1}>(orc::LazyTimezone::getImpl() const::{lambda()#1}&)::{lambda()#1}::_FUN() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#90x000076f54c599656 in __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:22
#10__pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:11
#110x000076f54c5996f3 in __pthread_once (control=<optimized out>, init=<optimized out>) at src/thread/pthread_once.c:47
#120x000076f54a049659 in orc::LazyTimezone::getEpoch() const () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#130x000076f54a0804cf in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#140x000076f54a08155d in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#150x000076f54a081c36 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#160x000076f54a0815e3 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#170x000076f54a02f60d in orc::RowReaderImpl::startNextStripe() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#180x000076f54a030005 in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#190x000076f5495206a5 in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#200x000076f549520d6a in arrow::adapters::orc::ORCFileReader::Impl::ReadTable(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#210x000076f54951a3d7 in arrow::adapters::orc::ORCFileReader::Read() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#220x000076f525a6c55c in __pyx_pw_7pyarrow_4_orc_9ORCReader_43read(_object*, _object* const*, long, _object*) ()
@pitrou based on the stacktrace and the report this seems to be the exact same issue fixed that introduced the failing tests, any idea?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
The Windows failures are completely different and are due to a flight compilation error, I am trying to understand what is the problem too:
2025-09-25T12:18:12.0217461Z "C:\arrow-build\install.vcxproj" (default target) (1) ->
2025-09-25T12:18:12.0217793Z "C:\arrow-build\ALL_BUILD.vcxproj" (default target) (3) ->
2025-09-25T12:18:12.0218183Z "C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj" (default target) (25) ->
2025-09-25T12:18:12.0218544Z (ClCompile target) -> 2025-09-25T12:18:12.0219110Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0220135Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,8): error C2146: syntax error: missing ')' before identifier 'LPWSABUF' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0221162Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0222161Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,8): error C2146: syntax error: missing ')' before identifier 'DWORD' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0223529Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1109,48): error C3646: 'lpfnCompletionProc': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0224620Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(2721,14): error C2061: syntax error: identifier 'LPCONDITIONPROC' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0225621Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0226632Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0227643Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0229336Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0230498Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3098,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0231788Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3202,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0232967Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3259,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0234136Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3307,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0235777Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3336,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0236955Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3380,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0238561Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(4119,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0240758Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(764,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0243403Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(805,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0245552Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(862,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0246917Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(905,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0247998Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(939,12): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0249132Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(949,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0250761Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(956,35): error C2065: 'lpCompletionRoutine': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0251901Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(430,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0253045Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(492,40): error C3646: 'lpCompletionRoutine': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254185Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(516,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254821Z 2025-09-25T12:18:12.0254890Z 13 Warning(s)
2025-09-25T12:18:12.0255116Z 27 Error(s)

We should try to push the vcpkg version update because we have been using a really old one and updating it fixes the macOS wheels.
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: b73a6f75ac91e3ef3475c274855cf69a1a57df57
Submitted crossbow builds: ursacomputing/crossbow @ actions-01928a4f01
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@pitrou
pitrou
commented
Sep 25, 2025

Copy link


Copy Markdown

Member
@raulcd Did you check that arrow::adapters::orc::ORCFileReader::Impl::ReadBatch catches exceptions appropriately?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: 51110d116e4fc4cb0d962e8f012e3177748e828e
Submitted crossbow builds: ursacomputing/crossbow @ actions-f5546167b3
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-macos-monterey-cp313-*-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: b02bc4f
Submitted crossbow builds: ursacomputing/crossbow @ actions-b64128ce9f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-1b5b55ee21
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Oct 2, 2025
@raulcd
raulcd
commented
Oct 2, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g wheel
@raulcd
raulcd
marked this pull request as ready for review
October 2, 2025 06:55
@github-actions
github-actionsBot
commented
Oct 2, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-896442bc8b
TaskStatus
python-sdistGitHub Actions
wheel-macos-monterey-cp310-cp310-amd64GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-amd64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-arm64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
requested review from
kou and pitrouOctober 2, 2025 11:26
kou
kou
approved these changes
Oct 2, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Oct 2, 2025
@pitrou
pitrou
commented
Oct 2, 2025
via email 

Copy link


Copy Markdown

Member
@raulcd
raulcd
merged commit cde3f6a
into
apache:mainOct 3, 2025

44 checks passed

@raulcdraulcd
removed
the 
awaiting merge
Awaiting merge
label
Oct 3, 2025
@raulcdraulcd
mentioned this pull request
Oct 3, 2025

Closed

@raulcd
raulcd
deleted the

GH-43416-4

branch
October 3, 2025 07:45
@lidavidmlidavidm
mentioned this pull request
Oct 3, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Oct 3, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cde3f6a.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
@koukou
mentioned this pull request
Oct 8, 2025
 Merged

@raulcdraulcd
mentioned this pull request
Oct 10, 2025
 Closed

zanmato1984 pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
@raulcd@zanmato1984
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
cf9d9bc
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@bveeramanibveeramani
mentioned this pull request
Nov 17, 2025

Closed

Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
@raulcd@Mottl
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
f002634
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@lidavidmlidavidmAwaiting requested review from lidavidmlidavidm is a code owner
@pitroupitrouAwaiting requested review from pitrou

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd@wgtmac@pitrou@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-47614: [CI] Upgrade vcpkg on our CI - #47627
Merged
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Oct 3, 2025
Merged
GH-47614: [CI] Upgrade vcpkg on our CI#47627
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Conversation
@raulcd
@raulcdraulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
What changes are included in this PR?
  • Update the vcpkg version to the latest released
  • Update minio version to solve failure due to newer aws-sdk
  • Remove unnecessary vcpkg patches
  • Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
  • Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
Are these changes tested?
Yes, via archery on CI.
Are there any user-facing changes?
No
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Sep 23, 2025
@raulcd

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-60c2e12547
TaskStatus
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp312-cp312-arm64 wheel-macos-monterey-cp312-cp312-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-63c80eedf6
TaskStatus
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view

1 similar comment

@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-musllinux-1-2-cp312-cp312-arm64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-75b62cd59e
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-557ed877e6
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-*
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ad950fd0f7
TaskStatus
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcdraulcd
mentioned this pull request
Sep 23, 2025
 Closed

@raulcd
raulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
There are two Python test failures on the musllinux wheel related to ORC timezone but there's no tzdata-legacy for alpine, I tried upgrading to alpine 3.22 instead of 3.21 but this did not solve the issue so I am unsure why those tests would fail now, the only change is the vcpkg upgrade which uses a newer ORC version but not on the underlying testing image:
 E subprocess.CalledProcessError: Command '['/usr/local/bin/python', '-c', 'if 1:\n import os\n os.environ[\'TZDIR\'] = \'/tmp/non_existent\'\n\n from pyarrow import orc\n try:\n orc_file = orc.ORCFile(\'/usr/local/lib/python3.12/site-packages/pyarrow/tests/data/orc/TestOrcFile.testDate1900.orc\')\n orc_file.read()\n except Exception as e:\n assert "time zone database" in str(e).lower(), e\n else:\n assert False, "Should have raised exception"\n ']' died with <Signals.SIGABRT: 6>.
usr/local/lib/python3.12/subprocess.py:571: CalledProcessError
----------------------------- Captured stderr call -----------------------------
terminate called after throwing an instance of 'orc::TimezoneError'
what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.

@wgtmac@kou any idea?

failure here:
https://github.com/ursacomputing/crossbow/actions/runs/17951257777/job/51050872037
@wgtmac
wgtmac
commented
Sep 24, 2025

Copy link


Copy Markdown

Member
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: c7fa2b963b212ac99c4661a741903ebd9480b4ce
Submitted crossbow builds: ursacomputing/crossbow @ actions-67f7bf6a17
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@wgtmac I've been investigating a little further the issue is with a couple tests that are "intentionally" removing the timezone and expecting ORC to raise an exception and Arrow to catch it but not to crash, the problem (on this specific case) is with ORC 2.1.0 which is the one on vcpkg and musllinux. See the backtrace:
terminate called after throwing an instance of 'orc::TimezoneError'what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.
Thread 1 "python" received signal SIGABRT, Aborted.
__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
warning: 40	./arch/x86_64/syscall_arch.h: No such file or directory
(gdb) backtrace
#0__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
#10x000076f54c58fe1b in raise (sig=sig@entry=6) at src/signal/raise.c:11
#20x000076f54c5739ad in abort () at src/exit/abort.c:11
#30x000076f5484f2a4a in ?? () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#40x000076f548504ef8 in __cxxabiv1::__terminate(void (*)()) () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#50x000076f548504f65 in std::terminate() () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#60x000076f5485051b8 in __cxa_throw () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#70x000076f54a04b1ee in orc::loadTZDB(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#80x000076f54a04b9f3 in std::once_flag::_Prepare_execution::_Prepare_execution<std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#1}>(orc::LazyTimezone::getImpl() const::{lambda()#1}&)::{lambda()#1}::_FUN() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#90x000076f54c599656 in __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:22
#10__pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:11
#110x000076f54c5996f3 in __pthread_once (control=<optimized out>, init=<optimized out>) at src/thread/pthread_once.c:47
#120x000076f54a049659 in orc::LazyTimezone::getEpoch() const () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#130x000076f54a0804cf in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#140x000076f54a08155d in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#150x000076f54a081c36 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#160x000076f54a0815e3 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#170x000076f54a02f60d in orc::RowReaderImpl::startNextStripe() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#180x000076f54a030005 in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#190x000076f5495206a5 in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#200x000076f549520d6a in arrow::adapters::orc::ORCFileReader::Impl::ReadTable(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#210x000076f54951a3d7 in arrow::adapters::orc::ORCFileReader::Read() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#220x000076f525a6c55c in __pyx_pw_7pyarrow_4_orc_9ORCReader_43read(_object*, _object* const*, long, _object*) ()
@pitrou based on the stacktrace and the report this seems to be the exact same issue fixed that introduced the failing tests, any idea?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
The Windows failures are completely different and are due to a flight compilation error, I am trying to understand what is the problem too:
2025-09-25T12:18:12.0217461Z "C:\arrow-build\install.vcxproj" (default target) (1) ->
2025-09-25T12:18:12.0217793Z "C:\arrow-build\ALL_BUILD.vcxproj" (default target) (3) ->
2025-09-25T12:18:12.0218183Z "C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj" (default target) (25) ->
2025-09-25T12:18:12.0218544Z (ClCompile target) -> 2025-09-25T12:18:12.0219110Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0220135Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,8): error C2146: syntax error: missing ')' before identifier 'LPWSABUF' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0221162Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0222161Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,8): error C2146: syntax error: missing ')' before identifier 'DWORD' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0223529Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1109,48): error C3646: 'lpfnCompletionProc': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0224620Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(2721,14): error C2061: syntax error: identifier 'LPCONDITIONPROC' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0225621Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0226632Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0227643Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0229336Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0230498Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3098,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0231788Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3202,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0232967Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3259,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0234136Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3307,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0235777Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3336,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0236955Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3380,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0238561Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(4119,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0240758Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(764,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0243403Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(805,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0245552Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(862,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0246917Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(905,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0247998Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(939,12): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0249132Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(949,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0250761Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(956,35): error C2065: 'lpCompletionRoutine': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0251901Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(430,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0253045Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(492,40): error C3646: 'lpCompletionRoutine': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254185Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(516,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254821Z 2025-09-25T12:18:12.0254890Z 13 Warning(s)
2025-09-25T12:18:12.0255116Z 27 Error(s)

We should try to push the vcpkg version update because we have been using a really old one and updating it fixes the macOS wheels.
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: b73a6f75ac91e3ef3475c274855cf69a1a57df57
Submitted crossbow builds: ursacomputing/crossbow @ actions-01928a4f01
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@pitrou
pitrou
commented
Sep 25, 2025

Copy link


Copy Markdown

Member
@raulcd Did you check that arrow::adapters::orc::ORCFileReader::Impl::ReadBatch catches exceptions appropriately?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: 51110d116e4fc4cb0d962e8f012e3177748e828e
Submitted crossbow builds: ursacomputing/crossbow @ actions-f5546167b3
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-macos-monterey-cp313-*-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: b02bc4f
Submitted crossbow builds: ursacomputing/crossbow @ actions-b64128ce9f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-1b5b55ee21
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Oct 2, 2025
@raulcd
raulcd
commented
Oct 2, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g wheel
@raulcd
raulcd
marked this pull request as ready for review
October 2, 2025 06:55
@github-actions
github-actionsBot
commented
Oct 2, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-896442bc8b
TaskStatus
python-sdistGitHub Actions
wheel-macos-monterey-cp310-cp310-amd64GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-amd64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-arm64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
requested review from
kou and pitrouOctober 2, 2025 11:26
kou
kou
approved these changes
Oct 2, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Oct 2, 2025
@pitrou
pitrou
commented
Oct 2, 2025
via email 

Copy link


Copy Markdown

Member
@raulcd
raulcd
merged commit cde3f6a
into
apache:mainOct 3, 2025

44 checks passed

@raulcdraulcd
removed
the 
awaiting merge
Awaiting merge
label
Oct 3, 2025
@raulcdraulcd
mentioned this pull request
Oct 3, 2025

Closed

@raulcd
raulcd
deleted the

GH-43416-4

branch
October 3, 2025 07:45
@lidavidmlidavidm
mentioned this pull request
Oct 3, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Oct 3, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cde3f6a.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
@koukou
mentioned this pull request
Oct 8, 2025
 Merged

@raulcdraulcd
mentioned this pull request
Oct 10, 2025
 Closed

zanmato1984 pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
@raulcd@zanmato1984
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
cf9d9bc
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@bveeramanibveeramani
mentioned this pull request
Nov 17, 2025

Closed

Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
@raulcd@Mottl
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
f002634
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@lidavidmlidavidmAwaiting requested review from lidavidmlidavidm is a code owner
@pitroupitrouAwaiting requested review from pitrou

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd@wgtmac@pitrou@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
GH-47614: [CI] Upgrade vcpkg on our CI - #47627
Merged
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Oct 3, 2025
Merged
GH-47614: [CI] Upgrade vcpkg on our CI#47627
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Conversation
@raulcd
@raulcdraulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
What changes are included in this PR?
  • Update the vcpkg version to the latest released
  • Update minio version to solve failure due to newer aws-sdk
  • Remove unnecessary vcpkg patches
  • Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
  • Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
Are these changes tested?
Yes, via archery on CI.
Are there any user-facing changes?
No
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Sep 23, 2025
@raulcd

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-60c2e12547
TaskStatus
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp312-cp312-arm64 wheel-macos-monterey-cp312-cp312-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-63c80eedf6
TaskStatus
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view

1 similar comment

@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-musllinux-1-2-cp312-cp312-arm64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-75b62cd59e
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-557ed877e6
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-*
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ad950fd0f7
TaskStatus
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcdraulcd
mentioned this pull request
Sep 23, 2025
 Closed

@raulcd
raulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
There are two Python test failures on the musllinux wheel related to ORC timezone but there's no tzdata-legacy for alpine, I tried upgrading to alpine 3.22 instead of 3.21 but this did not solve the issue so I am unsure why those tests would fail now, the only change is the vcpkg upgrade which uses a newer ORC version but not on the underlying testing image:
 E subprocess.CalledProcessError: Command '['/usr/local/bin/python', '-c', 'if 1:\n import os\n os.environ[\'TZDIR\'] = \'/tmp/non_existent\'\n\n from pyarrow import orc\n try:\n orc_file = orc.ORCFile(\'/usr/local/lib/python3.12/site-packages/pyarrow/tests/data/orc/TestOrcFile.testDate1900.orc\')\n orc_file.read()\n except Exception as e:\n assert "time zone database" in str(e).lower(), e\n else:\n assert False, "Should have raised exception"\n ']' died with <Signals.SIGABRT: 6>.
usr/local/lib/python3.12/subprocess.py:571: CalledProcessError
----------------------------- Captured stderr call -----------------------------
terminate called after throwing an instance of 'orc::TimezoneError'
what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.

@wgtmac@kou any idea?

failure here:
https://github.com/ursacomputing/crossbow/actions/runs/17951257777/job/51050872037
@wgtmac
wgtmac
commented
Sep 24, 2025

Copy link


Copy Markdown

Member
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: c7fa2b963b212ac99c4661a741903ebd9480b4ce
Submitted crossbow builds: ursacomputing/crossbow @ actions-67f7bf6a17
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@wgtmac I've been investigating a little further the issue is with a couple tests that are "intentionally" removing the timezone and expecting ORC to raise an exception and Arrow to catch it but not to crash, the problem (on this specific case) is with ORC 2.1.0 which is the one on vcpkg and musllinux. See the backtrace:
terminate called after throwing an instance of 'orc::TimezoneError'what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.
Thread 1 "python" received signal SIGABRT, Aborted.
__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
warning: 40	./arch/x86_64/syscall_arch.h: No such file or directory
(gdb) backtrace
#0__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
#10x000076f54c58fe1b in raise (sig=sig@entry=6) at src/signal/raise.c:11
#20x000076f54c5739ad in abort () at src/exit/abort.c:11
#30x000076f5484f2a4a in ?? () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#40x000076f548504ef8 in __cxxabiv1::__terminate(void (*)()) () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#50x000076f548504f65 in std::terminate() () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#60x000076f5485051b8 in __cxa_throw () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#70x000076f54a04b1ee in orc::loadTZDB(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#80x000076f54a04b9f3 in std::once_flag::_Prepare_execution::_Prepare_execution<std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#1}>(orc::LazyTimezone::getImpl() const::{lambda()#1}&)::{lambda()#1}::_FUN() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#90x000076f54c599656 in __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:22
#10__pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:11
#110x000076f54c5996f3 in __pthread_once (control=<optimized out>, init=<optimized out>) at src/thread/pthread_once.c:47
#120x000076f54a049659 in orc::LazyTimezone::getEpoch() const () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#130x000076f54a0804cf in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#140x000076f54a08155d in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#150x000076f54a081c36 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#160x000076f54a0815e3 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#170x000076f54a02f60d in orc::RowReaderImpl::startNextStripe() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#180x000076f54a030005 in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#190x000076f5495206a5 in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#200x000076f549520d6a in arrow::adapters::orc::ORCFileReader::Impl::ReadTable(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#210x000076f54951a3d7 in arrow::adapters::orc::ORCFileReader::Read() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#220x000076f525a6c55c in __pyx_pw_7pyarrow_4_orc_9ORCReader_43read(_object*, _object* const*, long, _object*) ()
@pitrou based on the stacktrace and the report this seems to be the exact same issue fixed that introduced the failing tests, any idea?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
The Windows failures are completely different and are due to a flight compilation error, I am trying to understand what is the problem too:
2025-09-25T12:18:12.0217461Z "C:\arrow-build\install.vcxproj" (default target) (1) ->
2025-09-25T12:18:12.0217793Z "C:\arrow-build\ALL_BUILD.vcxproj" (default target) (3) ->
2025-09-25T12:18:12.0218183Z "C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj" (default target) (25) ->
2025-09-25T12:18:12.0218544Z (ClCompile target) -> 2025-09-25T12:18:12.0219110Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0220135Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,8): error C2146: syntax error: missing ')' before identifier 'LPWSABUF' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0221162Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0222161Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,8): error C2146: syntax error: missing ')' before identifier 'DWORD' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0223529Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1109,48): error C3646: 'lpfnCompletionProc': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0224620Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(2721,14): error C2061: syntax error: identifier 'LPCONDITIONPROC' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0225621Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0226632Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0227643Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0229336Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0230498Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3098,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0231788Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3202,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0232967Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3259,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0234136Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3307,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0235777Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3336,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0236955Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3380,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0238561Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(4119,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0240758Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(764,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0243403Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(805,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0245552Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(862,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0246917Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(905,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0247998Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(939,12): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0249132Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(949,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0250761Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(956,35): error C2065: 'lpCompletionRoutine': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0251901Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(430,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0253045Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(492,40): error C3646: 'lpCompletionRoutine': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254185Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(516,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254821Z 2025-09-25T12:18:12.0254890Z 13 Warning(s)
2025-09-25T12:18:12.0255116Z 27 Error(s)

We should try to push the vcpkg version update because we have been using a really old one and updating it fixes the macOS wheels.
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: b73a6f75ac91e3ef3475c274855cf69a1a57df57
Submitted crossbow builds: ursacomputing/crossbow @ actions-01928a4f01
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@pitrou
pitrou
commented
Sep 25, 2025

Copy link


Copy Markdown

Member
@raulcd Did you check that arrow::adapters::orc::ORCFileReader::Impl::ReadBatch catches exceptions appropriately?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: 51110d116e4fc4cb0d962e8f012e3177748e828e
Submitted crossbow builds: ursacomputing/crossbow @ actions-f5546167b3
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-macos-monterey-cp313-*-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: b02bc4f
Submitted crossbow builds: ursacomputing/crossbow @ actions-b64128ce9f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-1b5b55ee21
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Oct 2, 2025
@raulcd
raulcd
commented
Oct 2, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g wheel
@raulcd
raulcd
marked this pull request as ready for review
October 2, 2025 06:55
@github-actions
github-actionsBot
commented
Oct 2, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-896442bc8b
TaskStatus
python-sdistGitHub Actions
wheel-macos-monterey-cp310-cp310-amd64GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-amd64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-arm64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
requested review from
kou and pitrouOctober 2, 2025 11:26
kou
kou
approved these changes
Oct 2, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Oct 2, 2025
@pitrou
pitrou
commented
Oct 2, 2025
via email 

Copy link


Copy Markdown

Member
@raulcd
raulcd
merged commit cde3f6a
into
apache:mainOct 3, 2025

44 checks passed

@raulcdraulcd
removed
the 
awaiting merge
Awaiting merge
label
Oct 3, 2025
@raulcdraulcd
mentioned this pull request
Oct 3, 2025

Closed

@raulcd
raulcd
deleted the

GH-43416-4

branch
October 3, 2025 07:45
@lidavidmlidavidm
mentioned this pull request
Oct 3, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Oct 3, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cde3f6a.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
@koukou
mentioned this pull request
Oct 8, 2025
 Merged

@raulcdraulcd
mentioned this pull request
Oct 10, 2025
 Closed

zanmato1984 pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
@raulcd@zanmato1984
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
cf9d9bc
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@bveeramanibveeramani
mentioned this pull request
Nov 17, 2025

Closed

Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
@raulcd@Mottl
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
f002634
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@lidavidmlidavidmAwaiting requested review from lidavidmlidavidm is a code owner
@pitroupitrouAwaiting requested review from pitrou

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd@wgtmac@pitrou@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-47614: [CI] Upgrade vcpkg on our CI - #47627
Merged
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Oct 3, 2025
Merged
GH-47614: [CI] Upgrade vcpkg on our CI#47627
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Conversation
@raulcd
@raulcdraulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
What changes are included in this PR?
  • Update the vcpkg version to the latest released
  • Update minio version to solve failure due to newer aws-sdk
  • Remove unnecessary vcpkg patches
  • Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
  • Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
Are these changes tested?
Yes, via archery on CI.
Are there any user-facing changes?
No
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Sep 23, 2025
@raulcd

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-60c2e12547
TaskStatus
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp312-cp312-arm64 wheel-macos-monterey-cp312-cp312-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-63c80eedf6
TaskStatus
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view

1 similar comment

@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-musllinux-1-2-cp312-cp312-arm64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-75b62cd59e
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-557ed877e6
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-*
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ad950fd0f7
TaskStatus
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcdraulcd
mentioned this pull request
Sep 23, 2025
 Closed

@raulcd
raulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
There are two Python test failures on the musllinux wheel related to ORC timezone but there's no tzdata-legacy for alpine, I tried upgrading to alpine 3.22 instead of 3.21 but this did not solve the issue so I am unsure why those tests would fail now, the only change is the vcpkg upgrade which uses a newer ORC version but not on the underlying testing image:
 E subprocess.CalledProcessError: Command '['/usr/local/bin/python', '-c', 'if 1:\n import os\n os.environ[\'TZDIR\'] = \'/tmp/non_existent\'\n\n from pyarrow import orc\n try:\n orc_file = orc.ORCFile(\'/usr/local/lib/python3.12/site-packages/pyarrow/tests/data/orc/TestOrcFile.testDate1900.orc\')\n orc_file.read()\n except Exception as e:\n assert "time zone database" in str(e).lower(), e\n else:\n assert False, "Should have raised exception"\n ']' died with <Signals.SIGABRT: 6>.
usr/local/lib/python3.12/subprocess.py:571: CalledProcessError
----------------------------- Captured stderr call -----------------------------
terminate called after throwing an instance of 'orc::TimezoneError'
what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.

@wgtmac@kou any idea?

failure here:
https://github.com/ursacomputing/crossbow/actions/runs/17951257777/job/51050872037
@wgtmac
wgtmac
commented
Sep 24, 2025

Copy link


Copy Markdown

Member
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: c7fa2b963b212ac99c4661a741903ebd9480b4ce
Submitted crossbow builds: ursacomputing/crossbow @ actions-67f7bf6a17
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@wgtmac I've been investigating a little further the issue is with a couple tests that are "intentionally" removing the timezone and expecting ORC to raise an exception and Arrow to catch it but not to crash, the problem (on this specific case) is with ORC 2.1.0 which is the one on vcpkg and musllinux. See the backtrace:
terminate called after throwing an instance of 'orc::TimezoneError'what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.
Thread 1 "python" received signal SIGABRT, Aborted.
__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
warning: 40	./arch/x86_64/syscall_arch.h: No such file or directory
(gdb) backtrace
#0__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
#10x000076f54c58fe1b in raise (sig=sig@entry=6) at src/signal/raise.c:11
#20x000076f54c5739ad in abort () at src/exit/abort.c:11
#30x000076f5484f2a4a in ?? () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#40x000076f548504ef8 in __cxxabiv1::__terminate(void (*)()) () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#50x000076f548504f65 in std::terminate() () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#60x000076f5485051b8 in __cxa_throw () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#70x000076f54a04b1ee in orc::loadTZDB(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#80x000076f54a04b9f3 in std::once_flag::_Prepare_execution::_Prepare_execution<std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#1}>(orc::LazyTimezone::getImpl() const::{lambda()#1}&)::{lambda()#1}::_FUN() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#90x000076f54c599656 in __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:22
#10__pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:11
#110x000076f54c5996f3 in __pthread_once (control=<optimized out>, init=<optimized out>) at src/thread/pthread_once.c:47
#120x000076f54a049659 in orc::LazyTimezone::getEpoch() const () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#130x000076f54a0804cf in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#140x000076f54a08155d in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#150x000076f54a081c36 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#160x000076f54a0815e3 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#170x000076f54a02f60d in orc::RowReaderImpl::startNextStripe() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#180x000076f54a030005 in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#190x000076f5495206a5 in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#200x000076f549520d6a in arrow::adapters::orc::ORCFileReader::Impl::ReadTable(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#210x000076f54951a3d7 in arrow::adapters::orc::ORCFileReader::Read() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#220x000076f525a6c55c in __pyx_pw_7pyarrow_4_orc_9ORCReader_43read(_object*, _object* const*, long, _object*) ()
@pitrou based on the stacktrace and the report this seems to be the exact same issue fixed that introduced the failing tests, any idea?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
The Windows failures are completely different and are due to a flight compilation error, I am trying to understand what is the problem too:
2025-09-25T12:18:12.0217461Z "C:\arrow-build\install.vcxproj" (default target) (1) ->
2025-09-25T12:18:12.0217793Z "C:\arrow-build\ALL_BUILD.vcxproj" (default target) (3) ->
2025-09-25T12:18:12.0218183Z "C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj" (default target) (25) ->
2025-09-25T12:18:12.0218544Z (ClCompile target) -> 2025-09-25T12:18:12.0219110Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0220135Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,8): error C2146: syntax error: missing ')' before identifier 'LPWSABUF' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0221162Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0222161Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,8): error C2146: syntax error: missing ')' before identifier 'DWORD' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0223529Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1109,48): error C3646: 'lpfnCompletionProc': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0224620Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(2721,14): error C2061: syntax error: identifier 'LPCONDITIONPROC' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0225621Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0226632Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0227643Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0229336Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0230498Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3098,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0231788Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3202,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0232967Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3259,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0234136Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3307,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0235777Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3336,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0236955Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3380,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0238561Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(4119,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0240758Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(764,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0243403Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(805,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0245552Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(862,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0246917Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(905,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0247998Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(939,12): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0249132Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(949,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0250761Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(956,35): error C2065: 'lpCompletionRoutine': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0251901Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(430,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0253045Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(492,40): error C3646: 'lpCompletionRoutine': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254185Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(516,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254821Z 2025-09-25T12:18:12.0254890Z 13 Warning(s)
2025-09-25T12:18:12.0255116Z 27 Error(s)

We should try to push the vcpkg version update because we have been using a really old one and updating it fixes the macOS wheels.
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: b73a6f75ac91e3ef3475c274855cf69a1a57df57
Submitted crossbow builds: ursacomputing/crossbow @ actions-01928a4f01
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@pitrou
pitrou
commented
Sep 25, 2025

Copy link


Copy Markdown

Member
@raulcd Did you check that arrow::adapters::orc::ORCFileReader::Impl::ReadBatch catches exceptions appropriately?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: 51110d116e4fc4cb0d962e8f012e3177748e828e
Submitted crossbow builds: ursacomputing/crossbow @ actions-f5546167b3
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-macos-monterey-cp313-*-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: b02bc4f
Submitted crossbow builds: ursacomputing/crossbow @ actions-b64128ce9f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-1b5b55ee21
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Oct 2, 2025
@raulcd
raulcd
commented
Oct 2, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g wheel
@raulcd
raulcd
marked this pull request as ready for review
October 2, 2025 06:55
@github-actions
github-actionsBot
commented
Oct 2, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-896442bc8b
TaskStatus
python-sdistGitHub Actions
wheel-macos-monterey-cp310-cp310-amd64GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-amd64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-arm64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
requested review from
kou and pitrouOctober 2, 2025 11:26
kou
kou
approved these changes
Oct 2, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Oct 2, 2025
@pitrou
pitrou
commented
Oct 2, 2025
via email 

Copy link


Copy Markdown

Member
@raulcd
raulcd
merged commit cde3f6a
into
apache:mainOct 3, 2025

44 checks passed

@raulcdraulcd
removed
the 
awaiting merge
Awaiting merge
label
Oct 3, 2025
@raulcdraulcd
mentioned this pull request
Oct 3, 2025

Closed

@raulcd
raulcd
deleted the

GH-43416-4

branch
October 3, 2025 07:45
@lidavidmlidavidm
mentioned this pull request
Oct 3, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Oct 3, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cde3f6a.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
@koukou
mentioned this pull request
Oct 8, 2025
 Merged

@raulcdraulcd
mentioned this pull request
Oct 10, 2025
 Closed

zanmato1984 pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
@raulcd@zanmato1984
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
cf9d9bc
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@bveeramanibveeramani
mentioned this pull request
Nov 17, 2025

Closed

Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
@raulcd@Mottl
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
f002634
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@lidavidmlidavidmAwaiting requested review from lidavidmlidavidm is a code owner
@pitroupitrouAwaiting requested review from pitrou

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd@wgtmac@pitrou@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
GH-47614: [CI] Upgrade vcpkg on our CI - #47627
Merged
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Oct 3, 2025
Merged
GH-47614: [CI] Upgrade vcpkg on our CI#47627
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Conversation
@raulcd
@raulcdraulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
What changes are included in this PR?
  • Update the vcpkg version to the latest released
  • Update minio version to solve failure due to newer aws-sdk
  • Remove unnecessary vcpkg patches
  • Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
  • Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
Are these changes tested?
Yes, via archery on CI.
Are there any user-facing changes?
No
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Sep 23, 2025
@raulcd

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-60c2e12547
TaskStatus
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp312-cp312-arm64 wheel-macos-monterey-cp312-cp312-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-63c80eedf6
TaskStatus
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view

1 similar comment

@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-musllinux-1-2-cp312-cp312-arm64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-75b62cd59e
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-557ed877e6
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-*
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ad950fd0f7
TaskStatus
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcdraulcd
mentioned this pull request
Sep 23, 2025
 Closed

@raulcd
raulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
There are two Python test failures on the musllinux wheel related to ORC timezone but there's no tzdata-legacy for alpine, I tried upgrading to alpine 3.22 instead of 3.21 but this did not solve the issue so I am unsure why those tests would fail now, the only change is the vcpkg upgrade which uses a newer ORC version but not on the underlying testing image:
 E subprocess.CalledProcessError: Command '['/usr/local/bin/python', '-c', 'if 1:\n import os\n os.environ[\'TZDIR\'] = \'/tmp/non_existent\'\n\n from pyarrow import orc\n try:\n orc_file = orc.ORCFile(\'/usr/local/lib/python3.12/site-packages/pyarrow/tests/data/orc/TestOrcFile.testDate1900.orc\')\n orc_file.read()\n except Exception as e:\n assert "time zone database" in str(e).lower(), e\n else:\n assert False, "Should have raised exception"\n ']' died with <Signals.SIGABRT: 6>.
usr/local/lib/python3.12/subprocess.py:571: CalledProcessError
----------------------------- Captured stderr call -----------------------------
terminate called after throwing an instance of 'orc::TimezoneError'
what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.

@wgtmac@kou any idea?

failure here:
https://github.com/ursacomputing/crossbow/actions/runs/17951257777/job/51050872037
@wgtmac
wgtmac
commented
Sep 24, 2025

Copy link


Copy Markdown

Member
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: c7fa2b963b212ac99c4661a741903ebd9480b4ce
Submitted crossbow builds: ursacomputing/crossbow @ actions-67f7bf6a17
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@wgtmac I've been investigating a little further the issue is with a couple tests that are "intentionally" removing the timezone and expecting ORC to raise an exception and Arrow to catch it but not to crash, the problem (on this specific case) is with ORC 2.1.0 which is the one on vcpkg and musllinux. See the backtrace:
terminate called after throwing an instance of 'orc::TimezoneError'what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.
Thread 1 "python" received signal SIGABRT, Aborted.
__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
warning: 40	./arch/x86_64/syscall_arch.h: No such file or directory
(gdb) backtrace
#0__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
#10x000076f54c58fe1b in raise (sig=sig@entry=6) at src/signal/raise.c:11
#20x000076f54c5739ad in abort () at src/exit/abort.c:11
#30x000076f5484f2a4a in ?? () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#40x000076f548504ef8 in __cxxabiv1::__terminate(void (*)()) () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#50x000076f548504f65 in std::terminate() () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#60x000076f5485051b8 in __cxa_throw () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#70x000076f54a04b1ee in orc::loadTZDB(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#80x000076f54a04b9f3 in std::once_flag::_Prepare_execution::_Prepare_execution<std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#1}>(orc::LazyTimezone::getImpl() const::{lambda()#1}&)::{lambda()#1}::_FUN() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#90x000076f54c599656 in __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:22
#10__pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:11
#110x000076f54c5996f3 in __pthread_once (control=<optimized out>, init=<optimized out>) at src/thread/pthread_once.c:47
#120x000076f54a049659 in orc::LazyTimezone::getEpoch() const () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#130x000076f54a0804cf in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#140x000076f54a08155d in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#150x000076f54a081c36 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#160x000076f54a0815e3 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#170x000076f54a02f60d in orc::RowReaderImpl::startNextStripe() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#180x000076f54a030005 in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#190x000076f5495206a5 in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#200x000076f549520d6a in arrow::adapters::orc::ORCFileReader::Impl::ReadTable(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#210x000076f54951a3d7 in arrow::adapters::orc::ORCFileReader::Read() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#220x000076f525a6c55c in __pyx_pw_7pyarrow_4_orc_9ORCReader_43read(_object*, _object* const*, long, _object*) ()
@pitrou based on the stacktrace and the report this seems to be the exact same issue fixed that introduced the failing tests, any idea?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
The Windows failures are completely different and are due to a flight compilation error, I am trying to understand what is the problem too:
2025-09-25T12:18:12.0217461Z "C:\arrow-build\install.vcxproj" (default target) (1) ->
2025-09-25T12:18:12.0217793Z "C:\arrow-build\ALL_BUILD.vcxproj" (default target) (3) ->
2025-09-25T12:18:12.0218183Z "C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj" (default target) (25) ->
2025-09-25T12:18:12.0218544Z (ClCompile target) -> 2025-09-25T12:18:12.0219110Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0220135Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,8): error C2146: syntax error: missing ')' before identifier 'LPWSABUF' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0221162Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0222161Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,8): error C2146: syntax error: missing ')' before identifier 'DWORD' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0223529Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1109,48): error C3646: 'lpfnCompletionProc': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0224620Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(2721,14): error C2061: syntax error: identifier 'LPCONDITIONPROC' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0225621Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0226632Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0227643Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0229336Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0230498Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3098,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0231788Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3202,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0232967Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3259,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0234136Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3307,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0235777Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3336,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0236955Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3380,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0238561Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(4119,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0240758Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(764,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0243403Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(805,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0245552Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(862,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0246917Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(905,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0247998Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(939,12): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0249132Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(949,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0250761Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(956,35): error C2065: 'lpCompletionRoutine': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0251901Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(430,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0253045Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(492,40): error C3646: 'lpCompletionRoutine': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254185Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(516,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254821Z 2025-09-25T12:18:12.0254890Z 13 Warning(s)
2025-09-25T12:18:12.0255116Z 27 Error(s)

We should try to push the vcpkg version update because we have been using a really old one and updating it fixes the macOS wheels.
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: b73a6f75ac91e3ef3475c274855cf69a1a57df57
Submitted crossbow builds: ursacomputing/crossbow @ actions-01928a4f01
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@pitrou
pitrou
commented
Sep 25, 2025

Copy link


Copy Markdown

Member
@raulcd Did you check that arrow::adapters::orc::ORCFileReader::Impl::ReadBatch catches exceptions appropriately?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: 51110d116e4fc4cb0d962e8f012e3177748e828e
Submitted crossbow builds: ursacomputing/crossbow @ actions-f5546167b3
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-macos-monterey-cp313-*-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: b02bc4f
Submitted crossbow builds: ursacomputing/crossbow @ actions-b64128ce9f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-1b5b55ee21
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Oct 2, 2025
@raulcd
raulcd
commented
Oct 2, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g wheel
@raulcd
raulcd
marked this pull request as ready for review
October 2, 2025 06:55
@github-actions
github-actionsBot
commented
Oct 2, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-896442bc8b
TaskStatus
python-sdistGitHub Actions
wheel-macos-monterey-cp310-cp310-amd64GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-amd64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-arm64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
requested review from
kou and pitrouOctober 2, 2025 11:26
kou
kou
approved these changes
Oct 2, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Oct 2, 2025
@pitrou
pitrou
commented
Oct 2, 2025
via email 

Copy link


Copy Markdown

Member
@raulcd
raulcd
merged commit cde3f6a
into
apache:mainOct 3, 2025

44 checks passed

@raulcdraulcd
removed
the 
awaiting merge
Awaiting merge
label
Oct 3, 2025
@raulcdraulcd
mentioned this pull request
Oct 3, 2025

Closed

@raulcd
raulcd
deleted the

GH-43416-4

branch
October 3, 2025 07:45
@lidavidmlidavidm
mentioned this pull request
Oct 3, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Oct 3, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cde3f6a.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
@koukou
mentioned this pull request
Oct 8, 2025
 Merged

@raulcdraulcd
mentioned this pull request
Oct 10, 2025
 Closed

zanmato1984 pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
@raulcd@zanmato1984
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
cf9d9bc
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@bveeramanibveeramani
mentioned this pull request
Nov 17, 2025

Closed

Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
@raulcd@Mottl
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
f002634
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@lidavidmlidavidmAwaiting requested review from lidavidmlidavidm is a code owner
@pitroupitrouAwaiting requested review from pitrou

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd@wgtmac@pitrou@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
GH-47614: [CI] Upgrade vcpkg on our CI - #47627
Merged
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Oct 3, 2025
Merged
GH-47614: [CI] Upgrade vcpkg on our CI#47627
raulcd merged 20 commits into
apache:mainfrom 
raulcd:GH-43416-4
Conversation
@raulcd
@raulcdraulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
What changes are included in this PR?
  • Update the vcpkg version to the latest released
  • Update minio version to solve failure due to newer aws-sdk
  • Remove unnecessary vcpkg patches
  • Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
  • Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
Are these changes tested?
Yes, via archery on CI.
Are there any user-facing changes?
No
@github-actionsgithub-actionsBot
added
the 
awaiting committer review
Awaiting committer review
label
Sep 23, 2025
@raulcd

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-60c2e12547
TaskStatus
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp312-cp312-arm64 wheel-macos-monterey-cp312-cp312-amd64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4
Submitted crossbow builds: ursacomputing/crossbow @ actions-63c80eedf6
TaskStatus
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view

1 similar comment

@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-musllinux-1-2-cp312-cp312-arm64
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-75b62cd59e
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-557ed877e6
TaskStatus
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
@raulcd

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 23, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-*
@github-actions
github-actionsBot
commented
Sep 23, 2025

Copy link


Copy Markdown

Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72
Submitted crossbow builds: ursacomputing/crossbow @ actions-ad950fd0f7
TaskStatus
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcdraulcd
mentioned this pull request
Sep 23, 2025
 Closed

@raulcd
raulcd
commented
Sep 23, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
There are two Python test failures on the musllinux wheel related to ORC timezone but there's no tzdata-legacy for alpine, I tried upgrading to alpine 3.22 instead of 3.21 but this did not solve the issue so I am unsure why those tests would fail now, the only change is the vcpkg upgrade which uses a newer ORC version but not on the underlying testing image:
 E subprocess.CalledProcessError: Command '['/usr/local/bin/python', '-c', 'if 1:\n import os\n os.environ[\'TZDIR\'] = \'/tmp/non_existent\'\n\n from pyarrow import orc\n try:\n orc_file = orc.ORCFile(\'/usr/local/lib/python3.12/site-packages/pyarrow/tests/data/orc/TestOrcFile.testDate1900.orc\')\n orc_file.read()\n except Exception as e:\n assert "time zone database" in str(e).lower(), e\n else:\n assert False, "Should have raised exception"\n ']' died with <Signals.SIGABRT: 6>.
usr/local/lib/python3.12/subprocess.py:571: CalledProcessError
----------------------------- Captured stderr call -----------------------------
terminate called after throwing an instance of 'orc::TimezoneError'
what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.

@wgtmac@kou any idea?

failure here:
https://github.com/ursacomputing/crossbow/actions/runs/17951257777/job/51050872037
@wgtmac
wgtmac
commented
Sep 24, 2025

Copy link


Copy Markdown

Member
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: c7fa2b963b212ac99c4661a741903ebd9480b4ce
Submitted crossbow builds: ursacomputing/crossbow @ actions-67f7bf6a17
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427
@wgtmac I've been investigating a little further the issue is with a couple tests that are "intentionally" removing the timezone and expecting ORC to raise an exception and Arrow to catch it but not to crash, the problem (on this specific case) is with ORC 2.1.0 which is the one on vcpkg and musllinux. See the backtrace:
terminate called after throwing an instance of 'orc::TimezoneError'what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.
Thread 1 "python" received signal SIGABRT, Aborted.
__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
warning: 40	./arch/x86_64/syscall_arch.h: No such file or directory
(gdb) backtrace
#0__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
#10x000076f54c58fe1b in raise (sig=sig@entry=6) at src/signal/raise.c:11
#20x000076f54c5739ad in abort () at src/exit/abort.c:11
#30x000076f5484f2a4a in ?? () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#40x000076f548504ef8 in __cxxabiv1::__terminate(void (*)()) () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#50x000076f548504f65 in std::terminate() () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#60x000076f5485051b8 in __cxa_throw () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#70x000076f54a04b1ee in orc::loadTZDB(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#80x000076f54a04b9f3 in std::once_flag::_Prepare_execution::_Prepare_execution<std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#1}>(orc::LazyTimezone::getImpl() const::{lambda()#1}&)::{lambda()#1}::_FUN() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#90x000076f54c599656 in __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:22
#10__pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:11
#110x000076f54c5996f3 in __pthread_once (control=<optimized out>, init=<optimized out>) at src/thread/pthread_once.c:47
#120x000076f54a049659 in orc::LazyTimezone::getEpoch() const () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#130x000076f54a0804cf in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#140x000076f54a08155d in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#150x000076f54a081c36 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#160x000076f54a0815e3 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#170x000076f54a02f60d in orc::RowReaderImpl::startNextStripe() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#180x000076f54a030005 in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#190x000076f5495206a5 in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#200x000076f549520d6a in arrow::adapters::orc::ORCFileReader::Impl::ReadTable(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#210x000076f54951a3d7 in arrow::adapters::orc::ORCFileReader::Read() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#220x000076f525a6c55c in __pyx_pw_7pyarrow_4_orc_9ORCReader_43read(_object*, _object* const*, long, _object*) ()
@pitrou based on the stacktrace and the report this seems to be the exact same issue fixed that introduced the failing tests, any idea?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
The Windows failures are completely different and are due to a flight compilation error, I am trying to understand what is the problem too:
2025-09-25T12:18:12.0217461Z "C:\arrow-build\install.vcxproj" (default target) (1) ->
2025-09-25T12:18:12.0217793Z "C:\arrow-build\ALL_BUILD.vcxproj" (default target) (3) ->
2025-09-25T12:18:12.0218183Z "C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj" (default target) (25) ->
2025-09-25T12:18:12.0218544Z (ClCompile target) -> 2025-09-25T12:18:12.0219110Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0220135Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1061,8): error C2146: syntax error: missing ')' before identifier 'LPWSABUF' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0221162Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,5): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0222161Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1074,8): error C2146: syntax error: missing ')' before identifier 'DWORD' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0223529Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(1109,48): error C3646: 'lpfnCompletionProc': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0224620Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(2721,14): error C2061: syntax error: identifier 'LPCONDITIONPROC' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0225621Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0226632Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3048,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0227643Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,10): error C2065: 'IN': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0229336Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3069,13): error C2146: syntax error: missing ')' before identifier 'SOCKET' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0230498Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3098,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0231788Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3202,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0232967Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3259,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0234136Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3307,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0235777Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3336,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0236955Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(3380,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0238561Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(4119,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0240758Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(764,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0243403Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(805,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0245552Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(862,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0246917Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(905,13): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0247998Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(939,12): error C2660: 'WSAIoctl': function does not take 9 arguments [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0249132Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(949,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0250761Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\ws2tcpip.h(956,35): error C2065: 'lpCompletionRoutine': undeclared identifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0251901Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(430,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0253045Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(492,40): error C3646: 'lpCompletionRoutine': unknown override specifier [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254185Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\mswsock.h(516,14): error C2061: syntax error: identifier 'LPWSAOVERLAPPED_COMPLETION_ROUTINE' [C:\arrow-build\src\arrow\flight\arrow_flight_shared.vcxproj]
2025-09-25T12:18:12.0254821Z 2025-09-25T12:18:12.0254890Z 13 Warning(s)
2025-09-25T12:18:12.0255116Z 27 Error(s)

We should try to push the vcpkg version update because we have been using a really old one and updating it fixes the macOS wheels.
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: b73a6f75ac91e3ef3475c274855cf69a1a57df57
Submitted crossbow builds: ursacomputing/crossbow @ actions-01928a4f01
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@pitrou
pitrou
commented
Sep 25, 2025

Copy link


Copy Markdown

Member
@raulcd Did you check that arrow::adapters::orc::ORCFileReader::Impl::ReadBatch catches exceptions appropriately?
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Sep 25, 2025

Copy link


Copy Markdown

Revision: 51110d116e4fc4cb0d962e8f012e3177748e828e
Submitted crossbow builds: ursacomputing/crossbow @ actions-f5546167b3
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@raulcd
raulcd
commented
Sep 25, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-macos-monterey-cp313-*-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: b02bc4f
Submitted crossbow builds: ursacomputing/crossbow @ actions-b64128ce9f
TaskStatus
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
commented
Oct 1, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
@github-actions
github-actionsBot
commented
Oct 1, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-1b5b55ee21
TaskStatus
wheel-windows-cp313-cp313-amd64GitHub Actions
@github-actionsgithub-actionsBot
added

awaiting changes
Awaiting changes
and removed

awaiting change review
Awaiting change review
labels
Oct 2, 2025
@raulcd
raulcd
commented
Oct 2, 2025

Copy link


Copy Markdown

MemberAuthor
@github-actions crossbow submit -g wheel
@raulcd
raulcd
marked this pull request as ready for review
October 2, 2025 06:55
@github-actions
github-actionsBot
commented
Oct 2, 2025

Copy link


Copy Markdown

Revision: 09c6acd
Submitted crossbow builds: ursacomputing/crossbow @ actions-896442bc8b
TaskStatus
python-sdistGitHub Actions
wheel-macos-monterey-cp310-cp310-amd64GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-amd64GitHub Actions
wheel-musllinux-1-2-cp311-cp311-arm64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-amd64GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64GitHub Actions
wheel-windows-cp310-cp310-amd64GitHub Actions
wheel-windows-cp311-cp311-amd64GitHub Actions
wheel-windows-cp312-cp312-amd64GitHub Actions
wheel-windows-cp313-cp313-amd64GitHub Actions
wheel-windows-cp313-cp313t-amd64GitHub Actions
@raulcd
raulcd
requested review from
kou and pitrouOctober 2, 2025 11:26
kou
kou
approved these changes
Oct 2, 2025
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@github-actionsgithub-actionsBot
added

awaiting merge
Awaiting merge
and removed

awaiting changes
Awaiting changes
labels
Oct 2, 2025
@pitrou
pitrou
commented
Oct 2, 2025
via email 

Copy link


Copy Markdown

Member
@raulcd
raulcd
merged commit cde3f6a
into
apache:mainOct 3, 2025

44 checks passed

@raulcdraulcd
removed
the 
awaiting merge
Awaiting merge
label
Oct 3, 2025
@raulcdraulcd
mentioned this pull request
Oct 3, 2025

Closed

@raulcd
raulcd
deleted the

GH-43416-4

branch
October 3, 2025 07:45
@lidavidmlidavidm
mentioned this pull request
Oct 3, 2025

Closed

@conbench-apache-arrow
conbench-apache-arrowBot
commented
Oct 3, 2025

Copy link


Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cde3f6a.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
@koukou
mentioned this pull request
Oct 8, 2025
 Merged

@raulcdraulcd
mentioned this pull request
Oct 10, 2025
 Closed

zanmato1984 pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
@raulcd@zanmato1984
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
cf9d9bc
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@bveeramanibveeramani
mentioned this pull request
Nov 17, 2025

Closed

Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
@raulcd@Mottl
apacheGH-47614: [CI] Upgrade vcpkg on our CI (apache#47627)
f002634
### Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
### What changes are included in this PR?
- Update the vcpkg version to the latest released
- Update minio version to solve failure due to newer aws-sdk
- Remove unnecessary vcpkg patches
- Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux.
- Avoid adding some flight sources on Windows unity builds that cause windows headers clashing.
### Are these changes tested?
Yes, via archery on CI.
### Are there any user-facing changes?
No
* GitHub Issue: apache#43416
* GitHub Issue: apache#47614
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@lidavidmlidavidmAwaiting requested review from lidavidmlidavidm is a code owner
@pitroupitrouAwaiting requested review from pitrou

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd@wgtmac@pitrou@kou