GH-47742: [C++][CI] Silence Valgrind leak on protobuf initialization by pitrou · Pull Request #47743 · apache/arrow

pitrou · 2025-10-07T15:42:46Z

Rationale for this change

Valgrind would report memory leaks induced by protobuf initialization on library load, for example:

==14628== 414 bytes in 16 blocks are possibly lost in loss record 22 of 26
==14628== at 0x4914EFF: operator new(unsigned long) (vg_replace_malloc.c:487)
==14628== by 0x8D0B6CA: void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>(char*, char*, std::forward_iterator_tag) [clone .isra.0] (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0)
==14628== by 0x8D33E62: google::protobuf::DescriptorPool::Tables::Tables() (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0)
==14628== by 0x8D340E2: google::protobuf::DescriptorPool::DescriptorPool(google::protobuf::DescriptorDatabase*, google::protobuf::DescriptorPool::ErrorCollector*) (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0)
==14628== by 0x8D341A2: google::protobuf::DescriptorPool::internal_generated_pool() (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0)
==14628== by 0x8D34277: google::protobuf::DescriptorPool::InternalAddGeneratedFile(void const*, int) (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0)
==14628== by 0x8D9C56F: google::protobuf::internal::AddDescriptorsRunner::AddDescriptorsRunner(google::protobuf::internal::DescriptorTable const*) (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0)
==14628== by 0x40D147D: call_init.part.0 (dl-init.c:70)
==14628== by 0x40D1567: call_init (dl-init.c:33)
==14628== by 0x40D1567: _dl_init (dl-init.c:117)
==14628== by 0x40EB2C9: ??? (in /usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2)

This was triggered by the libprotobuf upgrade on conda-forge from 3.21.12 to 4.25.3.

What changes are included in this PR?

Add a Valgrind suppression for these leak reports, as there is probably not much we can do about them.

Are these changes tested?

Yes, by existing CI test.

Are there any user-facing changes?

No.

GitHub Issue: [C++][CI] test-conda-cpp-valgrind failure #47742

…ation

pitrou · 2025-10-07T15:44:40Z

@github-actions crossbow submit test-conda-cpp-valgrind

pitrou · 2025-10-07T15:45:20Z

cc @zanmato1984 @adamreeve @kou @lidavidm

github-actions · 2025-10-07T15:46:50Z

Revision: 90c193d

Submitted crossbow builds: ursacomputing/crossbow @ actions-c6463cc89b

Task	Status
test-conda-cpp-valgrind

zanmato1984

LGTM with one nit.

pitrou · 2025-10-07T19:37:19Z

@github-actions crossbow submit test-conda-cpp-valgrind

github-actions · 2025-10-07T19:39:35Z

Revision: 8bccf7d

Submitted crossbow builds: ursacomputing/crossbow @ actions-d81ae2c48f

Task	Status
test-conda-cpp-valgrind

conbench-apache-arrow · 2025-10-07T23:50:21Z

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 2e90823.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

…47743) ### Rationale for this change Valgrind would report memory leaks induced by protobuf initialization on library load, for example: ``` ==14628== 414 bytes in 16 blocks are possibly lost in loss record 22 of 26 ==14628== at 0x4914EFF: operator new(unsigned long) (vg_replace_malloc.c:487) ==14628== by 0x8D0B6CA: void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>(char*, char*, std::forward_iterator_tag) [clone .isra.0] (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D33E62: google::protobuf::DescriptorPool::Tables::Tables() (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D340E2: google::protobuf::DescriptorPool::DescriptorPool(google::protobuf::DescriptorDatabase*, google::protobuf::DescriptorPool::ErrorCollector*) (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D341A2: google::protobuf::DescriptorPool::internal_generated_pool() (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D34277: google::protobuf::DescriptorPool::InternalAddGeneratedFile(void const*, int) (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D9C56F: google::protobuf::internal::AddDescriptorsRunner::AddDescriptorsRunner(google::protobuf::internal::DescriptorTable const*) (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x40D147D: call_init.part.0 (dl-init.c:70) ==14628== by 0x40D1567: call_init (dl-init.c:33) ==14628== by 0x40D1567: _dl_init (dl-init.c:117) ==14628== by 0x40EB2C9: ??? (in /usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2) ``` This was triggered by the `libprotobuf` upgrade on conda-forge from 3.21.12 to 4.25.3. ### What changes are included in this PR? Add a Valgrind suppression for these leak reports, as there is probably not much we can do about them. ### Are these changes tested? Yes, by existing CI test. ### Are there any user-facing changes? No. * GitHub Issue: #47742 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>

…ation (apache#47743) ### Rationale for this change Valgrind would report memory leaks induced by protobuf initialization on library load, for example: ``` ==14628== 414 bytes in 16 blocks are possibly lost in loss record 22 of 26 ==14628== at 0x4914EFF: operator new(unsigned long) (vg_replace_malloc.c:487) ==14628== by 0x8D0B6CA: void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>(char*, char*, std::forward_iterator_tag) [clone .isra.0] (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D33E62: google::protobuf::DescriptorPool::Tables::Tables() (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D340E2: google::protobuf::DescriptorPool::DescriptorPool(google::protobuf::DescriptorDatabase*, google::protobuf::DescriptorPool::ErrorCollector*) (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D341A2: google::protobuf::DescriptorPool::internal_generated_pool() (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D34277: google::protobuf::DescriptorPool::InternalAddGeneratedFile(void const*, int) (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x8D9C56F: google::protobuf::internal::AddDescriptorsRunner::AddDescriptorsRunner(google::protobuf::internal::DescriptorTable const*) (in /opt/conda/envs/arrow/lib/libprotobuf.so.25.3.0) ==14628== by 0x40D147D: call_init.part.0 (dl-init.c:70) ==14628== by 0x40D1567: call_init (dl-init.c:33) ==14628== by 0x40D1567: _dl_init (dl-init.c:117) ==14628== by 0x40EB2C9: ??? (in /usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2) ``` This was triggered by the `libprotobuf` upgrade on conda-forge from 3.21.12 to 4.25.3. ### What changes are included in this PR? Add a Valgrind suppression for these leak reports, as there is probably not much we can do about them. ### Are these changes tested? Yes, by existing CI test. ### Are there any user-facing changes? No. * GitHub Issue: apache#47742 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>

apacheGH-47742: [C++][CI] Silence Valgrind leak on protobuf initializ…
90c193d
…ation

github-actionsBot added Component: C++ awaiting review Awaiting review labels Oct 7, 2025

pitrou mentioned this pull request Oct 7, 2025
GH-47740: [C++][Parquet] Fix undefined behavior when reading invalid Parquet data #47741
Merged

zanmato1984 approved these changes Oct 7, 2025
View reviewed changes

Comment threadcpp/valgrind.supp Outdated

github-actionsBot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Oct 7, 2025

Use exact function names
8bccf7d

zanmato1984 approved these changes Oct 7, 2025
View reviewed changes

pitrou merged commit 2e90823 into apache:mainOct 7, 2025
40 checks passed

pitrou removed the awaiting committer review Awaiting committer review label Oct 7, 2025

pitrou mentioned this pull request Oct 7, 2025
[C++][CI] test-conda-cpp-valgrind failure #47742
Closed

pitrou deleted the gh47742-valgrind branch October 7, 2025 20:18

Navigation Menu

Uh oh!

GH-47742: [C++][CI] Silence Valgrind leak on protobuf initialization - #47743

GH-47742: [C++][CI] Silence Valgrind leak on protobuf initialization#47743
pitrou merged 2 commits into
apache:mainfrom
pitrou:gh47742-valgrind

pitrou commented Oct 7, 2025•
edited by github-actions Bot
Loading

Uh oh!

pitrou commented Oct 7, 2025

Uh oh!

pitrou commented Oct 7, 2025

Uh oh!

github-actionsBot commented Oct 7, 2025

Uh oh!

zanmato1984 left a comment

Uh oh!

Uh oh!

pitrou commented Oct 7, 2025

Uh oh!

github-actionsBot commented Oct 7, 2025

Uh oh!

Uh oh!

conbench-apache-arrowBot commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pitrou commented Oct 7, 2025• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

pitrou commented Oct 7, 2025

Uh oh!

pitrou commented Oct 7, 2025

Uh oh!

github-actionsBot commented Oct 7, 2025

Uh oh!

zanmato1984 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pitrou commented Oct 7, 2025

Uh oh!

github-actionsBot commented Oct 7, 2025

Uh oh!

Uh oh!

conbench-apache-arrowBot commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pitrou commented Oct 7, 2025•
edited by github-actions Bot
Loading