GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC - #47772

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr
Nov 30, 2025
Merged

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC#47772
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr

Conversation

@alinaliBQ

@alinaliBQalinaliBQ commented Oct 9, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

Add connection attribute support for ODBC driver.

What changes are included in this PR?

  • Implementation of SQLGetConnectAttr and SQLSetConnectAttr to get and set connection attributes
  • Tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

No

@github-actions

github-actionsBot commented Oct 9, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47708has been automatically assigned in GitHub to PR creator.

@alinaliBQ

alinaliBQ commented Oct 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Please review this draft ODBC API PR, thanks. The testing folder structure will be in a separate PR

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Oct 9, 2025
lidavidm
lidavidm reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 10, 2025
kou
kou reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@koukouOct 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetUp() as David commented in other PR?

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@kou

kou commented Oct 10, 2025

Copy link
Copy Markdown
Member

Could you create new draft PRs after you complete other draft PRs to reflect comments in other draft PRs?

@alinaliBQ

alinaliBQ commented Oct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Sure, will check the general comments first before creating new PRs. I will put the PRs to a pause for now since the comments are similar. Thanks for letting me know

@alinaliBQalinaliBQ mentioned this pull request Oct 10, 2025
Open
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from af5de2e to e8c404cCompareOctober 21, 2025 22:15
alinaliBQ
alinaliBQ commented Oct 21, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress of addressing comments. The team is still working on improving the subclass logic for separate test fixture (discussion is in #47788)

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@github-actionsgithub-actionsBot added awaiting review Awaiting review awaiting change review Awaiting change review awaiting committer review Awaiting committer review and removed awaiting changes Awaiting changes awaiting review Awaiting review awaiting change review Awaiting change review labels Oct 21, 2025
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e8c404c to c6c5af9CompareOctober 22, 2025 23:01
alinaliBQ
alinaliBQ commented Oct 22, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
lidavidm
lidavidm approved these changes Oct 23, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@lidavidmlidavidmOct 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EXPECT_FALSE

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 23, 2025
alinaliBQ
alinaliBQ commented Oct 23, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment •
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, please note that the tests in this PR requires connectivity support implementation (I will raise the PR for connectivity after #47760 is merged) in order to pass.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from c6c5af9 to 2332bdaCompareOctober 23, 2025 19:00
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from 2332bda to e5705e7CompareNovember 14, 2025 23:39
@alinaliBQ
alinaliBQ marked this pull request as ready for review November 14, 2025 23:39
@lidavidm

lidavidm commented Nov 28, 2025

Copy link
Copy Markdown
Member

@alinaliBQ can you resolve conflicts?

@alinaliBQ@justing-bq
Extract Implementation for SQLGetConnectAttr and SQLSetConnectAttr
23b8689
Use `EXPECT_FALSE`
Remove `using List`
Rebase from `master`
Work on code review comments
Add tests for connection attribute
Co-Authored-By: justing-bq <justin.gossett@improving.com>
Co-Authored-By: alinalibq <alina.li@improving.com>
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e5705e7 to 23b8689CompareNovember 28, 2025 22:15
@alinaliBQ

alinaliBQ commented Nov 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm Thank you for the ping, rebased and resolved conflict

@lidavidm
lidavidm merged commit 95cdc0c into apache:mainNov 30, 2025
45 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Nov 30, 2025
@lidavidmlidavidm mentioned this pull request Nov 30, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Nov 30, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 95cdc0c.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@alinaliBQ@Mottl
apacheGH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC (
9972c60
apache#47772)
### Rationale for this change
Add connection attribute support for ODBC driver.
### What changes are included in this PR?
- Implementation of `SQLGetConnectAttr` and `SQLSetConnectAttr` to get and set connection attributes
- Tests
### Are these changes tested?
Tested on local MSVC
### Are there any user-facing changes?
No
* GitHub Issue: apache#47708
Authored-by: Alina (Xi) Li <alina.li@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@lidavidmlidavidmlidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ@kou@lidavidm
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC - #47772

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr
Nov 30, 2025
Merged

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC#47772
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr

Conversation

@alinaliBQ

@alinaliBQalinaliBQ commented Oct 9, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

Add connection attribute support for ODBC driver.

What changes are included in this PR?

  • Implementation of SQLGetConnectAttr and SQLSetConnectAttr to get and set connection attributes
  • Tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

No

@github-actions

github-actionsBot commented Oct 9, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47708has been automatically assigned in GitHub to PR creator.

@alinaliBQ

alinaliBQ commented Oct 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Please review this draft ODBC API PR, thanks. The testing folder structure will be in a separate PR

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Oct 9, 2025
lidavidm
lidavidm reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 10, 2025
kou
kou reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@koukouOct 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetUp() as David commented in other PR?

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@kou

kou commented Oct 10, 2025

Copy link
Copy Markdown
Member

Could you create new draft PRs after you complete other draft PRs to reflect comments in other draft PRs?

@alinaliBQ

alinaliBQ commented Oct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Sure, will check the general comments first before creating new PRs. I will put the PRs to a pause for now since the comments are similar. Thanks for letting me know

@alinaliBQalinaliBQ mentioned this pull request Oct 10, 2025
Open
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from af5de2e to e8c404cCompareOctober 21, 2025 22:15
alinaliBQ
alinaliBQ commented Oct 21, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress of addressing comments. The team is still working on improving the subclass logic for separate test fixture (discussion is in #47788)

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@github-actionsgithub-actionsBot added awaiting review Awaiting review awaiting change review Awaiting change review awaiting committer review Awaiting committer review and removed awaiting changes Awaiting changes awaiting review Awaiting review awaiting change review Awaiting change review labels Oct 21, 2025
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e8c404c to c6c5af9CompareOctober 22, 2025 23:01
alinaliBQ
alinaliBQ commented Oct 22, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
lidavidm
lidavidm approved these changes Oct 23, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@lidavidmlidavidmOct 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EXPECT_FALSE

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 23, 2025
alinaliBQ
alinaliBQ commented Oct 23, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment •
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, please note that the tests in this PR requires connectivity support implementation (I will raise the PR for connectivity after #47760 is merged) in order to pass.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from c6c5af9 to 2332bdaCompareOctober 23, 2025 19:00
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from 2332bda to e5705e7CompareNovember 14, 2025 23:39
@alinaliBQ
alinaliBQ marked this pull request as ready for review November 14, 2025 23:39
@lidavidm

lidavidm commented Nov 28, 2025

Copy link
Copy Markdown
Member

@alinaliBQ can you resolve conflicts?

@alinaliBQ@justing-bq
Extract Implementation for SQLGetConnectAttr and SQLSetConnectAttr
23b8689
Use `EXPECT_FALSE`
Remove `using List`
Rebase from `master`
Work on code review comments
Add tests for connection attribute
Co-Authored-By: justing-bq <justin.gossett@improving.com>
Co-Authored-By: alinalibq <alina.li@improving.com>
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e5705e7 to 23b8689CompareNovember 28, 2025 22:15
@alinaliBQ

alinaliBQ commented Nov 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm Thank you for the ping, rebased and resolved conflict

@lidavidm
lidavidm merged commit 95cdc0c into apache:mainNov 30, 2025
45 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Nov 30, 2025
@lidavidmlidavidm mentioned this pull request Nov 30, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Nov 30, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 95cdc0c.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@alinaliBQ@Mottl
apacheGH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC (
9972c60
apache#47772)
### Rationale for this change
Add connection attribute support for ODBC driver.
### What changes are included in this PR?
- Implementation of `SQLGetConnectAttr` and `SQLSetConnectAttr` to get and set connection attributes
- Tests
### Are these changes tested?
Tested on local MSVC
### Are there any user-facing changes?
No
* GitHub Issue: apache#47708
Authored-by: Alina (Xi) Li <alina.li@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@lidavidmlidavidmlidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ@kou@lidavidm
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC - #47772

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr
Nov 30, 2025
Merged

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC#47772
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr

Conversation

@alinaliBQ

@alinaliBQalinaliBQ commented Oct 9, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

Add connection attribute support for ODBC driver.

What changes are included in this PR?

  • Implementation of SQLGetConnectAttr and SQLSetConnectAttr to get and set connection attributes
  • Tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

No

@github-actions

github-actionsBot commented Oct 9, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47708has been automatically assigned in GitHub to PR creator.

@alinaliBQ

alinaliBQ commented Oct 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Please review this draft ODBC API PR, thanks. The testing folder structure will be in a separate PR

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Oct 9, 2025
lidavidm
lidavidm reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 10, 2025
kou
kou reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@koukouOct 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetUp() as David commented in other PR?

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@kou

kou commented Oct 10, 2025

Copy link
Copy Markdown
Member

Could you create new draft PRs after you complete other draft PRs to reflect comments in other draft PRs?

@alinaliBQ

alinaliBQ commented Oct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Sure, will check the general comments first before creating new PRs. I will put the PRs to a pause for now since the comments are similar. Thanks for letting me know

@alinaliBQalinaliBQ mentioned this pull request Oct 10, 2025
Open
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from af5de2e to e8c404cCompareOctober 21, 2025 22:15
alinaliBQ
alinaliBQ commented Oct 21, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress of addressing comments. The team is still working on improving the subclass logic for separate test fixture (discussion is in #47788)

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@github-actionsgithub-actionsBot added awaiting review Awaiting review awaiting change review Awaiting change review awaiting committer review Awaiting committer review and removed awaiting changes Awaiting changes awaiting review Awaiting review awaiting change review Awaiting change review labels Oct 21, 2025
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e8c404c to c6c5af9CompareOctober 22, 2025 23:01
alinaliBQ
alinaliBQ commented Oct 22, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
lidavidm
lidavidm approved these changes Oct 23, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@lidavidmlidavidmOct 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EXPECT_FALSE

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 23, 2025
alinaliBQ
alinaliBQ commented Oct 23, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment •
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, please note that the tests in this PR requires connectivity support implementation (I will raise the PR for connectivity after #47760 is merged) in order to pass.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from c6c5af9 to 2332bdaCompareOctober 23, 2025 19:00
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from 2332bda to e5705e7CompareNovember 14, 2025 23:39
@alinaliBQ
alinaliBQ marked this pull request as ready for review November 14, 2025 23:39
@lidavidm

lidavidm commented Nov 28, 2025

Copy link
Copy Markdown
Member

@alinaliBQ can you resolve conflicts?

@alinaliBQ@justing-bq
Extract Implementation for SQLGetConnectAttr and SQLSetConnectAttr
23b8689
Use `EXPECT_FALSE`
Remove `using List`
Rebase from `master`
Work on code review comments
Add tests for connection attribute
Co-Authored-By: justing-bq <justin.gossett@improving.com>
Co-Authored-By: alinalibq <alina.li@improving.com>
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e5705e7 to 23b8689CompareNovember 28, 2025 22:15
@alinaliBQ

alinaliBQ commented Nov 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm Thank you for the ping, rebased and resolved conflict

@lidavidm
lidavidm merged commit 95cdc0c into apache:mainNov 30, 2025
45 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Nov 30, 2025
@lidavidmlidavidm mentioned this pull request Nov 30, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Nov 30, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 95cdc0c.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@alinaliBQ@Mottl
apacheGH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC (
9972c60
apache#47772)
### Rationale for this change
Add connection attribute support for ODBC driver.
### What changes are included in this PR?
- Implementation of `SQLGetConnectAttr` and `SQLSetConnectAttr` to get and set connection attributes
- Tests
### Are these changes tested?
Tested on local MSVC
### Are there any user-facing changes?
No
* GitHub Issue: apache#47708
Authored-by: Alina (Xi) Li <alina.li@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@lidavidmlidavidmlidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ@kou@lidavidm
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC - #47772

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr
Nov 30, 2025
Merged

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC#47772
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr

Conversation

@alinaliBQ

@alinaliBQalinaliBQ commented Oct 9, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

Add connection attribute support for ODBC driver.

What changes are included in this PR?

  • Implementation of SQLGetConnectAttr and SQLSetConnectAttr to get and set connection attributes
  • Tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

No

@github-actions

github-actionsBot commented Oct 9, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47708has been automatically assigned in GitHub to PR creator.

@alinaliBQ

alinaliBQ commented Oct 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Please review this draft ODBC API PR, thanks. The testing folder structure will be in a separate PR

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Oct 9, 2025
lidavidm
lidavidm reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 10, 2025
kou
kou reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@koukouOct 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetUp() as David commented in other PR?

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@kou

kou commented Oct 10, 2025

Copy link
Copy Markdown
Member

Could you create new draft PRs after you complete other draft PRs to reflect comments in other draft PRs?

@alinaliBQ

alinaliBQ commented Oct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Sure, will check the general comments first before creating new PRs. I will put the PRs to a pause for now since the comments are similar. Thanks for letting me know

@alinaliBQalinaliBQ mentioned this pull request Oct 10, 2025
Open
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from af5de2e to e8c404cCompareOctober 21, 2025 22:15
alinaliBQ
alinaliBQ commented Oct 21, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress of addressing comments. The team is still working on improving the subclass logic for separate test fixture (discussion is in #47788)

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@github-actionsgithub-actionsBot added awaiting review Awaiting review awaiting change review Awaiting change review awaiting committer review Awaiting committer review and removed awaiting changes Awaiting changes awaiting review Awaiting review awaiting change review Awaiting change review labels Oct 21, 2025
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e8c404c to c6c5af9CompareOctober 22, 2025 23:01
alinaliBQ
alinaliBQ commented Oct 22, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
lidavidm
lidavidm approved these changes Oct 23, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@lidavidmlidavidmOct 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EXPECT_FALSE

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 23, 2025
alinaliBQ
alinaliBQ commented Oct 23, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment •
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, please note that the tests in this PR requires connectivity support implementation (I will raise the PR for connectivity after #47760 is merged) in order to pass.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from c6c5af9 to 2332bdaCompareOctober 23, 2025 19:00
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from 2332bda to e5705e7CompareNovember 14, 2025 23:39
@alinaliBQ
alinaliBQ marked this pull request as ready for review November 14, 2025 23:39
@lidavidm

lidavidm commented Nov 28, 2025

Copy link
Copy Markdown
Member

@alinaliBQ can you resolve conflicts?

@alinaliBQ@justing-bq
Extract Implementation for SQLGetConnectAttr and SQLSetConnectAttr
23b8689
Use `EXPECT_FALSE`
Remove `using List`
Rebase from `master`
Work on code review comments
Add tests for connection attribute
Co-Authored-By: justing-bq <justin.gossett@improving.com>
Co-Authored-By: alinalibq <alina.li@improving.com>
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e5705e7 to 23b8689CompareNovember 28, 2025 22:15
@alinaliBQ

alinaliBQ commented Nov 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm Thank you for the ping, rebased and resolved conflict

@lidavidm
lidavidm merged commit 95cdc0c into apache:mainNov 30, 2025
45 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Nov 30, 2025
@lidavidmlidavidm mentioned this pull request Nov 30, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Nov 30, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 95cdc0c.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@alinaliBQ@Mottl
apacheGH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC (
9972c60
apache#47772)
### Rationale for this change
Add connection attribute support for ODBC driver.
### What changes are included in this PR?
- Implementation of `SQLGetConnectAttr` and `SQLSetConnectAttr` to get and set connection attributes
- Tests
### Are these changes tested?
Tested on local MSVC
### Are there any user-facing changes?
No
* GitHub Issue: apache#47708
Authored-by: Alina (Xi) Li <alina.li@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@lidavidmlidavidmlidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ@kou@lidavidm
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC - #47772

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr
Nov 30, 2025
Merged

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC#47772
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr

Conversation

@alinaliBQ

@alinaliBQalinaliBQ commented Oct 9, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

Add connection attribute support for ODBC driver.

What changes are included in this PR?

  • Implementation of SQLGetConnectAttr and SQLSetConnectAttr to get and set connection attributes
  • Tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

No

@github-actions

github-actionsBot commented Oct 9, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47708has been automatically assigned in GitHub to PR creator.

@alinaliBQ

alinaliBQ commented Oct 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Please review this draft ODBC API PR, thanks. The testing folder structure will be in a separate PR

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Oct 9, 2025
lidavidm
lidavidm reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 10, 2025
kou
kou reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@koukouOct 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetUp() as David commented in other PR?

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@kou

kou commented Oct 10, 2025

Copy link
Copy Markdown
Member

Could you create new draft PRs after you complete other draft PRs to reflect comments in other draft PRs?

@alinaliBQ

alinaliBQ commented Oct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Sure, will check the general comments first before creating new PRs. I will put the PRs to a pause for now since the comments are similar. Thanks for letting me know

@alinaliBQalinaliBQ mentioned this pull request Oct 10, 2025
Open
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from af5de2e to e8c404cCompareOctober 21, 2025 22:15
alinaliBQ
alinaliBQ commented Oct 21, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress of addressing comments. The team is still working on improving the subclass logic for separate test fixture (discussion is in #47788)

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@github-actionsgithub-actionsBot added awaiting review Awaiting review awaiting change review Awaiting change review awaiting committer review Awaiting committer review and removed awaiting changes Awaiting changes awaiting review Awaiting review awaiting change review Awaiting change review labels Oct 21, 2025
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e8c404c to c6c5af9CompareOctober 22, 2025 23:01
alinaliBQ
alinaliBQ commented Oct 22, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
lidavidm
lidavidm approved these changes Oct 23, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@lidavidmlidavidmOct 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EXPECT_FALSE

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 23, 2025
alinaliBQ
alinaliBQ commented Oct 23, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment •
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, please note that the tests in this PR requires connectivity support implementation (I will raise the PR for connectivity after #47760 is merged) in order to pass.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from c6c5af9 to 2332bdaCompareOctober 23, 2025 19:00
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from 2332bda to e5705e7CompareNovember 14, 2025 23:39
@alinaliBQ
alinaliBQ marked this pull request as ready for review November 14, 2025 23:39
@lidavidm

lidavidm commented Nov 28, 2025

Copy link
Copy Markdown
Member

@alinaliBQ can you resolve conflicts?

@alinaliBQ@justing-bq
Extract Implementation for SQLGetConnectAttr and SQLSetConnectAttr
23b8689
Use `EXPECT_FALSE`
Remove `using List`
Rebase from `master`
Work on code review comments
Add tests for connection attribute
Co-Authored-By: justing-bq <justin.gossett@improving.com>
Co-Authored-By: alinalibq <alina.li@improving.com>
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e5705e7 to 23b8689CompareNovember 28, 2025 22:15
@alinaliBQ

alinaliBQ commented Nov 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm Thank you for the ping, rebased and resolved conflict

@lidavidm
lidavidm merged commit 95cdc0c into apache:mainNov 30, 2025
45 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Nov 30, 2025
@lidavidmlidavidm mentioned this pull request Nov 30, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Nov 30, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 95cdc0c.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@alinaliBQ@Mottl
apacheGH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC (
9972c60
apache#47772)
### Rationale for this change
Add connection attribute support for ODBC driver.
### What changes are included in this PR?
- Implementation of `SQLGetConnectAttr` and `SQLSetConnectAttr` to get and set connection attributes
- Tests
### Are these changes tested?
Tested on local MSVC
### Are there any user-facing changes?
No
* GitHub Issue: apache#47708
Authored-by: Alina (Xi) Li <alina.li@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@lidavidmlidavidmlidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ@kou@lidavidm
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC - #47772

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr
Nov 30, 2025
Merged

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC#47772
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr

Conversation

@alinaliBQ

@alinaliBQalinaliBQ commented Oct 9, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

Add connection attribute support for ODBC driver.

What changes are included in this PR?

  • Implementation of SQLGetConnectAttr and SQLSetConnectAttr to get and set connection attributes
  • Tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

No

@github-actions

github-actionsBot commented Oct 9, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47708has been automatically assigned in GitHub to PR creator.

@alinaliBQ

alinaliBQ commented Oct 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Please review this draft ODBC API PR, thanks. The testing folder structure will be in a separate PR

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Oct 9, 2025
lidavidm
lidavidm reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 10, 2025
kou
kou reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@koukouOct 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetUp() as David commented in other PR?

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@kou

kou commented Oct 10, 2025

Copy link
Copy Markdown
Member

Could you create new draft PRs after you complete other draft PRs to reflect comments in other draft PRs?

@alinaliBQ

alinaliBQ commented Oct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Sure, will check the general comments first before creating new PRs. I will put the PRs to a pause for now since the comments are similar. Thanks for letting me know

@alinaliBQalinaliBQ mentioned this pull request Oct 10, 2025
Open
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from af5de2e to e8c404cCompareOctober 21, 2025 22:15
alinaliBQ
alinaliBQ commented Oct 21, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress of addressing comments. The team is still working on improving the subclass logic for separate test fixture (discussion is in #47788)

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@github-actionsgithub-actionsBot added awaiting review Awaiting review awaiting change review Awaiting change review awaiting committer review Awaiting committer review and removed awaiting changes Awaiting changes awaiting review Awaiting review awaiting change review Awaiting change review labels Oct 21, 2025
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e8c404c to c6c5af9CompareOctober 22, 2025 23:01
alinaliBQ
alinaliBQ commented Oct 22, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
lidavidm
lidavidm approved these changes Oct 23, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@lidavidmlidavidmOct 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EXPECT_FALSE

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 23, 2025
alinaliBQ
alinaliBQ commented Oct 23, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment •
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, please note that the tests in this PR requires connectivity support implementation (I will raise the PR for connectivity after #47760 is merged) in order to pass.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from c6c5af9 to 2332bdaCompareOctober 23, 2025 19:00
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from 2332bda to e5705e7CompareNovember 14, 2025 23:39
@alinaliBQ
alinaliBQ marked this pull request as ready for review November 14, 2025 23:39
@lidavidm

lidavidm commented Nov 28, 2025

Copy link
Copy Markdown
Member

@alinaliBQ can you resolve conflicts?

@alinaliBQ@justing-bq
Extract Implementation for SQLGetConnectAttr and SQLSetConnectAttr
23b8689
Use `EXPECT_FALSE`
Remove `using List`
Rebase from `master`
Work on code review comments
Add tests for connection attribute
Co-Authored-By: justing-bq <justin.gossett@improving.com>
Co-Authored-By: alinalibq <alina.li@improving.com>
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e5705e7 to 23b8689CompareNovember 28, 2025 22:15
@alinaliBQ

alinaliBQ commented Nov 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm Thank you for the ping, rebased and resolved conflict

@lidavidm
lidavidm merged commit 95cdc0c into apache:mainNov 30, 2025
45 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Nov 30, 2025
@lidavidmlidavidm mentioned this pull request Nov 30, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Nov 30, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 95cdc0c.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@alinaliBQ@Mottl
apacheGH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC (
9972c60
apache#47772)
### Rationale for this change
Add connection attribute support for ODBC driver.
### What changes are included in this PR?
- Implementation of `SQLGetConnectAttr` and `SQLSetConnectAttr` to get and set connection attributes
- Tests
### Are these changes tested?
Tested on local MSVC
### Are there any user-facing changes?
No
* GitHub Issue: apache#47708
Authored-by: Alina (Xi) Li <alina.li@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@lidavidmlidavidmlidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ@kou@lidavidm
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC - #47772

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr
Nov 30, 2025
Merged

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC#47772
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr

Conversation

@alinaliBQ

@alinaliBQalinaliBQ commented Oct 9, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

Add connection attribute support for ODBC driver.

What changes are included in this PR?

  • Implementation of SQLGetConnectAttr and SQLSetConnectAttr to get and set connection attributes
  • Tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

No

@github-actions

github-actionsBot commented Oct 9, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47708has been automatically assigned in GitHub to PR creator.

@alinaliBQ

alinaliBQ commented Oct 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Please review this draft ODBC API PR, thanks. The testing folder structure will be in a separate PR

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Oct 9, 2025
lidavidm
lidavidm reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 10, 2025
kou
kou reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@koukouOct 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetUp() as David commented in other PR?

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@kou

kou commented Oct 10, 2025

Copy link
Copy Markdown
Member

Could you create new draft PRs after you complete other draft PRs to reflect comments in other draft PRs?

@alinaliBQ

alinaliBQ commented Oct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Sure, will check the general comments first before creating new PRs. I will put the PRs to a pause for now since the comments are similar. Thanks for letting me know

@alinaliBQalinaliBQ mentioned this pull request Oct 10, 2025
Open
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from af5de2e to e8c404cCompareOctober 21, 2025 22:15
alinaliBQ
alinaliBQ commented Oct 21, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress of addressing comments. The team is still working on improving the subclass logic for separate test fixture (discussion is in #47788)

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@github-actionsgithub-actionsBot added awaiting review Awaiting review awaiting change review Awaiting change review awaiting committer review Awaiting committer review and removed awaiting changes Awaiting changes awaiting review Awaiting review awaiting change review Awaiting change review labels Oct 21, 2025
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e8c404c to c6c5af9CompareOctober 22, 2025 23:01
alinaliBQ
alinaliBQ commented Oct 22, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
lidavidm
lidavidm approved these changes Oct 23, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@lidavidmlidavidmOct 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EXPECT_FALSE

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 23, 2025
alinaliBQ
alinaliBQ commented Oct 23, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment •
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, please note that the tests in this PR requires connectivity support implementation (I will raise the PR for connectivity after #47760 is merged) in order to pass.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from c6c5af9 to 2332bdaCompareOctober 23, 2025 19:00
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from 2332bda to e5705e7CompareNovember 14, 2025 23:39
@alinaliBQ
alinaliBQ marked this pull request as ready for review November 14, 2025 23:39
@lidavidm

lidavidm commented Nov 28, 2025

Copy link
Copy Markdown
Member

@alinaliBQ can you resolve conflicts?

@alinaliBQ@justing-bq
Extract Implementation for SQLGetConnectAttr and SQLSetConnectAttr
23b8689
Use `EXPECT_FALSE`
Remove `using List`
Rebase from `master`
Work on code review comments
Add tests for connection attribute
Co-Authored-By: justing-bq <justin.gossett@improving.com>
Co-Authored-By: alinalibq <alina.li@improving.com>
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e5705e7 to 23b8689CompareNovember 28, 2025 22:15
@alinaliBQ

alinaliBQ commented Nov 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm Thank you for the ping, rebased and resolved conflict

@lidavidm
lidavidm merged commit 95cdc0c into apache:mainNov 30, 2025
45 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Nov 30, 2025
@lidavidmlidavidm mentioned this pull request Nov 30, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Nov 30, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 95cdc0c.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@alinaliBQ@Mottl
apacheGH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC (
9972c60
apache#47772)
### Rationale for this change
Add connection attribute support for ODBC driver.
### What changes are included in this PR?
- Implementation of `SQLGetConnectAttr` and `SQLSetConnectAttr` to get and set connection attributes
- Tests
### Are these changes tested?
Tested on local MSVC
### Are there any user-facing changes?
No
* GitHub Issue: apache#47708
Authored-by: Alina (Xi) Li <alina.li@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@lidavidmlidavidmlidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ@kou@lidavidm
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC - #47772

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr
Nov 30, 2025
Merged

GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC#47772
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47708-sql-connect-attr

Conversation

@alinaliBQ

@alinaliBQalinaliBQ commented Oct 9, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

Add connection attribute support for ODBC driver.

What changes are included in this PR?

  • Implementation of SQLGetConnectAttr and SQLSetConnectAttr to get and set connection attributes
  • Tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

No

@github-actions

github-actionsBot commented Oct 9, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47708has been automatically assigned in GitHub to PR creator.

@alinaliBQ

alinaliBQ commented Oct 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Please review this draft ODBC API PR, thanks. The testing folder structure will be in a separate PR

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label Oct 9, 2025
lidavidm
lidavidm reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 10, 2025
kou
kou reviewed Oct 10, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@koukouOct 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetUp() as David commented in other PR?

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@kou

kou commented Oct 10, 2025

Copy link
Copy Markdown
Member

Could you create new draft PRs after you complete other draft PRs to reflect comments in other draft PRs?

@alinaliBQ

alinaliBQ commented Oct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm@kou Sure, will check the general comments first before creating new PRs. I will put the PRs to a pause for now since the comments are similar. Thanks for letting me know

@alinaliBQalinaliBQ mentioned this pull request Oct 10, 2025
Open
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from af5de2e to e8c404cCompareOctober 21, 2025 22:15
alinaliBQ
alinaliBQ commented Oct 21, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress of addressing comments. The team is still working on improving the subclass logic for separate test fixture (discussion is in #47788)

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated

#ifdef SQL_ATTR_ASYNC_DBC_EVENT
TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) {
this->Connect();

@alinaliBQalinaliBQOct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this->Connect() from tests. we will move it to SetUp

@github-actionsgithub-actionsBot added awaiting review Awaiting review awaiting change review Awaiting change review awaiting committer review Awaiting committer review and removed awaiting changes Awaiting changes awaiting review Awaiting review awaiting change review Awaiting change review labels Oct 21, 2025
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e8c404c to c6c5af9CompareOctober 22, 2025 23:01
alinaliBQ
alinaliBQ commented Oct 22, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc
lidavidm
lidavidm approved these changes Oct 23, 2025
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@lidavidmlidavidmOct 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EXPECT_FALSE

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 23, 2025
alinaliBQ
alinaliBQ commented Oct 23, 2025
View reviewed changes

@alinaliBQalinaliBQ left a comment •
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, please note that the tests in this PR requires connectivity support implementation (I will raise the PR for connectivity after #47760 is merged) in order to pass.

Comment threadcpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc Outdated
out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize();
std::string out_connection_string =
ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len));
EXPECT_TRUE(!out_connection_string.empty());

@alinaliBQalinaliBQOct 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from c6c5af9 to 2332bdaCompareOctober 23, 2025 19:00
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from 2332bda to e5705e7CompareNovember 14, 2025 23:39
@alinaliBQ
alinaliBQ marked this pull request as ready for review November 14, 2025 23:39
@lidavidm

lidavidm commented Nov 28, 2025

Copy link
Copy Markdown
Member

@alinaliBQ can you resolve conflicts?

@alinaliBQ@justing-bq
Extract Implementation for SQLGetConnectAttr and SQLSetConnectAttr
23b8689
Use `EXPECT_FALSE`
Remove `using List`
Rebase from `master`
Work on code review comments
Add tests for connection attribute
Co-Authored-By: justing-bq <justin.gossett@improving.com>
Co-Authored-By: alinalibq <alina.li@improving.com>
@alinaliBQ
alinaliBQforce-pushed the gh-47708-sql-connect-attr branch from e5705e7 to 23b8689CompareNovember 28, 2025 22:15
@alinaliBQ

alinaliBQ commented Nov 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lidavidm Thank you for the ping, rebased and resolved conflict

@lidavidm
lidavidm merged commit 95cdc0c into apache:mainNov 30, 2025
45 checks passed
@lidavidmlidavidm removed the awaiting merge Awaiting merge label Nov 30, 2025
@lidavidmlidavidm mentioned this pull request Nov 30, 2025
Closed
@conbench-apache-arrow

conbench-apache-arrowBot commented Nov 30, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 95cdc0c.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@alinaliBQ@Mottl
apacheGH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC (
9972c60
apache#47772)
### Rationale for this change
Add connection attribute support for ODBC driver.
### What changes are included in this PR?
- Implementation of `SQLGetConnectAttr` and `SQLSetConnectAttr` to get and set connection attributes
- Tests
### Are these changes tested?
Tested on local MSVC
### Are there any user-facing changes?
No
* GitHub Issue: apache#47708
Authored-by: Alina (Xi) Li <alina.li@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments
@lidavidmlidavidmlidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ@kou@lidavidm