Uh oh!
There was an error while loading. Please reload this page.
GH-47710: [C++][FlightRPC] Statement attribute Support in ODBC - #47773
Merged
Conversation
alinaliBQ
commented
Oct 9, 2025
CollaboratorAuthor
lidavidm
left a comment
Member
There was a problem hiding this comment.
Same general comments as the other PRs.
alinaliBQforce-pushed
the
gh-47710-sql-stmt-attr
branch
from
October 21, 2025 22:30
42f4f14 to
1e025c7ComparealinaliBQ
commented
Oct 21, 2025
CollaboratorAuthor
we worked on:
|
alinaliBQforce-pushed
the
gh-47710-sql-stmt-attr
branch
from
October 22, 2025 23:07
1e025c7 to
be51a05ComparealinaliBQ
commented
Oct 22, 2025
CollaboratorAuthor
Rebased on top of |
Comment on lines
+39
to
+52
| namespace { | ||
| // Helper Functions | ||
| // Validate SQLULEN return value | ||
| void ValidateGetStmtAttr(SQLHSTMT statement, SQLINTEGER attribute, | ||
| SQLULEN expected_value) { | ||
| SQLULEN value = 0; | ||
| SQLINTEGER string_length = 0; | ||
| ASSERT_EQ(SQL_SUCCESS, | ||
| SQLGetStmtAttr(statement, attribute, &value, sizeof(value), &string_length)); | ||
| EXPECT_EQ(expected_value, value); | ||
| } |
Member
There was a problem hiding this comment.
Instead of having variants for each type of comparison (equal, greater than, etc.) wouldn't it be better to just have a getter for each type, and keep the assertion in the tests themselves? (It could throw on failure, for instance, to keep the signature simple.)
CollaboratorAuthor
There was a problem hiding this comment.
Yea that makes sense. I added getters, please let me know what you think
alinaliBQforce-pushed
the
gh-47710-sql-stmt-attr
branch
from
October 28, 2025 21:55
be51a05 to
aebac29ComparealinaliBQ
commented
Oct 28, 2025
alinaliBQ
left a comment
CollaboratorAuthor
There was a problem hiding this comment.
worked on comment
Comment on lines
+39
to
+52
| namespace { | ||
| // Helper Functions | ||
| // Validate SQLULEN return value | ||
| void ValidateGetStmtAttr(SQLHSTMT statement, SQLINTEGER attribute, | ||
| SQLULEN expected_value) { | ||
| SQLULEN value = 0; | ||
| SQLINTEGER string_length = 0; | ||
| ASSERT_EQ(SQL_SUCCESS, | ||
| SQLGetStmtAttr(statement, attribute, &value, sizeof(value), &string_length)); | ||
| EXPECT_EQ(expected_value, value); | ||
| } |
CollaboratorAuthor
There was a problem hiding this comment.
Yea that makes sense. I added getters, please let me know what you think
lidavidm
approved these changes
Oct 31, 2025
alinaliBQforce-pushed
the
gh-47710-sql-stmt-attr
branch
from
November 14, 2025 23:06
0675c21 to
bafe934ComparealinaliBQ
marked this pull request as ready for review
November 14, 2025 23:06
Co-Authored-By: rscales <robscales@icloud.com>
Add tests for setting and getting statement attributes Co-Authored-By: rscales <robscales@icloud.com>
- use `platform.h` - move `connect/disconnect` to `setup/teardown` - in-progress on subclassing test fixture Co-authored-by: justing-bq <justin.gossett@improving.com> Co-authored-by: alinalibq <alina.li@improving.com>
- remove `using List = std::list<T>;`
alinaliBQforce-pushed
the
gh-47710-sql-stmt-attr
branch
from
November 20, 2025 22:04
bafe934 to
501eab7Comparelidavidm
approved these changes
Nov 21, 2025
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 430d4b1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…pache#47773) ### Rationale for this change Support for getting and setting statement attributes in ODBC is added. ### What changes are included in this PR? - Implementation of `SQLGetStmtAttr` and `SQLSetStmtAttr` to get and set statement attributes. - Tests ### Are these changes tested? Tested on local MSVC ### Are there any user-facing changes? No * GitHub Issue: apache#47710 Lead-authored-by: Alina (Xi) Li <alina.li@improving.com> Co-authored-by: alinalibq <alina.li@improving.com> Co-authored-by: justing-bq <justin.gossett@improving.com> Signed-off-by: David Li <li.davidm96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Support for getting and setting statement attributes in ODBC is added.
What changes are included in this PR?
SQLGetStmtAttrandSQLSetStmtAttrto get and set statement attributes.Are these changes tested?
Tested on local MSVC
Are there any user-facing changes?
No