Uh oh!
There was an error while loading. Please reload this page.
GH-47840: [CI][C++] Check whether the CSV module/thread sanitizer is enabled or not before building example - #47841
Merged
Conversation
kou
commented
Oct 17, 2025
MemberAuthor
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
…not before building example `cpp/examples/minimal_build/` needs the CSV module.
kouforce-pushed
the
ci-cpp-test-build-example
branch
from
October 17, 2025 02:52
fa216d9 to
41742d9Comparekou
commented
Oct 17, 2025
MemberAuthor
@github-actions crossbow submit -g cpp |
Revision: 41742d9 Submitted crossbow builds: ursacomputing/crossbow @ actions-07b686f904
|
raulcd
approved these changes
Oct 17, 2025
raulcd
left a comment
Member
There was a problem hiding this comment.
LGTM, builds that were failing, test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 and test-ubuntu-24.04-cpp-thread-sanitizer, are passing now :)
Uh oh!
There was an error while loading. Please reload this page.
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bab5580. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
zanmato1984 pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Nov 5, 2025
…er is enabled or not before building example (apache#47841) ### Rationale for this change `cpp/examples/minimal_build/` needs the CSV module. We need additional flags for thread sanitizer. ### What changes are included in this PR? * Check whether `ARROW_CSV` is enabled. * Check whether thread sanitizer is enabled. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#47840 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…er is enabled or not before building example (apache#47841) ### Rationale for this change `cpp/examples/minimal_build/` needs the CSV module. We need additional flags for thread sanitizer. ### What changes are included in this PR? * Check whether `ARROW_CSV` is enabled. * Check whether thread sanitizer is enabled. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#47840 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
cpp/examples/minimal_build/needs the CSV module.We need additional flags for thread sanitizer.
What changes are included in this PR?
ARROW_CSVis enabled.Are these changes tested?
Yes.
Are there any user-facing changes?
No.