Uh oh!
There was an error while loading. Please reload this page.
GH-44248: [Format] Add TimestampWithOffset canonical extension type - #48002
Conversation
14fd59a to
fe8056fCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
d40c0bb to
b0d9be3Compare6ab0deb to
d4d50b3CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Drop JSON encoding recommendation - Inner fields must be non-nullble - Time unit is not a type parameter
Uh oh!
There was an error while loading. Please reload this page.
alamb
left a comment
There was a problem hiding this comment.
Thanks for this PR @serramatutu -- the basic idea looks good to me
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b10386e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. |
# Which issue does this PR close? Implement `arrow.timestamp_with_offset` canonical extension type. # Rationale for this change Be compliant with Arrow spec: apache/arrow#48002 # What changes are included in this PR? This commit adds a new `TimestampWithOffset` extension type. This type represents a timestamp column that stores potentially different timezone offsets per value. The timestamp is stored in UTC alongside the original timezone offset in minutes. # Are these changes tested? Yes. # Are there any user-facing changes? Yes, this is a new canonical extension type.
# Which issue does this PR close? Implement `arrow.timestamp_with_offset` canonical extension type. # Rationale for this change Be compliant with Arrow spec: apache/arrow#48002 # What changes are included in this PR? This commit adds a new `TimestampWithOffset` extension type. This type represents a timestamp column that stores potentially different timezone offsets per value. The timestamp is stored in UTC alongside the original timezone offset in minutes. # Are these changes tested? Yes. # Are there any user-facing changes? Yes, this is a new canonical extension type.
…type (apache#48002) ### Rationale for this change Closesapache#44248 Arrow has no built-in canonical way of representing the `TIMESTAMP WITH TIME ZONE` SQL type, which is present across multiple different database systems. Not having a native way to represent this forces users to either convert to UTC and drop the time zone, which may have correctness implications, or use bespoke workarounds. A new `arrow.timestamp_with_offset` extension type would introduce a standard canonical way of representing that information. Rust implementation: apache/arrow-rs#8743 Go implementation: apache/arrow-go#558 [DISCUSS] [thread in the mailing list](https://lists.apache.org/thread/yhbr3rj9l59yoxv92o2s6dqlop16sfnk). ### What changes are included in this PR? Proposal and documentation for `arrow.timestamp_with_offset` canonical extension type. ### Are these changes tested? N/A ### Are there any user-facing changes? Yes, this is an extension to the arrow format. * GitHub Issue: apache#44248 --------- Co-authored-by: David Li <li.davidm96@gmail.com> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Co-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Rationale for this change
Closes#44248
Arrow has no built-in canonical way of representing the
TIMESTAMP WITH TIME ZONESQL type, which is present across multiple different database systems. Not having a native way to represent this forces users to either convert to UTC and drop the time zone, which may have correctness implications, or use bespoke workarounds. A newarrow.timestamp_with_offsetextension type would introduce a standard canonical way of representing that information.Rust implementation: apache/arrow-rs#8743
Go implementation: apache/arrow-go#558
[DISCUSS] thread in the mailing list.
What changes are included in this PR?
Proposal and documentation for
arrow.timestamp_with_offsetcanonical extension type.Are these changes tested?
N/A
Are there any user-facing changes?
Yes, this is an extension to the arrow format.