Uh oh!
There was an error while loading. Please reload this page.
GH-47719: [C++][FlightRPC] Extract SQLTables Implementation - #48021
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
Uh oh!
There was an error while loading. Please reload this page.
| namespace { | ||
| // Helper Functions | ||
| std::wstring GetStringColumnW(SQLHSTMT stmt, int colId) { |
There was a problem hiding this comment.
we might consider moving this GetStringColumnW to a more accessible place shared by all tests
There was a problem hiding this comment.
Moved to odbc_test_suite.
justing-bq
commented
Nov 5, 2025
@lidavidm Could we get a review? Thanks. |
alinaliBQ
commented
Dec 6, 2025
I have rebased and tested the changes locally on MSVC |
| // Values are nulls | ||
| EXPECT_EQ(SQL_SUCCESS, | ||
| SQLTables(this->stmt, 0, sizeof(catalog_name), 0, sizeof(schema_name), 0, | ||
| sizeof(table_name), 0, sizeof(table_type))); |
There was a problem hiding this comment.
Same here, let's be explicit with nullptr instead of 0
| // All values and sizes are nulls | ||
| EXPECT_EQ(SQL_SUCCESS, SQLTables(this->stmt, 0, 0, 0, 0, 0, 0, 0, 0)); |
There was a problem hiding this comment.
fixed. Btw the sizes are supposed to be zeros instead of nulls, I have fixed the comment also
Co-authored-by: justing-bq <justin.gossett@improving.com> Co-authored-by: alinalibq <alina.li@improving.com> Co-Authored-By: rscales <robscales@icloud.com>
Address comment from David
alinaliBQ
left a comment
There was a problem hiding this comment.
Addressed comments from David. I will also check nullptr usages in other open PRs
| // Values are nulls | ||
| EXPECT_EQ(SQL_SUCCESS, | ||
| SQLTables(this->stmt, 0, sizeof(catalog_name), 0, sizeof(schema_name), 0, | ||
| sizeof(table_name), 0, sizeof(table_type))); |
| // All values and sizes are nulls | ||
| EXPECT_EQ(SQL_SUCCESS, SQLTables(this->stmt, 0, 0, 0, 0, 0, 0, 0, 0)); |
There was a problem hiding this comment.
fixed. Btw the sizes are supposed to be zeros instead of nulls, I have fixed the comment also
Uh oh!
There was an error while loading. Please reload this page.
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit cb31765. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…ache#48021) ### Rationale for this change Addresses apache#47719 ### What changes are included in this PR? SQLTables enabled. Table tests added. ### Are these changes tested? Tested locally on MSVC. ### Are there any user-facing changes? No. * GitHub Issue: apache#47719 Lead-authored-by: Alina (Xi) Li <alina.li@improving.com> Co-authored-by: justing-bq <justin.gossett@improving.com> Co-authored-by: alinalibq <alina.li@improving.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Rationale for this change
Addresses #47719
What changes are included in this PR?
SQLTables enabled. Table tests added.
Are these changes tested?
Tested locally on MSVC.
Are there any user-facing changes?
No.