Uh oh!
There was an error while loading. Please reload this page.
GH-47713: [C++][FlightRPC] ODBC return number of affected rows - #48037
Merged
Conversation
alinaliBQforce-pushed
the
gh-47713-sql-row-count
branch
from
November 10, 2025 19:43
4fcdc67 to
2120315ComparealinaliBQ
commented
Nov 12, 2025
CollaboratorAuthor
@lidavidm this draft PR is ready for review! Please have a look |
lidavidm
approved these changes
Nov 28, 2025
alinaliBQforce-pushed
the
gh-47713-sql-row-count
branch
from
December 3, 2025 23:02
2120315 to
67db4e7Comparelidavidm
reviewed
Dec 4, 2025
| CheckStringColumnW(this->stmt, 2, L"One"); | ||
| CheckIntColumn(this->stmt, 3, 3); | ||
| ASSERT_EQ(SQL_SUCCESS, SQLRowCount(this->stmt, 0)); |
Member
There was a problem hiding this comment.
nit, but can we write nullptr for nullptr and not use 0?
alinaliBQforce-pushed
the
gh-47713-sql-row-count
branch
from
December 4, 2025 21:10
67db4e7 to
b22c359CompareUpdate doc Co-Authored-By: alinalibq <alina.li@improving.com>
alinaliBQforce-pushed
the
gh-47713-sql-row-count
branch
from
December 6, 2025 00:24
b22c359 to
aed5b0eComparealinaliBQ
marked this pull request as ready for review
December 6, 2025 00:24
lidavidm
approved these changes
Dec 8, 2025
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 082377a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…pache#48037) ### Rationale for this change Make ODBC return number of affected rows as -1 which to BI tools means number of affected rows is unknown. This is because ODBC only supports `select` statement and doesn't support queries that affect rows. ### What changes are included in this PR? - SQLRowCount & tests ### Are these changes tested? Tested locally on MSVC ### Are there any user-facing changes? N/A * GitHub Issue: apache#47713 Authored-by: Alina (Xi) Li <alina.li@improving.com> Signed-off-by: David Li <li.davidm96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Make ODBC return number of affected rows as -1 which to BI tools means number of affected rows is unknown. This is because ODBC only supports
selectstatement and doesn't support queries that affect rows.What changes are included in this PR?
Are these changes tested?
Tested locally on MSVC
Are there any user-facing changes?
N/A