ARROW-5861: [Java] Initial implement to convert Avro record with primitive types - #4812

Closed
tianchen92 wants to merge 5 commits into
apache:masterfrom
tianchen92:ARROW-5861
Closed

ARROW-5861: [Java] Initial implement to convert Avro record with primitive types#4812
tianchen92 wants to merge 5 commits into
apache:masterfrom
tianchen92:ARROW-5861

Conversation

@tianchen92

@tianchen92tianchen92 commented Jul 5, 2019

Copy link
Copy Markdown
Contributor

Related to ARROW-5861.
Initial implement to support convert Avro record with primitive types to Arrow objects.

emkornfield
emkornfield reviewed Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
emkornfield
emkornfield requested changes Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
@codecov-io

codecov-io commented Jul 6, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4812 into master will increase coverage by 2.16%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #4812 +/- ##
==========================================
+ Coverage 87.42% 89.58% +2.16% 
==========================================
Files 994 661 -333 Lines 140102 96617 -43485 Branches 1418 0 -1418 ==========================================
- Hits 122481 86557 -35924 + Misses 17259 10060 -7199 + Partials 362 0 -362
Impacted FilesCoverage Δ
cpp/src/gandiva/precompiled/decimal_ops.cc97.17% <0%> (ø)⬆️
cpp/src/gandiva/precompiled/decimal_ops_test.cc97.43% <0%> (ø)⬆️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
... and 327 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c350bba...2439478. Read the comment docs.

emkornfield
emkornfield reviewed Jul 9, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java Outdated
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroStringConsumer.java Outdated
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/test/java/org/apache/arrow/AvroToArrowTest.java Outdated
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java Outdated
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated

allocateVectors(root, DEFAULT_BUFFER_SIZE);

List<Consumer> consumers = createAvroConsumers(root);

@emkornfieldemkornfieldJul 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we might need to understand more about decoders and the order they are expected to [decode(https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/io/ValidatingDecoder.html) in. This can also be for a follow-up PR

emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
emkornfield
emkornfield reviewed Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroBytesConsumer.java
@Override
public void consume(Decoder decoder) throws IOException {
VarBinaryHolder holder = new VarBinaryHolder();
ByteBuffer byteBuffer = decoder.readBytes(null);

@emkornfieldemkornfieldJul 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep a cached byte buffer for values below a certain size.

Even better would be if we could create a ByteBuffer that wraps the Vector and puts bytes directly where they need to go. This can be done in a separate PR.

@emkornfieldemkornfieldJul 16, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the first part of my comment (caching a ByteBuffer instead of creating a new one each time)?

Otherwise LGTM as start. @tianchen92

@tianchen92tianchen92Jul 16, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a new JIRA to address this, thanks!

emkornfield
emkornfield requested changes Jul 13, 2019
View reviewed changes

@emkornfieldemkornfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up

@tianchen92

tianchen92 commented Jul 13, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up

Many thanks for your feedback :), revise would be provided later.

@tianchen92

tianchen92 commented Jul 18, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@emkornfield Hi, Micah, could we get this PR merged? thanks :)
BTW, ask an unrelated question, seems theres no adapter to read csv to ARROW in Java which C++ has, is it necessary to implement it ？

And in the follow PR, I resolve most the comments and still have few questions, would you mind explaining a lot? thanks a lot!
#4846

emkornfield
emkornfield reviewed Jul 18, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java Outdated
import org.apache.avro.Schema.Type;
import org.apache.avro.io.Decoder;

import sun.reflect.generics.reflectiveObjects.NotImplementedException;

@emkornfieldemkornfieldJul 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed this, we should be using https://docs.oracle.com/javase/6/docs/api/java/lang/UnsupportedOperationException.html

@tianchen92tianchen92Jul 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks! hope could merge soon then I could start follow-up works

@emkornfield

emkornfield commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.

@tianchen92

tianchen92 commented Jul 18, 2019

Copy link
Copy Markdown
ContributorAuthor

An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.

Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.

@emkornfield

emkornfield commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.

Seems reasonable to me. Please ask on the mailing list in case anyone else has input.

@tianchen92

tianchen92 commented Jul 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.

Seems reasonable to me. Please ask on the mailing list in case anyone else has input.

Thanks for your effort, I will start discuss later :)

@tianchen92

tianchen92 commented Jul 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@emkornfield Build passed :)

@emkornfield

emkornfield commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

+1, thank you.

kszucs pushed a commit that referenced this pull request Jul 22, 2019
tianchen@kszucs
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
e415bd3
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closes#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
@asfimportasfimport mentioned this pull request Aug 1, 2019
Closed
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
tianchen@kou
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
2bb6a0a
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closesapache#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emkornfieldemkornfieldemkornfield requested changes

Assignees

No one assigned

Labels

Component: Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tianchen92@codecov-io@emkornfield@fsaintjacques
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types - #4812
Closed
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Closed
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types#4812
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Conversation
@tianchen92
@tianchen92tianchen92
commented
Jul 5, 2019

Copy link


Copy Markdown

Contributor
Related to ARROW-5861.

Initial implement to support convert Avro record with primitive types to Arrow objects.
emkornfield
emkornfield
reviewed
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
requested changes
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

@codecov-io
codecov-io
commented
Jul 6, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4812 into master will increase coverage by 2.16%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4812 +/- ##
==========================================
+ Coverage 87.42% 89.58% +2.16% 
==========================================
Files 994 661 -333 Lines 140102 96617 -43485 Branches 1418 0 -1418 ==========================================
- Hits 122481 86557 -35924 + Misses 17259 10060 -7199 + Partials 362 0 -362
Impacted FilesCoverage Δ
cpp/src/gandiva/precompiled/decimal_ops.cc97.17% <0%> (ø)⬆️
cpp/src/gandiva/precompiled/decimal_ops_test.cc97.43% <0%> (ø)⬆️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
... and 327 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update c350bba...2439478. Read the comment docs.
emkornfield
emkornfield
reviewed
Jul 9, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroStringConsumer.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/test/java/org/apache/arrow/AvroToArrowTest.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated


 allocateVectors(root, DEFAULT_BUFFER_SIZE);

 List<Consumer> consumers = createAvroConsumers(root);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we might need to understand more about decoders and the order they are expected to [decode(https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/io/ValidatingDecoder.html) in. This can also be for a follow-up PR
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroBytesConsumer.java
 @Override
 public void consume(Decoder decoder) throws IOException {
 VarBinaryHolder holder = new VarBinaryHolder();
 ByteBuffer byteBuffer = decoder.readBytes(null);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep a cached byte buffer for values below a certain size.
Even better would be if we could create a ByteBuffer that wraps the Vector and puts bytes directly where they need to go. This can be done in a separate PR.
@emkornfieldemkornfieldJul 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the first part of my comment (caching a ByteBuffer instead of creating a new one each time)?
Otherwise LGTM as start. @tianchen92
@tianchen92tianchen92Jul 16, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a new JIRA to address this, thanks!
emkornfield
emkornfield
requested changes
Jul 13, 2019
View reviewed changes
@emkornfieldemkornfield
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
@tianchen92
tianchen92
commented
Jul 13, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
Many thanks for your feedback :), revise would be provided later.
@tianchen92
tianchen92
commented
Jul 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Hi, Micah, could we get this PR merged? thanks :)

BTW, ask an unrelated question, seems theres no adapter to read csv to ARROW in Java which C++ has, is it necessary to implement it ？
And in the follow PR, I resolve most the comments and still have few questions, would you mind explaining a lot? thanks a lot!
#4846
emkornfield
emkornfield
reviewed
Jul 18, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

import org.apache.avro.Schema.Type;
import org.apache.avro.io.Decoder;

import sun.reflect.generics.reflectiveObjects.NotImplementedException;
@emkornfieldemkornfieldJul 18, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed this, we should be using https://docs.oracle.com/javase/6/docs/api/java/lang/UnsupportedOperationException.html
@tianchen92tianchen92Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks! hope could merge soon then I could start follow-up works
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
Thanks for your effort, I will start discuss later :)
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Build passed :)
@emkornfield
emkornfield
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
+1, thank you.
kszucs pushed a commit
that referenced
this pull request
Jul 22, 2019
tianchen@kszucs
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
e415bd3
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closes#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
tianchen@kou
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
2bb6a0a
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closesapache#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@emkornfieldemkornfieldemkornfield requested changes

Assignees


No one assigned


Labels

Component: Java

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianchen92@codecov-io@emkornfield@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types - #4812
Closed
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Closed
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types#4812
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Conversation
@tianchen92
@tianchen92tianchen92
commented
Jul 5, 2019

Copy link


Copy Markdown

Contributor
Related to ARROW-5861.

Initial implement to support convert Avro record with primitive types to Arrow objects.
emkornfield
emkornfield
reviewed
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
requested changes
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

@codecov-io
codecov-io
commented
Jul 6, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4812 into master will increase coverage by 2.16%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4812 +/- ##
==========================================
+ Coverage 87.42% 89.58% +2.16% 
==========================================
Files 994 661 -333 Lines 140102 96617 -43485 Branches 1418 0 -1418 ==========================================
- Hits 122481 86557 -35924 + Misses 17259 10060 -7199 + Partials 362 0 -362
Impacted FilesCoverage Δ
cpp/src/gandiva/precompiled/decimal_ops.cc97.17% <0%> (ø)⬆️
cpp/src/gandiva/precompiled/decimal_ops_test.cc97.43% <0%> (ø)⬆️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
... and 327 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update c350bba...2439478. Read the comment docs.
emkornfield
emkornfield
reviewed
Jul 9, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroStringConsumer.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/test/java/org/apache/arrow/AvroToArrowTest.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated


 allocateVectors(root, DEFAULT_BUFFER_SIZE);

 List<Consumer> consumers = createAvroConsumers(root);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we might need to understand more about decoders and the order they are expected to [decode(https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/io/ValidatingDecoder.html) in. This can also be for a follow-up PR
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroBytesConsumer.java
 @Override
 public void consume(Decoder decoder) throws IOException {
 VarBinaryHolder holder = new VarBinaryHolder();
 ByteBuffer byteBuffer = decoder.readBytes(null);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep a cached byte buffer for values below a certain size.
Even better would be if we could create a ByteBuffer that wraps the Vector and puts bytes directly where they need to go. This can be done in a separate PR.
@emkornfieldemkornfieldJul 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the first part of my comment (caching a ByteBuffer instead of creating a new one each time)?
Otherwise LGTM as start. @tianchen92
@tianchen92tianchen92Jul 16, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a new JIRA to address this, thanks!
emkornfield
emkornfield
requested changes
Jul 13, 2019
View reviewed changes
@emkornfieldemkornfield
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
@tianchen92
tianchen92
commented
Jul 13, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
Many thanks for your feedback :), revise would be provided later.
@tianchen92
tianchen92
commented
Jul 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Hi, Micah, could we get this PR merged? thanks :)

BTW, ask an unrelated question, seems theres no adapter to read csv to ARROW in Java which C++ has, is it necessary to implement it ？
And in the follow PR, I resolve most the comments and still have few questions, would you mind explaining a lot? thanks a lot!
#4846
emkornfield
emkornfield
reviewed
Jul 18, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

import org.apache.avro.Schema.Type;
import org.apache.avro.io.Decoder;

import sun.reflect.generics.reflectiveObjects.NotImplementedException;
@emkornfieldemkornfieldJul 18, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed this, we should be using https://docs.oracle.com/javase/6/docs/api/java/lang/UnsupportedOperationException.html
@tianchen92tianchen92Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks! hope could merge soon then I could start follow-up works
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
Thanks for your effort, I will start discuss later :)
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Build passed :)
@emkornfield
emkornfield
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
+1, thank you.
kszucs pushed a commit
that referenced
this pull request
Jul 22, 2019
tianchen@kszucs
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
e415bd3
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closes#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
tianchen@kou
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
2bb6a0a
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closesapache#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@emkornfieldemkornfieldemkornfield requested changes

Assignees


No one assigned


Labels

Component: Java

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianchen92@codecov-io@emkornfield@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types - #4812
Closed
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Closed
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types#4812
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Conversation
@tianchen92
@tianchen92tianchen92
commented
Jul 5, 2019

Copy link


Copy Markdown

Contributor
Related to ARROW-5861.

Initial implement to support convert Avro record with primitive types to Arrow objects.
emkornfield
emkornfield
reviewed
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
requested changes
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

@codecov-io
codecov-io
commented
Jul 6, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4812 into master will increase coverage by 2.16%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4812 +/- ##
==========================================
+ Coverage 87.42% 89.58% +2.16% 
==========================================
Files 994 661 -333 Lines 140102 96617 -43485 Branches 1418 0 -1418 ==========================================
- Hits 122481 86557 -35924 + Misses 17259 10060 -7199 + Partials 362 0 -362
Impacted FilesCoverage Δ
cpp/src/gandiva/precompiled/decimal_ops.cc97.17% <0%> (ø)⬆️
cpp/src/gandiva/precompiled/decimal_ops_test.cc97.43% <0%> (ø)⬆️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
... and 327 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update c350bba...2439478. Read the comment docs.
emkornfield
emkornfield
reviewed
Jul 9, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroStringConsumer.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/test/java/org/apache/arrow/AvroToArrowTest.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated


 allocateVectors(root, DEFAULT_BUFFER_SIZE);

 List<Consumer> consumers = createAvroConsumers(root);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we might need to understand more about decoders and the order they are expected to [decode(https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/io/ValidatingDecoder.html) in. This can also be for a follow-up PR
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroBytesConsumer.java
 @Override
 public void consume(Decoder decoder) throws IOException {
 VarBinaryHolder holder = new VarBinaryHolder();
 ByteBuffer byteBuffer = decoder.readBytes(null);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep a cached byte buffer for values below a certain size.
Even better would be if we could create a ByteBuffer that wraps the Vector and puts bytes directly where they need to go. This can be done in a separate PR.
@emkornfieldemkornfieldJul 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the first part of my comment (caching a ByteBuffer instead of creating a new one each time)?
Otherwise LGTM as start. @tianchen92
@tianchen92tianchen92Jul 16, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a new JIRA to address this, thanks!
emkornfield
emkornfield
requested changes
Jul 13, 2019
View reviewed changes
@emkornfieldemkornfield
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
@tianchen92
tianchen92
commented
Jul 13, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
Many thanks for your feedback :), revise would be provided later.
@tianchen92
tianchen92
commented
Jul 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Hi, Micah, could we get this PR merged? thanks :)

BTW, ask an unrelated question, seems theres no adapter to read csv to ARROW in Java which C++ has, is it necessary to implement it ？
And in the follow PR, I resolve most the comments and still have few questions, would you mind explaining a lot? thanks a lot!
#4846
emkornfield
emkornfield
reviewed
Jul 18, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

import org.apache.avro.Schema.Type;
import org.apache.avro.io.Decoder;

import sun.reflect.generics.reflectiveObjects.NotImplementedException;
@emkornfieldemkornfieldJul 18, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed this, we should be using https://docs.oracle.com/javase/6/docs/api/java/lang/UnsupportedOperationException.html
@tianchen92tianchen92Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks! hope could merge soon then I could start follow-up works
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
Thanks for your effort, I will start discuss later :)
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Build passed :)
@emkornfield
emkornfield
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
+1, thank you.
kszucs pushed a commit
that referenced
this pull request
Jul 22, 2019
tianchen@kszucs
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
e415bd3
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closes#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
tianchen@kou
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
2bb6a0a
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closesapache#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@emkornfieldemkornfieldemkornfield requested changes

Assignees


No one assigned


Labels

Component: Java

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianchen92@codecov-io@emkornfield@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types - #4812
Closed
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Closed
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types#4812
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Conversation
@tianchen92
@tianchen92tianchen92
commented
Jul 5, 2019

Copy link


Copy Markdown

Contributor
Related to ARROW-5861.

Initial implement to support convert Avro record with primitive types to Arrow objects.
emkornfield
emkornfield
reviewed
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
requested changes
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

@codecov-io
codecov-io
commented
Jul 6, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4812 into master will increase coverage by 2.16%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4812 +/- ##
==========================================
+ Coverage 87.42% 89.58% +2.16% 
==========================================
Files 994 661 -333 Lines 140102 96617 -43485 Branches 1418 0 -1418 ==========================================
- Hits 122481 86557 -35924 + Misses 17259 10060 -7199 + Partials 362 0 -362
Impacted FilesCoverage Δ
cpp/src/gandiva/precompiled/decimal_ops.cc97.17% <0%> (ø)⬆️
cpp/src/gandiva/precompiled/decimal_ops_test.cc97.43% <0%> (ø)⬆️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
... and 327 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update c350bba...2439478. Read the comment docs.
emkornfield
emkornfield
reviewed
Jul 9, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroStringConsumer.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/test/java/org/apache/arrow/AvroToArrowTest.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated


 allocateVectors(root, DEFAULT_BUFFER_SIZE);

 List<Consumer> consumers = createAvroConsumers(root);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we might need to understand more about decoders and the order they are expected to [decode(https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/io/ValidatingDecoder.html) in. This can also be for a follow-up PR
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroBytesConsumer.java
 @Override
 public void consume(Decoder decoder) throws IOException {
 VarBinaryHolder holder = new VarBinaryHolder();
 ByteBuffer byteBuffer = decoder.readBytes(null);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep a cached byte buffer for values below a certain size.
Even better would be if we could create a ByteBuffer that wraps the Vector and puts bytes directly where they need to go. This can be done in a separate PR.
@emkornfieldemkornfieldJul 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the first part of my comment (caching a ByteBuffer instead of creating a new one each time)?
Otherwise LGTM as start. @tianchen92
@tianchen92tianchen92Jul 16, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a new JIRA to address this, thanks!
emkornfield
emkornfield
requested changes
Jul 13, 2019
View reviewed changes
@emkornfieldemkornfield
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
@tianchen92
tianchen92
commented
Jul 13, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
Many thanks for your feedback :), revise would be provided later.
@tianchen92
tianchen92
commented
Jul 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Hi, Micah, could we get this PR merged? thanks :)

BTW, ask an unrelated question, seems theres no adapter to read csv to ARROW in Java which C++ has, is it necessary to implement it ？
And in the follow PR, I resolve most the comments and still have few questions, would you mind explaining a lot? thanks a lot!
#4846
emkornfield
emkornfield
reviewed
Jul 18, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

import org.apache.avro.Schema.Type;
import org.apache.avro.io.Decoder;

import sun.reflect.generics.reflectiveObjects.NotImplementedException;
@emkornfieldemkornfieldJul 18, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed this, we should be using https://docs.oracle.com/javase/6/docs/api/java/lang/UnsupportedOperationException.html
@tianchen92tianchen92Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks! hope could merge soon then I could start follow-up works
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
Thanks for your effort, I will start discuss later :)
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Build passed :)
@emkornfield
emkornfield
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
+1, thank you.
kszucs pushed a commit
that referenced
this pull request
Jul 22, 2019
tianchen@kszucs
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
e415bd3
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closes#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
tianchen@kou
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
2bb6a0a
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closesapache#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@emkornfieldemkornfieldemkornfield requested changes

Assignees


No one assigned


Labels

Component: Java

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianchen92@codecov-io@emkornfield@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types - #4812
Closed
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Closed
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types#4812
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Conversation
@tianchen92
@tianchen92tianchen92
commented
Jul 5, 2019

Copy link


Copy Markdown

Contributor
Related to ARROW-5861.

Initial implement to support convert Avro record with primitive types to Arrow objects.
emkornfield
emkornfield
reviewed
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
requested changes
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

@codecov-io
codecov-io
commented
Jul 6, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4812 into master will increase coverage by 2.16%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4812 +/- ##
==========================================
+ Coverage 87.42% 89.58% +2.16% 
==========================================
Files 994 661 -333 Lines 140102 96617 -43485 Branches 1418 0 -1418 ==========================================
- Hits 122481 86557 -35924 + Misses 17259 10060 -7199 + Partials 362 0 -362
Impacted FilesCoverage Δ
cpp/src/gandiva/precompiled/decimal_ops.cc97.17% <0%> (ø)⬆️
cpp/src/gandiva/precompiled/decimal_ops_test.cc97.43% <0%> (ø)⬆️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
... and 327 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update c350bba...2439478. Read the comment docs.
emkornfield
emkornfield
reviewed
Jul 9, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroStringConsumer.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/test/java/org/apache/arrow/AvroToArrowTest.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated


 allocateVectors(root, DEFAULT_BUFFER_SIZE);

 List<Consumer> consumers = createAvroConsumers(root);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we might need to understand more about decoders and the order they are expected to [decode(https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/io/ValidatingDecoder.html) in. This can also be for a follow-up PR
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroBytesConsumer.java
 @Override
 public void consume(Decoder decoder) throws IOException {
 VarBinaryHolder holder = new VarBinaryHolder();
 ByteBuffer byteBuffer = decoder.readBytes(null);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep a cached byte buffer for values below a certain size.
Even better would be if we could create a ByteBuffer that wraps the Vector and puts bytes directly where they need to go. This can be done in a separate PR.
@emkornfieldemkornfieldJul 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the first part of my comment (caching a ByteBuffer instead of creating a new one each time)?
Otherwise LGTM as start. @tianchen92
@tianchen92tianchen92Jul 16, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a new JIRA to address this, thanks!
emkornfield
emkornfield
requested changes
Jul 13, 2019
View reviewed changes
@emkornfieldemkornfield
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
@tianchen92
tianchen92
commented
Jul 13, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
Many thanks for your feedback :), revise would be provided later.
@tianchen92
tianchen92
commented
Jul 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Hi, Micah, could we get this PR merged? thanks :)

BTW, ask an unrelated question, seems theres no adapter to read csv to ARROW in Java which C++ has, is it necessary to implement it ？
And in the follow PR, I resolve most the comments and still have few questions, would you mind explaining a lot? thanks a lot!
#4846
emkornfield
emkornfield
reviewed
Jul 18, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

import org.apache.avro.Schema.Type;
import org.apache.avro.io.Decoder;

import sun.reflect.generics.reflectiveObjects.NotImplementedException;
@emkornfieldemkornfieldJul 18, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed this, we should be using https://docs.oracle.com/javase/6/docs/api/java/lang/UnsupportedOperationException.html
@tianchen92tianchen92Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks! hope could merge soon then I could start follow-up works
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
Thanks for your effort, I will start discuss later :)
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Build passed :)
@emkornfield
emkornfield
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
+1, thank you.
kszucs pushed a commit
that referenced
this pull request
Jul 22, 2019
tianchen@kszucs
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
e415bd3
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closes#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
tianchen@kou
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
2bb6a0a
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closesapache#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@emkornfieldemkornfieldemkornfield requested changes

Assignees


No one assigned


Labels

Component: Java

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianchen92@codecov-io@emkornfield@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types - #4812
Closed
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Closed
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types#4812
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Conversation
@tianchen92
@tianchen92tianchen92
commented
Jul 5, 2019

Copy link


Copy Markdown

Contributor
Related to ARROW-5861.

Initial implement to support convert Avro record with primitive types to Arrow objects.
emkornfield
emkornfield
reviewed
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
requested changes
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

@codecov-io
codecov-io
commented
Jul 6, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4812 into master will increase coverage by 2.16%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4812 +/- ##
==========================================
+ Coverage 87.42% 89.58% +2.16% 
==========================================
Files 994 661 -333 Lines 140102 96617 -43485 Branches 1418 0 -1418 ==========================================
- Hits 122481 86557 -35924 + Misses 17259 10060 -7199 + Partials 362 0 -362
Impacted FilesCoverage Δ
cpp/src/gandiva/precompiled/decimal_ops.cc97.17% <0%> (ø)⬆️
cpp/src/gandiva/precompiled/decimal_ops_test.cc97.43% <0%> (ø)⬆️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
... and 327 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update c350bba...2439478. Read the comment docs.
emkornfield
emkornfield
reviewed
Jul 9, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroStringConsumer.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/test/java/org/apache/arrow/AvroToArrowTest.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated


 allocateVectors(root, DEFAULT_BUFFER_SIZE);

 List<Consumer> consumers = createAvroConsumers(root);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we might need to understand more about decoders and the order they are expected to [decode(https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/io/ValidatingDecoder.html) in. This can also be for a follow-up PR
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroBytesConsumer.java
 @Override
 public void consume(Decoder decoder) throws IOException {
 VarBinaryHolder holder = new VarBinaryHolder();
 ByteBuffer byteBuffer = decoder.readBytes(null);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep a cached byte buffer for values below a certain size.
Even better would be if we could create a ByteBuffer that wraps the Vector and puts bytes directly where they need to go. This can be done in a separate PR.
@emkornfieldemkornfieldJul 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the first part of my comment (caching a ByteBuffer instead of creating a new one each time)?
Otherwise LGTM as start. @tianchen92
@tianchen92tianchen92Jul 16, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a new JIRA to address this, thanks!
emkornfield
emkornfield
requested changes
Jul 13, 2019
View reviewed changes
@emkornfieldemkornfield
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
@tianchen92
tianchen92
commented
Jul 13, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
Many thanks for your feedback :), revise would be provided later.
@tianchen92
tianchen92
commented
Jul 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Hi, Micah, could we get this PR merged? thanks :)

BTW, ask an unrelated question, seems theres no adapter to read csv to ARROW in Java which C++ has, is it necessary to implement it ？
And in the follow PR, I resolve most the comments and still have few questions, would you mind explaining a lot? thanks a lot!
#4846
emkornfield
emkornfield
reviewed
Jul 18, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

import org.apache.avro.Schema.Type;
import org.apache.avro.io.Decoder;

import sun.reflect.generics.reflectiveObjects.NotImplementedException;
@emkornfieldemkornfieldJul 18, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed this, we should be using https://docs.oracle.com/javase/6/docs/api/java/lang/UnsupportedOperationException.html
@tianchen92tianchen92Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks! hope could merge soon then I could start follow-up works
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
Thanks for your effort, I will start discuss later :)
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Build passed :)
@emkornfield
emkornfield
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
+1, thank you.
kszucs pushed a commit
that referenced
this pull request
Jul 22, 2019
tianchen@kszucs
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
e415bd3
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closes#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
tianchen@kou
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
2bb6a0a
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closesapache#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@emkornfieldemkornfieldemkornfield requested changes

Assignees


No one assigned


Labels

Component: Java

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianchen92@codecov-io@emkornfield@fsaintjacques

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types - #4812
Closed
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Closed
ARROW-5861: [Java] Initial implement to convert Avro record with primitive types#4812
tianchen92 wants to merge 5 commits into
apache:masterfrom 
tianchen92:ARROW-5861
Conversation
@tianchen92
@tianchen92tianchen92
commented
Jul 5, 2019

Copy link


Copy Markdown

Contributor
Related to ARROW-5861.

Initial implement to support convert Avro record with primitive types to Arrow objects.
emkornfield
emkornfield
reviewed
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
requested changes
Jul 5, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

@codecov-io
codecov-io
commented
Jul 6, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #4812 into master will increase coverage by 2.16%.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #4812 +/- ##
==========================================
+ Coverage 87.42% 89.58% +2.16% 
==========================================
Files 994 661 -333 Lines 140102 96617 -43485 Branches 1418 0 -1418 ==========================================
- Hits 122481 86557 -35924 + Misses 17259 10060 -7199 + Partials 362 0 -362
Impacted FilesCoverage Δ
cpp/src/gandiva/precompiled/decimal_ops.cc97.17% <0%> (ø)⬆️
cpp/src/gandiva/precompiled/decimal_ops_test.cc97.43% <0%> (ø)⬆️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
... and 327 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update c350bba...2439478. Read the comment docs.
emkornfield
emkornfield
reviewed
Jul 9, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroStringConsumer.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/test/java/org/apache/arrow/AvroToArrowTest.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrow.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated


 allocateVectors(root, DEFAULT_BUFFER_SIZE);

 List<Consumer> consumers = createAvroConsumers(root);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we might need to understand more about decoders and the order they are expected to [decode(https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/io/ValidatingDecoder.html) in. This can also be for a follow-up PR
emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

emkornfield
emkornfield
reviewed
Jul 13, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/consumers/AvroBytesConsumer.java
 @Override
 public void consume(Decoder decoder) throws IOException {
 VarBinaryHolder holder = new VarBinaryHolder();
 ByteBuffer byteBuffer = decoder.readBytes(null);
@emkornfieldemkornfieldJul 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep a cached byte buffer for values below a certain size.
Even better would be if we could create a ByteBuffer that wraps the Vector and puts bytes directly where they need to go. This can be done in a separate PR.
@emkornfieldemkornfieldJul 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the first part of my comment (caching a ByteBuffer instead of creating a new one each time)?
Otherwise LGTM as start. @tianchen92
@tianchen92tianchen92Jul 16, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a new JIRA to address this, thanks!
emkornfield
emkornfield
requested changes
Jul 13, 2019
View reviewed changes
@emkornfieldemkornfield
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
@tianchen92
tianchen92
commented
Jul 13, 2019

Copy link


Copy Markdown

ContributorAuthor
Thanks this looks a lot closer to what I was expecting. It still seems like there might be some additional details we need to learn about the AVRO API but I think this can be done as a follow-up
Many thanks for your feedback :), revise would be provided later.
@tianchen92
tianchen92
commented
Jul 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Hi, Micah, could we get this PR merged? thanks :)

BTW, ask an unrelated question, seems theres no adapter to read csv to ARROW in Java which C++ has, is it necessary to implement it ？
And in the follow PR, I resolve most the comments and still have few questions, would you mind explaining a lot? thanks a lot!
#4846
emkornfield
emkornfield
reviewed
Jul 18, 2019
View reviewed changes
Comment threadjava/adapter/avro/src/main/java/org/apache/arrow/AvroToArrowUtils.java
Outdated

import org.apache.avro.Schema.Type;
import org.apache.avro.io.Decoder;

import sun.reflect.generics.reflectiveObjects.NotImplementedException;
@emkornfieldemkornfieldJul 18, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed this, we should be using https://docs.oracle.com/javase/6/docs/api/java/lang/UnsupportedOperationException.html
@tianchen92tianchen92Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks! hope could merge soon then I could start follow-up works
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
An adapter for CSV would probably be nice as well. I don't know if there is an efficient CSV parser in java that we could potentially already leverage (or if we want bindings to the C++ version). might be worth an e-mail to the mailing list to get opinions.
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
@emkornfield
emkornfield
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Maybe https://commons.apache.org/proper/commons-csv/ is a good choice.
Seems reasonable to me. Please ask on the mailing list in case anyone else has input.
Thanks for your effort, I will start discuss later :)
@tianchen92
tianchen92
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@emkornfield Build passed :)
@emkornfield
emkornfield
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
+1, thank you.
kszucs pushed a commit
that referenced
this pull request
Jul 22, 2019
tianchen@kszucs
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
e415bd3
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closes#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
@asfimportasfimport
mentioned this pull request
Aug 1, 2019

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
tianchen@kou
ARROW-5861: [Java] Initial implement to convert Avro record with prim…
2bb6a0a
…itive types
Related to [ARROW-5861](https://issues.apache.org/jira/browse/ARROW-5861).
Initial implement to support convert Avro record with primitive types to Arrow objects.
Author: tianchen <niki.lj@alibaba-inc.com>
Closesapache#4812 from tianchen92/ARROW-5861 and squashes the following commits:
2439478 <tianchen> use UnsupportedOperationException
fa3f39a <tianchen> resolve comments
7c3a730 <tianchen> add consumers and use GenericDatumReader
61d2dac <tianchen> fix style
54479c8 <tianchen> Initial implement to convert Avro record with primitive types
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@emkornfieldemkornfieldemkornfield requested changes

Assignees


No one assigned


Labels

Component: Java

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@tianchen92@codecov-io@emkornfield@fsaintjacques