Skip to content

GH-44810: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::Make() - #48285

Merged
kou merged 24 commits into
apache:mainfrom
hiroyuki-sato:topic/parquet-result-reader
Dec 11, 2025
Merged

GH-44810: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::Make()#48285
kou merged 24 commits into
apache:mainfrom
hiroyuki-sato:topic/parquet-result-reader

Conversation

@hiroyuki-sato

@hiroyuki-satohiroyuki-sato commented Nov 28, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

FileReader::Make previously returned Status and required callers to pass an out parameter.

What changes are included in this PR?

Introduce a Result<std::unique_ptr<FileReader>> returning API to allow clearer error propagation

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

Status version FileReader::Make has been deprecated.

static ::arrow::Status Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
const ArrowReaderProperties& properties,
std::unique_ptr<FileReader>* out);
static ::arrow::Status Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
std::unique_ptr<FileReader>* out);

@github-actions

github-actionsBot commented Nov 28, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #44810has been automatically assigned in GitHub to PR creator.

kou
kou reviewed Nov 28, 2025
View reviewed changes
Comment threadcpp/src/parquet/arrow/arrow_reader_writer_test.cc Outdated
Comment threadcpp/src/parquet/arrow/arrow_reader_writer_test.cc Outdated
Comment threadcpp/src/parquet/arrow/arrow_reader_writer_test.cc Outdated
Comment threadcpp/src/parquet/arrow/reader.cc Outdated
Comment threadcpp/src/parquet/arrow/reader.cc Outdated
Comment threadcpp/src/parquet/arrow/reader.h
Comment threadcpp/src/parquet/arrow/reader.h
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting review Awaiting review awaiting changes Awaiting changes awaiting change review Awaiting change review labels Nov 28, 2025
@hiroyuki-sato
hiroyuki-satoforce-pushed the topic/parquet-result-reader branch from 86eba06 to 7ef530cCompareNovember 29, 2025 12:47
@github-actionsgithub-actionsBot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Nov 29, 2025
hiroyuki-sato
hiroyuki-sato commented Dec 1, 2025
View reviewed changes

@hiroyuki-satohiroyuki-sato left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou CI passed Please take a look when you get a chacne.

Comment threadcpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated
kou
kou reviewed Dec 1, 2025
View reviewed changes
Comment threadcpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated
Comment threadcpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated
Comment threadcpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Dec 1, 2025
hiroyuki-sato
hiroyuki-sato commented Dec 2, 2025
View reviewed changes
Comment threadcpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes Component: Gandiva awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Dec 2, 2025
@hiroyuki-sato
hiroyuki-satoforce-pushed the topic/parquet-result-reader branch 2 times, most recently from 39cc9ea to 45249ddCompareDecember 8, 2025 00:50
@hiroyuki-sato
hiroyuki-satoforce-pushed the topic/parquet-result-reader branch from f1abda7 to 4045dc8CompareDecember 9, 2025 05:20
@hiroyuki-sato

hiroyuki-sato commented Dec 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@kou Thank you for your review. I add auto parameter. Please take a look when you get a chance.

kou
kou reviewed Dec 11, 2025
View reviewed changes
Comment threadcpp/src/parquet/arrow/reader.cc Outdated
@github-actionsgithub-actionsBot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Dec 11, 2025
kou
kou approved these changes Dec 11, 2025
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 7a36fcc into apache:mainDec 11, 2025
44 of 45 checks passed
@koukou removed the awaiting change review Awaiting change review label Dec 11, 2025
@koukou mentioned this pull request Dec 11, 2025
Closed
@github-actionsgithub-actionsBot added the awaiting merge Awaiting merge label Dec 11, 2025
@hiroyuki-sato
hiroyuki-sato deleted the topic/parquet-result-reader branch December 11, 2025 12:09
@conbench-apache-arrow

conbench-apache-arrowBot commented Dec 13, 2025

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 7a36fcc.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@hiroyuki-sato@kou@Mottl
apacheGH-44810: [C++][Parquet] Add arrow::Result version of parquet::…
93d4e6e
…arrow::FileReader::Make() (apache#48285)
### Rationale for this change
`FileReader::Make` previously returned `Status` and required callers to pass an `out` parameter.
### What changes are included in this PR?
Introduce a `Result<std::unique_ptr<FileReader>>` returning API to allow clearer error propagation ### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes. Status version `FileReader::Make` has been deprecated.
```cpp
static ::arrow::Status Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
const ArrowReaderProperties& properties,
std::unique_ptr<FileReader>* out);
static ::arrow::Status Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
std::unique_ptr<FileReader>* out);
```
* GitHub Issue: apache#44810
Lead-authored-by: Hiroyuki Sato <hiroysato@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@HuaHuaYHuaHuaY mentioned this pull request Jul 31, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@wgtmacwgtmacAwaiting requested review from wgtmacwgtmac is a code owner

Assignees

No one assigned

Labels

awaiting mergeAwaiting mergeComponent: C++Component: Parquet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiroyuki-sato@kou