Uh oh!
There was an error while loading. Please reload this page.
GH-48337: [C++][Parquet] Improve column encryption API - #48338
Merged
Conversation
pitrou
commented
Dec 4, 2025
MemberAuthor
@EnricoMi@adamreeve Does this look ok to you? |
adamreeve
approved these changes
Dec 5, 2025
adamreeve
left a comment
Contributor
There was a problem hiding this comment.
👍 This is so much nicer.
I think removing the column_path property is fine and unlikely to cause much of a problem for user code.
Uh oh!
There was an error while loading. Please reload this page.
EnricoMi
reviewed
Dec 8, 2025
EnricoMi
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! This is a good simplification.
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 85ea78d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…48338) ### Rationale for this change While working on PR apache#48336 I quickly got irritated by the clumsiness of the Parquet encryption configuration API. This issue attempts to reduce the verbosity of `ColumnEncryptionProperties` construction. ### What changes are included in this PR? 1. Remove unused `column_path` member in `ColumnEncryptionProperties` 2. Add convenience `ColumnEncryptionProperties` factory functions to avoid going through the clumsy `Builder` API ### Are these changes tested? Yes ### Are there any user-facing changes? Two deprecated constructors and a removed accessor for an useless property. **This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.) * GitHub Issue: apache#48337 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While working on PR #48336 I quickly got irritated by the clumsiness of the Parquet encryption configuration API. This issue attempts to reduce the verbosity of
ColumnEncryptionPropertiesconstruction.What changes are included in this PR?
column_pathmember inColumnEncryptionPropertiesColumnEncryptionPropertiesfactory functions to avoid going through the clumsyBuilderAPIAre these changes tested?
Yes
Are there any user-facing changes?
Two deprecated constructors and a removed accessor for an useless property.
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)