Uh oh!
There was an error while loading. Please reload this page.
GH-48363: [GLib][Ruby] Add AssumeTimezoneOptions - #48370
Merged
Merged
Conversation
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ca5cb92. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
### Rationale for this change The `AssumeTimezoneOptions` class is not available in GLib/Ruby, and it is used together with the `assume_timezone` compute function. ### What changes are included in this PR? This adds the `GArrowAssumeTimezoneOptions` to GLib. ### Are these changes tested? Yes, with Ruby unit tests. ### Are there any user-facing changes? Yes, a new class. * GitHub Issue: apache#48363 Authored-by: Sten Larsson <sten@burtcorp.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
AssumeTimezoneOptionsclass is not available in GLib/Ruby, and it is used together with theassume_timezonecompute function.What changes are included in this PR?
This adds the
GArrowAssumeTimezoneOptionsto GLib.Are these changes tested?
Yes, with Ruby unit tests.
Are there any user-facing changes?
Yes, a new class.