Uh oh!
There was an error while loading. Please reload this page.
GH-48388: [Ruby] Add support for reading map array - #48389
Merged
Conversation
hiroyuki-sato
self-requested a review
December 8, 2025 00:38
hiroyuki-sato
approved these changes
Dec 8, 2025
hiroyuki-sato
left a comment
Collaborator
There was a problem hiding this comment.
+1
LD_LIBRARY_PATH=/tmp/local/lib GI_TYPELIB_PATH=/tmp/local/lib/girepository-1.0 ./test/run.rb
Loaded suite test
Started
/path/to/arrow/ruby/red-arrow-format/lib/arrow-format/file-reader.rb:60: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
Finished in 0.155625674 seconds.
--------------------------------------------------------------------------------
11 tests, 11 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
--------------------------------------------------------------------------------
70.68 tests/s, 70.68 assertions/s
kou
commented
Dec 10, 2025
MemberAuthor
@github-actions crossbow submit test-debian-ruby |
Revision: 041e634 Submitted crossbow builds: ursacomputing/crossbow @ actions-8606ba23ed
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4723b79. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
### Rationale for this change It's a list of struct array. ### What changes are included in this PR? * Add `ArrowFormat::MapType` * Add `ArrowFormat::MapArray` ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#48388 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's a list of struct array.
What changes are included in this PR?
ArrowFormat::MapTypeArrowFormat::MapArrayAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.