Uh oh!
There was an error while loading. Please reload this page.
GH-48877: [C++][Parquet] Fix writer not to throw for bloom filter on disabled bool column - #48878
Merged
Conversation
…er on disabled bool column
mapleFU
approved these changes
Jan 16, 2026
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8b648be. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…er on disabled bool column (apache#48878) ### Rationale for this change Now that apache#37400 is merged. After a quick integration, I found that the Parquet writer throws if bloom filter is enabled and there is at least one boolean column (even when it is not enabled). ### What changes are included in this PR? Move the bloom filter type check after bloom filter enablement check. ### Are these changes tested? Yes, added test to verify this does not throw. ### Are there any user-facing changes? No. * GitHub Issue: apache#48877 Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Gang Wu <ustcwg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Now that #37400 is merged. After a quick integration, I found that the Parquet writer throws if bloom filter is enabled and there is at least one boolean column (even when it is not enabled).
What changes are included in this PR?
Move the bloom filter type check after bloom filter enablement check.
Are these changes tested?
Yes, added test to verify this does not throw.
Are there any user-facing changes?
No.