MINOR: try to use r-universe's testing - #49216

Closed
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran
Closed

MINOR: try to use r-universe's testing#49216
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran

Conversation

@jonkeane

@jonkeanejonkeane commented Feb 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Attempt to replicate CRAN failure for macos builds

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Feb 10, 2026
@apacheapache deleted a comment from github-actionsBotFeb 10, 2026
@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'github' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21869907596

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 360df90

Submitted crossbow builds: ursacomputing/crossbow @ actions-d09ca985d9

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 252a803

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f04cba2b1

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: d616461

Submitted crossbow builds: ursacomputing/crossbow @ actions-17a151558e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 293cc70

Submitted crossbow builds: ursacomputing/crossbow @ actions-a18d3cc190

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 7a4ddfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-228df6aa82

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: ce125af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7bd1a0a3

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 4f4ef08

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e57ec0008

TaskStatus
test-r-macos-as-cranGitHub Actions

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 4a2e35f

Submitted crossbow builds: ursacomputing/crossbow @ actions-50d90d2566

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21891861622

@jonkeane
jonkeaneforce-pushed the older_macos_cran branch 2 times, most recently from d9435bd to 5ed5de1CompareFebruary 11, 2026 03:50
@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 5ed5de1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e57ebb9392

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

Success at replicating CRAN's old build system failures https://github.com/ursacomputing/crossbow/actions/runs/21892102160/job/63199955397#step:9:1773

Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:38: error: no template named 'floating_point' in namespace 'std'; did you mean 'is_floating_point'?
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~^~~~~~~~~~~~~~
| is_floating_point
/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:860:50: note: 'is_floating_point' declared here
860 | template <class _Tp> struct _LIBCPP_TEMPLATE_VIS is_floating_point
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:56: error: expected '(' for function-style cast or type construction
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
299 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:33: error: non-type template parameter has non-literal type 'FloatingPointType'
299 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:300:20: error: template argument for template type parameter must be a type
300 | struct AntiExtrema<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:287:20: note: template parameter is declared here
287 | template <typename CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
317 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:33: error: non-type template parameter has non-literal type 'FloatingPointType'
317 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:318:17: error: template argument for template type parameter must be a type
318 | struct MinMaxOp<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:311:20: note: template parameter is declared here
311 | template <typename CType>
| ^
8 errors generated.

This was referenced Feb 11, 2026
Closed
Merged
@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9d305b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-9a0c0b0c8e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9ce0746

Submitted crossbow builds: ursacomputing/crossbow @ actions-71b6e6cd81

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-0493c458bc

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f756cc4f

TaskStatus
test-r-macos-as-cranGitHub Actions

thisisnic pushed a commit that referenced this pull request Feb 16, 2026
@jonkeane
GH-49176: [C++] CRAN build fail on missing std::floating_point concept (
1d76e1e
#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in #49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: #49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@jonkeane

jonkeane commented Feb 16, 2026

Copy link
Copy Markdown
MemberAuthor

Replaced by #49221

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Feb 18, 2026
@jonkeane@thisisnic
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
d1cea28
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@jonkeane@Mottl
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
9e2e7de
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@koukouAwaiting requested review from koukou is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@thisisnicthisisnicAwaiting requested review from thisisnic

Assignees

No one assigned

Labels

awaiting change reviewAwaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonkeane
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

MINOR: try to use r-universe's testing - #49216

Closed
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran
Closed

MINOR: try to use r-universe's testing#49216
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran

Conversation

@jonkeane

@jonkeanejonkeane commented Feb 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Attempt to replicate CRAN failure for macos builds

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Feb 10, 2026
@apacheapache deleted a comment from github-actionsBotFeb 10, 2026
@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'github' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21869907596

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 360df90

Submitted crossbow builds: ursacomputing/crossbow @ actions-d09ca985d9

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 252a803

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f04cba2b1

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: d616461

Submitted crossbow builds: ursacomputing/crossbow @ actions-17a151558e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 293cc70

Submitted crossbow builds: ursacomputing/crossbow @ actions-a18d3cc190

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 7a4ddfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-228df6aa82

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: ce125af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7bd1a0a3

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 4f4ef08

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e57ec0008

TaskStatus
test-r-macos-as-cranGitHub Actions

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 4a2e35f

Submitted crossbow builds: ursacomputing/crossbow @ actions-50d90d2566

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21891861622

@jonkeane
jonkeaneforce-pushed the older_macos_cran branch 2 times, most recently from d9435bd to 5ed5de1CompareFebruary 11, 2026 03:50
@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 5ed5de1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e57ebb9392

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

Success at replicating CRAN's old build system failures https://github.com/ursacomputing/crossbow/actions/runs/21892102160/job/63199955397#step:9:1773

Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:38: error: no template named 'floating_point' in namespace 'std'; did you mean 'is_floating_point'?
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~^~~~~~~~~~~~~~
| is_floating_point
/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:860:50: note: 'is_floating_point' declared here
860 | template <class _Tp> struct _LIBCPP_TEMPLATE_VIS is_floating_point
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:56: error: expected '(' for function-style cast or type construction
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
299 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:33: error: non-type template parameter has non-literal type 'FloatingPointType'
299 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:300:20: error: template argument for template type parameter must be a type
300 | struct AntiExtrema<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:287:20: note: template parameter is declared here
287 | template <typename CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
317 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:33: error: non-type template parameter has non-literal type 'FloatingPointType'
317 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:318:17: error: template argument for template type parameter must be a type
318 | struct MinMaxOp<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:311:20: note: template parameter is declared here
311 | template <typename CType>
| ^
8 errors generated.

This was referenced Feb 11, 2026
Closed
Merged
@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9d305b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-9a0c0b0c8e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9ce0746

Submitted crossbow builds: ursacomputing/crossbow @ actions-71b6e6cd81

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-0493c458bc

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f756cc4f

TaskStatus
test-r-macos-as-cranGitHub Actions

thisisnic pushed a commit that referenced this pull request Feb 16, 2026
@jonkeane
GH-49176: [C++] CRAN build fail on missing std::floating_point concept (
1d76e1e
#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in #49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: #49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@jonkeane

jonkeane commented Feb 16, 2026

Copy link
Copy Markdown
MemberAuthor

Replaced by #49221

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Feb 18, 2026
@jonkeane@thisisnic
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
d1cea28
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@jonkeane@Mottl
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
9e2e7de
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@koukouAwaiting requested review from koukou is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@thisisnicthisisnicAwaiting requested review from thisisnic

Assignees

No one assigned

Labels

awaiting change reviewAwaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonkeane
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

MINOR: try to use r-universe's testing - #49216

Closed
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran
Closed

MINOR: try to use r-universe's testing#49216
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran

Conversation

@jonkeane

@jonkeanejonkeane commented Feb 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Attempt to replicate CRAN failure for macos builds

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Feb 10, 2026
@apacheapache deleted a comment from github-actionsBotFeb 10, 2026
@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'github' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21869907596

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 360df90

Submitted crossbow builds: ursacomputing/crossbow @ actions-d09ca985d9

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 252a803

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f04cba2b1

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: d616461

Submitted crossbow builds: ursacomputing/crossbow @ actions-17a151558e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 293cc70

Submitted crossbow builds: ursacomputing/crossbow @ actions-a18d3cc190

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 7a4ddfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-228df6aa82

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: ce125af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7bd1a0a3

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 4f4ef08

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e57ec0008

TaskStatus
test-r-macos-as-cranGitHub Actions

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 4a2e35f

Submitted crossbow builds: ursacomputing/crossbow @ actions-50d90d2566

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21891861622

@jonkeane
jonkeaneforce-pushed the older_macos_cran branch 2 times, most recently from d9435bd to 5ed5de1CompareFebruary 11, 2026 03:50
@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 5ed5de1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e57ebb9392

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

Success at replicating CRAN's old build system failures https://github.com/ursacomputing/crossbow/actions/runs/21892102160/job/63199955397#step:9:1773

Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:38: error: no template named 'floating_point' in namespace 'std'; did you mean 'is_floating_point'?
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~^~~~~~~~~~~~~~
| is_floating_point
/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:860:50: note: 'is_floating_point' declared here
860 | template <class _Tp> struct _LIBCPP_TEMPLATE_VIS is_floating_point
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:56: error: expected '(' for function-style cast or type construction
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
299 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:33: error: non-type template parameter has non-literal type 'FloatingPointType'
299 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:300:20: error: template argument for template type parameter must be a type
300 | struct AntiExtrema<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:287:20: note: template parameter is declared here
287 | template <typename CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
317 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:33: error: non-type template parameter has non-literal type 'FloatingPointType'
317 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:318:17: error: template argument for template type parameter must be a type
318 | struct MinMaxOp<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:311:20: note: template parameter is declared here
311 | template <typename CType>
| ^
8 errors generated.

This was referenced Feb 11, 2026
Closed
Merged
@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9d305b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-9a0c0b0c8e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9ce0746

Submitted crossbow builds: ursacomputing/crossbow @ actions-71b6e6cd81

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-0493c458bc

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f756cc4f

TaskStatus
test-r-macos-as-cranGitHub Actions

thisisnic pushed a commit that referenced this pull request Feb 16, 2026
@jonkeane
GH-49176: [C++] CRAN build fail on missing std::floating_point concept (
1d76e1e
#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in #49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: #49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@jonkeane

jonkeane commented Feb 16, 2026

Copy link
Copy Markdown
MemberAuthor

Replaced by #49221

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Feb 18, 2026
@jonkeane@thisisnic
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
d1cea28
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@jonkeane@Mottl
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
9e2e7de
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@koukouAwaiting requested review from koukou is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@thisisnicthisisnicAwaiting requested review from thisisnic

Assignees

No one assigned

Labels

awaiting change reviewAwaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonkeane
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

MINOR: try to use r-universe's testing - #49216

Closed
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran
Closed

MINOR: try to use r-universe's testing#49216
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran

Conversation

@jonkeane

@jonkeanejonkeane commented Feb 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Attempt to replicate CRAN failure for macos builds

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Feb 10, 2026
@apacheapache deleted a comment from github-actionsBotFeb 10, 2026
@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'github' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21869907596

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 360df90

Submitted crossbow builds: ursacomputing/crossbow @ actions-d09ca985d9

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 252a803

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f04cba2b1

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: d616461

Submitted crossbow builds: ursacomputing/crossbow @ actions-17a151558e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 293cc70

Submitted crossbow builds: ursacomputing/crossbow @ actions-a18d3cc190

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 7a4ddfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-228df6aa82

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: ce125af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7bd1a0a3

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 4f4ef08

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e57ec0008

TaskStatus
test-r-macos-as-cranGitHub Actions

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 4a2e35f

Submitted crossbow builds: ursacomputing/crossbow @ actions-50d90d2566

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21891861622

@jonkeane
jonkeaneforce-pushed the older_macos_cran branch 2 times, most recently from d9435bd to 5ed5de1CompareFebruary 11, 2026 03:50
@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 5ed5de1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e57ebb9392

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

Success at replicating CRAN's old build system failures https://github.com/ursacomputing/crossbow/actions/runs/21892102160/job/63199955397#step:9:1773

Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:38: error: no template named 'floating_point' in namespace 'std'; did you mean 'is_floating_point'?
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~^~~~~~~~~~~~~~
| is_floating_point
/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:860:50: note: 'is_floating_point' declared here
860 | template <class _Tp> struct _LIBCPP_TEMPLATE_VIS is_floating_point
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:56: error: expected '(' for function-style cast or type construction
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
299 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:33: error: non-type template parameter has non-literal type 'FloatingPointType'
299 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:300:20: error: template argument for template type parameter must be a type
300 | struct AntiExtrema<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:287:20: note: template parameter is declared here
287 | template <typename CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
317 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:33: error: non-type template parameter has non-literal type 'FloatingPointType'
317 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:318:17: error: template argument for template type parameter must be a type
318 | struct MinMaxOp<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:311:20: note: template parameter is declared here
311 | template <typename CType>
| ^
8 errors generated.

This was referenced Feb 11, 2026
Closed
Merged
@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9d305b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-9a0c0b0c8e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9ce0746

Submitted crossbow builds: ursacomputing/crossbow @ actions-71b6e6cd81

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-0493c458bc

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f756cc4f

TaskStatus
test-r-macos-as-cranGitHub Actions

thisisnic pushed a commit that referenced this pull request Feb 16, 2026
@jonkeane
GH-49176: [C++] CRAN build fail on missing std::floating_point concept (
1d76e1e
#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in #49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: #49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@jonkeane

jonkeane commented Feb 16, 2026

Copy link
Copy Markdown
MemberAuthor

Replaced by #49221

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Feb 18, 2026
@jonkeane@thisisnic
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
d1cea28
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@jonkeane@Mottl
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
9e2e7de
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@koukouAwaiting requested review from koukou is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@thisisnicthisisnicAwaiting requested review from thisisnic

Assignees

No one assigned

Labels

awaiting change reviewAwaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonkeane
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

MINOR: try to use r-universe's testing - #49216

Closed
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran
Closed

MINOR: try to use r-universe's testing#49216
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran

Conversation

@jonkeane

@jonkeanejonkeane commented Feb 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Attempt to replicate CRAN failure for macos builds

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Feb 10, 2026
@apacheapache deleted a comment from github-actionsBotFeb 10, 2026
@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'github' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21869907596

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 360df90

Submitted crossbow builds: ursacomputing/crossbow @ actions-d09ca985d9

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 252a803

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f04cba2b1

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: d616461

Submitted crossbow builds: ursacomputing/crossbow @ actions-17a151558e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 293cc70

Submitted crossbow builds: ursacomputing/crossbow @ actions-a18d3cc190

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 7a4ddfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-228df6aa82

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: ce125af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7bd1a0a3

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 4f4ef08

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e57ec0008

TaskStatus
test-r-macos-as-cranGitHub Actions

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 4a2e35f

Submitted crossbow builds: ursacomputing/crossbow @ actions-50d90d2566

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21891861622

@jonkeane
jonkeaneforce-pushed the older_macos_cran branch 2 times, most recently from d9435bd to 5ed5de1CompareFebruary 11, 2026 03:50
@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 5ed5de1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e57ebb9392

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

Success at replicating CRAN's old build system failures https://github.com/ursacomputing/crossbow/actions/runs/21892102160/job/63199955397#step:9:1773

Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:38: error: no template named 'floating_point' in namespace 'std'; did you mean 'is_floating_point'?
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~^~~~~~~~~~~~~~
| is_floating_point
/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:860:50: note: 'is_floating_point' declared here
860 | template <class _Tp> struct _LIBCPP_TEMPLATE_VIS is_floating_point
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:56: error: expected '(' for function-style cast or type construction
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
299 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:33: error: non-type template parameter has non-literal type 'FloatingPointType'
299 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:300:20: error: template argument for template type parameter must be a type
300 | struct AntiExtrema<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:287:20: note: template parameter is declared here
287 | template <typename CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
317 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:33: error: non-type template parameter has non-literal type 'FloatingPointType'
317 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:318:17: error: template argument for template type parameter must be a type
318 | struct MinMaxOp<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:311:20: note: template parameter is declared here
311 | template <typename CType>
| ^
8 errors generated.

This was referenced Feb 11, 2026
Closed
Merged
@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9d305b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-9a0c0b0c8e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9ce0746

Submitted crossbow builds: ursacomputing/crossbow @ actions-71b6e6cd81

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-0493c458bc

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f756cc4f

TaskStatus
test-r-macos-as-cranGitHub Actions

thisisnic pushed a commit that referenced this pull request Feb 16, 2026
@jonkeane
GH-49176: [C++] CRAN build fail on missing std::floating_point concept (
1d76e1e
#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in #49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: #49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@jonkeane

jonkeane commented Feb 16, 2026

Copy link
Copy Markdown
MemberAuthor

Replaced by #49221

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Feb 18, 2026
@jonkeane@thisisnic
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
d1cea28
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@jonkeane@Mottl
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
9e2e7de
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@koukouAwaiting requested review from koukou is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@thisisnicthisisnicAwaiting requested review from thisisnic

Assignees

No one assigned

Labels

awaiting change reviewAwaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonkeane
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

MINOR: try to use r-universe's testing - #49216

Closed
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran
Closed

MINOR: try to use r-universe's testing#49216
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran

Conversation

@jonkeane

@jonkeanejonkeane commented Feb 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Attempt to replicate CRAN failure for macos builds

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Feb 10, 2026
@apacheapache deleted a comment from github-actionsBotFeb 10, 2026
@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'github' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21869907596

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 360df90

Submitted crossbow builds: ursacomputing/crossbow @ actions-d09ca985d9

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 252a803

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f04cba2b1

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: d616461

Submitted crossbow builds: ursacomputing/crossbow @ actions-17a151558e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 293cc70

Submitted crossbow builds: ursacomputing/crossbow @ actions-a18d3cc190

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 7a4ddfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-228df6aa82

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: ce125af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7bd1a0a3

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 4f4ef08

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e57ec0008

TaskStatus
test-r-macos-as-cranGitHub Actions

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 4a2e35f

Submitted crossbow builds: ursacomputing/crossbow @ actions-50d90d2566

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21891861622

@jonkeane
jonkeaneforce-pushed the older_macos_cran branch 2 times, most recently from d9435bd to 5ed5de1CompareFebruary 11, 2026 03:50
@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 5ed5de1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e57ebb9392

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

Success at replicating CRAN's old build system failures https://github.com/ursacomputing/crossbow/actions/runs/21892102160/job/63199955397#step:9:1773

Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:38: error: no template named 'floating_point' in namespace 'std'; did you mean 'is_floating_point'?
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~^~~~~~~~~~~~~~
| is_floating_point
/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:860:50: note: 'is_floating_point' declared here
860 | template <class _Tp> struct _LIBCPP_TEMPLATE_VIS is_floating_point
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:56: error: expected '(' for function-style cast or type construction
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
299 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:33: error: non-type template parameter has non-literal type 'FloatingPointType'
299 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:300:20: error: template argument for template type parameter must be a type
300 | struct AntiExtrema<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:287:20: note: template parameter is declared here
287 | template <typename CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
317 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:33: error: non-type template parameter has non-literal type 'FloatingPointType'
317 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:318:17: error: template argument for template type parameter must be a type
318 | struct MinMaxOp<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:311:20: note: template parameter is declared here
311 | template <typename CType>
| ^
8 errors generated.

This was referenced Feb 11, 2026
Closed
Merged
@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9d305b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-9a0c0b0c8e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9ce0746

Submitted crossbow builds: ursacomputing/crossbow @ actions-71b6e6cd81

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-0493c458bc

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f756cc4f

TaskStatus
test-r-macos-as-cranGitHub Actions

thisisnic pushed a commit that referenced this pull request Feb 16, 2026
@jonkeane
GH-49176: [C++] CRAN build fail on missing std::floating_point concept (
1d76e1e
#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in #49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: #49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@jonkeane

jonkeane commented Feb 16, 2026

Copy link
Copy Markdown
MemberAuthor

Replaced by #49221

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Feb 18, 2026
@jonkeane@thisisnic
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
d1cea28
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@jonkeane@Mottl
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
9e2e7de
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@koukouAwaiting requested review from koukou is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@thisisnicthisisnicAwaiting requested review from thisisnic

Assignees

No one assigned

Labels

awaiting change reviewAwaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonkeane
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

MINOR: try to use r-universe's testing - #49216

Closed
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran
Closed

MINOR: try to use r-universe's testing#49216
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran

Conversation

@jonkeane

@jonkeanejonkeane commented Feb 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Attempt to replicate CRAN failure for macos builds

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Feb 10, 2026
@apacheapache deleted a comment from github-actionsBotFeb 10, 2026
@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'github' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21869907596

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 360df90

Submitted crossbow builds: ursacomputing/crossbow @ actions-d09ca985d9

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 252a803

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f04cba2b1

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: d616461

Submitted crossbow builds: ursacomputing/crossbow @ actions-17a151558e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 293cc70

Submitted crossbow builds: ursacomputing/crossbow @ actions-a18d3cc190

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 7a4ddfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-228df6aa82

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: ce125af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7bd1a0a3

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 4f4ef08

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e57ec0008

TaskStatus
test-r-macos-as-cranGitHub Actions

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 4a2e35f

Submitted crossbow builds: ursacomputing/crossbow @ actions-50d90d2566

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21891861622

@jonkeane
jonkeaneforce-pushed the older_macos_cran branch 2 times, most recently from d9435bd to 5ed5de1CompareFebruary 11, 2026 03:50
@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 5ed5de1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e57ebb9392

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

Success at replicating CRAN's old build system failures https://github.com/ursacomputing/crossbow/actions/runs/21892102160/job/63199955397#step:9:1773

Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:38: error: no template named 'floating_point' in namespace 'std'; did you mean 'is_floating_point'?
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~^~~~~~~~~~~~~~
| is_floating_point
/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:860:50: note: 'is_floating_point' declared here
860 | template <class _Tp> struct _LIBCPP_TEMPLATE_VIS is_floating_point
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:56: error: expected '(' for function-style cast or type construction
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
299 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:33: error: non-type template parameter has non-literal type 'FloatingPointType'
299 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:300:20: error: template argument for template type parameter must be a type
300 | struct AntiExtrema<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:287:20: note: template parameter is declared here
287 | template <typename CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
317 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:33: error: non-type template parameter has non-literal type 'FloatingPointType'
317 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:318:17: error: template argument for template type parameter must be a type
318 | struct MinMaxOp<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:311:20: note: template parameter is declared here
311 | template <typename CType>
| ^
8 errors generated.

This was referenced Feb 11, 2026
Closed
Merged
@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9d305b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-9a0c0b0c8e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9ce0746

Submitted crossbow builds: ursacomputing/crossbow @ actions-71b6e6cd81

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-0493c458bc

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f756cc4f

TaskStatus
test-r-macos-as-cranGitHub Actions

thisisnic pushed a commit that referenced this pull request Feb 16, 2026
@jonkeane
GH-49176: [C++] CRAN build fail on missing std::floating_point concept (
1d76e1e
#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in #49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: #49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@jonkeane

jonkeane commented Feb 16, 2026

Copy link
Copy Markdown
MemberAuthor

Replaced by #49221

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Feb 18, 2026
@jonkeane@thisisnic
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
d1cea28
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@jonkeane@Mottl
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
9e2e7de
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@koukouAwaiting requested review from koukou is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@thisisnicthisisnicAwaiting requested review from thisisnic

Assignees

No one assigned

Labels

awaiting change reviewAwaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonkeane
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

MINOR: try to use r-universe's testing - #49216

Closed
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran
Closed

MINOR: try to use r-universe's testing#49216
jonkeane wants to merge 1 commit into
apache:mainfrom
jonkeane:older_macos_cran

Conversation

@jonkeane

@jonkeanejonkeane commented Feb 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Attempt to replicate CRAN failure for macos builds

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Feb 10, 2026
@apacheapache deleted a comment from github-actionsBotFeb 10, 2026
@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'github' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21869907596

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 360df90

Submitted crossbow builds: ursacomputing/crossbow @ actions-d09ca985d9

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 252a803

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f04cba2b1

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: d616461

Submitted crossbow builds: ursacomputing/crossbow @ actions-17a151558e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 293cc70

Submitted crossbow builds: ursacomputing/crossbow @ actions-a18d3cc190

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 7a4ddfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-228df6aa82

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: ce125af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c7bd1a0a3

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown

Revision: 4f4ef08

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e57ec0008

TaskStatus
test-r-macos-as-cranGitHub Actions

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 4a2e35f

Submitted crossbow builds: ursacomputing/crossbow @ actions-50d90d2566

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown 
Failed to render template `r/github.macos.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/21891861622

@jonkeane
jonkeaneforce-pushed the older_macos_cran branch 2 times, most recently from d9435bd to 5ed5de1CompareFebruary 11, 2026 03:50
@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 11, 2026

Copy link
Copy Markdown

Revision: 5ed5de1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e57ebb9392

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

Success at replicating CRAN's old build system failures https://github.com/ursacomputing/crossbow/actions/runs/21892102160/job/63199955397#step:9:1773

Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:38: error: no template named 'floating_point' in namespace 'std'; did you mean 'is_floating_point'?
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~^~~~~~~~~~~~~~
| is_floating_point
/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:860:50: note: 'is_floating_point' declared here
860 | template <class _Tp> struct _LIBCPP_TEMPLATE_VIS is_floating_point
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:56: error: expected '(' for function-style cast or type construction
281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>;
| ~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
299 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:33: error: non-type template parameter has non-literal type 'FloatingPointType'
299 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:300:20: error: template argument for template type parameter must be a type
300 | struct AntiExtrema<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:287:20: note: template parameter is declared here
287 | template <typename CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'?
317 | template <CFloatingPointConcept CType>
| ^~~~~~~~~~~~~~~~~~~~~
| FloatingPointType
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:33: error: non-type template parameter has non-literal type 'FloatingPointType'
317 | template <CFloatingPointConcept CType>
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
336 | class ARROW_EXPORT FloatingPointType : public NumberType {
| ^
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:318:17: error: template argument for template type parameter must be a type
318 | struct MinMaxOp<CType> {
| ^~~~~
/Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:311:20: note: template parameter is declared here
311 | template <typename CType>
| ^
8 errors generated.

This was referenced Feb 11, 2026
Closed
Merged
@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9d305b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-9a0c0b0c8e

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 9ce0746

Submitted crossbow builds: ursacomputing/crossbow @ actions-71b6e6cd81

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-0493c458bc

TaskStatus
test-r-macos-as-cranGitHub Actions

@jonkeane

jonkeane commented Feb 13, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-macos-as-cran

@github-actions

github-actionsBot commented Feb 13, 2026

Copy link
Copy Markdown

Revision: 192326c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f756cc4f

TaskStatus
test-r-macos-as-cranGitHub Actions

thisisnic pushed a commit that referenced this pull request Feb 16, 2026
@jonkeane
GH-49176: [C++] CRAN build fail on missing std::floating_point concept (
1d76e1e
#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in #49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: #49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@jonkeane

jonkeane commented Feb 16, 2026

Copy link
Copy Markdown
MemberAuthor

Replaced by #49221

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Feb 18, 2026
@jonkeane@thisisnic
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
d1cea28
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@jonkeane@Mottl
apacheGH-49176: [C++] CRAN build fail on missing std::floating_point …
9e2e7de
…concept (apache#49221)
### Rationale for this change
Passing builds on CRAN
### What changes are included in this PR?
A workaround for C++20 compatibility issues
### Are these changes tested?
Yes, we can ship these tests in this PR or we can keep them in apache#49216 either is fine by me. ### Are there any user-facing changes?
No
* GitHub Issue: apache#49176
Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@koukouAwaiting requested review from koukou is a code owner
@raulcdraulcdAwaiting requested review from raulcdraulcd is a code owner
@thisisnicthisisnicAwaiting requested review from thisisnic

Assignees

No one assigned

Labels

awaiting change reviewAwaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonkeane