Skip to content

GH-49522: [CI] Update chrome_version for emscripten job to latest stable (v148) - #49523

Merged
kou merged 10 commits into
apache:mainfrom
raulcd:GH-49522
May 11, 2026
Merged

GH-49522: [CI] Update chrome_version for emscripten job to latest stable (v148)#49523
kou merged 10 commits into
apache:mainfrom
raulcd:GH-49522

Conversation

@raulcd

@raulcdraulcd commented Mar 16, 2026

Copy link
Copy Markdown
Member

Rationale for this change

The 134 version fails to be installed from stable releases on chrome due to a new stable version released.

What changes are included in this PR?

  • Update version of latest stable chrome driver to 148 and how we look for version on instrall script.
  • Update selenium to newer version to work with newer chrome.
  • Fixes to cross-compilation build after upgrading Abseil and Protobuf and moving to FetchContent.
  • Updated timeout so Chrome job doesn't time out.
  • Skip substrait tests which currently fail on Pyodide.

Are these changes tested?

Yes, via archery job.

Are there any user-facing changes?

No

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit emscripten

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #49522has been automatically assigned in GitHub to PR creator.

@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label Mar 16, 2026
@github-actions

Copy link
Copy Markdown

Revision: c4158e6

Submitted crossbow builds: ursacomputing/crossbow @ actions-cbb2562ce1

TaskStatus
test-conda-python-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit emscripten

@github-actions

Copy link
Copy Markdown

Revision: e2ca39e

Submitted crossbow builds: ursacomputing/crossbow @ actions-ea4c4095ee

TaskStatus
test-conda-python-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown
No such command 'test-conda-python-emscripten'.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/23196269305

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: e5e292f

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da4beaaea

TaskStatus
test-conda-python-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: 161a055

Submitted crossbow builds: ursacomputing/crossbow @ actions-464839126e

TaskStatus
test-conda-python-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: 983d8c3

Submitted crossbow builds: ursacomputing/crossbow @ actions-19e34e57d9

TaskStatus
test-conda-python-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: bb872b8

Submitted crossbow builds: ursacomputing/crossbow @ actions-fac357fe8f

TaskStatus
test-conda-python-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: 5527ee8

Submitted crossbow builds: ursacomputing/crossbow @ actions-72adffdbbc

TaskStatus
test-conda-python-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: a2d3041

Submitted crossbow builds: ursacomputing/crossbow @ actions-3a7b321f2a

TaskStatus
test-conda-python-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: 14f6f7c

Submitted crossbow builds: ursacomputing/crossbow @ actions-63ad76f778

TaskStatus
test-conda-python-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: cbf6f4e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5d5bdca4fe

TaskStatus
test-conda-python-emscriptenGitHub Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

Copy link
Copy Markdown

Revision: bb16a71

Submitted crossbow builds: ursacomputing/crossbow @ actions-364bd8f9dc

TaskStatus
test-conda-python-emscriptenGitHub Actions

@raulcdraulcd changed the title GH-49522: [CI] Update chrome_version for emscripten job to latest stable (v146)GH-49522: [CI] Update chrome_version for emscripten job to latest stable (v148)May 8, 2026
@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit emscripten

@github-actions

Copy link
Copy Markdown

Revision: bb16a71

Submitted crossbow builds: ursacomputing/crossbow @ actions-ba72a37d1e

TaskStatus
test-conda-python-emscriptenGitHub Actions
test-ubuntu-22.04-cpp-emscriptenGitHub Actions

@raulcd
raulcd marked this pull request as ready for review May 8, 2026 18:25
@raulcd

Copy link
Copy Markdown
MemberAuthor

@kou do you want to take a look at the CMake changes? This job has been failing for a couple of months now and is back to green here

kou
kou approved these changes May 11, 2026

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sorry. I missed this.

@kou
kou merged commit a3c2ff1 into apache:mainMay 11, 2026
57 checks passed
@koukou removed the awaiting committer review Awaiting committer review label May 11, 2026
@github-actionsgithub-actionsBot added the awaiting merge Awaiting merge label May 11, 2026
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit a3c2ff1.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@raulcd
raulcd deleted the GH-49522 branch May 11, 2026 14:30
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a3c2ff1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…st stable (v148) (apache#49523)
### Rationale for this change
The `134` version fails to be installed from stable releases on chrome due to a new stable version released.
### What changes are included in this PR?
- Update version of latest stable chrome driver to `148` and how we look for version on instrall script.
- Update selenium to newer version to work with newer chrome.
- Fixes to cross-compilation build after upgrading Abseil and Protobuf and moving to FetchContent.
- Updated timeout so Chrome job doesn't time out.
- Skip substrait tests which currently fail on Pyodide.
### Are these changes tested?
Yes, via archery job.
### Are there any user-facing changes?
No
* GitHub Issue: apache#49522
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@raulcd@kou