Uh oh!
There was an error while loading. Please reload this page.
GH-49898: [C++][CI] Use mold in more builds - #49899
Merged
Merged
Conversation
We're currently using the mold linker only on a couple of C++ builds. Use it in more builds to get faster link times and thus faster CI builds.
pitrou
requested review from
assignUser, jonkeane, kou and raulcd
as code ownersApril 29, 2026 16:27
pitrou
commented
Apr 29, 2026
MemberAuthor
@github-actions crossbow submit -g cpp |
Revision: eb0c13a Submitted crossbow builds: ursacomputing/crossbow @ actions-4c03283919
|
pitrou
commented
Apr 29, 2026
MemberAuthor
@kou Could you take a look at this PR? |
Uh oh!
There was an error while loading. Please reload this page.
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 684c21e. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 684c21e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 110 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Mottl pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
### Rationale for this change We're currently using the mold linker only on a couple of C++ builds. This PR uses it in more builds to get faster link times and thus faster CI builds. ### Are these changes tested? Yes, by CI builds. ### Are there any user-facing changes? No. * GitHub Issue: apache#49898 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit
that referenced
this pull request
May 26, 2026
…1247 (#50033) ### Rationale for this change Fixes#49767 - intermittent SIGSEGV in the ODBC Linux CI job, the crash occurs during `_dl_relocate_object` before `main()` : #49767 (comment) apt ships mold 2.30.0 on Ubuntu 24.04 'Noble Numbat'. mold 2.30.0 has a non-determinism bug in section placement that causes this crash ([rui314/mold#1247](rui314/mold#1247)). Fixed upstream in [mold 2.31.0](https://github.com/rui314/mold/releases/tag/v2.31.0). ### What changes are included in this PR? Disable mold on Ubuntu 24.04 in `ubuntu-24.04-cpp.dockerfile` by setting `ARROW_USE_MOLD=OFF`. Re-enable if apt mold reaches 2.31+ - note that Ubuntu 24.04 'Noble Numbat' might never update to 2.31+ https://launchpad.net/ubuntu/noble/+source/mold - its mold release is over 2 years old. A follow-up issue tracking apt mold updates and other CI jobs using mold (more added with #49898/#49899) will be opened separately. ### Are these changes tested? Yes, ODBC Linux job runs complete successfully on fork: [1st](https://github.com/tadeja/arrow/actions/runs/26389905866/job/77676883090), [2nd](https://github.com/tadeja/arrow/actions/runs/26389905866/job/77684025003) , [3rd](https://github.com/tadeja/arrow/actions/runs/26389905866/job/77685765548) , [4th](https://github.com/tadeja/arrow/actions/runs/26389905866/job/77693037433) ### Are there any user-facing changes? No. * GitHub Issue: #49767 Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We're currently using the mold linker only on a couple of C++ builds. This PR uses it in more builds to get faster link times and thus faster CI builds.
Are these changes tested?
Yes, by CI builds.
Are there any user-facing changes?
No.