Skip to content

GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer - #49924

Merged
pitrou merged 1 commit into
apache:mainfrom
rok:default_pre_buffer
May 6, 2026
Merged

GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer#49924
pitrou merged 1 commit into
apache:mainfrom
rok:default_pre_buffer

Conversation

@rok

@rokrok commented May 5, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Default pre_buffer=True on parquet APIs should probably be made consistent.

What changes are included in this PR?

Couple of default parameter changes and an updated docstring.

Are these changes tested?

By CI.

Are there any user-facing changes?

Users will see changes to default behavior. It's hard to estimate how disruptive (if at all) this will be.

@rok
rok requested review from AlenkaF and raulcd as code ownersMay 5, 2026 13:59
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #49923has been automatically assigned in GitHub to PR creator.

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's hope CI doesn't break

@pitrou
pitrou merged commit 2a89d03 into apache:mainMay 6, 2026
19 of 20 checks passed
@pitroupitrou removed the awaiting committer review Awaiting committer review label May 6, 2026
@github-actionsgithub-actionsBot added the awaiting committer review Awaiting committer review label May 6, 2026
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 2a89d03.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2a89d03.

There was 1 benchmark result with an error:

There were 6 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2a89d03.

There was 1 benchmark result with an error:

There were 6 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…quet pre_buffer (apache#49924)
### Rationale for this change
Default `pre_buffer=True` on parquet APIs should probably be made consistent.
### What changes are included in this PR?
Couple of default parameter changes and an updated docstring.
### Are these changes tested?
By CI.
### Are there any user-facing changes?
Users will see changes to default behavior. It's hard to estimate how disruptive (if at all) this will be.
* GitHub Issue: apache#49923
Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rok@pitrou