Skip to content

GH-49948: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) but keep bumped minIO version - #49945

Merged
rok merged 1 commit into
apache:mainfrom
tadeja:revert-pins-from-49931
May 16, 2026
Merged

GH-49948: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) but keep bumped minIO version#49945
rok merged 1 commit into
apache:mainfrom
tadeja:revert-pins-from-49931

Conversation

@tadeja

@tadejatadeja commented May 7, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Rationale for this change

Ready to revert pinned packages on MINGW64 with tests all passing now - see updated umbrella issue #49948 and #49958.
Past origin PR discussion #49931 (review)

What changes are included in this PR?

Reverting PR #49931's temporary pins workaround - so completely removing step - name: Pin MSYS2 packages.

Are these changes tested?

Yes, tests now pass on current upstream MSYS2

Are there any user-facing changes?

No.

@github-actionsgithub-actionsBot added the awaiting review Awaiting review label May 7, 2026
@tadeja
tadejaforce-pushed the revert-pins-from-49931 branch from 4f1af1b to 4c7390fCompareMay 7, 2026 12:45
@tadejatadeja mentioned this pull request May 7, 2026
Merged
@tadeja
tadejaforce-pushed the revert-pins-from-49931 branch from 4c7390f to cb652aaCompareMay 7, 2026 16:49
@tadejatadeja mentioned this pull request May 7, 2026
Closed
@tadejatadeja changed the title GH-49930: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) but keep bumped minIO versionGH-49948: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) but keep bumped minIO versionMay 7, 2026
@github-actions

github-actionsBot commented May 7, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #49948has been automatically assigned in GitHub to PR creator.

@tadejatadeja mentioned this pull request May 11, 2026
Closed
@tadejatadeja mentioned this pull request May 12, 2026
Closed
@tadeja
tadejaforce-pushed the revert-pins-from-49931 branch from b31db22 to cb652aaCompareMay 15, 2026 19:30
@tadeja

tadeja commented May 16, 2026

Copy link
Copy Markdown
MemberAuthor

See updated #49948 and #49958, ready to revert pinned package versions with this PR!

GCC 125312 related fix already merged in upstream MSYS2 - Version 16.1.0-4 is available on https://packages.msys2.org/packages/mingw-w64-x86_64-gcc-libs, it downloads and allows all tests on our MinGW job to pass now:
https://github.com/apache/arrow/actions/runs/25937291262/job/76296127141#step:5:109

@tadeja
tadeja marked this pull request as ready for review May 16, 2026 06:41
@tadeja
tadejaforce-pushed the revert-pins-from-49931 branch from cb652aa to 0e22776CompareMay 16, 2026 08:05
rok
rok approved these changes May 16, 2026
View reviewed changes

@rokrok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed the upstream development and this makes sense to me. Will merge if CI green.

@github-actionsgithub-actionsBot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 16, 2026
@rok
rok merged commit 27513af into apache:mainMay 16, 2026
18 checks passed
@rokrok removed the awaiting merge Awaiting merge label May 16, 2026
raulcd
raulcd reviewed May 16, 2026
View reviewed changes

@raulcdraulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @tadeja

@github-actionsgithub-actionsBot added the awaiting changes Awaiting changes label May 16, 2026
@conbench-apache-arrow

conbench-apache-arrowBot commented May 16, 2026

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 27513af.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

@tadeja
tadeja deleted the revert-pins-from-49931 branch May 21, 2026 13:50
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
@tadeja@Mottl
apacheGH-49948: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) …
3175a42
…but keep bumped minIO version (apache#49945)
### Rationale for this change
Ready to revert pinned packages on MINGW64 with tests all passing now - see updated umbrella issue apache#49948 and apache#49958.
Past origin PR discussion apache#49931 (review)
### What changes are included in this PR?
Reverting PR apache#49931's temporary pins workaround - so completely removing step ` - name: Setup MSYS2`.
### Are these changes tested?
Yes, tests now pass on current upstream MSYS2
### Are there any user-facing changes?
No.
* GitHub Issue: apache#49948
Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com>
Signed-off-by: Rok Mihevc <rok@mihevc.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulcdraulcdraulcd left review comments
@rokrokrok approved these changes
@assignUserassignUserAwaiting requested review from assignUserassignUser is a code owner
@jonkeanejonkeaneAwaiting requested review from jonkeanejonkeane is a code owner
@koukouAwaiting requested review from koukou is a code owner

Assignees

No one assigned

Labels

awaiting changesAwaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tadeja@rok@raulcd