Uh oh!
There was an error while loading. Please reload this page.
ARROW-6142: [R] Install instructions on linux could be clearer - #5027
ARROW-6142: [R] Install instructions on linux could be clearer#5027nealrichardson wants to merge 5 commits into
Conversation
karldw
commented
Aug 7, 2019
Thank you! Other users who have the same question I asked in |
| "<https://arrow.apache.org/install/>", | ||
| "for how to install the C++ package from a PPA." | ||
| "to find pre-compiled binary packages for some common Linux distributions,", | ||
| "such as Debian, Ubuntu, CentOS, and Fedora." |
There was a problem hiding this comment.
We don't provide packages for Fedora yet...
There was a problem hiding this comment.
Oops, I was blindly following #4948 (comment). Will revise.
nealrichardson
commented
Aug 7, 2019
Thanks for the clarification @karldw, I misunderstood before. Will add reference to those two packages. |
nealrichardson
commented
Aug 7, 2019
Revised, PTAL |
| "for how to install the C++ package from a PPA." | ||
| "to find pre-compiled binary packages for some common Linux distributions,", | ||
| "including Debian, Ubuntu, and CentOS. You'll need to install 'libarrow-dev'", | ||
| "and 'libparquet-dev'." |
There was a problem hiding this comment.
libarrow-dev and libparquet-dev are right package names for Debian and Ubuntu.
But arrow-devel and parquet-devel are right package names for CentOS.
BTW, we can install only libparquet-dev or parquet-devel because libarrow-dev and arrow-devel are automatically installed as dependency.
There was a problem hiding this comment.
Ok, revised accordingly.
kou
left a comment
There was a problem hiding this comment.
+1
We can merge this with a small fix. ("arrow" -> "Arrow")
Thanks!
| "to find pre-compiled binary packages for some common Linux distributions,", | ||
| "including Debian, Ubuntu, and CentOS. You'll need to install", | ||
| "'libparquet-dev' on Debian and Ubuntu, or 'parquet-devel' on CentOS. This", | ||
| "will also automatically install the arrow C++ library as a dependency." |
There was a problem hiding this comment.
Could you use "Arrow" instead of "arrow"?
kou
commented
Aug 8, 2019
I'll merge this when CI is green. |
nealrichardson
commented
Aug 8, 2019
Here's my fork, which I'm guessing will finish faster: https://travis-ci.org/nealrichardson/arrow/jobs/569137979 |
codecov-io
commented
Aug 8, 2019
Codecov Report
@@ Coverage Diff @@## master #5027 +/- ##
==========================================
- Coverage 87.33% 75.3% -12.03%
==========================================
Files 895 57 -838 Lines 119946 3620 -116326 Branches 1418 0 -1418 ==========================================
- Hits 104751 2726 -102025 + Misses 14833 894 -13939 + Partials 362 0 -362Continue to review full report at Codecov.
|
kou
commented
Aug 8, 2019
Thanks. CI is green. I'll merge this. |
This updates the language in `install_arrow()` to follow the README revision that will land in https://github.com/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33. The [Jira ticket](https://issues.apache.org/jira/browse/ARROW-6142) requested three things; this is `#2` in the list. On `#1`, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here. `#3` is out of scope. Closesapache#5027 from nealrichardson/no-ppa and squashes the following commits: 80b142e <Neal Richardson> s/arrow/Arrow/ 44c9659 <Neal Richardson> Tweak language again 36cfe28 <Neal Richardson> Further linux install revisions 79bd7e0 <Neal Richardson> One more PPurge 63f75bd <Neal Richardson> Revise install_arrow instructions for Linux Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This updates the language in
install_arrow()to follow the README revision that will land in https://github.com/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33.The Jira ticket requested three things; this is
#2in the list. On#1, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here.#3is out of scope.