Uh oh!
There was an error while loading. Please reload this page.
GH-47877: [Packaging][C++][FlightRPC][ODBC] Add arrow-flight-sql-odbc - #50288
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Yum/RPM packaging for the C++ Flight SQL components by enabling and packaging the Flight SQL ODBC driver, so users can install it via RPMs.
Changes:
- Enable building the Flight SQL ODBC driver in the RPM build (
-DARROW_FLIGHT_SQL_ODBC=ON) and add the required build dependency (unixODBC-devel). - Add new RPM subpackages for the driver:
arrow${so_version}-flight-sql-odbc-libsandarrow-flight-sql-odbc-devel, and adjust file ownership betweenflight-sql-develand the new ODBC devel package. - Extend the Yum verification script to install the new
arrow-flight-sql-odbc-develpackage.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| dev/tasks/linux-packages/apache-arrow/yum/centos-9-stream/Dockerfile | Adds unixODBC development headers to the CentOS 9 Stream build container. |
| dev/tasks/linux-packages/apache-arrow/yum/amazon-linux-2023/Dockerfile | Adds unixODBC development headers to the Amazon Linux 2023 build container. |
| dev/tasks/linux-packages/apache-arrow/yum/almalinux-8/Dockerfile | Adds unixODBC development headers to the AlmaLinux 8 build container. |
| dev/tasks/linux-packages/apache-arrow/yum/almalinux-9/Dockerfile | Adds unixODBC development headers to the AlmaLinux 9 build container. |
| dev/tasks/linux-packages/apache-arrow/yum/almalinux-10/Dockerfile | Adds unixODBC development headers to the AlmaLinux 10 build container. |
| dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in | Enables ODBC build in RPM, adds new ODBC RPM subpackages, and adjusts Flight SQL devel dependencies/files. |
| dev/release/verify-yum.sh | Installs the new Flight SQL ODBC devel package during RPM verification. |
Comment on lines
+509
to
+512
| License: Apache-2.0 | ||
| Requires: %{name}%{so_version}-flight-sql-odbc-libs = %{version}-%{release} | ||
| Requires: %{name}-flight-sql-devel = %{version}-%{release} | ||
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a1ec26f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If we provide RPM for Flight SQL ODBC driver, users can install it easily.
What changes are included in this PR?
arrow${MAJOR_VERSION}-flight-sql-odbc-libsarrow-flight-sql-odbc-develAre these changes tested?
No.
We need to generate configuration files but it's out-of-scope of this PR. We need to work on it as a separated task.
Are there any user-facing changes?
Yes.