Uh oh!
There was an error while loading. Please reload this page.
ARROW-6218: [Java] Add UINT type test in integration to avoid potential overflow - #5072
Closed
tianchen92 wants to merge 2 commits into
Closed
ARROW-6218: [Java] Add UINT type test in integration to avoid potential overflow#5072tianchen92 wants to merge 2 commits into
tianchen92 wants to merge 2 commits into
Conversation
tianchen92
commented
Aug 13, 2019
ContributorAuthor
| final UInt4Vector uInt4Vector = new UInt4Vector("uint4", allocator); | ||
| final UInt1Vector uInt1Vector = new UInt1Vector("uint1", allocator)) { | ||
| long[] longValues = new long[]{0x8000000000000000L, 0x7fffffffffffffffL, 0xffffffffffffffffL}; |
Contributor
There was a problem hiding this comment.
Long.MIN_VALUE, Long.MAX_VALUE, -1L?
Codecov Report
@@ Coverage Diff @@## master #5072 +/- ##
==========================================
+ Coverage 87.61% 89.71% +2.1%
==========================================
Files 1009 670 -339 Lines 144082 99567 -44515 Branches 1418 0 -1418 ==========================================
- Hits 126231 89327 -36904 + Misses 17489 10240 -7249 + Partials 362 0 -362Continue to review full report at Codecov.
|
praveenbingo
approved these changes
Aug 13, 2019
praveenbingo
left a comment
Contributor
There was a problem hiding this comment.
+1 LGTM. thanks @tianchen92
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…al overflow Related to [ARROW-6218](https://issues.apache.org/jira/browse/ARROW-6218). As per discussion apache#5002 For UINT type, when write/read json data in integration test, it extend data type(i.e. Long->BigInteger, Int->Long) to avoid potential overflow. Like UINT8 the write side and read side code like this: >case UINT8: generator.writeNumber(UInt8Vector.getNoOverflow(buffer, index)); break; >BigInteger value = parser.getBigIntegerValue(); buf.writeLong(value.longValue()); Should add a test to avoid potential overflow in the data transfer process. Closesapache#5072 from tianchen92/ARROW-6218 and squashes the following commits: 2bdbe7e <tianchen> use MIN_VALUE and MAX_VALUE 1430979 <tianchen> ARROW-6218: Add UINT type test in integration to avoid potential overflow Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Praveen <praveen@dremio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6218.
As per discussion #5002
For UINT type, when write/read json data in integration test, it extend data type(i.e. Long->BigInteger, Int->Long) to avoid potential overflow.
Like UINT8 the write side and read side code like this:
Should add a test to avoid potential overflow in the data transfer process.